On Sun, Mar 31, 2019 at 10:08 AM Justin Mclean <jus...@classsoftware.com> wrote:
> Hi, > > > The LICENSE file has a table that maps a file to its license "key" and > the > > license is then stored in the (top-level) "licenses" directory (in the > > header of the table, there is a note about that: "text is in file in > > licenses directory"). We used to put all the licenses into the LICENSE > > file, but we were told that is confusing (as the LICENSE file gets fairly > > huge, esp. for the convenience binary), so the licenses were put into a > > separate directory. > > Yep that the recommended way i.e. add a pointer to where the license is > located rather than the full license text when there are many licenses. I > think you are missing a couple, give me a couple of days and I’ll come up > with a list for you. > Thanks! > > Or we can change the reference in the table in the LICENSE file to > > read like "licenses/CDDL-1.0" instead of "CDDL-1.0”. > > That I think would make it clearer. > Ok, I think that will be easy to do. > > > Do you mean licenses under nbbuild/licenses and under the modules, like: > > java/maven.embedder/external? The LICENSE file should not refer to them > > (that only ever refers to the top-level licenses directory), so these > > should be OK? > > It OK it just makes it very hard to check the release for what is bundled > and not and what needs to go in LICENSE. > > >> 1. > >> > ./ide/css.editor/test/unit/src/org/netbeans/modules/css/editor/module/main/properties/PropertiesATest.java > >> > > > > What is the problem with this file? Looking at the file, I am not sure > > what's the problem. > > May of been a false positive as it contains the text: > "/*!* Many thanks to Sorin Stefan and Nicole Sullivan!*(Refers to section > A. Libraries) * Copyright(c) 2007,Yahoo!Inc. All rights reserved. * Code > licensed under the BSD License:* > http://developer.yahoo.net/yui/license.txt * version:2.2.1 */“ > Hmm, true. Looking at the history, it does not reveal much. We might want to simply include the license to be on the safe side (assuming we can find it the proper version.) Thanks, Jan > But it seems odd to have that in there. > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
