Hi Justin, On Sat, Mar 30, 2019 at 7:58 AM Justin Mclean <jus...@classsoftware.com> wrote:
> HI, > > > I assume we are taking about files like: > > > https://github.com/apache/incubator-netbeans/blob/master/java/java.hints/test/unit/data/org/netbeans/test/java/hints/AddCast1.java > > Those are some of the files yes but there are a few not in test > directories. Does the project use rat to look for issues? By my very rough > count there are 5,000 + source files without ASF headers, Yes, we use rat. We have exclusions here: https://github.com/apache/incubator-netbeans/blob/master/nbbuild/rat-exclusions.txt Annotated with a reason why the given exclusion (or a set of exclustions) is there. (13,000+ if you include the .pass files), but only two dozen files of those > source file are out side of test directories. > Would you please have a list? I tried this: java -jar ~/Downloads/apache-rat-0.12.jar . >rat cat rat | grep '== File:' | grep -e '\.java$' -e '\.jsp$' -e '\.php$' -e '\.js$' | grep -v 'test/unit/data' | grep -v 'test/qa-functional/data' And it yields the following list for me: == File: ./enterprise/web.jsf/src/org/netbeans/modules/web/jsf/facelets/resources/templates/forward.jsp == File: ./enterprise/web.jsf/src/org/netbeans/modules/web/jsf/resources/jsfcrud.js == File: ./enterprise/web.primefaces/src/org/netbeans/modules/web/primefaces/templates/jsfcrud.js == File: ./php/php.atoum/src/org/netbeans/modules/php/atoum/ui/resources/AtoumTest.php == File: ./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/BlankLines.php == File: ./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Braces.php == File: ./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Spaces.php == File: ./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/TabsIndents.php == File: ./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Uses.php == File: ./php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Wrapping.php With some work, these should be handlable. Thanks, Jan > > BTW If this was the only issue I’d would have voted differently, although > the question needs to be asked why this issue has been raised previously on > this list and no response given? > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
