On Wed, May 23, 2018 at 10:44 PM, Ate Douma <a...@douma.nu> wrote: > > > On 2018-05-23 20:57, Emilian Bold wrote: > >> Ate, could we get a vote on this release? >> > > Sure :-) > > >> If you look at https://cwiki.apache.org/confl >> uence/display/NETBEANS/Apache+NetBeans+9.0+RC1 we are already making >> progress on the (non-blocking) issues reported. >> > > Yes, thanks for creating the follow-up issues to address the reported > issues. > With those tickets and the explanation given on my first question > I'm now +1 on this release candidate. > > I would like to add that I agree with Justin that, while it might not be > a ASF policy issue to have a GPL license file in the distribution, I > also don't see how it serves any purpose and only will trigger > unnecessary warnings or worries by users or checker tools. > My recommendation is to get rid of those GPL license files. >
PR sent removing the license files: https://github.com/apache/incubator-netbeans/pull/561 Thanks, Jan > Regards, > Ate > > > >> --emi >> >> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >> >> On 21 May 2018 3:54 PM, Ate Douma <a...@douma.nu> wrote: >> >> I'm inclined to vote positive on this RC1, overall looks great! >>> >>> - verified the MD5 and SHA1, and PGP signatures with the ASC files. >>> - executed rat check (ant rat) and verified the report. >>> - build and run the source (using JDK8), and all seems fine. >>> However I still have two questions: >>> a) nbbuild/licenses folder still has the GPL license file, >>> which I >>> thought/expected no longer should be needed with the fix from >>> NETBEANS-305 [1]? >>> Is there still a GPL usage left? If so this then could be a >>> blocker IMO. >>> b) Justin provided detailed feedback on the 9.0-Beta-RC3 on >>> (possible) >>> needed improvements/fixes for the binary dist LICENSE/NOTICE >>> file [2], >>> thereafter recorded as a todo action list on the wiki [3] (end >>> of page). >>> Some of those points have been addressed (marked DONE), but >>> many/most >>> are not, and neither resolved/fixed (or otherwise marked as >>> NVT). >>> As just an example, Justin noticed for the >>> ./ide/modules/ext/smackx.jar >>> file that it included the BSD licensed JZlib, which wasn't >>> mentioned in >>> the LICENSE file. And still isn't for this 9.0-RC1. >>> I don't think any of those are blockers, but it would be good >>> to address >>> these (create NETBEANS issues for them) before the final 9.0 >>> release. >>> Regards, Ate >>> [1] https://issues.apache.org/jira/browse/NETBEANS-305 >>> https://github.com/apache/incubator-netbeans/pull/540 >>> [2] >>> http://mail-archives.apache.org/mod_mbox/incubator-general/ >>> 201801.mbox/<c4c5d5c4-ab44-4afe-ade2-9e91f593a...@classsoftware.com> >>> [3] >>> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+ >>> NetBeans+9.0+Beta+rc3 >>> On 2018-05-21 00:33, Emilian Bold wrote: >>> >>> >>>> Hi all, >>>> >>>> The Apache NetBeans community has voted on and approved a proposal to >>>> release Apache NetBeans 9.0 RC1 (incubating) rc1. >>>> >>>> We now kindly request that the Incubator PMC members review and vote on >>>> this incubator release candidate. >>>> >>>> Apache NetBeans 9.0 RC1 (incubating) vote thread: >>>> >>>> https://lists.apache.org/thread.html/c2a06adc83e2819e6d96c7d >>>> ff8d0e22a97001f99bfda12515d4d9609@<dev.netbeans.apache.org> >>>> >>>> Apache NetBeans 9.0 RC1 (incubating) vote result thread: >>>> >>>> https://lists.apache.org/thread.html/94f7a5e4601e26c7edb8264 >>>> df7df53dd8ed215ecfc568816a162f2af@<dev.netbeans.apache.org> >>>> >>>> Apache NetBeans 9.0 RC1 (incubating) constitutes all the modules in the >>>> Apache NetBeans Git repo, which together provide the NetBeans Platform >>>> (i.e., the underlying application framework), as well as all the modules >>>> that provide the Java SE-related features of Apache NetBeans. >>>> >>>> In short, Apache NetBeans 9.0 RC1 (incubating) is a full IDE for Java >>>> SE development. >>>> >>>> Build artifacts available here: >>>> >>>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/in >>>> cubating-netbeans-java/incubating-9.0-rc1-rc1 >>>> >>>> The specific artifact to be voted on: >>>> >>>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/in >>>> cubating-netbeans-java/incubating-9.0-rc1-rc1/incubating- >>>> netbeans-java-9.0-rc1-source.zip >>>> >>>> Included in the above are the DEPENDENCIES, DISCLAIMER, LICENSE, and >>>> NOTICE files, as well as a README file with build instructions, which are >>>> the same as these: >>>> >>>> https://github.com/apache/incubator-netbeans/blob/master/README.md >>>> >>>> SHA1: a1a265455c8246f849b14982fa3c36b351b21876 >>>> >>>> KEYS file: >>>> >>>> https://dist.apache.org/repos/dist/release/incubator/netbeans/KEYS >>>> >>>> Apache NetBeans Git Repo tag: 9.0-rc1-rc1: >>>> >>>> https://github.com/apache/incubator-netbeans/tree/9.0-rc1-rc1 >>>> >>>> Note: NetBeans license violation checks are managed via the >>>> rat-exclusions.txt file: >>>> >>>> https://github.com/apache/incubator-netbeans/blob/master/ >>>> nbbuild/rat-exclusions.txt >>>> >>>> Rat report shows no unknown licenses, except for license files: >>>> >>>> https://builds.apache.org/job/incubator-netbeans-release/302 >>>> /artifact/rat-java-temp/nbbuild/build/rat-report.txt >>>> >>>> The license files listed in the Rat report are known and an issue >>>> exists for solving this: >>>> >>>> https://issues.apache.org/jira/browse/NETBEANS-305 >>>> >>>> Included as a convenience binary, not relevant for the voting purposes >>>> (unzip it, run it and you'll see Apache NetBeans): >>>> >>>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/in >>>> cubating-netbeans-java/incubating-9.0-rc1-rc1/incubating- >>>> netbeans-java-9.0-rc1-bin.zip >>>> >>>> Also included as a convenience binary the NBMs: >>>> >>>> https://dist.apache.org/repos/dist/dev/incubator/netbeans/in >>>> cubating-netbeans-java/incubating-9.0-rc1-rc1/nbms >>>> >>>> New & Noteworthy features of the 9.0 Release: >>>> >>>> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+ >>>> NetBeans+9.0+New+and+Noteworthy >>>> >>>> Release specific wiki page: >>>> >>>> https://cwiki.apache.org/confluence/display/NETBEANS/Apache+ >>>> NetBeans+9.0+RC1 >>>> >>>> How (and what) to try out the release: >>>> >>>> 1. Download the artifact to be voted on and unzip it. >>>> 2. Build it using the README provided by the artifact. >>>> 3. Look in nbbuild/netbeans for the NetBeans installation created by >>>> the build process. >>>> 4. Run the NetBeans executable and (if you're running on JDK 8) you'll >>>> be prompted to install nb-javac, after agreeing to its licensing terms, and >>>> (if you're running on JDK 9), you'll be able to use javac directly from JDK >>>> 9 and, optionally, you'll be prompted to install nb-javac, after agreeing >>>> to its licensing terms. >>>> >>>> If the above succeeds, i.e., Apache NetBeans installs and starts up, >>>> you will have a development environment that complies with Apache IP >>>> requirements and you should vote +1 in this thread. >>>> >>>> Please try out the package, using the instructions above, and vote! >>>> >>>> The vote is open for 7 days >>>> >>>> [ ] +1 Release this package as Apache NetBeans 9.0 RC1 (incubating) >>>> >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>>> >>>> [ ] -1 Do not release this package because... >>>> >>>> Emilian Bold >>>> >>>> on behalf of the Apache NetBeans PPMC >>>> >>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>> >>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>> >>> >>> -- >>> >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org >> For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org > For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >