Hi Egeyar,
Thanks for including me in this discussion.
>>> This option is similar to -frecord-gcc-switches.
For the record I will also note that there is -fverbose-asm which
does almost the same thing, but only records the options as comments
in the assembler. They are never converted into data
ix
this.
Is this OK ?
Cheers
Nick
libiberty/ChangeLog
2020-01-20 Nick Clifton
* testsuite/demangle-expected: Fix expected demangling.
Index: libiberty/testsuite/demangle-expected
===
--- libiberty/testsuite/demangle-
Hi Christophe,
I have a follow-up one: I think the same applies to binutils, but I
don't think any maintainer / contributor expressed an opinion, and
IIUC patch policy for binutils is (lightly) documented at
https://sourceware.org/binutils/wiki/HowToContribute
Maybe Nick can update it?
Done.
Hi Kewen,
This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
defines in fr30 port.
gcc/ChangeLog:
* config/fr30/fr30.h (FLOAT_TYPE_SIZE): Remove.
(DOUBLE_TYPE_SIZE): Likewise.
(LONG_DOUBLE_TYPE_SIZE): Likewise.
Approved - please apply.
Cheers
Nick
Hi Kewen,
This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
defines in frv port.
gcc/ChangeLog:
* config/frv/frv.h (FLOAT_TYPE_SIZE): Remove.
(DOUBLE_TYPE_SIZE): Likewise.
(LONG_DOUBLE_TYPE_SIZE): Likewise.
Approved - please apply.
Cheers
Nick
Hi Kewen,
This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
defines in iq2000 port.
gcc/ChangeLog:
* config/iq2000/iq2000.h (FLOAT_TYPE_SIZE): Remove.
(DOUBLE_TYPE_SIZE): Likewise.
(LONG_DOUBLE_TYPE_SIZE): Likewise.
Approved - please apply.
Cheers
Nick
Hi Kewen,
This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
defines in m32c port.
gcc/ChangeLog:
* config/m32c/m32c.h (FLOAT_TYPE_SIZE): Remove.
(DOUBLE_TYPE_SIZE): Likewise.
(LONG_DOUBLE_TYPE_SIZE): Likewise.
Approved - please apply.
Cheers
Nick
Hi Kewen,
This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
defines in m32r port.
gcc/ChangeLog:
* config/m32r/m32r.h (FLOAT_TYPE_SIZE): Remove.
(DOUBLE_TYPE_SIZE): Likewise.
(LONG_DOUBLE_TYPE_SIZE): Likewise.
Approved - please apply.
Cheers
Nick
Hi Kewen,
This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
defines in msp430 port.
gcc/ChangeLog:
* config/msp430/msp430.h (FLOAT_TYPE_SIZE): Remove.
(DOUBLE_TYPE_SIZE): Likewise.
(LONG_DOUBLE_TYPE_SIZE): Likewise.
Approved - please apply.
Cheers
Nick
Hi Kewen,
This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
defines in stormy16 port.
gcc/ChangeLog:
* config/stormy16/stormy16.h (FLOAT_TYPE_SIZE): Remove.
(DOUBLE_TYPE_SIZE): Likewise.
(LONG_DOUBLE_TYPE_SIZE): Likewise.
Approved - please apply.
Cheers
Nic
Hi Kewen,
This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
defines in rx port, and add new port specific hook
implementation rx_c_mode_for_floating_type.
gcc/ChangeLog:
* config/rx/rx.cc (rx_c_mode_for_floating_type): New function.
(TARGET_C_MODE_FOR_FLOATING_TYPE): Ne
Hi Jeff,
2.43 was released over an weekend. Is it possible to let it be supported after
2.44? cc Nick and jan.
I don't think it's critical enough to backport to 2.43. I'd just put it on the
trunk so that it's available in 2.44.
It might be worth adding it to the 2.43 branch as well. It i
Hi Nelson,
Sounds good to me, too. Once get the approval, I will backport them to
binutils-2_43-branch :-)
Please could you ping me once you have done that.
I will make sure not to make the point release before receiving your message.
Cheers
Nick
commit an
update patch?
Thanks. I have gone ahead and checked in this patch:
Cheers
Nick
gcc/ChangeLog
2013-08-20 Nick Clifton
* target.def (narrow_volatile_bitfield): Note that the default
value is false, not !TARGET_STRICT_ALIGN.
* doc/tm.texi: Regenerate.
Index
Hi Joseph,
Your patch itself makes sense on general principles, but the concept of an
AVR Linux target doesn't - this is an 8-bit processor Really, the bug
you've found is that there's an avr-*-* case that is too general, matching
nonsensical targets such as AVR Linux rather than just avr-*-
was not
sure whether it was better to accept avr-*-elf or avr-*-elf*. I went
for the latter in case there were AVR ELF variants, but I defer to your
superior knowledge.
OK to apply ?
Cheers
Nick
gcc/ChangeLog
2013-08-27 Nick Clifton
* config.gcc (AVR): Restrict allowed targets to
Hi Sandeep,
gas/config:
2013-07-18 Sandeep Kumar Singh
* rx.h: Add option -mcpu for target variants RX100 and RX200.
Approved - please apply.
Cheers
Nick
).
OK to apply ?
Cheers
Nick
gcc/testsuite/ChangeLog
2013-09-16 Nick Clifton
* lib/target-supports.exp (check_effective_target_trampolines):
Add MSP430 to the list of targets that do not support
trampolines.
(check_profiling_available): Add MSP430 to the list of
functions (which disable interrupts whilst they execute) and reentrant
functions (which disable interrupts but always reenable them upon
exit).
Tested with no regressions on an msp430-elf toolchain.
Cheers
Nick
gcc/ChangeLog
2013-09-17 Nick Clifton
* config/msp430/msp430-protos.h
Hi Mike,
Ok, I assume that the changes to hppa and return 0 are intentional and good…
- || [istarget hppa64-hp-hpux11.23] } {
- return 0;
+|| [istarget hppa64-hp-hpux11.23] } {
+ return 0;
Sorry - yes - they are just whitespace adjustments so that the entries
line
the
function in the assembler output. This is mainly for debugging
purposes.
Cheers
Nick
gcc/ChangeLog
2013-09-18 Nick Clifton
* config/msp430/msp430.h (ASM_SPEC): Pass -md on to the assembler.
(ASM_DECLARE_FUNCTION_NAME): Define.
Index: gcc/config/msp430/msp430.h
PSI to SI conversion pattern for when signed pointer values need to be
stored in an SI pair of registers.
Cheers
Nick
gcc/ChangeLog
2013-09-26 Nick Clifton
* config/msp430/msp430.c (msp430_expand_epilogue): Fix compile
time warning message.
(msp430_print_operand_raw
Hi Mike,
I must say though, it seems wrong to have to provide a sign-extend pointer
pattern when pointers (on the MSP430) are unsigned.
Agreed. If we instead ask, is it sane for gcc to ever want to signed extend in
this case, the answer appears to be no. Why does it, ptr_mode is SImode, an
regressions on msp430-elf, rl78-elf and xstormy16-elf
targets.
OK to apply ?
Cheers
Nick
gcc/testsuite/ChangeLog
2013-09-30 Nick Clifton
* gcc.c-torture/compile/20010327-1.c: Only run the test for
int32plus targets.
* gcc.c-torture/compile/990617-1.c: Likewise.
Hi Mike,
It may be reasonable to special case ptr32plus to say no on your platform, from
check_effective_target_tls_native, we see code like:
you could do something like:
proc check_effective_target_ptr32plus { } {
# msp430 never really has 32 or more bits in a pointer.
if { [ista
Hi Guys,
Is there a target specific way to add a flag bit to a function decl ?
For the RX port I want to be able to mark a function decl for which I
have issued a warning message. Unfortunately I could find no easy way
to do this other than stealing one of the generic bits (no_limit_stac
Hi Ian,
Can't you just keep a list of the decls for which you have issued the
warning?
Yes - that would work too. In fact I agree that this would be cleaner
solution in my particular case. I'll create a new patch...
How many decls do you expect to be on that list?
Not very many. Mayb
problem.
Cheers
Nick
PS. I have even remembered to include a patch to the html documentation
as well!
gcc/ChangeLog
2012-10-03 Nick Clifton
* config/rx/rx.c (struct decl_chain): New local structure.
(warned_decls): New local variable. Contains a stack of decls for
Hi Steven,
iq2000 build is broken since at least r162089 (July 2010). I'm going
to commit this patch to fix this part of the build problem.
Thanks.
It still
fails later one, but I don't care about that
FYI I have this patch installed in my local sources that allows the
iq2000 port to buil
Hi Steve,
It looks like there is another patch that has not been
checked in to the GCC top level tree but not binutils and a patch
in binutils but not GCC. Is there any automation for this or is
it still up to each person checking in files to copy stuff over
by hand?
As far as I know it is st
toolchain.
OK to apply ?
Cheers
Nick
gcc/ChangeLog
2013-10-17 Nick Clifton
* gcc.c (do_spec_1): Do not insert a space after a %* substitution
unless it is the last part of a spec substring.
* doc/invoke.texi (Spec Files): Document space insertion
behaviour of
Hi Guys,
I am applying the patch below as an obvious update to the 20020312-2.c
test for the RL78 and MSP430 targets. Neither of them use a specific
regiser for PIC support, but the test needs to be explicitly told
that.
Cheers
Nick
gcc/testsuite/ChangeLog
2013-10-24 Nick Clifton
-gnu toolchain
with no regressions and several improvements.
OK to apply ?
Cheers
Nick
gcc/testsuite/ChangeLog
2013-10-24 Nick Clifton
* c-c++-common/pr57793.c: Add expected error messages for
targets with small integers.
* gcc.dg/c99-stdint-1.c: Only run on 32-bit
Hi Matthias,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69129
this fixes the bootstrap errors for me, seen in both libgnat and libgfortran.
Great - I have gone ahead and checked the patch in.
Cheers
Nick
does turn out that these kinds of functions can
also trigger this kind of bug, then the patch could be extended
later. Plus a new bug report is likely to include a new testcase that
can be added to the testsuite.
So ... OK to apply ?
Cheers
Nick
gcc/ChangeLog
2016-01-26 Nick Clifton
Hi Kyrill,
> 2016-01-22 Kyrylo Tkachov
>
> * config/arm/arm.c (arm_new_rtx_costs, MULT case): Properly extract
> the operands of the SIGN_EXTENDs from a SMUL[TB][TB] rtx.
Approved - please apply.
Cheers
Nick
Hi Kyrill,
I would like to approve this patch, but cannot, since it is not ARM
specific. I think that if you ping the list you may be able to get a
response, and it would be nice to see this whole patch series checked
in before the gcc 6 branch occurs.
Cheers
Nick
PS. If necessary yo
> 2016-01-22 Kyrylo Tkachov
>
> * gcc.target/arm/wmul-3.c: Simplify test to generate just
> a single smulbb instruction.
> * gcc.target/amr/wmul-1.c: Add -mtune=cortex-a9 to dg-options.
> * gcc.target/amr/wmul-2.c: Likewise.
Approved - please apply.
Cheers
Nick
ode generation, so I
added a fix to (silently) disable interworking if the target
architecture does not support Thumb instructions.
Any comments or criticisms before I apply the patch ?
Cheers
Nick
gcc/ChangeLog
2016-02-16 Nick Clifton
PR target/62554
PR target/69
Hi Guys,
I am checking in this patch to update the list of MSP430 devices
built in to the msp430 backend.
Cheers
Nick
gcc/ChangeLog
2016-02-17 Nick Clifton
* config/msp430/msp430.c (msp430_mcu_data): Sync with data from
TI's devices.csv file as of March 2016.
Hi Kyrill,
> Ok for trunk?
>
> 2016-01-29 Kyrylo Tkachov
>
> PR target/69161
> * config/arm/predicates.md (arm_comparison_operator_mode):
> New predicate.
> * config/arm/arm.md (*mov_scc): Use arm_comparison_operator_mode
> instead of arm_comparison_operator.
> (*mov_n
Clifton
PR middle-end/49889
* varasm.c (merge_weak): Generate an error if an attempt is made
to convert a non-weak static function into a weak, public function.
gcc/testsuite/ChangeLog
2016-02-17 Nick Clifton
PR middle-end/49889
* gcc.dg/pr49889.c: New test
Hi Christophe,
> Could you modify your new testcases, such that they call
> check_effective_target_arm_arm_ok ?
Good idea - done.
> I'm just realizing that we currently generate arm_arch_vX_ok
> for X >=4 only. Maybe you should also add v3?
Possibly. I am not at all sure how important v3 suppo
Hi Jeff,
>>Redefining a previously defined static function as both public and
>>weak triggers an ICE in ipa-visibility.c:
>>
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49899
> Does this fix a regression?
How far back am I allowed to go ? :-)
The bug as reported in the PR existed i
Hi Jeff,
> My inclination would be to defer to gcc-7. Richi, Jakub or Joseph, as
> release managers, would have the final say though.
It's OK. I will resubmit after gcc 6 branches.
Cheers
Nick
heers
Nick
gcc/ChangeLog
2016-03-01 Nick Clifton
* config.gcc (cr16-*-elf): Add newlib-stdint.h to tm_file.
Index: gcc/config.gcc
===
--- gcc/config.gcc (revision 233857)
+++ gcc/config.gcc (working copy)
@@ -1
OK to apply ?
Tested with an mep-elf toolchain.
Cheers
Nick
gcc/ChangeLog
2016-03-01 Nick Clifton
* config.gcc (mep-*-elf): Add newlib-stdint.h to tm_file.
Index: gcc/config.gcc
===
--- gcc/config.gcc (revision
Hi DJ,
> Ok.
Thanks - patch committed. (I know that you have now deprecated the MeP port,
but at least with this patch in place the toolchain can now be built if obsolete
targets are enabled).
Cheers
Nick
, but using a special value of 2 to do
so. Then when the second call occurs we can detect this case and
ensure that we do not set flag_omit_leaf_frame_pointer to false.
Tested with no regressions on an aarch64-elf toolchain.
OK to apply ?
Cheers
Nick
gcc/ChangeLog
2016-03-04 Nick Clifton
/ChangeLog
2013-12-13 Nick Clifton
* config/msp430/msp430.c (is_wakeup_func): New function. Returns
true if the current function has the wakeup attribute.
(msp430_start_function): Note if the function has the wakeup
attribute.
(msp430_attribute_table): Add
interrupt handler exits.
Cheers
Nick
gcc/ChangeLog
2013-12-13 Nick Clifton
* config/msp430/msp430.c (is_wakeup_func): New function. Returns
true if the current function has the wakeup attribute.
(msp430_start_function): Note if the function has the wakeup
place, not three.
There were no regressions when tested with a i686-pc-linux-gnu or a
x86_64-pc-linux-gnu toolchain, and the test was fixed for a rl78-elf
toolchain.
OK to apply ?
Cheers
Nick
gcc/testsuite/ChangeLog
2013-12-18 Nick Clifton
* gcc.dg/pr32912-2.c: Fix for 16
patch was created by Peter Bigot for a
different PR:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52856
gcc/ChangeLog
2013-12-30 Nick Clifton
PR target/59631
* stor-layout.c (get_mode_bounds): Use GET_MODE_PRECISION instead
of GET_MODE_BITSIZE.
Ind
Hi Guys,
I am applying the patch below to the MSP430 backend to enable the use
of %A, %B, %C and %D in asm statements as selectors of 16-bit parts of
a 64-bit value. This is at the request of TI, for compatibility with
their compiler.
Cheers
Nick
gcc/ChangeLog
2013-12-30 Nick
Hi Volker,
apparently you added the wrong PR number to the patch. You probably
meant PR 59613. Would you mind fixing that in the ChangeLog?
Doh! Sorry - fixed.
Cheers
Nick
-13 Nick Clifton
PR middle-end/28865
* varasm.c (output_constant): Return the number of bytes actually
emitted.
(output_constructor_array_range): Update the field size with the
number of bytes emitted by output_constant
Hi Helmut, Hi Ulrich, Hi Andreas,
A toolchain configured as --target=s390-linux currently fails to build
gcc because of an undefined function:
undefined reference to `s390_host_detect_local_cpu(int, char const**)'
Makefile:1858: recipe for target 'xgcc' failed
The patch below fix
anything in high memory relative to this symbol.
Tested with no regressions on an rl78-elf toolchain.
OK to apply ?
Cheers
Nick
gcc/ChangeLog
2015-07-27 Nick Clifton
* config/rl78/rl78.c (rl78_addsi3_internal): New function.
Optimizes the case where -mes0 is active and
Hi Guys,
I am checking in the patch below to fix the M32R port's handling of
its __model__ attribute. This attribute takes a parameter identifying
the memory model to use, but gcc was not being told to expect this
identifier.
Cheers
Nick
gcc/ChangeLog
2015-07-31 Nick Cl
?
Cheers
Nick
gcc/ChangeLog
2015-08-04 Nick Clifton
* config/rl78/rl78.c (rl78_force_nonfar_3): Remove optimization
to allow identical far pointers to remain.
gcc/testsuite/ChangeLog
2015-08-04 Nick Clifton
* gcc.target/rl78: New directory.
* gcc.target/rl78
regressions on an rl78-elf toolchain.
OK to apply ?
Cheers
Nick
gcc/ChangeLog
2015-08-05 Nick Clifton
* config/rl78/rl78.c (rl78_rtx_costs): Treat MULT insns as cheap
if optimizing for size.
Index: gcc/config/rl78/rl78.c
Hi DJ,
This is OK, but note that it prevents some operations like:
__far int i;
foo()
{
i ++;
}
from being implemented with a minimum set of opcodes. This might be
particularly troublesome for volatile far things.
Right - it is something I will have to look into.
Cheers
Nick
newlib stdint types were not being defined. So please may I apply the
patch below to correct this problem ?
Cheers
Nick
gcc/ChangeLog
2015-10-06 Nick Clifton
* config.gcc (lm32-elf): Add newlib-stdint.h to tm_file.
Index: gcc/config.gcc
Hi DJ,
This is the patch that I have checked in.
Cheers
Nick
gcc/ChangeLog
2015-10-06 Nick Clifton
* config/rl78/rl78.c (rl78_rtx_costs): Improve cost estimates for
multiplication.
Index: gcc/config/rl78/rl78.c
regressions on an msp430-elf toolchain.
Cheers
Nick
gcc/ChangeLog
2015-10-06 Nick Clifton
* config/msp430/msp430.c (ATTR_NOINIT): New constant.
(ATTR_PERSIST): New constant.
(msp430_data_attr): New function - verifies an attribute that only
applies to variables
val ?
Cheers
Nick
gcc/ChangeLog
2015-10-22 Nick Clifton
* cfgrtl.c (not_a_stmt_hasher): New struct.
(not_a_stmt_htab): New hash table.
(is_a_stmt): New function. Returns true iff the given insn is on
the list of insns known not to start a line of source c
Hi Bernd,
Could you point me at the code generating these NOPs
It is in cfgrtl.c:fixup_reorder_chain()
nb = split_edge (e);
if (!INSN_P (BB_END (nb)))
BB_END (nb) = emit_insn_after_noloc (gen_nop (), BB_END (nb),
nb
Hi Guys,
I am checking in the patch below to allow gcc to pass the new MSP430
-msilicon-errata and -msilicon-errata-warn option on to the
assembler.
Cheers
Nick
gcc/ChangeLog
2015-10-22 Nick Clifton
* config/msp430/msp430.opt: Add -msilicon-errata and
-msilicon
Hi Guys,
I am checking in the patch below to fix a small spelling mistake that
I recently introduced to the RL78 documentation:
gcc/ChangeLog
2015-10-26 Nick Clifton
* doc/invoke.texi (RL78 Options): Fix spelling mistake.
Index: gcc/doc/invoke.texi
and the extension instructions, but also where the extra
hard registers are used for another purpose as well ?
Tested with no regressions (or fixes) on an x86-pc-linux-gnu target.
Also tested with no regression and 7 fixes on an rl78-elf target.
Cheers
Nick
gcc/ChangeLog
2015-11-18 Nick
Hi Bernd,
I had a look around. There's code testing HARD_REGNO_NREGS in
ree.c:combine_set_extension. It's inside #if 0, and labelled
"temporarily disabled". See if enabling that helps you? (Jeff, that #if
0 was added by you).
I suspect that the code was disabled because it prevented too many
Hi Jeff,
The code there would solve this problem, but the approach is is overly
cautious, since it disables the optimization for all extensions that
increase the number of hard registers used. Some of these will be
viable candidates, provided that the extra hard registers are no used.
(This is
.
gcc/ChangeLog
2015-11-25 Nick Clifton
* config.gcc (extra_gcc_objs): Define for MSP430.
* common/config/msp430/msp430-common.c (msp430_handle_option):
Pass both -mmcu and -mcpu on to the back end if they are both
defined.
* config/msp430/msp430.c
-06-08 Nick Clifton
* varasm.c (dump_enabled_to_asm_out_file): New function. Prints
enabled options to the asm_out_file.
(elf_record_gcc_switches): If verbose-asm is set then also dump
all enabled options to the asm file.
* toplec.c (print_switch_values
Hi Richard,
>>The -frecord-gcc-switches option records the gcc command line. It
>>does not however expand options like -O2 into the optimizations that
>>this enables.
>
> I think individually enabled passes by -On are not really useful information
> as you generally cannot replace -
Hi Jakub,
>> Regardless, the point of this patch is to record which options were enabled,
>> via
>> whatever route, in the binaries. This can be useful to users, or
>> distributors,
>> who want to check that, for example, a specific security option was enabled,
>> or
>> that a particular a pa
Hi Jozef,
> Ok for trunk and gcc-7-branch?
Approved - please apply (to both).
Cheers
Nick
Hi Jozef,
> Sorry, didn't mention in that last post that I don't have write access,
> could someone please apply this for me.
Applied. Sorry about the delay (again).
Cheers
Nick
Hi Guys,
It seems to me that it might be worth taking a step back here,
and consider adding a security framework to gcc. Mitigations
for CVEs in the past have resulted in individual patches being
added to gcc, oftern in a target specific manner, and with no
real framework to support the
Hi Guys,
The patch below allows the zlib library to be built when the build
directory is the same as the source directory. This patch has been in
the binutils/gdb sources for a while now, but unfortunately was never
copied to gcc. So I am trying to right that mistake now.
OK to apply
Hi Prathamesh,
> I am getting the following build error with trunk:
> ../../gcc/gcc/tree.c: In member function ‘void
> escaped_string::escape(const char*)’:
> ../../gcc/gcc/tree.c:12457:20: error: cast from type ‘const char*’ to
> type ‘char*’ casts away qualifiers [-Werror=cast-qual]
>m_str =
Hi Martin,
> I'm getting a bootstrap failure:
*sigh* yes - my bad. Fortunately a patch has already been posted:
https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01039.html
And I think that it has now been approved.
Cheers
Nick
Hi Oleg,
> OK for trunk and GCC 7?
Approved. Do you have access to the repository, or would you like me to apply
the patch for you ?
Cheers
Nick
Hi Oleg,
> gcc/ChangeLog:
> PR target/81819
> * config/rx/rx.c (rx_is_restricted_memory_address):
> Handle SUBREG case.
Go ahead make my day^H^H^H^H^H^H
Approved - please apply.
Cheers
Nick
hstk to enable CET
% gcc -c main.c -fcf-protection=return -mshstk
%
What do you think ? Is the patch OK for the mainline ?
Cheers
Nick
gcc/ChangeLog
2018-02-05 Nick Clifton
PR 84145
* config/i386/i386.c (ix86_option_override_internal): Rework
checks fo
it simple. :-)
No regressions with an x86_64-pc-linux-gnu toolchain.
OK to apply ?
Cheers
Nick
gcc/ChangeLog
2018-02-05 Nick Clifton
PR 84195
* tree.c (warn_deprecated_use): Sanitize deprecation messages.
Index: gcc/tree.c
Hi Igor,
>> Attached is a potential patch for PR 84145:
>>
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84145
> Coincidentally, I have worked on the same patch.
Great minds, etc :-)
> Please look at the patch, I uploaded it to the bug. The main differences are
>
> - updated the output mes
Hi Martin,
> My only suggestions are to consider how control characters and
> excessively messages are handled in other contexts and adopt
> the same approach here.
Are there other places where user-supplied messages are displayed by gcc ?
> In the tests I did, control characters
> were mostly
Hi Sebastian,
Sorry for missing this one. If it helps in the future, feel free to ping me
directly.
> +2018-01-09 Sebastian Perta
> +
> + *config/rx.md: updated "movsicc" expand to be matched by GCC
> + *testsuite/gcc.target/rx/movsicc.c: new test case
Approved - please apply.
Ch
Hi Sebastian,
> +2018-01-05 Sebastian Perta
> +
> + * config/rx/constraints.md: added new constraint
> CALL_OP_SYMBOL_REF
> + to allow or block "symbol_ref" depending on value of TARGET_JSR
> + * config/rx/rx.md: use CALL_OP_SYMBOL_REF in call_internal and
> + call_value_interna
decided to leave it for now. Fixing them
will require mucking about in the C preprocessor library, which
I did not fancy doing at the moment.
So, is this enhanced patch OK now ?
Cheers
Nick
gcc/ChangeLog
2018-02-07 Nick Clifton
PR 84195
* tree.c (warn_deprecated_use): Replace
Hi David,
>> + /* PR 84195: Replace control characters in the message with their
>> + escaped equivalents. Allow newlines if -fmessage-length has
>> + been set to a non-zero value.
>
> I'm not quite sure why we allow newlines in this case, sorry.
Because the documentation
Nick
gcc/ChangeLog
2018-02-08 Nick Clifton
* config/rs6000/rs6000.c (rs6000_option_override_internal):
In LTO mode prefer function attributes over command line -mcpu
setting.
Index: gcc/config/rs6000/rs6000.c
Hi Segher,
> I thought you were going to do a patch like the following, to make the
> e500 cores less special (they are not):
Sorry - my bad. I defer to your patch then. Whatever it takes to get
the BZ fixed and off the books... :-)
Cheers
Nick
oor C++ coding - it is not my strong point. I am
an assembler level programmer at heart).
Cheers
Nick
gcc/ChangeLog
2018-02-09 Nick Clifton
PR 84195
* tree.c (escaped_string): New class. Converts an unescaped
string into its escaped equivalent.
(warn_deprecate
Hi Oleg,
> OK for trunk?
> gcc/ChangeLog:
>
> PR target/83831
> * config/rx/rx-protos.h (rx_reg_dead_or_unused_after_insn,
> rx_copy_reg_dead_or_unused_notes, rx_fuse_in_memory_bitop): New
> declarations.
> (set_of_reg): New struct.
> (rx_find_set_of_reg, rx_f
Hi David,
Attached is a revised version of the patch which I hope addresses all
of your (very helpful) comments on the v3 patch.
OK to apply once the sources are back on stage 1 ?
Cheers
Nick
gcc/ChangeLog
2018-02-09 Nick Clifton
PR 84195
* tree.c (escaped_string
Hi Martin,
> Since the class manages a resource it should ideally make sure it
> doesn't try to release the same resource multiple times. I.e., its
> copy constructor and assignment operators should either "do the right
> thing" (whatever you think that is) or be made inaccessible (or declared
Hi Cary, Hi Sriraman,
>> Ping. Is this alright to apply now or should I wait for Stage 1?
>>
>> * plugin-api.h (ld_plugin_get_wrap_symbols): New
>> plugin interface.
>
> I'd say go ahead and apply the patch in binutils, and wait for Stage 1
> to sync back to GCC, unless someone there OKs it so
Hi Oleg,
> Ping.
Sorry - I am not very good at spotting RX bugs on the gcc-patches list. :-(
>> gcc/ChangeLog:
>> * config/rx/rx.c (rx_rtx_costs): New function.
>> (TARGET_RTX_COSTS): Override to use rx_rtx_costs.
Approved - please apply.
Cheers
Nick
1 - 100 of 469 matches
Mail list logo
