Re: [PATCH] libgomp: Update SVE tests

2025-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2025 at 05:13:12PM +0530, Tejas Belagod wrote: > Thanks for the explanation. I looked into why some of the tests may have > failed - my flawed understanding of the reduction clause was why I didn't > have the += in the loops - it might have passed for me as I probably hit the > exa

[Fortran, Patch, Teams, 5/5] Add teams support in image_index and num_images for F2018

2025-04-10 Thread Andre Vehreschild
Hi all, attached patch reworks the NUM_IMAGES() implementation to adhere to the Fortran 2018 standard. Regtests ok on x86_64-pc-linux-gnu / F41. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From 1d0262dc068f4c6018d669a88387dbb7baaff39a Mon Sep 17 00:0

[Fortran, Patch, Teams, 0/5] Improve on Fortran 2018 teams support

2025-04-10 Thread Andre Vehreschild
Hi all, I again have a series of patches. This time to improve the teams support in gfortran. 1/5: Improves/Unifies handling of STAT= and ERRMSG= handling, which is part of all TEAM statements. I wanted to prevent repeating myself over and over so I factored this out (DRY principle). Because the

[Fortran, Patch, Team, 2/5] Improve F2018 TEAM handling [PR87326, PR87556, PR88254, PR103896]

2025-04-10 Thread Andre Vehreschild
Hi all, attached patch reworks (FORM|CHANGE|END|SYNC) TEAM to implement the Fortran 2018 as much as possible. This work has been done in sync with enhancing the OpenCoarrays library. Because CHANGE TEAM has an association list very similar to ASSOCIATE, the common code has been factored out to imp

[PATCH] riscv: Fix incorrect gnu property alignment on rv32

2025-04-10 Thread Jesse Huang
Codegen is incorrectly emitting a ".p2align 3" that coerces the alignment of the .note.gnu.property section from 4 to 8 on rv32. --- gcc/config/riscv/riscv.cc | 2 +- gcc/testsuite/gcc.target/riscv/gnu-property-rv32.c | 12 gcc/testsuite/gcc.target/riscv/gnu-

[pushed] Darwin: Add spec substitution for static-libgcobol.

2025-04-10 Thread Iain Sandoe
Tested on x86_64 Darwin, Linux, pushed to trunk, thanks Iain --- 8< --- This just follows the common pattern used for other runtime libs. gcc/ChangeLog: * config/darwin.h (LINK_SPEC): Add support for -static-libgcobol. Signed-off-by: Iain Sandoe --- gcc/config/darwin.h | 1 +

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Hans-Peter Nilsson
> From: Christophe Lyon > Date: Thu, 10 Apr 2025 15:21:23 +0200 Not sure why I'm CC:ed on this one, not being a maintainer of the testsuite or targets where gcov tests are exercised, but FWIW: LGTM except for the two nits: > ping? > > On Tue, 1 Apr 2025 at 22:37, Christophe Lyon > wrote: > >

Re: [PATCH] libgomp: Update SVE tests

2025-04-10 Thread Richard Sandiford
Tejas Belagod writes: > On 4/10/25 5:13 PM, Tejas Belagod wrote: >> On 4/9/25 4:13 PM, Jakub Jelinek wrote: >>> On Wed, Apr 09, 2025 at 04:01:49PM +0530, Tejas Belagod wrote: > It also looks like there might be a missing "+" in simd_reduction: > >     #pragma omp simd reduction (+:va,

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Christophe Lyon
ping? On Tue, 1 Apr 2025 at 22:37, Christophe Lyon wrote: > > After commit r15-8947-g8ed2d5d219e999, which added new tests using > gcov, the CI noticed failures because it was calling 'gcov' instead of > $target-gcov. > > This is because the CI scripts override GXX_UNDER_TEST, but still run > the

Re: [PATCH] riscv: Fix incorrect gnu property alignment on rv32

2025-04-10 Thread Kito Cheng
On Thu, Apr 10, 2025 at 9:12 PM Jesse Huang wrote: > > Codegen is incorrectly emitting a ".p2align 3" that coerces the > alignment of the .note.gnu.property section from 4 to 8 on rv32. > --- > gcc/config/riscv/riscv.cc | 2 +- > gcc/testsuite/gcc.target/riscv/gnu-proper

[PATCH 1/3][stage1] Remove --param vect-force-slp

2025-04-10 Thread Richard Biener
The following removes the ability to switch back to non SLP-only operation of the vectorizer - a requirement to start cleaning out non-SLP paths without risk of regressing that case. * params.opt (--param=vect-force-slp): Remove. * doc/invoke.texi (--param=vect-force-slp): Likewise

Re: Questions on replacing a structure pointer reference to a call to .ACCESS_WITH_SIZE in C FE

2025-04-10 Thread Siddhesh Poyarekar
On 2025-04-10 07:48, Martin Uecker wrote: For the currently implemented subset, updates to the storage of the annotated FAM and updates to its counted_by size need to be coupled to prevent reordering because their relationship is otherwise implicit. This proposed feature would need the counted_b

Re: [PATCH] Makefile.tpl: Implement per-stage GDCFLAGS [PR116975]

2025-04-10 Thread Sam James
Iain Buclaw writes: > Hi, > > This patch implements STAGE1_GDCFLAGS and others to the configure > machinery, allowing the GDCFLAGS for each bootstrap stage of building > gdc to be overriden, as is the case with CXXFLAGS for other front-ends. > > This is limited to just the generation of recipes f

[pushed] c++: lambda in constraint of lambda [PR119175]

2025-04-10 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- Here when we went to mangle the constraints of from<0>, the outer lambda has no mangling scope, but the inner one was treated as having the outer one as its scope. And mangling the outer one means mangling its constraints, which include the

[PATCH 3/3][stage1] Prune non-SLP paths from vectorizer loop analysis

2025-04-10 Thread Richard Biener
The following prunes non-SLP iteration and the parts of non-SLP stmt analysis that is no longer necessary - we need to keep the parts that bail on stmts not covered by SLP discovery or that failed SLP discovery. This will only go away when a we can build a fully covering single-lane SLP graph to f

[PATCH 2/3][stage1] Remove non-SLP vector loop transform

2025-04-10 Thread Richard Biener
The following removes the stmt-based vectorization loop transform code. This also removes some debug stmt handling (that looked incomplete) which is also handled during peeling, and special-casing some stmts that should be killed off early and not left to DCE. Moving of dump from vect_transform_lo

[committed] cobol: New testcases for reference modification.

2025-04-10 Thread Robert Dubner
cobol: New testcases for reference modification. gcc/testsuite * cobol.dg/group2/Dynamic_reference_modification.cob: New testcase. * cobol.dg/group2/Length_overflow__1_.cob: Likewise. * cobol.dg/group2/Length_overflow__2_.cob: Likewise. * co

Re: [PATCH] libgomp: Update SVE tests

2025-04-10 Thread Tejas Belagod
On 4/10/25 5:56 PM, Richard Sandiford wrote: Tejas Belagod writes: On 4/10/25 5:13 PM, Tejas Belagod wrote: On 4/9/25 4:13 PM, Jakub Jelinek wrote: On Wed, Apr 09, 2025 at 04:01:49PM +0530, Tejas Belagod wrote: It also looks like there might be a missing "+" in simd_reduction:     #pragma

[pushed] Darwin, libgcobol: Enable for x86_64 Darwin.

2025-04-10 Thread Iain Sandoe
Tested on x86_64 Darwin, Linux, pushed to trunk, thanks Iain --- 8< --- Now that we have libquadmath support, we can enable for x86_64, at least. libgcobol/ChangeLog: * configure.tgt: Enable for x86_64 Darwin. Signed-off-by: Iain Sandoe --- libgcobol/configure.tgt | 2 +- 1 file chan

Re: [PATCH v3 00/19] FMV refactor and ACLE compliance.

2025-04-10 Thread Alfie Richards
Hello, I have another revision of this coming as I discovered some issues at higher optimisation levels and have found a bunch of nits. Kind regards, Alfie On 27/03/2025 15:45, Alfie Richards wrote: Hi All, This is an update on the patch series enabling ACLE compliant FMV behaviour for targ

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Christophe Lyon
On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > Not sure why I'm CC:ed on this one, not being a maintainer > of the testsuite or targets where gcov tests are exercised, Because you fixed a problem in r13-4103-ge91d

[Fortran, Patch, Team, 3/5] Update get_team, team_number and image_status to F2018 [PR88154, PR88960, PR97210, PR103001]

2025-04-10 Thread Andre Vehreschild
Hi all, attached patch reworks GET_TEAM(), TEAM_NUMBER() and IMAGE_STATUS() to adhere to the Fortran 2018 as much as possible and to play nicely with the previous patch of the TEAM statements. Regtests ok on x86_64-pc-linux-gnu / F41. Ok for mainline? Regards, Andre -- Andre Vehreschild

[PATCH] [PR119706] aarch64: Add test case.

2025-04-10 Thread Jennifer Schmitz
This patch adds a test case to the testsuite for PR119706. The bug was already fixed by https://gcc.gnu.org/pipermail/gcc-patches/2025-April/680573.html. OK for mainline? Signed-off-by: Jennifer Schmitz gcc/testsuite/ PR tree-optimization/119706 * g++.target/aarch64/sve/pr119706

Re: .ACCESS_WITH_SIZE and pointer ranges

2025-04-10 Thread Siddhesh Poyarekar
On 2025-04-10 11:12, Martin Uecker wrote: range-ops is setup to pull range information from builtin functions already in gimple-range-op.cc:: gimple_range_op_handler::maybe_builtin_call ().  We'd just need to write a handler for this new one.  You can pull information from 2 operands under normal

Re: [PATCH v1 3/4] libstdc++: Implement std::extents [PR107761].

2025-04-10 Thread Luc Grosheintz
On 4/9/25 9:23 AM, Luc Grosheintz wrote: This implements std::extents from according to N4950 and contains partial progress towards PR107761. If an extent changes its type, there's a precondition in the standard, that the value is representable in the target integer type. This commit uses a

[committed] libstdc++: Adjust value of __cpp_lib_constrained_equality for C++20

2025-04-10 Thread Jonathan Wakely
The P3379R0 bump to __cpp_lib_constrained_equality relates to changes that only affect std::expected, so there's no reason to define the updated value in C++20. This change restores the previous value (202403) for C++20, and only uses the new value (202411) for C++23 and later. Also remove the TO

[PATCH] libstdc++: Use constexpr-if for std::basic_string::_S_copy_chars

2025-04-10 Thread Jonathan Wakely
For C++11 and later we can remvoe four overloads of _S_copy_chars and use constexpr-if in the generic _S_copy_chars. This simplifies overload resolution for _S_copy_chars, and also means that we optimize for other iterators such as std::vector::iterator. We still need all the _S_copy_chars overloa

Re: [PATCH v4] libstdc++: Implement debug format for strings and characters formatters [PR109162]

2025-04-10 Thread Jonathan Wakely
On 10/04/25 11:24 +0200, Tomasz Kamiński wrote: This patch implements part P2286R8 that specified debug (escaped) format for the strings and characters sequences. This include both handling of the '?' format specifier and set_debug_format member. To indicate partial support we define __glibcxx_f

RE: [committed] cobol: Proper comparison of alphanumeric to refmoded numeric-display [PR119682]

2025-04-10 Thread Robert Dubner
I just pushed another eleven testcases, one of which is inspired by the original PR. > -Original Message- > From: Richard Biener > Sent: Thursday, April 10, 2025 01:14 > To: Robert Dubner > Cc: Patches GCC > Subject: Re: [committed] cobol: Proper comparison of alphanumeric to > refmode

Re: [PATCH] c++: alias_ctad_tweaks ICE w/ inherited CTAD [PR119687]

2025-04-10 Thread Jason Merrill
On 4/9/25 11:11 AM, Patrick Palka wrote: Bootstrap and regtest running on x86_64-pc-linux-gnu, does this look OK for trunk/14 if successful? OK. On a similar note, as a small optimization in deduction_guides_for I think we can replace the lookup_add loop with a single call to lookup_add, but

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Hans-Peter Nilsson
> From: Christophe Lyon > Date: Thu, 10 Apr 2025 15:38:48 +0200 > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > > > From: Christophe Lyon > > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > > > Not sure why I'm CC:ed on this one, not being a maintainer > > of the testsuite or target

[Fortran, Patch, Team, 4/5] Add team-support to this_image [PR87326]

2025-04-10 Thread Andre Vehreschild
Hi all, attached patch reworks the implementation of THIS_IMAGE() to adhere as much as possible to the Fortran 2018 standard. Regtests ok on x86_64-pc-linux-gnu / F41. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de From c6da27813d7a7622cae2663af7e25d21e

[PATCH] testsuite: arm: rename arm_v8_1_lob_ok into arm_v8_1_lob_hw

2025-04-10 Thread Christophe Lyon
All arm effective-targets using check_runtime use the "_hw" or "_multilib" suffix, so rename arm_v8_1_lob_ok into arm_v8_1_lob_hw for consistency. gcc/testsuite/ChangeLog * lib/target-supports.exp: Rename arm_v8_1_lob_ok into arm_v8_1_lob_hw. * gcc.target/arm/lob1.c: Likew

[PATCH] c++/modules: More fixes for merging DECL_MAYBE_DELETED functions

2025-04-10 Thread Nathaniel Shead
Regression raised with my by private correspondance. Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? -- >8 -- My change in r15-9216 broke the case where we imported an uninstantiated defaulted function over the top of one we had already finished. This patch ensures that we don't

Re: .ACCESS_WITH_SIZE and pointer ranges

2025-04-10 Thread Andrew MacLeod
On 4/8/25 13:13, Siddhesh Poyarekar wrote: On 2025-04-08 12:41, Qing Zhao wrote: For the following small example: [ counted_by_whole]$ cat t.c #include #include struct annotated {    size_t count;    char other;    char array[] __attribute__((counted_by (count))); }; #define MAX(A, B) (A

Re: .ACCESS_WITH_SIZE and pointer ranges

2025-04-10 Thread Siddhesh Poyarekar
On 2025-04-10 10:50, Andrew MacLeod wrote: Its not clear to me exactly what is being asked, but I think the suggestion is that pointer references are being replaced with a builtin function called .ACCESS_WITH_SIZE ?    and I presume that builtin function has some parameters that give you releva

Re: [PATCH] c++/modules: More fixes for merging DECL_MAYBE_DELETED functions

2025-04-10 Thread Jason Merrill
On 4/10/25 8:46 AM, Nathaniel Shead wrote: Regression raised with my by private correspondance. Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? -- >8 -- My change in r15-9216 broke the case where we imported an uninstantiated defaulted function over the top of one we had alread

[PATCH] libstdc++: Fix atomic CAS hang with C++11 [PR114865]

2025-04-10 Thread Jonathan Wakely
The std::atomic constructor clears padding bits so that compare_exchange will not fail due to differences in padding bits. But we can only do that for C++14 and later, because in C++11 a constexpr constructor must have an empty body. However, the code in compare_exchange_strong assumes that padding

Re: [PATCH] c++: Use G_ instead of _ around cp/errors.cc gcc-internal-format strings [PR119684]

2025-04-10 Thread Jason Merrill
On 4/9/25 3:16 PM, Jakub Jelinek wrote: Hi! These pp_printf/pp_verbatim format strings should be gcc-internal-format, they use the pretty-print.cc format specifier handling rather than libc *printf, but pp_printf/pp_verbatim are intentionally not handled through exgettext because not everything

Re: .ACCESS_WITH_SIZE and pointer ranges

2025-04-10 Thread Martin Uecker
Am Donnerstag, dem 10.04.2025 um 10:55 -0400 schrieb Siddhesh Poyarekar: > On 2025-04-10 10:50, Andrew MacLeod wrote: > > Its not clear to me exactly what is being asked, but I think the > > suggestion is that pointer references are being replaced with a builtin > > function called .ACCESS_WITH_S

Re: [PATCH GCC 15] c++: ICE with nested default targ lambdas [PR119574]

2025-04-10 Thread Jason Merrill
On 4/8/25 10:29 AM, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? OK. -- >8 -- Here we substitute into the inner lambda twice, first during default argument substitution for the outer template parameters, then during that for the inner t

[PATCH] libgcobol, v2: Handle long double as an alternate IEEE754 128b

2025-04-10 Thread Jakub Jelinek
On Wed, Apr 09, 2025 at 02:22:16PM +0200, Rainer Orth wrote: > > Here is what I'm testing as an incremental fix, so far OK on x86_64-darwin > > and powerpcle64 (GLIBC 2.34) .. others in progress. Does it help the > > Solaris cases? > > I'll give it a try. Here's what I have (I believe it's more

[PATCH v2] libstdc++: Implement C++26 features (P2546R5)

2025-04-10 Thread Jonathan Wakely
It would be good to provide a macOS definition of is_debugger_present as per https://developer.apple.com/library/archive/qa/qa1361/_index.html but that isn't included in this change. libstdc++-v3/ChangeLog: * config.h.in: Regenerate. * configure: Regenerate. * configure.ac

[committed] RISC-V: Include local riscv_vector.h in testsuite

2025-04-10 Thread Kito Cheng
That could prevent us including stdint.h from glibc, and that will cause problem when the corresponding multilib isn't built. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/abi-callee-saved-1-fixed-1.c: Include local riscv_vector.h. * gcc.target/riscv/rvv/base/abi-ca

[committed] RISC-V: Fix the behavior for multilib-generator with --cmodel=large on rv32

2025-04-10 Thread Kito Cheng
Large code model is only supported on RV64, so we don't need to generate the multilibs for RV32 with --cmodel=large. And the compact code model is something we don't supported on upstream (which is accidentally added in the past), so we need to remove it. gcc/ChangeLog: * config/riscv/mul

[PATCH] Avoid using POINTER_DIFF_EXPR for overlap checks [PR119399]

2025-04-10 Thread Richard Sandiford
In r10-4803-g8489e1f45b50600c I'd used POINTER_DIFF_EXPR to subtract the two pointers involved in an overlap test. I'm not sure whether I'd specifically chosen that over MINUS_EXPR or not; if so, the only reason I can think of is that it is probably faster on targets with PSImode pointers. Regard

Re: [PATCH v1 1/4] libstdc++: Setup internal FTM for mdspan.

2025-04-10 Thread Tomasz Kaminski
On Wed, Apr 9, 2025 at 9:30 AM Luc Grosheintz wrote: > Uses the FTM infrastructure to create an internal feature testing macro > for partial availability of mdspan; which is then used to hide the > contents of the header mdspan when compiling against a standard prior to > C++23. > > libstdc++-v3/

[PATCH] middle-end/119706 - allow POLY_INT_CST as is_gimple_mem_ref_addr

2025-04-10 Thread Richard Biener
We currently only INTEGER_CST, but not POLY_INT_CST, which leads to the situation that when the POLY_INT_CST is only indrectly present via a SSA def the IL is valid but when propagated it's not. That's unsustainable. Bootstrap and regtest running on x86_64-unknown-linux-gnu, will push after that s

Re: Questions on replacing a structure pointer reference to a call to .ACCESS_WITH_SIZE in C FE

2025-04-10 Thread Martin Uecker
Am Donnerstag, dem 10.04.2025 um 06:56 -0400 schrieb Siddhesh Poyarekar: > On 2025-04-10 01:41, Martin Uecker wrote: > > I have some questions about this: The access would add new reads > > to the size field. For counted_by, so far, those are somehow > > coupled to the access to the member. From

Re: [PATCH] libgomp: Update SVE tests

2025-04-10 Thread Tejas Belagod
On 4/10/25 5:13 PM, Tejas Belagod wrote: On 4/9/25 4:13 PM, Jakub Jelinek wrote: On Wed, Apr 09, 2025 at 04:01:49PM +0530, Tejas Belagod wrote: It also looks like there might be a missing "+" in simd_reduction:     #pragma omp simd reduction (+:va, i)     for (j = 0; j < 16; j++)   va = sv

[PATCH v5 2/2] i386: Enable -mnop-mcount for -fpic with PLTs

2025-04-10 Thread Ard Biesheuvel
From: Ard Biesheuvel -mnop-mcount can be trivially enabled for -fPIC codegen as long as PLTs are being used, given that the instruction encodings are identical, only the target may resolve differently depending on how the linker decides to incorporate the object file. So relax the option check,

[PATCH v5 1/2] i386: Prefer PLT indirection for __fentry__ calls under -fPIC

2025-04-10 Thread Ard Biesheuvel
From: Ard Biesheuvel Commit bde21de1205 ("i386: Honour -mdirect-extern-access when calling __fentry__") updated the logic that emits mcount() / __fentry__() calls into function prologues when profiling is enabled, to avoid GOT-based indirect calls when a direct call would suffice. There are two

Re: [PATCH 2/2] libgcobol: Allow libgcobol to use libquadmath [PR119244].

2025-04-10 Thread Jakub Jelinek
On Sun, Apr 06, 2025 at 09:02:07AM +0100, Iain Sandoe wrote: > Many of the changes are mechanical: > 1. 'GCOB_FP128' in place of _Float128. > 2. Using FP128_FUNC to represent the spelling of intrinsics. > 3. Using GCOB_FP128_LITERAL() to choose the suffix for literals. > > This allows for: >

Re: OpenACC: Support GCC/C++-special 'default(_GCC_firstprivate)' clause [PR119692]

2025-04-10 Thread Tobias Burnus
Hi Thomas, Thomas Schwinge wrote: To allow me to progress with other work items, is the attached "OpenACC: Support GCC/C++-special 'default(_GCC_firstprivate)' clause [PR119692]" OK to push to trunk branch, with a few test cases added? I assume this patch has been withdrawn. (Collateral from

Re: [PATCH v4] libstdc++: Implement debug format for strings and characters formatters [PR109162]

2025-04-10 Thread Tomasz Kaminski
On Thu, Apr 10, 2025 at 6:39 PM Jonathan Wakely wrote: > On 10/04/25 11:24 +0200, Tomasz Kamiński wrote: > >This patch implements part P2286R8 that specified debug (escaped) > >format for the strings and characters sequences. This include both > >handling of the '?' format specifier and set_debug

[Fortran, Patch, Teams, 1/5] Unify handling of STAT= and ERRMSG= optional arguments [PR87939]

2025-04-10 Thread Andre Vehreschild
Hi all, this patch unifies handling of STAT= and ERRMSG= for some users of these optional arguments. The first introduction of the arguments seems to stem from SYNC, which choose the rule name sync_stat in the Fortran grammar. Therefore I named the structure and participating routines the same. Th

[PATCH] rtl-optimization/119689 - compare-debug failure with LRA

2025-04-10 Thread Richard Biener
The previous change to fix LRA rematerialization broke compare-debug for i586 bootstrap. Fixed by using prev_nonnote_nondebug_insn instead of prev_nonnote_insn. Bootstrapped on i586-linux where the miscompare is gone with this patch. Bootstrap and regtest running on x86_64-unknown-linux-gnu. OK

Re: [PATCH GCC 15] c++: ICE with nested default targ lambdas [PR119574]

2025-04-10 Thread Jason Merrill
On 4/10/25 12:34 PM, Jason Merrill wrote: On 4/8/25 10:29 AM, Patrick Palka wrote: The template arguments aren't dependent however -- they're just incomplete because when we deferred them we were in the middle deduction, and we consider a NULL_TREE template argument as dependent. I wonder what

Re: Questions on replacing a structure pointer reference to a call to .ACCESS_WITH_SIZE in C FE

2025-04-10 Thread Qing Zhao
Hi, Martin, Thanks a lot for all your comments and questions, really helpful. > On Apr 10, 2025, at 01:41, Martin Uecker wrote: > > Am Mittwoch, dem 09.04.2025 um 18:31 + schrieb Qing Zhao: >> Hi, Joseph and Martin, >> >> When I implemented the patch to attach the counted_by information to

[PATCH] realloc-1.c: accept long long in warning for llp64

2025-04-10 Thread Jonathan Yong
Attached patch OK for master branch? Will push soon if there are no objections. From 075f2ab502ca7291887c1fa75b5351fb0cbad013 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Wed, 9 Apr 2025 14:21:22 + Subject: [PATCH] realloc-1.c: accept long long in warning for llp64 MI

Re: [PATCH] riscv: Fix r15-9270 fallout on RISC-V

2025-04-10 Thread Robin Dapp
Tested with compilation of x86_64-linux -> riscv64-linux cross, ok for trunk? Yes. -- Regards Robin

Re: Questions on replacing a structure pointer reference to a call to .ACCESS_WITH_SIZE in C FE

2025-04-10 Thread Martin Uecker
Am Donnerstag, dem 10.04.2025 um 17:05 + schrieb Qing Zhao: > Hi, Martin, > > Thanks a lot for all your comments and questions, really helpful. > > ... > > > > An example I could imagine is when you memcpy > > the struct. (but it is also not entirely clear why this > > should not be allo

Re: [PATCH] testsuite: arm: rename arm_v8_1_lob_ok into arm_v8_1_lob_hw

2025-04-10 Thread Richard Earnshaw (lists)
On 10/04/2025 14:55, Christophe Lyon wrote: > All arm effective-targets using check_runtime use the "_hw" or > "_multilib" suffix, so rename arm_v8_1_lob_ok into arm_v8_1_lob_hw for > consistency. > > gcc/testsuite/ChangeLog > > * lib/target-supports.exp: Rename arm_v8_1_lob_ok into >

Re: [PATCH] [PR119706] aarch64: Add test case.

2025-04-10 Thread Richard Biener
> Am 10.04.2025 um 17:27 schrieb Jennifer Schmitz : > > This patch adds a test case to the testsuite for PR119706. > The bug was already fixed by > https://gcc.gnu.org/pipermail/gcc-patches/2025-April/680573.html. > > OK for mainline? Ok Richard > Signed-off-by: Jennifer Schmitz > > gc

Re: [PATCH v1 3/4] libstdc++: Implement std::extents [PR107761].

2025-04-10 Thread Tomasz Kaminski
On Wed, Apr 9, 2025 at 9:28 AM Luc Grosheintz wrote: > This implements std::extents from according to N4950 and > contains partial progress towards PR107761. > > If an extent changes its type, there's a precondition in the standard, > that the value is representable in the target integer type. T

Re: [PATCH v2] testcase: Add testcase for shrink wrapping of vector::push_back [PR118502]

2025-04-10 Thread Andrew Pinski
On Sun, Mar 9, 2025 at 1:35 PM Andrew Pinski wrote: > > LLVM folks noticed that GCC was shrink wrapping the call to > vector::push_back. > So I thought it was a good idea to commit a testcase to make sure GCC does > not regress > in this area unknowning. > > Note the shrink wrapping started with

Re: [PATCH v2] aarch64, Darwin: Initial implementation of Apple cores [PR113257].

2025-04-10 Thread Iain Sandoe
> On 7 Apr 2025, at 13:24, Kyrylo Tkachov wrote: > > > >> On 7 Apr 2025, at 10:21, Tamar Christina wrote: >> >>> -Original Message- >>> From: Kyrylo Tkachov >>> Sent: Monday, March 31, 2025 1:43 PM >>> To: i...@sandoe.co.uk >>> Cc: Tamar Christina ; GCC Patches >> patc...@gcc.gnu.o

Re: [Stage1][Middle-end][object-size][PATCH v1] Evaluate the object size by the size of the pointee type

2025-04-10 Thread Qing Zhao
> On Apr 7, 2025, at 22:15, Siddhesh Poyarekar wrote: > > On 2025-04-07 14:53, Qing Zhao wrote: >>> Is there a reason to do this at the very end like this and not in the >>> GIMPLE_ASSIGN case in the switch block? Something like this: >>> >>> tree rhs = gimple_assign_rhs1 (stmt); >>>

[PING][PATCH] doc: Clarify REG_EH_REGION note usage

2025-04-10 Thread Konstantinos Eleftheriou
Hi, Just a ping for https://gcc.gnu.org/pipermail/gcc-patches/2025-March/677635.html. Thanks, Konstantinos

[COMMITTED 10/32] gccrs: feature: Add min_specialization feature

2025-04-10 Thread arthur . cohen
From: Arthur Cohen gcc/rust/ChangeLog: * checks/errors/rust-feature.cc (Feature::create): Handle `#![feature(min_specialization)]`. * checks/errors/rust-feature.h: Likewise. --- gcc/rust/checks/errors/rust-feature.cc | 4 gcc/rust/checks/errors/rust-feature.h | 1 + 2 fil

Re: [PATCH v4 1/2] i386: Prefer PLT indirection for __fentry__ calls under -fPIC

2025-04-10 Thread Ard Biesheuvel
On Wed, 9 Apr 2025 at 16:46, H.J. Lu wrote: > > On Wed, Apr 9, 2025 at 1:53 AM Ard Biesheuvel wrote: > > > > From: Ard Biesheuvel > > > > Commit bde21de1205 ("i386: Honour -mdirect-extern-access when calling > > __fentry__") updated the logic that emits mcount() / __fentry__() calls > > into fun

Re: [PATCH 5/7] ipa-cp: Use the collected pass-through types to propagate constants (PR118097)

2025-04-10 Thread Jan Hubicka
> This patch revisits the fix for PR 118097 and instead of deducing the > necessary operation type it just uses the value collected and streamed > by an earlier patch. > > It is bigger than the ones for propagating value ranges and known bits > because we track constants both in parameters themsel

Re: [PATCH v5 5/5] libgomp: Add AArch64 SVE target tests to libgomp.

2025-04-10 Thread Mark Wielaard
Hi Tejas, On Tue, Apr 08, 2025 at 12:02:12PM +0530, Tejas Belagod wrote: > On 4/7/25 3:33 PM, Jakub Jelinek wrote: > >On Mon, Apr 07, 2025 at 03:28:29PM +0530, Tejas Belagod wrote: > >>Add AArch64 SVE target exectute tests to test various workshare constructs > >>and > >>clauses with SVE types. >

[PATCH v1 4/4] libstdc++: Add tests for std::extents.

2025-04-10 Thread Luc Grosheintz
A prior commit added std::extents, this commits adds the tests. The bulk is focussed on testing the constructors. These are split into three groups: 1. the ctor from other extents and the copy ctor, 2. the ctor from a pack of integer-like objects, 3. the ctor from shapes, i.e. span and array. For

[PATCH] expr: Use constant_lower_bound classifying constructor els [PR116595].

2025-04-10 Thread Robin Dapp
Hi, in categorize_ctor_elements_1 we do VECTOR_CST_NELTS (value).to_constant () but VALUE's type can be a VLA vector (since r15-5780-g17b520a10cdaab). This patch uses constant_lower_bound instead. Bootstrapped and regtested on x86, aarch64, and power 10. Regtested on rv64gcv_zvl512b. Regards

Re: [PATCH v4] libstdc++: Implement debug format for strings and characters formatters [PR109162]

2025-04-10 Thread Jonathan Wakely
On Thu, 10 Apr 2025 at 18:53, Tomasz Kaminski wrote: > > > > On Thu, Apr 10, 2025 at 6:39 PM Jonathan Wakely wrote: >> What happened to the changes to bits/version.def and bits/version.h ? >> >> I thought you were going to change version.def to use no_stdname but >> now it's not in the patch at a

[PING][PATCH v3] reassoc: Optimize CMP/XOR expressions [PR116860]

2025-04-10 Thread Konstantinos Eleftheriou
Hi, Just a ping for https://gcc.gnu.org/pipermail/gcc-patches/2025-March/677788.html . Thanks, Konstantinos

[PATCH] Add std::deque shrink_to_fit test

2025-04-10 Thread François Dumont
Hi     No problem detected now that we really test std::deque shrink_to_fit implementation.     libstdc++: Add std::deque<>::shrink_to_fit test     The existing test is currently testing std::vector. Make it test std::deque.     libstdc++-v3/ChangeLog:     * testsuite/23_container

[COMMITTED 24/32] gccrs: Fix unresolved label error message

2025-04-10 Thread arthur . cohen
From: Pierre-Emmanuel Patry gcc/rust/ChangeLog: * resolve/rust-ast-resolve-expr.cc (ResolveExpr::visit): Change error message to match rustc. gcc/testsuite/ChangeLog: * rust/compile/undeclared_label.rs: Change test expected string. Signed-off-by: Pierre-Emmanue

Re: [PATCH] libgomp: Update SVE tests

2025-04-10 Thread Tejas Belagod
On 4/9/25 4:13 PM, Jakub Jelinek wrote: On Wed, Apr 09, 2025 at 04:01:49PM +0530, Tejas Belagod wrote: It also looks like there might be a missing "+" in simd_reduction: #pragma omp simd reduction (+:va, i) for (j = 0; j < 16; j++) va = svld1_s32 (svptrue_b32 (), a); res = sv

Re: [PATCH] libgcobol, v2: Handle long double as an alternate IEEE754 128b

2025-04-10 Thread Iain Sandoe
> On 10 Apr 2025, at 17:36, Jakub Jelinek wrote: > > On Wed, Apr 09, 2025 at 02:22:16PM +0200, Rainer Orth wrote: >>> Here is what I'm testing as an incremental fix, so far OK on x86_64-darwin >>> and powerpcle64 (GLIBC 2.34) .. others in progress. Does it help the >>> Solaris cases? >> >> I

Re: Questions on replacing a structure pointer reference to a call to .ACCESS_WITH_SIZE in C FE

2025-04-10 Thread Qing Zhao
> On Apr 10, 2025, at 13:43, Martin Uecker wrote: > > Am Donnerstag, dem 10.04.2025 um 17:05 + schrieb Qing Zhao: >> Hi, Martin, >> >> Thanks a lot for all your comments and questions, really helpful. >> >> > > ... >>> >>> An example I could imagine is when you memcpy >>> the struct.

[PATCH] bitintlower: Fix up handling of nested casts in m_upward_2limbs cases [PR119707]

2025-04-10 Thread Jakub Jelinek
Hi! The following testcase is miscompiled I believe starting with PR112941 r14-6742. That commit fixed the bitint-55.c testcase. The m_first initialization for such conversion initializes 2 SSA_NAMEs, one is PHI result on the loop (m_data[save_data_cnt]) and the other (m_data[save_data_cnt+1]) is

[COMMITTED htdocs] gcc-3.2/changes: fix 'several' typo

2025-04-10 Thread Sam James
--- Pushed. htdocs/gcc-3.2/changes.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-3.2/changes.html b/htdocs/gcc-3.2/changes.html index 7b9ea63f..4ab9fdce 100644 --- a/htdocs/gcc-3.2/changes.html +++ b/htdocs/gcc-3.2/changes.html @@ -59,7 +59,7 @@ C++ -

[committed] d: Fix infinite loop in isAliasThisTuple

2025-04-10 Thread Iain Buclaw
Hi, This reverts a change in the upstream D implementation of the compiler, as the refactoring introduced a regression. Bootstrapped and regression tested on x86_64-linux-gnu/-m32, and committed to mainline. Regards, Iain. --- gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd 51816cd01d

[PATCH] sanitizer: Store no_sanitize attribute value in uint32 instead of unsigned

2025-04-10 Thread Keith Packard
A target using 16-bit ints won't have enough bits to hold the whole flag_sanitize set. Be explicit about using uint32 for the attribute data. Signed-off-by: Keith Packard --- gcc/c-family/c-attribs.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/c-family/c-attribs.

Re: [PATCH] Improve [-W..] display for -Wformat

2025-04-10 Thread Sam James
Vishnu Mohandas writes: > Hello, Hi, > The patch below proposes a possible improvement for the issue mentioned in > bug 65445. Although I'm not certain that it > address all the concerns, it does seem to make it better.> Unfortunately, I see a few issues here. There needs to be a ChangeLog en

[COMMITTED] Doc: Discourage the use of -ffloat-store [PR14708]

2025-04-10 Thread Sandra Loosemore
gcc/ChangeLog PR middle-end/14708 * doc/invoke.texi (Optimize Options): List -fexcess-precision before -ffloat-store, moving some background discussion to the former from the latter. Recommend using -fexcess-precision=standard instead of -ffloat-store. ---

Re: [PATCH] realloc-1.c: accept long long in warning for llp64

2025-04-10 Thread Jonathan Yong
On 4/9/25 2:27 PM, Jonathan Yong wrote: Attached patch OK for master branch? Will push soon if there are no objections. Pushed to master branch.

Re: [PATCH] bf-ms-attrib.c: Fix expected struct size

2025-04-10 Thread Jonathan Yong
On 4/9/25 2:35 PM, Jonathan Yong wrote: Attached patch OK for master branch? Gcc produced struct sizes match those of MSVC when __ms_struct__ is used, both producing a layout size of 12. Will push soon if there are no objections. Pushed to master branch.

[PATCH v2] riscv: Fix incorrect gnu property alignment on rv32

2025-04-10 Thread Jesse Huang
Codegen is incorrectly emitting a ".p2align 3" that coerces the alignment of the .note.gnu.property section from 4 to 8 on rv32. 2025-04-11 Jesse Huang gcc/ChangeLog * config/riscv/riscv.cc (riscv_file_end): Fix .p2align value. gcc/testsuite/ChangeLog * gcc.target/riscv/gnu-

[COMMITTED 04/32] gccrs: Fix ICE when resolving lifetimes without name

2025-04-10 Thread arthur . cohen
From: Philip Herron We dont need to assert here the lifetime code already supports this case. Fixes Rust-GCC#3657 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-base.cc: remove assertion gcc/testsuite/ChangeLog: * rust/compile/issue-3657.rs: New test. Signed-off-by: Phi

[COMMITTED] Doc: Add missing documentation for -ftree-cselim [PR87909]

2025-04-10 Thread Sandra Loosemore
gcc/ChangeLog PR tree-optimization/87909 * common.opt.urls: Regenerate. * doc/invoke.texi (Option Summary): Add -ftree-cselim. (Optimize Options): Likewise. --- gcc/common.opt.urls | 3 +++ gcc/doc/invoke.texi | 10 -- 2 files changed, 11 insertions(+), 2 d

Re: [PATCH] Add std::deque shrink_to_fit test

2025-04-10 Thread Tomasz Kaminski
On Thu, Apr 10, 2025 at 10:47 PM Jonathan Wakely wrote: > On 10/04/25 22:36 +0200, François Dumont wrote: > >After running the test with -fno-exceptions option we rather need this > >patch. > > > >Ok to commit ? > > > >François > > > > > >On 10/04/2025 21:08, François Dumont wrote: > >>Hi > >> >

Re: [PATCH] libstdc++: Add P1206R7 from_range members to std::string [PR111055]

2025-04-10 Thread Tomasz Kaminski
On Fri, Apr 11, 2025 at 1:32 AM Jonathan Wakely wrote: > This is the last piece of P1206R7, adding new members to > std::basic_string. > > libstdc++-v3/ChangeLog: > > PR libstdc++/111055 > * include/bits/basic_string.h (_S_copy_range): New function. > (basic_string(from_ra

Re: [PATCH] aarch64: Fix CFA offsets in non-initial stack probes [PR119610]

2025-04-10 Thread Richard Biener
On Thu, Apr 10, 2025 at 10:10 PM Richard Sandiford wrote: > > PR119610 is about incorrect CFI output for a stack probe when that > probe is not the initial allocation. The main aarch64 stack probe > function, aarch64_allocate_and_probe_stack_space, implicitly assumed > that the incoming stack poi

[PATCH] Improve [-W..] display for -Wformat

2025-04-10 Thread Vishnu Mohandas
Hello, The patch below proposes a possible improvement for the issue mentioned in bug 65445. Although I'm not certain that it address all the concerns, it does seem to make it better. Bootstrapped on x86_64 Linux. Thanks, Vishnu 1 │ diff --git a/gcc/opt-functions.awk b/gcc/opt-functions.awk

[PATCH] dwarf2out: Decrease dw_loc_descr_node and dw_attr_struct struct sizes [PR119711]

2025-04-10 Thread Jakub Jelinek
Hi! As noted by Richi on a large testcase, there are unnecessary paddings in some heavily used dwarf2out.{h,cc} structures on 64-bit hosts. struct dw_val_node { enum dw_val_class val_class;/* 0 4 */ /* XXX 4 bytes hole, try to pack */ struct

[COMMITTED 21/32] gccrs: Remove unused error constructor and getter

2025-04-10 Thread arthur . cohen
From: Pierre-Emmanuel Patry These constructor for eroneous state are not in use anymore since we replaced this error state with an optional in the parent nodes. gcc/rust/ChangeLog: * ast/rust-expr.h: Remove error getter and constructor. Signed-off-by: Pierre-Emmanuel Patry --- gcc/ru

Re: [PATCH 2/2] libgcobol: Allow libgcobol to use libquadmath [PR119244].

2025-04-10 Thread Rainer Orth
Jakub Jelinek writes: > On Sun, Apr 06, 2025 at 09:02:07AM +0100, Iain Sandoe wrote: >> >> + >> +#if !defined (HAVE_STRTOF128) >> +# if USE_QUADMATH >> +# define strtof128 strtoflt128 >> +# else >> +# error "no available string to float 128" >> +# endif >> +#endif > > If there is no strtof128

  1   2   >