> From: Christophe Lyon <christophe.l...@linaro.org>
> Date: Thu, 10 Apr 2025 15:21:23 +0200
Not sure why I'm CC:ed on this one, not being a maintainer
of the testsuite or targets where gcov tests are exercised,
but FWIW: LGTM except for the two nits:
> ping?
>
> On Tue, 1 Apr 2025 at 22:37, Christophe Lyon <christophe.l...@linaro.org>
> wrote:
> > diff --git a/gcc/testsuite/g++.dg/gcov/gcov.exp
> > b/gcc/testsuite/g++.dg/gcov/gcov.exp
> > index 50f60c4a011..d85bf125d16 100644
> > --- a/gcc/testsuite/g++.dg/gcov/gcov.exp
> > +++ b/gcc/testsuite/g++.dg/gcov/gcov.exp
> > @@ -21,12 +21,19 @@ load_lib g++-dg.exp
> > load_lib gcov.exp
> >
> > global GXX_UNDER_TEST
> > +global GCOV_UNDER_TEST
> >
> > -# Find gcov in the same directory as $GXX_UNDER_TEST.
> > -if { ![is_remote host] && [string match "*/*" [lindex $GXX_UNDER_TEST 0]]
> > } {
> > - set GCOV [file dirname [lindex $GXX_UNDER_TEST
> > 0]]/[gcc-transform-out-of-tree gcov]
> > +# Find gcov in the same directory as $GXX_UNDER_TEST. under
> > +# GCOV_UNDER_TEST is defined.
Cutnpasto; s/. under/, unless/?
> > diff --git a/gcc/testsuite/gnat.dg/gcov/gcov.exp
> > b/gcc/testsuite/gnat.dg/gcov/gcov.exp
> > index 4fa887d5bad..d5977a85e8a 100644
> > --- a/gcc/testsuite/gnat.dg/gcov/gcov.exp
> > +++ b/gcc/testsuite/gnat.dg/gcov/gcov.exp
> > +# GCOV_UNDER_TEST is defined..
Extra ".".
brgds, H-p
