Re: [PATCH 0/2] Add tests to verify OpenACC clause locations

2020-11-03 Thread Thomas Schwinge
Hi! On 2019-12-10T15:23:01+0100, Frederik Harwath wrote: > On 09.12.19 16:58, Harwath, Frederik wrote: >> [use] the location of clauses in warnings instead of the location of the >> loop to which the clause belongs. > Frederik Harwath (2): > Use clause locations in OpenACC nested reduction wa

Re: [PATCH] libstdc++: use lt_host_flags for libstdc++.la

2020-11-03 Thread Jonathan Wakely via Gcc-patches
On 16/09/20 13:16 +, JonY via Libstdc++ wrote: For platforms like Mingw and Cygwin, cygwin refuses to generate the shared library without using -no-undefined. Attached patch makes sure the right flags are used, since libtool is already used to link libstdc++. Patch OK? I've pushed it to t

[patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Olivier Hainque
Hello, This change is a proposal to add /* { dg-require-effective-target fpic } */ to tests in gcc.target/i386 that do use -fpic or -fPIC but don't currently query the target support. This corresponds to what many other fpic tests do and helps the vxWorks ports at least, as -fpic is typicall

Re: [PATCH] Add missing gnu-versioned-namespace symbols

2020-11-03 Thread Jonathan Wakely via Gcc-patches
On 02/11/20 21:52 +0100, François Dumont via Libstdc++ wrote: On 02/11/20 3:17 pm, Jonathan Wakely wrote: On 01/11/20 20:48 +0100, François Dumont via Libstdc++ wrote: Several tests are failing because of those missing symbols. I understand why we need to export symbols relying in the ver

Re: [PATCH] Fix column information for omp_clauses in Fortran code

2020-11-03 Thread Thomas Schwinge
Hi! On 2019-12-09T16:58:44+0100, "Harwath, Frederik" wrote: > Tobias has recently fixed a problem with the column information in gfortran > locations > ("PR 92793 - fix column used for error diagnostic"). In context of: > [use] the location of clauses in warnings instead of the location of t

Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Jakub Jelinek via Gcc-patches
On Tue, Nov 03, 2020 at 09:25:03AM +0100, Olivier Hainque wrote: > Hello, > > This change is a proposal to add > > /* { dg-require-effective-target fpic } */ > > to tests in gcc.target/i386 that do use -fpic or -fPIC > but don't currently query the target support. > > This corresponds to wha

Re: [og8] Report errors on missing OpenACC reduction clauses in nested reductions

2020-11-03 Thread Thomas Schwinge
Hi! On 2018-12-20T15:28:33+0100, I wrote: > On behalf of Gergő (who doesn't have write access yet) I've pushed the > attached to openacc-gcc-8-branch. (Which then eventually got into master branch via Frederik.) > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/goacc/nested-reductions-fail.c >

Re: [Patch, fortran] PR83118 - [8/9/10/11 Regression] Bad intrinsic assignment of class(*) array component of derived type

2020-11-03 Thread Paul Richard Thomas via Gcc-patches
Ping! On Thu, 29 Oct 2020 at 15:59, Paul Richard Thomas < paul.richard.tho...@gmail.com> wrote: > Hi Everyone, > > I am afraid that this is a rather long sad story, mainly due to my efforts > with gfortran being interrupted by daytime work. I posted the first version > of the patch nearly a year

Re: [Patch] Fortran: Add !GCC$ attributes DEPRECATED

2020-11-03 Thread Paul Richard Thomas via Gcc-patches
Hi Tobias, That looks to be the best that can be done with a sensible amount of effort. OK by me. Regards Paul On Mon, 2 Nov 2020 at 19:09, Tobias Burnus wrote: > This adds the Fortran equivalent to __attribute__((deprecated)), > except that "deprecated(message)" is not supported and that on

Re: [og8] Report errors on missing OpenACC reduction clauses in nested reductions

2020-11-03 Thread Thomas Schwinge
Hi! On 2020-11-03T09:39:54+0100, I wrote: > On 2018-12-20T15:28:33+0100, I wrote: >> On behalf of Gergő (who doesn't have write access yet) I've pushed the >> attached to openacc-gcc-8-branch. > > (Which then eventually got into master branch via Frederik.) >> --- /dev/null >> +++ b/gcc/testsuite

[patch] Add dg-require-effective-target fpic to gcc.target/powerpc tests

2020-11-03 Thread Olivier Hainque
Hello, This change is a proposal to add /* { dg-require-effective-target fpic } */ to a few tests in gcc.target/powerpc that do use -fpic or -fPIC but don't currently query the target support. This corresponds to what many other fpic tests do and helps the vxWorks ports at least, as -fpic is

[PATCH] testsuite/97688 - fix check_vect () with __AVX2__

2020-11-03 Thread Richard Biener
This fixes the cpuid check to always specify a subleaf zero which is required to detect AVX2 and doesn't hurt for level one. Without this fix we get zero runtime coverage when -mavx2 is specified. Tested on x86_64-unknown-linux-gnu. 2020-11-03 Richard Biener PR testsuite/97688

Re: [PATCH] Fix PR97205

2020-11-03 Thread Richard Biener
On Mon, 2 Nov 2020, Bernd Edlinger wrote: > On 11/2/20 3:07 PM, Richard Biener wrote: > > On Mon, 2 Nov 2020, Bernd Edlinger wrote: > > > >> Hi, > >> > >> this makes sure that stack allocated SSA_NAMEs are > >> at least MODE_ALIGNED. Also increase the MEM_ALIGN > >> for the corresponding rtl obj

RE: [PATCH] aarch64: Add backend support for expanding __builtin_memset

2020-11-03 Thread Sudakshina Das via Gcc-patches
Hi Richard > -Original Message- > From: Richard Sandiford > Sent: 30 October 2020 19:56 > To: Sudakshina Das > Cc: Wilco Dijkstra ; gcc-patches@gcc.gnu.org; > Kyrylo Tkachov ; Richard Earnshaw > > Subject: Re: [PATCH] aarch64: Add backend support for expanding > __builtin_memset > > >

Re: [patch] lto test: Add dg-require-effective-target lto on test using -flto

2020-11-03 Thread Richard Biener via Gcc-patches
On Mon, Nov 2, 2020 at 6:25 PM Olivier Hainque wrote: > > Hello, > > This patch is a proposal to add a > > /* { dg-require-effective-target lto } */ > > directive to a "dg-do link" test using -flto, to > prevent failure on targets missing LTO support such > as VxWorks for it's "kernel" mode wher

Re: [PATCH] Fix PR97205

2020-11-03 Thread Bernd Edlinger
On 11/3/20 10:34 AM, Richard Biener wrote: > On Mon, 2 Nov 2020, Bernd Edlinger wrote: > >> On 11/2/20 3:07 PM, Richard Biener wrote: >>> On Mon, 2 Nov 2020, Bernd Edlinger wrote: >>> Hi, this makes sure that stack allocated SSA_NAMEs are at least MODE_ALIGNED. Also increas

[PATCH] tree-optimization/97678 - fix SLP induction epilogue vectorization

2020-11-03 Thread Richard Biener
This restores not tracking SLP nodes for induction initial values in not nested context because this interferes with peeling and epilogue vectorization. Boostrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-11-03 Richard Biener PR tree-optimization/97678 * tree-vect

Re: [PATCH] Fix PR97205

2020-11-03 Thread Richard Biener
On Tue, 3 Nov 2020, Bernd Edlinger wrote: > > > On 11/3/20 10:34 AM, Richard Biener wrote: > > On Mon, 2 Nov 2020, Bernd Edlinger wrote: > > > >> On 11/2/20 3:07 PM, Richard Biener wrote: > >>> On Mon, 2 Nov 2020, Bernd Edlinger wrote: > >>> > Hi, > > this makes sure that stack a

Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Olivier Hainque
> On 3 Nov 2020, at 09:30, Jakub Jelinek wrote: > 70% of the tests you've changed have a target *-linux* or similar > right above that line, what is the point of adding the fpic > effective targets to those? Those surely aren't run on vxWorks > and on x86 Linux fpic is always supported. Good

Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Jakub Jelinek via Gcc-patches
On Tue, Nov 03, 2020 at 11:24:24AM +0100, Olivier Hainque wrote: > > > > On 3 Nov 2020, at 09:30, Jakub Jelinek wrote: > > > 70% of the tests you've changed have a target *-linux* or similar > > right above that line, what is the point of adding the fpic > > effective targets to those? Those s

RE: [PATCH 1/x] arm: Add vld1_lane_bf16 + vldq_lane_bf16 intrinsics

2020-11-03 Thread Kyrylo Tkachov via Gcc-patches
Hi Andrea, > -Original Message- > From: Andrea Corallo > Sent: 26 October 2020 15:59 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; nd > Subject: [PATCH 1/x] arm: Add vld1_lane_bf16 + vldq_lane_bf16 intrinsics > > Hi all, > > I'd like to submit the following

RE: [PATCH 2/x] arm: add vst1_lane_bf16 + vstq_lane_bf16 intrinsics

2020-11-03 Thread Kyrylo Tkachov via Gcc-patches
Hi Andrea, > -Original Message- > From: Andrea Corallo > Sent: 26 October 2020 16:02 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; nd > Subject: [PATCH 2/x] arm: add vst1_lane_bf16 + vstq_lane_bf16 intrinsics > > Hi all, > > Second patch of the serie here ad

RE: [PATCH 4/x] arm: Add vst1_bf16 + vst1q_bf16 intrinsics

2020-11-03 Thread Kyrylo Tkachov via Gcc-patches
Hi Andrea, > -Original Message- > From: Andrea Corallo > Sent: 02 November 2020 09:02 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; nd > Subject: [PATCH 4/x] arm: Add vst1_bf16 + vst1q_bf16 intrinsics > > Hi all, > > Forth patch of the serie here adding vst1

Avoid recursion in tree-inline.c

2020-11-03 Thread Jan Hubicka
Hi, this patch avoids recursion in tree-inline.c by producing necessary clones early. This avoids an ICE on overuse of AUX pointer there. Bootstrapped/regtested x86_64-linux, comitted. Honza gcc/ChangeLog: 2020-11-03 Jan Hubicka PR ipa/97578 * ipa-inline-transform.c (maybe_m

Re: [PATCH 4/x] arm: Add vst1_bf16 + vst1q_bf16 intrinsics

2020-11-03 Thread Andrea Corallo via Gcc-patches
Kyrylo Tkachov writes: [...] > I see this patch also has the hunk: > diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c > index 33e8015b140..6dc5df93216 100644 > --- a/gcc/config/arm/arm-builtins.c > +++ b/gcc/config/arm/arm-builtins.c > @@ -946,6 +946,9 @@ typedef struct {

RE: [PATCH 1/5] [PR target/96342] Change field "simdlen" into poly_uint64

2020-11-03 Thread yangyang (ET)
Hi, I have revised the patch based on your suggestions. I use multiple_p instead of !multiple_p if the eq situation is OK to make it easier to understand. > >> > if (n->simdclone->inbranch) > >> > this_badness += 2048; > >> > int target_badness = targetm.simd_clone.usable (n); @@ -

[PATCH] bootstrap/97666 - fix array of bool allocation

2020-11-03 Thread Richard Biener
This fixes the bad assumption that sizeof (bool) == 1 Bootstrap / regtest running on x86_64-unknown-linux-gnu. 2020-11-03 Richard Biener PR bootstrap/97666 * tree-vect-slp.c (vect_build_slp_tree_2): Scale allocation of skip_args by sizeof (bool). --- gcc/tree-vect-slp

RE: [PATCH 4/x] arm: Add vst1_bf16 + vst1q_bf16 intrinsics

2020-11-03 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: 03 November 2020 11:01 > To: Kyrylo Tkachov > Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw > ; nd > Subject: Re: [PATCH 4/x] arm: Add vst1_bf16 + vst1q_bf16 intrinsics > > Kyrylo Tkachov writes: > [...] > > I see this patch also h

RE: [PATCH 3/x] arm: Add vld1_bf16 + vld1q_bf16 intrinsics

2020-11-03 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: 02 November 2020 09:01 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; nd > Subject: [PATCH 3/x] arm: Add vld1_bf16 + vld1q_bf16 intrinsics > > Hi all, > > Third patch of the serie here adding vld1_bf16, vl

Re: [PATCH][AArch64] ACLE intrinsics: get low/high half from BFloat16 vector

2020-11-03 Thread Dennis Zhang via Gcc-patches
Hi Richard, On 10/30/20 2:07 PM, Richard Sandiford wrote: Dennis Zhang writes: diff --git a/gcc/config/aarch64/aarch64-simd-builtins.def b/gcc/config/aarch64/aarch64-simd-builtins.def index 332a0b6b1ea..39ebb776d1d 100644 --- a/gcc/config/aarch64/aarch64-simd-builtins.def +++ b/gcc/config/aar

Re: [patch] lto test: Add dg-require-effective-target lto on test using -flto

2020-11-03 Thread Olivier Hainque
> On 3 Nov 2020, at 11:03, Richard Biener wrote: > Sure - consider such fixes obvious in the future. Understood. Thanks for your prompt feedback Richard :) Cheers, Olivier >>* gcc.dg/tree-ssa/pr71077.c: Add >>dg-require-effective-target lto.

RE: [PATCH 5/x] arm: Add vldN_lane_bf16 + vldNq_lane_bf16 intrisics

2020-11-03 Thread Kyrylo Tkachov via Gcc-patches
HI Andrea, > -Original Message- > From: Andrea Corallo > Sent: 02 November 2020 09:03 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; nd > Subject: [PATCH 5/x] arm: Add vldN_lane_bf16 + vldNq_lane_bf16 intrisics > > Hi all, > > 5th patch of the serie here addi

RE: [PATCH 6/x] arm: Add vstN_lane_bf16 + vstNq_lane_bf16 intrisics

2020-11-03 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: 02 November 2020 09:04 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; nd > Subject: [PATCH 6/x] arm: Add vstN_lane_bf16 + vstNq_lane_bf16 intrisics > > Hi all, > > last patch for this the serie adding vst2

Re: [PATCH] aarch64: Add backend support for expanding __builtin_memset

2020-11-03 Thread Richard Sandiford via Gcc-patches
Sudakshina Das writes: >> -Original Message- >> From: Richard Sandiford >> Sent: 30 October 2020 19:56 >> To: Sudakshina Das >> Cc: Wilco Dijkstra ; gcc-patches@gcc.gnu.org; >> Kyrylo Tkachov ; Richard Earnshaw >> >> Subject: Re: [PATCH] aarch64: Add backend support for expanding >> __b

[PATCH] fortran/97652 - workaround missing canonicalization of PDT types

2020-11-03 Thread Richard Biener
This marks PDT types as needing structural comparison for TBAA if we didn't pick up a canonical variant (which we should IMHO always do). This workaround fixes the gfortran.dg/pdt_14.f03 fail which materializes as testsuite timeout which is quite annoying. Bootstrap / regtest pending on x86_64-un

Re: PING [Patch] x86: Enable GCC support for Intel AVX-VNNI extension

2020-11-03 Thread Hongtao Liu via Gcc-patches
ping^2, i hope this patch could land on GCC11. On Wed, Oct 28, 2020 at 5:23 PM Hongyu Wang wrote: > > Hongyu Wang 于2020年10月14日周三 上午11:27写道: > > > > Hi: > > > > This patch is about to support Intel AVX-VNNI instructions. > > > > AVX-VNNI is an equivalent to AVX512-VNNI with VEX encoding. The > >

Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Olivier Hainque
> On 3 Nov 2020, at 11:25, Jakub Jelinek wrote: > > Ok, thanks. Thanks Jakub! I have a couple of similar ones (for fpic) for non-target-specific tests in preparation. Then JIC, two smaller ones in the same spirit already sent: https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557477.ht

RE: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions emitted at -O3

2020-11-03 Thread xiezhiheng
> -Original Message- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Friday, October 30, 2020 6:24 PM > To: xiezhiheng > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions > emitted at -O3 > > xiezhiheng writes: > >> -

Re: [PATCH] fortran/97652 - workaround missing canonicalization of PDT types

2020-11-03 Thread Paul Richard Thomas via Gcc-patches
Hi Richi, That's OK for master and as far back as you have the fortitude to go. Thanks for the fix. I agree that we should always pick up a canonical variant. When I finally get "a minute or two" to fix the rather fundamental problems with PDTs, I will make sure that this goes away. I am also cu

[PATCH] testsuite: Fix gcc.target/i386/zero-scratch-regs-*.c scan-asm directives

2020-11-03 Thread Uros Bizjak via Gcc-patches
Improve zero-scratch-regs-*.c scan-asm regexps and add target selectors for 32bit targets. 2020-11-03 Uroš Bizjak gcc/testsuite/ChangeLog: * gcc.target/i386/zero-scratch-regs-1.c: Add ia32 target selector where appropriate. Improve scan-assembler regexp. * gcc.target/i386/zero-sc

Re: [PATCH] fortran/97652 - workaround missing canonicalization of PDT types

2020-11-03 Thread Tobias Burnus
On 03.11.20 12:34, Richard Biener wrote: This marks PDT types as needing structural comparison for TBAA if we didn't pick up a canonical variant (which we should IMHO always do). This workaround fixes the gfortran.dg/pdt_14.f03 fail which materializes as testsuite timeout which is quite annoyin

[patch] vxworks: Sync the aarch64-vx7r2 libgcc config with that of Linux

2020-11-03 Thread Olivier Hainque
This adds ${cpu_type}/t-lse and t-slibgcc-libgcc to the tmake_file list for aarch64-vxworks7* configurations, as the Linux port does. t-lse is needed by all triplets now anyway and the standard setting for slibgcc makes sense as we are working on reintroducing PIC support for RTPs on various targ

[PATCH] tree-optimization/80928 - SLP vectorize nested loop induction

2020-11-03 Thread Richard Biener
This adds SLP vectorization of nested inductions. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-11-03 Richard Biener PR tree-optimization/80928 * tree-vect-loop.c (vectorizable_induction): SLP vectorize nested inductions. * gcc.dg/vect/vect-

Re: [PATCH] fortran/97652 - workaround missing canonicalization of PDT types

2020-11-03 Thread Richard Biener
On Tue, 3 Nov 2020, Paul Richard Thomas wrote: > Hi Richi, > > That's OK for master and as far back as you have the fortitude to go. We only know that the issue is exposed on trunk so I'll leave it there only as a temporary workaround. > Thanks for the fix. > > I agree that we should always pi

Re: [PATCH] Fix PR97205

2020-11-03 Thread Bernd Edlinger
On 11/3/20 11:16 AM, Richard Biener wrote: > On Tue, 3 Nov 2020, Bernd Edlinger wrote: > >> >> >> On 11/3/20 10:34 AM, Richard Biener wrote: >>> On Mon, 2 Nov 2020, Bernd Edlinger wrote: >>> On 11/2/20 3:07 PM, Richard Biener wrote: > On Mon, 2 Nov 2020, Bernd Edlinger wrote: >

[PATCH] Save some memory at debug stream-in time

2020-11-03 Thread Richard Biener
This allows us to release references to BLOCKs by not keeping them rooted in the external_die_map but instead remove it from there as soon as we created the corresponding stub DIE. For decls it doesn't help since we still keep the decl_die_table. Bootstrapped on x86_64-unknown-linux-gnu, testing

[PATCH 5/X] libsanitizer: mid-end: Introduce stack variable handling for HWASAN

2020-11-03 Thread Matthew Malcomson via Gcc-patches
Hi Richard, I'm sending up the revised patch 5 (introducing stack variable handling) without the other changes to other patches. I figure there's been quite a lot of changes to this patch and I wanted to give you time to review them while I worked on finishing the less widespread changes in patch

libcpp: dependency emission tidying

2020-11-03 Thread Nathan Sidwell
This patch cleans up the interface to the dependency generation a little. We now only check the option in one place, and the cpp_get_deps function returns nullptr if there are no dependencies. I also reworded the -MT and -MQ help text to be make agnostic -- as there are ideas about emitting, sa

Re: [PATCH][AArch64] ACLE intrinsics: convert from BFloat16 to Float32

2020-11-03 Thread Dennis Zhang via Gcc-patches
On 11/2/20 7:05 PM, Richard Sandiford wrote: Dennis Zhang writes: Hi Richard, On 10/29/20 5:48 PM, Richard Sandiford wrote: Dennis Zhang writes: diff --git a/gcc/config/aarch64/aarch64-simd-builtins.def b/gcc/config/aarch64/aarch64-simd-builtins.def index 5bc596dbffc..b68c3ca7f4b 100644

c++: rtti cleanups

2020-11-03 Thread Nathan Sidwell
Here are a few cleanups from the modules branch. Generally some RAII, and a bit of lazy namespace pushing. gcc/cp/ * rtti.c (init_rtti_processing): Move var decl to its init. (get_tinfo_decl): Likewise. Break out creation to called helper ... (get_tinfo_

c++: cp_tree_equal cleanups

2020-11-03 Thread Nathan Sidwell
A couple of small fixes. I noticed bind_template_template_parms was not marking the parm a template parm (this broke some module handling). Debugging CALL_EXPR comparisons led me to refactor cp_tree_equal's CALL_EXPR code (and my recent fix to debug printing of same). Finally TREE_VECS are bes

Re: [PATCH] Optimize macro: make it more predictable

2020-11-03 Thread Richard Biener via Gcc-patches
On Fri, Oct 23, 2020 at 1:47 PM Martin Liška wrote: > > Hey. > > This is a follow-up of the discussion that happened in thread about > no_stack_protector > attribute: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545916.html > > The current optimize attribute works in the following way: > -

Re: [PATCH 6/x] arm: Add vstN_lane_bf16 + vstNq_lane_bf16 intrisics

2020-11-03 Thread Andrea Corallo via Gcc-patches
Kyrylo Tkachov writes: >> -Original Message- >> From: Andrea Corallo >> Sent: 02 November 2020 09:04 >> To: gcc-patches@gcc.gnu.org >> Cc: Kyrylo Tkachov ; Richard Earnshaw >> ; nd >> Subject: [PATCH 6/x] arm: Add vstN_lane_bf16 + vstNq_lane_bf16 intrisics >> >> Hi all, >> >> last pat

Re: Add fnspec to C++ new and delete

2020-11-03 Thread Richard Biener
On Tue, 27 Oct 2020, Jan Hubicka wrote: > Hi, > this patch makes C++ new and delete operators to be handled as > malloc/free for fnspec. > > I still do not understand why free is ".co " and not ".cO ". > I do not think we need to invalidate memory referenced to by blockbeing > freed. > > Bootstr

Re: [PATCH] Optimize macro: make it more predictable

2020-11-03 Thread Jakub Jelinek via Gcc-patches
On Tue, Nov 03, 2020 at 02:27:52PM +0100, Richard Biener wrote: > On Fri, Oct 23, 2020 at 1:47 PM Martin Liška wrote: > > This is a follow-up of the discussion that happened in thread about > > no_stack_protector > > attribute: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545916.html > > >

Re: [PATCH] Optimize macro: make it more predictable

2020-11-03 Thread Richard Biener via Gcc-patches
On Tue, Nov 3, 2020 at 2:35 PM Jakub Jelinek wrote: > > On Tue, Nov 03, 2020 at 02:27:52PM +0100, Richard Biener wrote: > > On Fri, Oct 23, 2020 at 1:47 PM Martin Liška wrote: > > > This is a follow-up of the discussion that happened in thread about > > > no_stack_protector > > > attribute: http

Re: libcpp: dependency emission tidying

2020-11-03 Thread Tobias Burnus
Hi Nathan, I now get: ../../repos/gcc/libcpp/init.c:670:15: error: unused variable ‘deps’ [-Werror=unused-variable] 670 | if (mkdeps *deps = cpp_get_deps (pfile)) | ^~~~ see last three lines of the quoted patch below. Tobias On 03.11.20 14:02, Nathan Sidwell wrote:

Re: [PATCH][PR target/97540] Don't extract memory from operand for normal memory constraint.

2020-11-03 Thread Richard Sandiford via Gcc-patches
Vladimir Makarov via Gcc-patches writes: > On 2020-10-27 2:53 a.m., Hongtao Liu wrote: >> Hi: >>For inline asm, there could be an operand like (not (mem:)), it's >> not a valid operand for normal memory constraint. >>Bootstrap is ok, regression test is ok for make check >> RUNTESTFLAGS="--

Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions emitted at -O3

2020-11-03 Thread Richard Sandiford via Gcc-patches
xiezhiheng writes: >> -Original Message- >> From: Richard Sandiford [mailto:richard.sandif...@arm.com] >> Sent: Friday, October 30, 2020 6:24 PM >> To: xiezhiheng >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions >> emitted at -O3 >>

Re: libcpp: dependency emission tidying

2020-11-03 Thread Nathan Sidwell
Whoops, that broke bootstrap. Pushing this fix. libcpp/ * init.c (cpp_read_main_file): Use cpp_get_deps result. -- Nathan Sidwell diff --git c/libcpp/init.c w/libcpp/init.c index 5b2607e3767..6c52f50de39 100644 --- c/libcpp/init.c +++ w/libcpp/init.c @@ -669,7 +669,7

Re: [PATCH][AArch64] ACLE intrinsics: get low/high half from BFloat16 vector

2020-11-03 Thread Richard Sandiford via Gcc-patches
Dennis Zhang writes: > Hi Richard, > > On 10/30/20 2:07 PM, Richard Sandiford wrote: >> Dennis Zhang writes: >>> diff --git a/gcc/config/aarch64/aarch64-simd-builtins.def >>> b/gcc/config/aarch64/aarch64-simd-builtins.def >>> index 332a0b6b1ea..39ebb776d1d 100644 >>> --- a/gcc/config/aarch64/aar

[PATCH] middle-end/97579 - fix VEC_COND_EXPR ISEL optab query

2020-11-03 Thread Richard Biener
This fixes a mistake in the optab query done by ISEL. It doesn't fix the PR but shifts the ICE elsewhere. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2020-11-03 Richard Biener PR middle-end/97579 * gimple-isel.cc (gimple_expand_vec_cond_expr): Use

[PATCH] tree-optimization/97623 - limit PRE hoist insertion

2020-11-03 Thread Richard Biener
This limits insert iteration caused by PRE insertions generating hoist insertion opportunities and vice versa. The patch limits the hoist insertion iterations to three by default. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2020-11-03 Richard Biener PR tr

Re: PowerPC: Add __float128 conversions to/from Decimal

2020-11-03 Thread Segher Boessenkool
On Tue, Nov 03, 2020 at 01:12:29AM +, Joseph Myers wrote: > On Mon, 2 Nov 2020, Segher Boessenkool wrote: > > > > Also note that if you want to use printf as opposed to strfromf128 for > > > IEEE binary128 you'll need to use __printfieee128 (the version that > > > expects long double to be I

[committed] Cleanup of a merge mistake in fold-const.c

2020-11-03 Thread Bernd Edlinger
Hi, this removes a duplicated statement, in fold-const.c in function getbyterep: The comment, "Ideally this would turn into a gcc_checking_assert over time." and the following if-statement are duplicated so one of them can be removed: if (init_bytes > array_size) init_bytes = array_size;

RE: [PATCH] SLP: Move load/store-lanes check till late

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi Richi, We decided to take the regression in any code-gen this could give and fix it properly next stage-1. As such here's a new patch based on your previous feedback. Ok for master? Thanks, Tamar gcc/ChangeLog: * tree-vect-slp.c (vect_analyze_slp_instance): Moved load/store lanes

RE: [PATCH v2 6/16]middle-end Add Complex Addition with rotation detection

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi All, here is a respin with the requested changes. I just realized I haven't updated the documentation yet but will do so soon since I'm sure there will be feedback :) Thanks, Tamar gcc/ChangeLog: * doc/md.texi: Document optabs. * internal-fn.def (COMPLEX_ADD_ROT90, COMPLEX_A

RE: [PATCH v2 4/16]middle-end: Add dissolve code for when SLP fails and non-SLP loop vectorization is to be tried.

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi All, Here's a respin of this patch with the requested changes. Thanks, Tamar gcc/ChangeLog: * tree-vect-loop.c (vect_dissolve_slp_only_patterns): New (vect_dissolve_slp_only_groups): Call vect_dissolve_slp_only_patterns. > -Original Message- > From: Gcc-patches On B

RE: [PATCH v2 7/16]middle-end: Add Complex Multiplication and Multiplication with Conjucate detection

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi All, This is a respin of this patch using the new approach. Thanks, Tamar gcc/ChangeLog: * doc/md.texi: Document optabs. * internal-fn.def (COMPLEX_MUL, COMPLEX_MUL_CONJ): New. * optabs.def (cmul_optab, cmul_conj_optab): New, * tree-vect-slp-patterns.c (vect_b

RE: [PATCH v2 2/16]middle-end: Refactor and expose some vectorizer helper functions.

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi All, This patch is a respin of the previous one defining a new helper function add_pattern_stmt. Ok for master? Thanks, Tamar gcc/ChangeLog: * tree-vect-patterns.c (vect_mark_pattern_stmts): Remove static inline. * tree-vect-slp.c (vect_create_new_slp_node): Remove static an

RE: [PATCH v2 5/16]middle-end: Add shared machinery for matching patterns involving complex numbers.

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi All, This is a respin containing the requested changes. Ok for master? Thanks, Tamar gcc/ChangeLog: * tree-vect-slp-patterns.c (vect_match_expression_p, vect_check_lane_permute, vect_detect_pair_op, vect_mark_stmts_as_in_pattern, class complex_pattern, comple

RE: [PATCH v2 3/16]middle-end Add basic SLP pattern matching scaffolding.

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi Richi, This is a respin which includes the changes you requested. Thanks, Tamar gcc/ChangeLog: * Makefile.in (tree-vect-slp-patterns.o): New. * doc/passes.texi: Update documentation. * tree-vect-slp.c (vect_print_slp_tree): Add new state. (vect_match_slp_patte

RE: [PATCH v2 8/16]middle-end: add Complex Multiply and Accumulate/Subtract and Multiply and Accumulate/Subtract with Conjucate detection

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi All, This is a respin of the patch using the new approach. Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. Ok for master? Thanks, Tamar gcc/ChangeLog: * doc/md.texi: Document optabs. * internal-fn.def (COMPLEX_FMA, COMPLEX_FMA_CONJ, COMPLEX_FMS, COMP

[PATCH v2 9/18]middle-end optimize slp simplify back to back permutes.

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi All, This optimizes sequential permutes. i.e. if there are two permutes back to back this function applies the permute of the parent to the child and removed the parent. If the resulting permute in the child is now a no-op. Then the child is also dropped from the graph and the parent's parent

[PATCH v2 10/18]middle-end simplify lane permutes which selects from loads from the same DR.

2020-11-03 Thread Tamar Christina via Gcc-patches
Hi All, This change allows one to simplify lane permutes that select from multiple load leafs that load from the same DR group by promoting the VEC_PERM node into a load itself and pushing the lane permute into it as a load permute. This saves us from having to calculate where to materialize a ne

[PATCH] libgcc: Add a weak stub for __sync_synchronize

2020-11-03 Thread Bernd Edlinger
Hi, this fixes a problem with a missing symbol __sync_synchronize which happens when newlib is used together with libstdc++ for the non-threaded simulator target arm-none-eabi. There are several questions on stackoverflow about this issue. I would like to add a weak symbol for this target, since

[PATCH] Tweaks to ranger cache

2020-11-03 Thread Andrew MacLeod via Gcc-patches
This patch does some minor tweaking to the ranger caches. 1 - the ssa_block_range class is a vector over the BB's and contains pointers to any calculated on-entry ranges for an ssa-name.    The class wasn't doing any bounds checking... Its a pretty controlled enviroment, but still... safer to

[PATCH] More Ranger cache tweaks

2020-11-03 Thread Andrew MacLeod via Gcc-patches
The range on entry cache is managed by the ranger_cache class. Part of the service it provides is auto-filling the cache when a request is made for the range on entry to a block. The Ranger makes sure the global range at the def statement has been calculated then submits a requests for the ran

Move pass_oacc_device_lower after pass_graphite

2020-11-03 Thread Frederik Harwath
Hi, as a first step towards enabling the use of Graphite for optimizing OpenACC loops this patch moves the OpenACC device lowering after the Graphite pass. This means that the device lowering now takes place after some crucial optimization passes. Thus new instances of those passes are added ins

Re: [PATCH v4] builtins: (not just) rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2020-11-03 Thread Raoni Fassina Firmino via Gcc-patches
On Wed, Oct 28, 2020 at 12:03:33PM -0500, Segher Boessenkool wrote: > For raising invalid we could perhaps set VXSOFT, but is that okay for > other libcs than just glibc? So that can be a future improvement if it > turns out to be useful, as we discussed elsewhere. Yeap. > With those tweaks, the

Re: [PATCH 1/5] [PR target/96342] Change field "simdlen" into poly_uint64

2020-11-03 Thread Richard Sandiford via Gcc-patches
"yangyang (ET)" writes: > Hi, > > I have revised the patch based on your suggestions. I use multiple_p instead > of !multiple_p if the eq situation is OK to make it easier to understand. > >> >> > if (n->simdclone->inbranch) >> >> > this_badness += 2048; >> >> > int target_badness =

Re: [Patch + RFC][contrib] gcc-changelog/git_commit.py: Check for missing description

2020-11-03 Thread Martin Liška
On 10/30/20 2:16 PM, Tobias Burnus wrote: In terms of issues, it seems as if Ubuntu 20.04.1 LTS has a too old unidiff – I copied the check from test_email.py and applied it to git_email.py – otherwise, nearly all tests fail. Hello. Please apply this hunk separately, it's fine. Still, I do s

Re: [Patch + RFC][contrib] gcc-changelog/git_commit.py: Check for missing description

2020-11-03 Thread Martin Liška
On 10/30/20 2:16 PM, Tobias Burnus wrote: In terms of issues, it seems as if Ubuntu 20.04.1 LTS has a too old unidiff – I copied the check from test_email.py and applied it to git_email.py – otherwise, nearly all tests fail. Still, I do see some fails – I have attached the fails I got. (fails.lo

[PATCH][pushed] Add setup.cfg for pytest.

2020-11-03 Thread Martin Liška
It adds FLAKE8 automatically when pytest is run. Installed. contrib/ChangeLog: * gcc-changelog/setup.cfg: New file. --- contrib/gcc-changelog/setup.cfg | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 contrib/gcc-changelog/setup.cfg diff --git a/contrib/gcc-changelog/setup.

cpplib: Fix off-by-one error

2020-11-03 Thread Nathan Sidwell
I noticed a fencepost error in the preprocessor. We should be checking if the next char is at the limit, not the current char (which can't be, because we're looking at it). libcpp/ * lex.c (_cpp_clean_line): Fix DOS off-by-one error. pushing to trunk -- Nathan Sidwell diff --gi

c++: Make extern-C mismatch an error

2020-11-03 Thread Nathan Sidwell
duplicate_decls was being lenient about extern-c mismatches, allowing you to have two declarations in the symbol table after emitting an error. This resulted in duplicate error messages in modules, when we find the same problem multiple times. Let's just not let that happen. gcc/cp/

c++: A couple of template instantiation cleanups

2020-11-03 Thread Nathan Sidwell
I noticed that we were handling lambda extra scope during template instantiation in a different order to how we handle the non-template case. Reordered that for consistency. Also some more RAII during template instantiation. gcc/cp/ * pt.c (tsubst_lambda_expr): Reorder extra-sc

Re: [PATCH v3] rs6000: Use direct move for char/short vector CTOR [PR96933]

2020-11-03 Thread Segher Boessenkool
Hi! On Tue, Nov 03, 2020 at 03:25:19PM +0800, Kewen.Lin wrote: > > I'm trying to be stricter about the test cases. > > > > +++ b/gcc/testsuite/gcc.target/powerpc/pr96933-1.c > > @@ -0,0 +1,14 @@ > > +/* { dg-do compile { target { lp64 && has_arch_pwr9 } } } */ > > +/* { dg-require-effective-targe

c++: Directly fixup deferred eh-specs

2020-11-03 Thread Nathan Sidwell
eh-specifiers in a class definition are complete-definition contexts, and we sometimes need to deferr their parsing. We create a deferred eh specifier, which can end up persisting in the type system due to variants being created before the deferred parse. This causes problems in modules handlin

Re: [PATCH] c++: Don't try to parse a function declaration as deduction guide [PR97663]

2020-11-03 Thread Marek Polacek via Gcc-patches
On Mon, Nov 02, 2020 at 08:13:09PM +0100, Jakub Jelinek via Gcc-patches wrote: > Hi! > > While these function declarations have NULL decl_specifiers->type, > they have still type specifiers specified from which the default int > in the return type is added, so we shouldn't try to parse those as >

Re: [PATCH][AArch64] ACLE intrinsics: get low/high half from BFloat16 vector

2020-11-03 Thread Dennis Zhang via Gcc-patches
On 11/3/20 2:05 PM, Richard Sandiford wrote: Dennis Zhang writes: Hi Richard, On 10/30/20 2:07 PM, Richard Sandiford wrote: Dennis Zhang writes: diff --git a/gcc/config/aarch64/aarch64-simd-builtins.def b/gcc/config/aarch64/aarch64-simd-builtins.def index 332a0b6b1ea..39ebb776d1d 100644 --

Re: [patch] Add dg-require-effective-target fpic to gcc.target/powerpc tests

2020-11-03 Thread Segher Boessenkool
Hi! On Tue, Nov 03, 2020 at 10:12:54AM +0100, Olivier Hainque wrote: > This change is a proposal to add > > /* { dg-require-effective-target fpic } */ > > to a few tests in gcc.target/powerpc that do use > -fpic or -fPIC but don't currently query the target > support. > > This corresponds to

cpplib: EOF in pragmas

2020-11-03 Thread Nathan Sidwell
This patch moves the generation of PRAGMA_EOF earlier, to when we set need_line, rather than when we try and get the next line. It also prevents peeking past a PRAGMA token. libcpp/ * lex.c (cpp_peek_token): Do not peek past CPP_PRAGMA. (_cpp_lex_direct): Handle EOF i

[patch] g++ tests: Add dg-require-effective-target fpic to a few g++ tests

2020-11-03 Thread Olivier Hainque
Hello, This change is a proposal to add /* { dg-require-effective-target fpic } */ to a few tests in g++.dg that use -fpic or -fPIC but don't currently query the target support. This corresponds to what most other fpic tests do (typically, unless this is implied by some other test such as "t

Re: [patch] Add dg-require-effective-target fpic to gcc.target/powerpc tests

2020-11-03 Thread Olivier Hainque
Hi Segher, > On 3 Nov 2020, at 18:00, Segher Boessenkool > wrote: > >> /* { dg-require-effective-target fpic } */ >> >> to a few tests in gcc.target/powerpc that do use >> -fpic or -fPIC but don't currently query the target >> support. > This is fine for trunk, thanks! Great :-) >> --- a/gc

[PATCH] "used" attribute saves decl from linker garbage collection

2020-11-03 Thread Jozef Lawrynowicz
The attached patch implements TARGET_ASM_MARK_DECL_PRESERVED for ELF GNU OSABI targets, so that declarations that have the "used" attribute applied will be saved from linker garbage collection. TARGET_ASM_MARK_DECL_PRESERVED will emit an assembler ".retain" directive for the decl, and the assemble

Re: [PATCH] "used" attribute saves decl from linker garbage collection

2020-11-03 Thread H.J. Lu via Gcc-patches
On Tue, Nov 3, 2020 at 9:41 AM Jozef Lawrynowicz wrote: > > The attached patch implements TARGET_ASM_MARK_DECL_PRESERVED for ELF GNU > OSABI targets, so that declarations that have the "used" attribute > applied will be saved from linker garbage collection. > > TARGET_ASM_MARK_DECL_PRESERVED will

Re: [PATCH, 1/3, OpenMP] Target mapping changes for OpenMP 5.0, front-end parts

2020-11-03 Thread Chung-Lin Tang
Hi Jakub, here is v3 of this patch set. On 2020/10/29 7:44 PM, Jakub Jelinek wrote: +extern void c_omp_adjust_clauses (tree, bool); So, can you please rename the function to either c_omp_adjust_target_clauses or c_omp_adjust_mapping_clauses or c_omp_adjust_map_clauses? I've renamed it to 'c_o

Re: [PATCH, 2/3, OpenMP] Target mapping changes for OpenMP 5.0, middle-end parts and compiler testcases

2020-11-03 Thread Chung-Lin Tang
On 2020/10/29 7:49 PM, Jakub Jelinek wrote: On Wed, Oct 28, 2020 at 06:32:21PM +0800, Chung-Lin Tang wrote: @@ -8958,25 +9083,20 @@ gimplify_scan_omp_clauses (tree *list_p, gimple_seq *pre_p, /* An "attach/detach" operation on an update directive should behave as

Re: [PATCH, 3/3, OpenMP] Target mapping changes for OpenMP 5.0, libgomp parts [resend]

2020-11-03 Thread Chung-Lin Tang
On 2020/10/28 6:33 PM, Chung-Lin Tang wrote: On 2020/9/1 9:37 PM, Chung-Lin Tang wrote: his patch is the changes to libgomp and testcases. There is now (again) a need to indicate OpenACC/OpenMP and an 'enter data' style directive, so the associated changes to 'enum gomp_map_vars_kind'. There i

  1   2   >