On Tue, Nov 03, 2020 at 11:24:24AM +0100, Olivier Hainque wrote: > > > > On 3 Nov 2020, at 09:30, Jakub Jelinek <ja...@redhat.com> wrote: > > > 70% of the tests you've changed have a target *-linux* or similar > > right above that line, what is the point of adding the fpic > > effective targets to those? Those surely aren't run on vxWorks > > and on x86 Linux fpic is always supported. > > Good point. We had quite a few actual failures > and I did a pretty systematic search, missing the > linux implication. > > > No objection to adding it to the rest. > > Ok, amended change below. > > Thanks for your prompt feedback on this Jakub!
Ok, thanks. > 2020-11-03 Olivier Hainque <hain...@adacore.com> > > gcc/testsuite/ > > * gcc.target/i386/pr45352-1.c: Add dg-require-effective-target fpic. > * gcc.target/i386/pr47602.c: Likewise. > * gcc.target/i386/pr55151.c: Likewise. > * gcc.target/i386/pr55458.c: Likewise. > * gcc.target/i386/pr56348.c: Likewise. > * gcc.target/i386/pr57097.c: Likewise. > * gcc.target/i386/pr65753.c: Likewise. > * gcc.target/i386/pr65915.c: Likewise. > * gcc.target/i386/pr66232-5.c: Likewise. > * gcc.target/i386/pr66334.c: Likewise. > * gcc.target/i386/pr66819-2.c: Likewise. > * gcc.target/i386/pr67265.c: Likewise. > * gcc.target/i386/pr81481.c: Likewise. > * gcc.target/i386/pr83994.c: Likewise. Jakub