> On 3 Nov 2020, at 09:30, Jakub Jelinek <ja...@redhat.com> wrote:
> 70% of the tests you've changed have a target *-linux* or similar
> right above that line, what is the point of adding the fpic
> effective targets to those? Those surely aren't run on vxWorks
> and on x86 Linux fpic is always supported.
Good point. We had quite a few actual failures
and I did a pretty systematic search, missing the
linux implication.
> No objection to adding it to the rest.
Ok, amended change below.
Thanks for your prompt feedback on this Jakub!
Best Regards,
Olivier
2020-11-03 Olivier Hainque <hain...@adacore.com>
gcc/testsuite/
* gcc.target/i386/pr45352-1.c: Add dg-require-effective-target fpic.
* gcc.target/i386/pr47602.c: Likewise.
* gcc.target/i386/pr55151.c: Likewise.
* gcc.target/i386/pr55458.c: Likewise.
* gcc.target/i386/pr56348.c: Likewise.
* gcc.target/i386/pr57097.c: Likewise.
* gcc.target/i386/pr65753.c: Likewise.
* gcc.target/i386/pr65915.c: Likewise.
* gcc.target/i386/pr66232-5.c: Likewise.
* gcc.target/i386/pr66334.c: Likewise.
* gcc.target/i386/pr66819-2.c: Likewise.
* gcc.target/i386/pr67265.c: Likewise.
* gcc.target/i386/pr81481.c: Likewise.
* gcc.target/i386/pr83994.c: Likewise.
---
gcc/testsuite/gcc.target/i386/pr45352-1.c | 1 +
gcc/testsuite/gcc.target/i386/pr47602.c | 1 +
gcc/testsuite/gcc.target/i386/pr55151.c | 1 +
gcc/testsuite/gcc.target/i386/pr55458.c | 1 +
gcc/testsuite/gcc.target/i386/pr56348.c | 1 +
gcc/testsuite/gcc.target/i386/pr57097.c | 1 +
gcc/testsuite/gcc.target/i386/pr65753.c | 1 +
gcc/testsuite/gcc.target/i386/pr65915.c | 1 +
gcc/testsuite/gcc.target/i386/pr66232-5.c | 1 +
gcc/testsuite/gcc.target/i386/pr66334.c | 1 +
gcc/testsuite/gcc.target/i386/pr66819-2.c | 1 +
gcc/testsuite/gcc.target/i386/pr67265.c | 1 +
gcc/testsuite/gcc.target/i386/pr81481.c | 1 +
gcc/testsuite/gcc.target/i386/pr83994.c | 1 +
14 files changed, 14 insertions(+)
diff --git a/gcc/testsuite/gcc.target/i386/pr45352-1.c
b/gcc/testsuite/gcc.target/i386/pr45352-1.c
index 5cd1bd842d80..f5e96b270166 100644
--- a/gcc/testsuite/gcc.target/i386/pr45352-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr45352-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-mtune=amdfam10 -O3 -fpeel-loops -fselective-scheduling2
-fsel-sched-pipelining -fPIC" } */
static int FIR_Tab_16[16][16];
diff --git a/gcc/testsuite/gcc.target/i386/pr47602.c
b/gcc/testsuite/gcc.target/i386/pr47602.c
index fa5f5bd7d351..5ed1e1fd490c 100644
--- a/gcc/testsuite/gcc.target/i386/pr47602.c
+++ b/gcc/testsuite/gcc.target/i386/pr47602.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
/* Test verifies that %ebx is no longer fixed when generating PIC code on
i686. */
diff --git a/gcc/testsuite/gcc.target/i386/pr55151.c
b/gcc/testsuite/gcc.target/i386/pr55151.c
index 62da8cb7781e..d6255a83dee7 100644
--- a/gcc/testsuite/gcc.target/i386/pr55151.c
+++ b/gcc/testsuite/gcc.target/i386/pr55151.c
@@ -1,5 +1,6 @@
/* PR rtl-optimization/55151 */
/* { dg-do compile { target { ! ia32 } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
int a, b, c, d, e, f, g, h, i, j, k, l;
diff --git a/gcc/testsuite/gcc.target/i386/pr55458.c
b/gcc/testsuite/gcc.target/i386/pr55458.c
index 7164ca905db2..1dea55c50c9e 100644
--- a/gcc/testsuite/gcc.target/i386/pr55458.c
+++ b/gcc/testsuite/gcc.target/i386/pr55458.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
/* Test verifies that %ebx is no longer fixed when generating PIC code on
i686. */
diff --git a/gcc/testsuite/gcc.target/i386/pr56348.c
b/gcc/testsuite/gcc.target/i386/pr56348.c
index c31814f60f47..93423d9190d9 100644
--- a/gcc/testsuite/gcc.target/i386/pr56348.c
+++ b/gcc/testsuite/gcc.target/i386/pr56348.c
@@ -1,5 +1,6 @@
/* PR target/56348 */
/* { dg-do compile { target ia32 } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fPIC -mfpmath=sse -msse2" } */
typedef unsigned int size_t;
diff --git a/gcc/testsuite/gcc.target/i386/pr57097.c
b/gcc/testsuite/gcc.target/i386/pr57097.c
index 2f0093840df5..debacbfc048b 100644
--- a/gcc/testsuite/gcc.target/i386/pr57097.c
+++ b/gcc/testsuite/gcc.target/i386/pr57097.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fPIC" } */
extern double ad[], bd[], cd[], dd[];
extern long long all[], bll[], cll[], dll[];
diff --git a/gcc/testsuite/gcc.target/i386/pr65753.c
b/gcc/testsuite/gcc.target/i386/pr65753.c
index 562f54bff6bd..117d6ed0cf17 100644
--- a/gcc/testsuite/gcc.target/i386/pr65753.c
+++ b/gcc/testsuite/gcc.target/i386/pr65753.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC -O2" } */
/* { dg-final { scan-assembler-not "call" } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr65915.c
b/gcc/testsuite/gcc.target/i386/pr65915.c
index 990c5aaa2e4d..6588de47c4a2 100644
--- a/gcc/testsuite/gcc.target/i386/pr65915.c
+++ b/gcc/testsuite/gcc.target/i386/pr65915.c
@@ -1,4 +1,5 @@
/* { dg-do run } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mavx512f -fpic -mcmodel=medium" } */
/* { dg-require-effective-target avx512f } */
/* { dg-require-effective-target lp64 } */
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-5.c
b/gcc/testsuite/gcc.target/i386/pr66232-5.c
index 87f93802694f..76705a529848 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-5.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-5.c
@@ -1,5 +1,6 @@
/* { dg-do compile { target { ! ia32 } } } */
/* { dg-require-effective-target maybe_x32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -mx32" } */
extern void (*bar) (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66334.c
b/gcc/testsuite/gcc.target/i386/pr66334.c
index 97dfecc8725c..19c2396073cd 100644
--- a/gcc/testsuite/gcc.target/i386/pr66334.c
+++ b/gcc/testsuite/gcc.target/i386/pr66334.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fexceptions -fasynchronous-unwind-tables" } */
/* { dg-final { scan-assembler "movl\[ \\t\].+, %ebx" } } */
extern int foo (int);
diff --git a/gcc/testsuite/gcc.target/i386/pr66819-2.c
b/gcc/testsuite/gcc.target/i386/pr66819-2.c
index 9de4f97a9063..ad2a33e7fd24 100644
--- a/gcc/testsuite/gcc.target/i386/pr66819-2.c
+++ b/gcc/testsuite/gcc.target/i386/pr66819-2.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target ia32 } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC -O2 -mregparm=3" } */
/* { dg-final { scan-assembler-not "call" } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr67265.c
b/gcc/testsuite/gcc.target/i386/pr67265.c
index 2671acc043ad..1708d537b98a 100644
--- a/gcc/testsuite/gcc.target/i386/pr67265.c
+++ b/gcc/testsuite/gcc.target/i386/pr67265.c
@@ -3,6 +3,7 @@
/* { dg-do compile } */
/* { dg-require-stack-check "" } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O -fstack-check -fPIC" } */
int a, b, c, d, e;
diff --git a/gcc/testsuite/gcc.target/i386/pr81481.c
b/gcc/testsuite/gcc.target/i386/pr81481.c
index a5b936fdacc1..49f7821ea5be 100644
--- a/gcc/testsuite/gcc.target/i386/pr81481.c
+++ b/gcc/testsuite/gcc.target/i386/pr81481.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ssse3 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -mssse3" } */
/* { dg-final { scan-assembler-not "pshufb\[ \t\]\\(%esp\\)" } } */
#include <immintrin.h>
diff --git a/gcc/testsuite/gcc.target/i386/pr83994.c
b/gcc/testsuite/gcc.target/i386/pr83994.c
index dc0b7cb44c44..1eb47e3cf0a2 100644
--- a/gcc/testsuite/gcc.target/i386/pr83994.c
+++ b/gcc/testsuite/gcc.target/i386/pr83994.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -march=i686 -fpic -fstack-clash-protection" } */
/* { dg-require-effective-target ia32 } */
--
2.17.1
