On Tue, Nov 03, 2020 at 09:25:03AM +0100, Olivier Hainque wrote:
> Hello,
>
> This change is a proposal to add
>
> /* { dg-require-effective-target fpic } */
>
> to tests in gcc.target/i386 that do use -fpic or -fPIC
> but don't currently query the target support.
>
> This corresponds to what many other fpic tests do
> and helps the vxWorks ports at least, as -fpic is
> typically not supported in at least one of the two
> major modes of such port (kernel vs RTP).
70% of the tests you've changed have a target *-linux* or similar
right above that line, what is the point of adding the fpic
effective targets to those? Those surely aren't run on vxWorks
and on x86 Linux fpic is always supported.
No objection to adding it to the rest.
Jakub
