Re: Patch ping (stage1-ish patches)

2013-11-28 Thread Jakub Jelinek
On Wed, Nov 27, 2013 at 01:06:06PM -0700, Jeff Law wrote: > + HOST_WIDE_INT offset, sz; > + sz = ASAN_RED_ZONE_SIZE; > + sz = data.asan_vec[0] - prev_offset; > > Seems to me like the first assignment to sz is dead. Clearly > something isn't right here. Thanks for catching that

Re: [PING^2] [PATCH] PR59063

2013-11-28 Thread Jakub Jelinek
On Wed, Nov 27, 2013 at 05:52:30PM +0400, Yury Gribov wrote: > > Perhaps it is time for libsanitizer.spec filled in during > configure of libsanitizer > > that the spec would source in? > > Draft patch is attached, let's see if I understood your > recommendation correctly. Some obvious quirks: > 1

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-28 Thread Jakub Jelinek
On Wed, Nov 27, 2013 at 12:01:50PM +0400, Yury Gribov wrote: > As discussed in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59106 > only a subset of libubsan should be built with RTTI support. > Attached patch adds custom build rules for relevant files. We assume GNU make I think, I wonder if this

Re: [PATCH] OpenMP #pragma omp declare simd support (take 2)

2013-11-28 Thread Andreas Schwab
Causes an ICE on ia64. spawn /usr/local/gcc/gcc-20131128/Build/gcc/xgcc -B/usr/local/gcc/gcc-20131128/Build/gcc/ /usr/local/gcc/gcc-20131128/gcc/testsuite/gcc.dg/vect/vect-simd-clone-1.c -fno-diagnostics-show-caret -fdiagnostics-color=never -flto -ffat-lto-objects -ftree-vectorize -fno-vect

Re: [Patch, RTL] Eliminate redundant vec_select moves.

2013-11-28 Thread Richard Sandiford
Tejas Belagod writes: > Richard Sandiford wrote: >> Tejas Belagod writes: The problem is that one reg rtx can span several hard registers. E.g. (reg:V4SI 32) might represent one 64-bit register (no. 32), but it might instead represent two 32-bit registers (nos. 32 and 33). Obv

Re: [Patch, ARM] Fix ICE when high register is used as pic base register for thumb1 target

2013-11-28 Thread Richard Earnshaw
On 28/11/13 05:55, Terry Guo wrote: > > >> -Original Message- >> From: Richard Earnshaw >> Sent: Tuesday, November 26, 2013 5:44 PM >> To: Terry Guo >> Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org >> Subject: Re: [Patch, ARM] Fix ICE when high register is used as pic base >> register

[PING ^ 2] [PATCH 1/n] Add conditional compare support

2013-11-28 Thread Zhenqiang Chen
Hi, Patch is rebased with the latest trunk with changes: * simplify_while_replacing (recog.c) should not swap operands of compares in CCMP. * make sure no other instructions can clobber CC except compares in CCMP when expanding CCMP. For easy to read, I add the following description(in expr.c).

[PATCH, nds32] Committed: Adjust MULT performance cost.

2013-11-28 Thread Chung-Ju Wu
Hi, all, The multiplication operation is low cost in nds32 target. COSTS_N_INSNS(5) is too expensive for performance. Adjust MULT cost to COSTS_N_INSNS(1). Committed as Rev. 205478: http://gcc.gnu.org/r205478 Index: gcc/ChangeLog =

Re: [PATCH, testsuite] Fix some testcases for nds32 target and provide new nds32 target specific tests

2013-11-28 Thread Chung-Ju Wu
Hi, Mike, There is a pending testsuite patch for nds32 target: http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01584.html Is it OK for trunk? :) Best regards, jasonwucj 2013/11/14 Chung-Ju Wu : > > I would like to modify some testcases for nds32 target. > Also I have some nds32 target specif

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-11-28 Thread Richard Earnshaw
On 27/11/13 18:35, Jeff Law wrote: > On 11/27/13 03:19, Yvan Roux wrote: >> Ping. >> >> On 20 November 2013 10:22, Yvan Roux wrote: >>> Hi, >>> >>> as Richard said, only a subset of rclass is allowed to be returned by >>> preferred_reload_class. > I don't think he was quite that definitive. "One

Re: [PATCH, ARM, LRA] Fixed bootstrap failure in Thumb mode

2013-11-28 Thread Richard Earnshaw
On 27/11/13 18:27, Jeff Law wrote: > On 11/27/13 10:49, Yvan Roux wrote: >>> How can that be correct? >>> >>> The secondary reload macros/hooks define cases where additional registers >>> are needed to reload certain forms of rtl. I doubt the use of LRA >>> completely eliminates the need for secon

RE: [PING] [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-11-28 Thread Bernd Edlinger
Hi, On Wed, 27 Nov 2013 12:07:16, Jeff Law wrote: > > On 11/27/13 05:29, Bernd Edlinger wrote: >> Hi, >> >> ping... >> >> this patch still open: >> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02291.html >> >> Note: it does, as it is, _not_ depend on the keep_aligning patch. >> And it would fix s

[Patch, ARM] Add v7m specific extra rtx cost table

2013-11-28 Thread Terry Guo
Hello, This patch intends to add a specific extra rtx cost table for v7-m profile targets. Tested with gcc regression test, no new regressions. Is it OK to trunk? BR, Terry 2013-11-28 Terry Guo * config/arm/aarch-cost-tables.h (v7m_extra_costs): New table.diff --git a/gcc/config/a

Re: [Patch, ARM] Add v7m specific extra rtx cost table

2013-11-28 Thread Kyrill Tkachov
On 28/11/13 10:34, Terry Guo wrote: Hello, This patch intends to add a specific extra rtx cost table for v7-m profile targets. Tested with gcc regression test, no new regressions. Is it OK to trunk? BR, Terry 2013-11-28 Terry Guo * config/arm/aarch-cost-tables.h (v7m_extra_cost

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-28 Thread Richard Earnshaw
On 18/09/13 10:15, bin.cheng wrote: > > >> -Original Message- >> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- >> ow...@gcc.gnu.org] On Behalf Of bin.cheng >> Sent: Monday, September 02, 2013 3:09 PM >> To: Richard Earnshaw >> Cc: gcc-patches@gcc.gnu.org >> Subject: RE: [PATCH

Re: [PATCH v2] libgcc: AArch64: Check for correct signal insns on BE when unwinding

2013-11-28 Thread Richard Earnshaw
On 27/11/13 10:43, Matthew Leach wrote: > Hi, > > When unwinding the stack, the unwind code checks for two opcodes that > denote a registrations of a signal handler. This is broken on BE as > the opcodes will be in the wrong byte-order as insns are always LE. > > Add the correct checks when compi

Re: [Patch, ARM] Add v7m specific extra rtx cost table

2013-11-28 Thread Richard Earnshaw
On 28/11/13 10:39, Kyrill Tkachov wrote: > On 28/11/13 10:34, Terry Guo wrote: >> Hello, >> >> This patch intends to add a specific extra rtx cost table for v7-m profile >> targets. Tested with gcc regression test, no new regressions. Is it OK to >> trunk? >> >> BR, >> Terry >> >> 2013-11-28 Terry

Re: [Patch, ARM] Add v7m specific extra rtx cost table

2013-11-28 Thread Richard Earnshaw
On 28/11/13 10:34, Terry Guo wrote: > Hello, > > This patch intends to add a specific extra rtx cost table for v7-m profile > targets. Tested with gcc regression test, no new regressions. Is it OK to > trunk? > > BR, > Terry > > 2013-11-28 Terry Guo > >* config/arm/aarch-cost-tab

RE: [Patch, ARM] Add v7m specific extra rtx cost table

2013-11-28 Thread Terry Guo
> -Original Message- > From: Richard Earnshaw > Sent: Thursday, November 28, 2013 7:09 PM > To: Terry Guo > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [Patch, ARM] Add v7m specific extra rtx cost table > > On 28/11/13 10:34, Terry Guo wrote: > > Hello, > > > > This patch intends to add a

RE: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-28 Thread Gopalasubramanian, Ganesh
This patch adds influence of macro TARGET_LOOP_UNROLL_ADJUST during constant iterations (decide_unroll_constant_iterations). The macro has been already checked for runtime iterations (decide_unroll_runtime_iterations), and for unroll stupid (decide_unroll_stupid). Bootstrapping and test passes

Store the SSA name range type in the tree structure

2013-11-28 Thread Richard Sandiford
At the moment, an anti range ~[A,B] is stored as [B+1,A-1]. This makes it harder to store the range in the natural precision of A and B, since B+1 and A-1 might not be representable in that precision. This patch instead stores the original minimum and maximum values and uses a spare tree bit to r

[Patch, AArch64] Relax CANNOT_CHANGE_MODE_CLASS.

2013-11-28 Thread Tejas Belagod
Hi, Currently, CANNOT_CHANGE_MODE_CLASS is too restrictive wrt the mode-changes it allows on FPREGs - it allows none at the moment. In fact, there are many mode changes that are safe and can be allowed. For example, in a pattern like: (subreg:SF (reg:V4SF v0) 0) it is legal to reduce th

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-28 Thread Yury Gribov
> I wonder if this can't be done through > just adding -fno-rtti to AM_CXXFLAGS and say > ubsan_handlers_cxx.% ubsan_type_hash.% : AM_CXXFLAGS += -frtti Yup, that did the trick. Attaching modified patch. diff --git a/libsanitizer/ubsan/Makefile.am b/libsanitizer/ubsan/Makefile.am index e98984a..

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-28 Thread Jakub Jelinek
On Thu, Nov 28, 2013 at 03:29:02PM +0400, Yury Gribov wrote: > > I wonder if this can't be done through > > just adding -fno-rtti to AM_CXXFLAGS and say > > ubsan_handlers_cxx.% ubsan_type_hash.% : AM_CXXFLAGS += -frtti > > Yup, that did the trick. Attaching modified patch. > @@ -13,11 +13,13 @@

Re: wide-int, gimple

2013-11-28 Thread Richard Sandiford
Jakub Jelinek writes: > On Mon, Nov 25, 2013 at 12:24:30PM +0100, Richard Biener wrote: >> On Sat, Nov 23, 2013 at 8:21 PM, Mike Stump wrote: >> > Richi has asked the we break the wide-int patch so that the >> > individual port and front end maintainers can review their parts >> > without have to

[PATCH] Fix PR59323

2013-11-28 Thread Richard Biener
This fixes PR59323 - we were unifying TYPE_DECLs used in different BLOCK_VARS - ultimately because they were errorneously put into the global indexed decls. Fixed by including some more kinds that, when having function context, are not indexed. This is the minimal set of kinds to fix the testcas

Re: [PATCH ARM]Refine scaled address expression on ARM

2013-11-28 Thread Bin.Cheng
On Thu, Nov 28, 2013 at 6:48 PM, Richard Earnshaw wrote: > On 18/09/13 10:15, bin.cheng wrote: >> >> >>> -Original Message- >>> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- >>> ow...@gcc.gnu.org] On Behalf Of bin.cheng >>> Sent: Monday, September 02, 2013 3:09 PM >>> To: Richar

[wide-int] Small wide_int_to_tree optimisation

2013-11-28 Thread Richard Sandiford
This patch convers some gcc_asserts to gcc_checking_asserts. I think the first two in particular should be checking-only, since we ignore the bits above the target precision anyway. Also we have: /* This is a little hokie, but if the prec is smaller than what is necessary t

[wwwdocs] Update obvious fix commit policy

2013-11-28 Thread Diego Novillo
[ sent first version in html. apologies for the dup. ] Based on the recent discussion on the obvious fix policy. OK to commit? Index: htdocs/svnwrite.html === RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v retrieving revision 1.2

Re: [PATCH] Get rid of useless -fno-rtti for libubsan

2013-11-28 Thread Yury Gribov
> The above hunk is not needed anymore, is it? Right. > Ok for trunk without that hunk (and with Makefile.in regenerated again). Done, r205482. -Y

[PATCH, doc] Document -fsanitize=signed-integer-overflow

2013-11-28 Thread Marek Polacek
As promised, this patch on top of this patch by Tobias: http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03082.html adds the documentation for -fsanitize=signed-integer-overflow. Ok to install after the actual implementation is in? 2013-11-28 Marek Polacek * doc/invoke.texi: Document -fsa

Re: [testsuite] Properly set ld_library_path in cilk-plus tests

2013-11-28 Thread Rainer Orth
Hi Balaji, >> 2013-11-26 Rainer Orth >> >> * gcc.dg/cilk-plus/cilk-plus.exp: Append to ld_library_path. >> Call set_ld_library_path_env_vars. >> * g++.dg/cilk-plus/cilk-plus.exp: Likewise. > > Thanks for catching this! Sorry I didn't catch it sooner. I am just getting > myself f

Re: [testsuite] Properly set ld_library_path in cilk-plus tests

2013-11-28 Thread Rainer Orth
Hi Jeff, >> 2013-11-26 Rainer Orth >> >> * gcc.dg/cilk-plus/cilk-plus.exp: Append to ld_library_path. >> Call set_ld_library_path_env_vars. >> * g++.dg/cilk-plus/cilk-plus.exp: Likewise. > Thanks for taking care of this. You're probably getting more cilk+ fallout > than most bec

Re: Patch ping (stage1-ish patches)

2013-11-28 Thread Rainer Orth
Hi Jeff, >> On my side, there's >> >> [c++, driver] Add -lrt on Solaris >> http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01488.html >> >> resubmitted as >> >> http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00412.html >> >> It's unclear if the more intrusive solution outlined in the second >> message

GCC -mach=native on OS X 10.8

2013-11-28 Thread Vera Loeser
Dear all, I use the GCC 4.8 from Macports and I'd like to optimize my code by using the flag -march=native. For that I have to use the assembler of clang, because the GNU assembler is too old and cannot use the AVX extensions. By setting the flags "-Wa,-q" the GCC should work. But with optimizi

Re: GCC -mach=native on OS X 10.8

2013-11-28 Thread Iain Sandoe
Hello Vera, On 28 Nov 2013, at 13:15, Vera Loeser wrote: > I use the GCC 4.8 from Macports and I'd like to optimize my code by using the > flag -march=native. For that I have to use the assembler of clang, because > the GNU assembler is too old and cannot use the AVX extensions. By setting > t

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-11-28 Thread Richard Biener
On Thu, Nov 28, 2013 at 12:23 AM, Tom de Vries wrote: > On 27-11-13 07:20, Jeff Law wrote: >> >> On 11/26/13 14:10, Tom de Vries wrote: >>> >>> On 26-11-13 11:12, Richard Biener wrote: On Tue, Nov 26, 2013 at 8:57 AM, Tom de Vries wrote: > > Jason, > > This patch pr

Re: [wwwdocs] Update obvious fix commit policy

2013-11-28 Thread Diego Novillo
New version with a slightly cleaned up wording: Index: htdocs/svnwrite.html === RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v retrieving revision 1.29 diff -u -d -u -p -r1.29 svnwrite.html --- htdocs/svnwrite.html24 Sep 20

Re: [RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4

2013-11-28 Thread Richard Biener
On Thu, Nov 28, 2013 at 12:23 PM, Gopalasubramanian, Ganesh wrote: > This patch adds influence of macro TARGET_LOOP_UNROLL_ADJUST during constant > iterations (decide_unroll_constant_iterations). > The macro has been already checked for runtime iterations > (decide_unroll_runtime_iterations), a

Re: [PATCH i386] Enable -freorder-blocks-and-partition

2013-11-28 Thread Jan Hubicka
> Dear Teresa and Jan, >I tried to test Teresa's patch, but I've encountered two bugs > during usage of -fprofile-generate/use (one in SPEC CPU 2006 and > Inkscape). Thanks, this is non-LTO run. Is there a chance to get -flto version, too? So we see how things combine with -freorder-function >

Re: Store the SSA name range type in the tree structure

2013-11-28 Thread Richard Biener
On Thu, Nov 28, 2013 at 12:26 PM, Richard Sandiford wrote: > At the moment, an anti range ~[A,B] is stored as [B+1,A-1]. This makes > it harder to store the range in the natural precision of A and B, since > B+1 and A-1 might not be representable in that precision. > > This patch instead stores t

Re: _Cilk_spawn and _Cilk_sync for C++

2013-11-28 Thread Jason Merrill
On 11/27/2013 11:05 PM, Iyer, Balaji V wrote: Found the bug. I was not utilizing the stabilize_expr's output correctly. Unfortunately, I think I was misleading you with talk of stabilize; like you said, you want to evaluate the whole expression in the spawned function rather than in the calle

[patch] comitted : Re: [resend] - Probable buglet in ipa-prop.c

2013-11-28 Thread Andrew MacLeod
On 11/27/2013 05:51 PM, Jeff Law wrote: On 11/27/13 15:30, Andrew MacLeod wrote: On 11/27/2013 05:16 PM, Jeff Law wrote: On 11/27/13 14:30, Andrew MacLeod wrote: mailer added html again... When trying some of my updated prototype changes on trunk, the

Re: [wwwdocs] Update obvious fix commit policy

2013-11-28 Thread Diego Novillo
Fixed quotation as per IRC feedback. Index: htdocs/svnwrite.html === RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v retrieving revision 1.29 diff -u -d -u -p -r1.29 svnwrite.html --- htdocs/svnwrite.html24 Sep 2013 18:26:29

Re: wide-int, gimple

2013-11-28 Thread Richard Biener
On Thu, Nov 28, 2013 at 12:58 PM, Richard Sandiford wrote: > Jakub Jelinek writes: >> On Mon, Nov 25, 2013 at 12:24:30PM +0100, Richard Biener wrote: >>> On Sat, Nov 23, 2013 at 8:21 PM, Mike Stump wrote: >>> > Richi has asked the we break the wide-int patch so that the >>> > individual port and

Re: [wide-int] Small wide_int_to_tree optimisation

2013-11-28 Thread Richard Biener
On Thu, Nov 28, 2013 at 1:05 PM, Richard Sandiford wrote: > This patch convers some gcc_asserts to gcc_checking_asserts. > I think the first two in particular should be checking-only, > since we ignore the bits above the target precision anyway. > > Also we have: > > /* This is a little

Re: [wwwdocs] Update obvious fix commit policy

2013-11-28 Thread Richard Biener
On Thu, Nov 28, 2013 at 3:14 PM, Diego Novillo wrote: > Fixed quotation as per IRC feedback. > > Index: htdocs/svnwrite.html > === > RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v > retrieving revision 1.29 > diff -u -d -u -p -r1.2

Re: [wwwdocs] Update obvious fix commit policy

2013-11-28 Thread Diego Novillo
On Thu, Nov 28, 2013 at 9:25 AM, Richard Biener wrote: > Why remove ChangeLog files, web pages and comments? Either > enumerate everything or just enumerate nothing and simply say > "Obvious fixes can be committed without prior approval." Thanks, that's much better. I was trying to be more inc

[PATCH] Fix PR59330

2013-11-28 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2013-11-28 Richard Biener PR tree-optimization/59330 * tree-ssa-dce.c (eliminate_unnecessary_stmts): Simplify and fix delayed marking of free calls not necessary. * gcc.dg/torture/pr59330.

Re: [ARM] Fix register r3 wrongly used to save ip in nested APCS frame

2013-11-28 Thread Richard Earnshaw
Eric, My apologies for taking so long to look at this. > 2013-09-05 Eric Botcazou > > * config/arm/arm.c (arm_expand_prologue): In a nested APCS frame with > arguments to push onto the stack and no varargs, save ip into a stack > slot if r3 isn't available on entry. Sorry, b

[PATCH] One more testcase for PR59323

2013-11-28 Thread Richard Biener
Committed. Richard. 2013-11-28 Richard Biener PR lto/59323 * gcc.dg/lto/pr59323-2_0.c: New testcase. Index: gcc/testsuite/gcc.dg/lto/pr59323-2_0.c === --- gcc/testsuite/gcc.dg/lto/pr59323-2_0.c (revision 0)

[PATCH, i386 libgcc]: Define __FP_FRAC_ADDI_4 in 32bit sfp-machine.h

2013-11-28 Thread Uros Bizjak
Hello! Attached patch introduces __FP_FRAC_ADDI_4 to improve 32bit soft-fp code a bit. The effect can be seen in a couple of places, for example in divtf3 the part of code changes from: 70f:83 c0 04 add$0x4,%eax 712:89 84 24 90 00 00 00 mov%eax,0x90(%

Re: [wwwdocs] Update obvious fix commit policy

2013-11-28 Thread Richard Earnshaw
On 28/11/13 14:28, Diego Novillo wrote: > On Thu, Nov 28, 2013 at 9:25 AM, Richard Biener > wrote: > >> Why remove ChangeLog files, web pages and comments? Either >> enumerate everything or just enumerate nothing and simply say >> "Obvious fixes can be committed without prior approval." > > Tha

Re: [wwwdocs] Update obvious fix commit policy

2013-11-28 Thread Diego Novillo
On Thu, Nov 28, 2013 at 10:32 AM, Richard Earnshaw wrote: > I think it might be worth saying that one class of 'obvious' fix that we > don't want to go in without prior clearance are bulk white space > clean-ups. These can be a right-royal pain to deal with if you're in > the middle of a big re-

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-11-28 Thread Eric Botcazou
> Ok if testing succeeds there but please leave out the checking bits. Yes, they (perhaps unsurprisingly) trigger in Ada, I'll investigate. -- Eric Botcazou

Re: [wwwdocs] Update obvious fix commit policy

2013-11-28 Thread H.J. Lu
On Thu, Nov 28, 2013 at 7:38 AM, Diego Novillo wrote: > On Thu, Nov 28, 2013 at 10:32 AM, Richard Earnshaw wrote: > >> I think it might be worth saying that one class of 'obvious' fix that we >> don't want to go in without prior clearance are bulk white space >> clean-ups. These can be a right-r

PATCH: PR c/59309: FAIL: c-c++-common/cilk-plus/CK/spawnee_inline.c -g -fcilkplus (test for excess errors)

2013-11-28 Thread H.J. Lu
Hi, For function without arguments, gimplify_cilk_spawn checks *arg_array == NULL_TREE But arg_array is a TREE vector of zero elements. This patch updates gimplify_cilk_spawn to properly handle function without arguments. Tested on Linux/x86-64 with GCC bootstraped using -fsanitize=address. OK

[PATCH][ARM] Set "conds" attribute for non-predicable ARMv8-A instructions

2013-11-28 Thread Kyrill Tkachov
Hi all, Some ARMv8-A instructions in the vrint* family as well as the vmaxnm and vminnm ones do not have a conditional variant and have therefore their "predicable" attribute set to "no". However we've discovered that they can still end up conditionalised in some cases because of the arm_cond_

Re: [PATCH][ARM] Set "conds" attribute for non-predicable ARMv8-A instructions

2013-11-28 Thread Richard Earnshaw
On 28/11/13 16:10, Kyrill Tkachov wrote: > Hi all, > > Some ARMv8-A instructions in the vrint* family as well as the vmaxnm and > vminnm > ones do not have a conditional variant and have therefore their "predicable" > attribute set to "no". > However we've discovered that they can still end up

Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-28 Thread Joseph S. Myers
On Wed, 27 Nov 2013, Max Woodbury wrote: > There should be a way to change the __FILE__ value without changing the > line number sequencing. Whatever that mechanism is, it should NOT > introduce maintenance problems that involve counting lines of code. I think that #line is mainly intended for u

Re: Store the SSA name range type in the tree structure

2013-11-28 Thread Richard Sandiford
Richard Biener writes: > On Thu, Nov 28, 2013 at 12:26 PM, Richard Sandiford > wrote: >> At the moment, an anti range ~[A,B] is stored as [B+1,A-1]. This makes >> it harder to store the range in the natural precision of A and B, since >> B+1 and A-1 might not be representable in that precision.

RE: _Cilk_spawn and _Cilk_sync for C++

2013-11-28 Thread Iyer, Balaji V
> -Original Message- > From: Jason Merrill [mailto:ja...@redhat.com] > Sent: Thursday, November 28, 2013 9:11 AM > To: Iyer, Balaji V; gcc-patches@gcc.gnu.org > Cc: Jeff Law > Subject: Re: _Cilk_spawn and _Cilk_sync for C++ > > On 11/27/2013 11:05 PM, Iyer, Balaji V wrote: > > Found the

RE: PATCH: PR c/59309: FAIL: c-c++-common/cilk-plus/CK/spawnee_inline.c -g -fcilkplus (test for excess errors)

2013-11-28 Thread Iyer, Balaji V
> -Original Message- > From: Lu, Hongjiu > Sent: Thursday, November 28, 2013 11:06 AM > To: gcc-patches@gcc.gnu.org > Cc: Iyer, Balaji V > Subject: PATCH: PR c/59309: FAIL: c-c++-common/cilk- > plus/CK/spawnee_inline.c -g -fcilkplus (test for excess errors) > > Hi, > > For function with

Re: [WWWDOCS] Document IPA/LTO/FDO/i386 changes in GCC-4.9

2013-11-28 Thread Jan Hubicka
> > + Functions are no longer pointlessly renamed. > > Readers may struggle a bit with this. What does it refer to? We previously renamed every static function foo into foo.1234 (just as a precaution because other compilation unit may have also function foo). This confuses many thins, so n

Re: [PING] [PATCH, ARM, testcase] Skip target arm-neon for lp1243022.c

2013-11-28 Thread Richard Earnshaw
On 28/11/13 06:17, Zhenqiang Chen wrote: > > >> -Original Message- >> From: Jeff Law [mailto:l...@redhat.com] >> Sent: Thursday, November 28, 2013 12:43 AM >> To: Zhenqiang Chen; gcc-patches@gcc.gnu.org >> Cc: Ramana Radhakrishnan; Richard Earnshaw >> Subject: Re: [PING] [PATCH, ARM, test

RE: _Cilk_spawn and _Cilk_sync for C++

2013-11-28 Thread Iyer, Balaji V
> -Original Message- > From: Jason Merrill [mailto:ja...@redhat.com] > Sent: Thursday, November 28, 2013 9:11 AM > To: Iyer, Balaji V; gcc-patches@gcc.gnu.org > Cc: Jeff Law > Subject: Re: _Cilk_spawn and _Cilk_sync for C++ > > On 11/27/2013 11:05 PM, Iyer, Balaji V wrote: > > Found the

[wide-int] small cleanup in wide-int.*

2013-11-28 Thread Kenneth Zadeck
This patch does three things in wide-int: 1) it cleans up some comments. 2) removes a small amount of trash. 3) it changes the max size of the wide int from being 4x of MAX_BITSIZE_MODE_ANY_INT to 2x +1. This should improve large muls and divs as well as perhaps help with some cache behavior.

[PATCH] Fix up bogus warning (PR sanitizer/59331)

2013-11-28 Thread Marek Polacek
We wrongly warned on instrumented VLAs that the size expression's value is not used (with cc1plus only). Unfortunately, this hasn't been detected before due to disabled warnings in the VLA tests. This patch adds a (void) cast to suppress the warning as well as enables the warnings in the VLA test

RFC: PR bootstrap/59199: [4.9 Regression] r205032 caused LTO bootstrap to fail with bootstrap-profile

2013-11-28 Thread H.J. Lu
There is a bad interaction between inlined C++ member functions and LTO + profiledbootstrap, which leads to LTO bootstrap to fail with bootstrap-profile: Existing SSA name for symbol marked for renaming: aloop_37 In member function \u2018__base_ctor \u2019: lto1: internal compiler error: SSA corr

[wide-int] Handle more ltu_p cases inline

2013-11-28 Thread Richard Sandiford
The existing ltu_p fast path can handle any pairs of single-HWI inputs, even for precision > HOST_BITS_PER_WIDE_INT. In that case both xl and yl are implicitly sign-extended to the larger precision, but with the extended values still being compared as unsigned. The extension doesn't change the re

[wide-int] Handle more cmps and cmpu cases inline

2013-11-28 Thread Richard Sandiford
As Richi asked, this patch makes cmps use the same shortcuts as lts_p. It also makes cmpu use the shortcut that I justed added to ltu_p. On that same fold-const.ii testcase, this reduces the number of cmps_large calls from 66924 to 916. It reduces the number of cmpu_large calls from 3462 to 4. T

[wide-int] Handle more add and sub cases inline

2013-11-28 Thread Richard Sandiford
Currently add and sub have no fast path for offset_int and widest_int, they just call the out-of-line version. This patch handles the single-HWI cases inline. At least on x86_64, this only adds one branch per call; the fast path itself is straight-line code. On the same fold-const.ii testcase, t

Re: [PATCH] Convert more passes to new dump framework

2013-11-28 Thread Martin Jambor
Hi, On Tue, Aug 06, 2013 at 10:18:05AM -0700, Sharad Singhai wrote: > On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor wrote: > > On Tue, Aug 06, 2013 at 09:22:02AM -0700, Sharad Singhai wrote: > >> On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li > >> wrote: > >> > On Tue, Aug 6, 2013 at 5:37 A

Re: [wide-int] Handle more ltu_p cases inline

2013-11-28 Thread Richard Earnshaw
On 28/11/13 17:29, Richard Sandiford wrote: > The existing ltu_p fast path can handle any pairs of single-HWI inputs, > even for precision > HOST_BITS_PER_WIDE_INT. In that case both xl and > yl are implicitly sign-extended to the larger precision, but with the > extended values still being compar

Re: wide-int, vax

2013-11-28 Thread Jan-Benedict Glaw
On Sat, 2013-11-23 11:23:08 -0800, Mike Stump wrote: > * config/vax/vax.c: Include wide-int.h. > (vax_float_literal): Use real_from_integer. Looks good to me, but Matt must tell for sure. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signat

*ping* Re: PR37132 – RFC patch for generation of DWARF symbol for Fortran's namelists (DW_TAG_namelist)

2013-11-28 Thread Tobias Burnus
A slightly early *ping* Tobias Burnus wrote: attached is an updated version of the patch. Change: Tobias Burnus wrote: But for "USE mod_name, only: nml", one is supposed to generate a DW_TAG_imported_declaration. And there I am stuck. For normal variables, the DW_TAG_imported_declaration ref

Re: [PATCH] Fix PR59330

2013-11-28 Thread H.J. Lu
On Thu, Nov 28, 2013 at 6:49 AM, Richard Biener wrote: > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2013-11-28 Richard Biener > > PR tree-optimization/59330 > * tree-ssa-dce.c (eliminate_unnecessary_stmts): Simplify > and fix delayed

Re: [PATCH] Fix PR59330

2013-11-28 Thread Jakub Jelinek
On Thu, Nov 28, 2013 at 11:14:45AM -0800, H.J. Lu wrote: > On Thu, Nov 28, 2013 at 6:49 AM, Richard Biener wrote: > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > > > Richard. > > > > 2013-11-28 Richard Biener > > > > PR tree-optimization/59330 > > * tre

Re: [patch] Fix PR middle-end/59138

2013-11-28 Thread Bernd Edlinger
Hi Eric, I think I see a small flaw in that patch: + /* Make sure not to write past the end of the struct. */ + store_bit_field (dest, + adj_bytelen * BITS_PER_UNIT, bytepos * BITS_PER_UNIT, + bytepos * BITS_PER_UNIT, ssize * BITS_PER_UNIT, + VOIDmode, tmps[i]); the parameter B

patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-28 Thread Vladimir Makarov
The following patch fixes PR57293 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57293 It is actually an implementation of missed LRA functionality in reg elimination. Before the patch any explicit change of stack pointer in RTL resulted in necessity to use the frame pointer. The patch has

Re: [wide-int] Handle more add and sub cases inline

2013-11-28 Thread Kenneth Zadeck
I would like to see some comment to the effect that this to allow inlining for the common case for widest int and offset int without inlining the uncommon case for regular wide-int. On 11/28/2013 12:38 PM, Richard Sandiford wrote: Currently add and sub have no fast path for offset_int and w

Fwd: Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-28 Thread Max Woodbury
Original Message Subject: Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives Date: Thu, 28 Nov 2013 17:32:41 -0500 From: Max Woodbury To: Joseph S. Myers On 11/28/2013 11:34 AM, Joseph S. Myers wrote: On Wed, 27 Nov 2013, Max Woodbury wrote: There

Re: Fwd: Re: [PATCH] Postpone __LINE__ evaluation to the end of #line directives

2013-11-28 Thread Joseph S. Myers
On Thu, 28 Nov 2013, Max Woodbury wrote: > As for the sequence of comments you point to, they are discussing the > use of __LINE__ in macros, not directives. The standard is quite a bit > more explicit about token substitution in directives, making it fairly > clear that substitution is not to oc

[PATCH] SIMD clones LTO fixes part 1 (PR lto/59326)

2013-11-28 Thread Jakub Jelinek
Hi! Here is the first part of LTO fixes for #pragma omp declare simd, in partuclar support for streaming OMP_CLAUSEs. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2013-11-28 Jakub Jelinek PR lto/59326 * tree-core.h (enum omp_clause_schedule_kind): Add

[PATCH] SIMD clones LTO fixes part 2 (PR lto/59326)

2013-11-28 Thread Jakub Jelinek
Hi! And here is second part of the fixes. Still, the vect-simd-clone-12.c testcase fails with -flto -flto-partition=1to1, so there is further work to do, but at least all current test succeed and actually use SIMD elementals when they should. Bootstrapped/regtested on x86_64-linux and i686-linux

[PATCH] Avoid SIMD clone dg-do run tests if assembler doesn't support AVX2 (PR lto/59326)

2013-11-28 Thread Jakub Jelinek
Hi! As we create SIMD clones for all of SSE2, AVX and AVX2 ISAs right now, the assembler needs to support SSE2, AVX and AVX2. Apparently some folks are still using binutils that don't handle that, this patch conditionalizes the test on that. Bootstrapped/regtested on x86_64-linux and i686-linux,

[committed] Fix bootstrap with 32-bit HWI (PR middle-end/59327)

2013-11-28 Thread Jakub Jelinek
Hi! With 32-bit HWI, we would get a -Wsign-compare warning here, this patch fixes it. Bootstrapped/regtested on x86_64-linux and i686-linux, committed as obvious. 2013-11-28 Jakub Jelinek PR middle-end/59327 * cfgexpand.c (expand_used_vars): Avoid warning on 32-bit HW

[committed] Fix #pragma omp atomic cleanup handling (PR c++/59297)

2013-11-28 Thread Jakub Jelinek
Hi! This patch fixes missing CLEANUP_POINT_EXPR around OMP_ATOMIC, which resulted in ICEs. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk and 4.8 branch. 2013-11-28 Jakub Jelinek PR c++/59297 * semantics.c (finish_omp_atomic): Call finish_expr_stmt

[PATCH] Fix handling of invalid {con,de}structor attribute arg (PR c/59280)

2013-11-28 Thread Jakub Jelinek
Hi! Calling default_conversion on IDENTIFIER_NODE which doesn't even have a type results in ICEs. On the other side, if arg is already error_mark_node, we have already reported an error and there is no point issuing another error. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for tru

Re: [PATCH] Fix handling of invalid {con,de}structor attribute arg (PR c/59280)

2013-11-28 Thread Joseph S. Myers
On Fri, 29 Nov 2013, Jakub Jelinek wrote: > Hi! > > Calling default_conversion on IDENTIFIER_NODE which doesn't even have a type > results in ICEs. On the other side, if arg is already error_mark_node, we > have already reported an error and there is no point issuing another error. > > Bootstra

Re: [PING][PATCH] LRA: check_rtl modifies RTL instruction stream

2013-11-28 Thread Alan Modra
On Wed, Nov 20, 2013 at 11:18:49AM -0700, Jeff Law wrote: > >2013-11-13 Robert Suchanek > > > > * lra.c (lra): Set lra_in_progress before check_rtl call. > > * recog.c (insn_invalid_p): Add !lra_in_progress to prevent > > adding clobber regs when LRA is runnin

Re: [PATCH] Fix up bogus warning (PR sanitizer/59331)

2013-11-28 Thread Jason Merrill
On 11/28/2013 12:14 PM, Marek Polacek wrote: t = fold_build2 (COMPOUND_EXPR, TREE_TYPE (t), - ubsan_instrument_vla (input_location, t), t); + ubsan_instrument_vla (input_location, t), + /* Cast to

Update docs for C99 and C11 support

2013-11-28 Thread Joseph S. Myers
This patch updates various documentation in GCC regarding the state of C99 and C11 support, in particular updating the documentation of implementation-defined behavior for C11. Tested with "make info html pdf" and committed. 2013-11-29 Joseph Myers * doc/implement-c.texi: Document C11

List C11 features in 4.9 release notes

2013-11-28 Thread Joseph S. Myers
I've applied this patch to mention new C11 features in the 4.9 release notes. (I expect there are plenty more features all over GCC that still need adding to the release notes - someone will need to review the changes that have gone in since 4.8, looking for significant new features.) Index: c

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-28 Thread H.J. Lu
On Thu, Nov 28, 2013 at 2:11 PM, Vladimir Makarov wrote: > The following patch fixes PR57293 > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57293 > > It is actually an implementation of missed LRA functionality in reg > elimination. Before the patch any explicit change of stack pointer in >

Fix C99 inline function definition following static inline declaration (PR c/57574)

2013-11-28 Thread Joseph S. Myers
This patch fixes PR 57574, where a function defined (in C99 mode) as "inline" following a "static inline" declaration was wrongly considered an external reference, meaning (a) spurious diagnostics about references to static variables and (b) undefined references to the function could be generated a

Re: [wide-int] Handle more ltu_p cases inline

2013-11-28 Thread Kenneth Zadeck
this is fine. kenny On 11/28/2013 12:29 PM, Richard Sandiford wrote: The existing ltu_p fast path can handle any pairs of single-HWI inputs, even for precision > HOST_BITS_PER_WIDE_INT. In that case both xl and yl are implicitly sign-extended to the larger precision, but with the extended value

Re: [wide-int] Handle more cmps and cmpu cases inline

2013-11-28 Thread Kenneth Zadeck
like the add/sub patch, enhance the comment so that it says that it is designed to hit the widestint and offset int common cases. kenny On 11/28/2013 12:34 PM, Richard Sandiford wrote: As Richi asked, this patch makes cmps use the same shortcuts as lts_p. It also makes cmpu use the shortcut tha

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-11-28 Thread Vladimir Makarov
On 11/28/2013, 7:51 PM, H.J. Lu wrote: On Thu, Nov 28, 2013 at 2:11 PM, Vladimir Makarov wrote: The following patch fixes PR57293 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57293 It is actually an implementation of missed LRA functionality in reg elimination. Before the patch any expl

RE: [PATCH] Fix PR58944

2013-11-28 Thread Bernd Edlinger
Hi, On Wed, 27 Nov 2013 19:49:39, Uros Bizjak wrote: > > On Mon, Nov 25, 2013 at 10:08 PM, Sriraman Tallam wrote: > >> I have attached a patch to fix this bug : >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58944 >> >> A similar problem was also reported here: >> http://gcc.gnu.org/ml/gcc-pat

  1   2   >