On 28/11/13 14:28, Diego Novillo wrote: > On Thu, Nov 28, 2013 at 9:25 AM, Richard Biener > <richard.guent...@gmail.com> wrote: > >> Why remove ChangeLog files, web pages and comments? Either >> enumerate everything or just enumerate nothing and simply say >> "Obvious fixes can be committed without prior approval." > > Thanks, that's much better. I was trying to be more inclusive. > > > Index: htdocs/svnwrite.html > =================================================================== > RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v > retrieving revision 1.29 > diff -u -d -u -p -r1.29 svnwrite.html > --- htdocs/svnwrite.html 24 Sep 2013 18:26:29 -0000 1.29 > +++ htdocs/svnwrite.html 28 Nov 2013 14:26:54 -0000 > @@ -147,10 +147,12 @@ list.</p> > > <p>The following changes can be made by everyone with SVN write access:</p> > > -<p>Fixes for obvious typos in ChangeLog files, docs, web pages, comments > -and similar stuff. Just check in the fix and copy it to > -<code>gcc-patches</code>. We don't want to get overly anal-retentive > -about checkin policies.</p> > +<p>Obvious fixes can be committed without prior approval. Just check > +in the fix and copy it to <code>gcc-patches</code>. A good test to > +determine whether a fix is obvious: <q>will the person who objects to > +my work the most be able to find a fault with my fix?</q> If the fix > +is later found to be faulty, it can always be rolled back. We don't > +want to get overly restrictive about checkin policies.</p> > > <p>Similarly, no outside approval is needed to revert a patch that you > checked in.</p> >
I think it might be worth saying that one class of 'obvious' fix that we don't want to go in without prior clearance are bulk white space clean-ups. These can be a right-royal pain to deal with if you're in the middle of a big re-write of a hunk of code. R.
