Re: Pre-Patch RFC: proposed changes to option-lookup

2013-10-31 Thread Marek Polacek
On Thu, Oct 31, 2013 at 12:15:41AM -0600, Jeff Law wrote: > On 10/30/13 14:39, David Malcolm wrote: > >[Sending this to gcc-patches to double-check that the idea is sound > >before continuing to work on this large patch. [1] ] > > > >I want to eliminate hidden use of the preprocessor in our code, i

Re: [RFC/CFT] auto-wipe dump files [was: Re: [committed] Fix up bb-slp-31.c testcase]

2013-10-31 Thread Bernhard Reutner-Fischer
On 31 October 2013 01:01, Mike Stump wrote: > On Oct 30, 2013, at 2:41 AM, Bernhard Reutner-Fischer > wrote: >>> I've noticed that this testcase doesn't clean up after itself. > >> This was nagging me last weekend.. ;) >> What about automating this? > > So, the idea sounds very nice. > > One thi

Re: [RFC/CFT] auto-wipe dump files [was: Re: [committed] Fix up bb-slp-31.c testcase]

2013-10-31 Thread Jakub Jelinek
On Thu, Oct 31, 2013 at 09:34:41AM +0100, Bernhard Reutner-Fischer wrote: > The cleanup routine would currently run 7 regexes on the incoming > compiler-flags which is supposedly pretty fast. > But yes, we could as well key off scan-dump. If we do that, i'd > suggest to simply wipe all potential du

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-31 Thread Bernhard Reutner-Fischer
On 30 October 2013 23:22, Mike Stump wrote: > On Oct 30, 2013, at 3:14 PM, Bernhard Reutner-Fischer > wrote: >> On 30 October 2013 22:47, Mike Stump wrote: >>> >>> Was there a significant purpose for the added C++ comment? If not, can you >>> remove that? If so, can you explain? >> >> grep -

[wide-int] Fix ada builds

2013-10-31 Thread Richard Sandiford
I applied this obvious patch to get the ada frontend building. Richard Index: gcc/ada/gcc-interface/decl.c === --- gcc/ada/gcc-interface/decl.c(revision 204174) +++ gcc/ada/gcc-interface/decl.c(working copy) @@ -1658

[wide-int] Various division fixes

2013-10-31 Thread Richard Sandiford
There are several Ada failures on the branch, all related to division and modulus: - div_floor adjusted truncated negative quotients in the wrong direction (up instead of down). E.g. -5 /[fl] 2 gave -1 rather than -3. - {div,mod}_round used the wrong condition to check when rounding was needed

[PATCH, MPX, 2/X] Pointers Checker [7/25] Suppress BUILT_IN_CHKP_ARG_BND optimizations.

2013-10-31 Thread Ilya Enkovich
Hi, Here is a patch which hadles the problem with optimization of BUILT_IN_CHKP_ARG_BND calls. Pointer Bounds Checker expects that argument of this call is a default SSA_NAME of the PARM_DECL whose bounds we want to get. The problem is in optimizations which may replace arg with it's copy or

RE: [PATCH 1/n] Add conditional compare support

2013-10-31 Thread Zhenqiang Chen
> -Original Message- > From: Richard Henderson [mailto:r...@redhat.com] > Sent: Thursday, October 31, 2013 4:14 AM > To: Zhenqiang Chen > Cc: Richard Earnshaw; 'Richard Biener'; GCC Patches > Subject: Re: [PATCH 1/n] Add conditional compare support > > > +/* RCODE0, RCODE1 and a valid re

[PATCH, MPX, 2/X] Pointers Checker [8/25] Languages support

2013-10-31 Thread Ilya Enkovich
Hi, This patch adds support Pointer Bounds Checker into c-family and LTO front-ends. The main purpose of changes in front-end is to register all statically initialized objects for checker. We also need to register such objects created by compiler. Thanks, Ilya -- gcc/ 2013-10-29 Ilya Enko

[PATCH, MPX, 2/X] Pointers Checker [9/25] Bound constants

2013-10-31 Thread Ilya Enkovich
Hi, Here is a patch which adds support for bound constant to be used as DECL_INITIAL for constant static bounds generated by compiler. Thanks, Ilya -- gcc/ 2013-10-23 Ilya Enkovich * emit-rtl.c (immed_double_const): Support MODE_POINTER_BOUNDS. * explow.c (trunc_int_for_mod

[PATCH, MPX, 2/X] Pointers Checker [10/25] Calls copy and verification

2013-10-31 Thread Ilya Enkovich
Hi, Here is a patch to support of instrumented code in calls verifiers and calls copy with skipped args. Thanks, Ilya -- gcc/ 2013-10-29 Ilya Enkovich * cgraph.c (gimple_check_call_args): Handle bound args. * gimple.c (gimple_call_copy_skip_args): Likewise. (validat

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-10-31 Thread Marek Polacek
On Wed, Oct 30, 2013 at 03:41:53PM -0700, Mike Stump wrote: > The dtors only run, after the ctors run. We mark where the ctors finish > spot, as the _start_ of the region for which we have to clean up. Really, > the cleanup has nothing to do with ctors. You can have dtors, without any > ctors

RE: [PATCH] Fix C++0x memory model for -fno-strict-volatile-bitfields on ARM

2013-10-31 Thread Bernd Edlinger
Hello, meanwhile, I have added a test case to that patch. Boot-strapped and regression-tested as usual. OK for trunk? Bernd. > Hi, > > On Fri, 25 Oct 2013 11:26:20, Richard Biener wrote: >> >> On Fri, Oct 25, 2013 at 10:40 AM, Bernd Edlinger >> wrote: >>> Hello, >>> >>> this patch fixes the r

Re: Honnor ix86_accumulate_outgoing_args again

2013-10-31 Thread Florian Weimer
On 10/10/2013 08:40 PM, Jan Hubicka wrote: + In 32bit mode enabling argument accumulation results in about 5% code size + growth becuase move instructions are less compact than push. In 64bit + mode the difference is less drastic but visible. + + FIXME: Unlike earlier implementations, th

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-10-31 Thread Uros Bizjak
Hello! > SAD (Sum of Absolute Differences) is a common and important algorithm > in image processing and other areas. SSE2 even introduced a new > instruction PSADBW for it. A SAD loop can be greatly accelerated by > this instruction after being vectorized. This patch introduced a new > operation

Re: patch to fix PR58784 (ARM LRA crash)

2013-10-31 Thread Ramana Radhakrishnan
On Wed, Oct 30, 2013 at 3:03 PM, Vladimir Makarov wrote: > The following patch fixes > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58784 > > LRA has an old check of legitimate addresses. It was written before a newer > address decomposition code which makes more correct checks of addresses. > >

Re: patch to fix PR58784 (ARM LRA crash)

2013-10-31 Thread Ramana Radhakrishnan
On Wed, Oct 30, 2013 at 3:03 PM, Vladimir Makarov wrote: > The following patch fixes > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58784 > > LRA has an old check of legitimate addresses. It was written before a newer > address decomposition code which makes more correct checks of addresses. > >

Re: [wide-int] Various division fixes

2013-10-31 Thread Kenneth Zadeck
On 10/31/2013 05:01 AM, Richard Sandiford wrote: There are several Ada failures on the branch, all related to division and modulus: - div_floor adjusted truncated negative quotients in the wrong direction (up instead of down). E.g. -5 /[fl] 2 gave -1 rather than -3. - {div,mod}_round used t

Re: [wide-int] Update main comment

2013-10-31 Thread Kenneth Zadeck
On 10/30/2013 02:34 PM, Richard Sandiford wrote: Kenneth Zadeck writes: On 10/30/2013 07:01 AM, Richard Sandiford wrote: Kenneth Zadeck writes: On 10/29/2013 06:37 PM, Richard Sandiford wrote: This patch tries to update the main wide_int comment to reflect the current implementation. - bit

Re: changing a collision resolution strategy of the symbol table of identifiers

2013-10-31 Thread Florian Weimer
On 10/20/2013 02:55 PM, Roman Gareev wrote: During testing of the linux kernel (3.8.8) compilation time, the acquired results were the following: increasing by 0.17% for the version 4.8.0, increasing by 1.12% for the version 4.8.1, decreasing by 0.598% for trunk (this are average values). Can y

Re: [C++ Patch] PR 58466

2013-10-31 Thread Paolo Carlini
... for now I'm reverting this commit. The issue is just an ICE on invalid and the fix is causing problems, per c++/58932 - sorry about that. Thanks, Paolo. /// /cp 2013-10-31 Paolo Carlini PR c++/58932 Revert: 2013-10-18 Paolo Carlini

Re: [PATCH] Invalid unpoisoning of stack redzones on ARM

2013-10-31 Thread Yury Gribov
>> So ok to commit? > Ok with the change suggested by Richard, I think it was: addr = copy_to_mode_reg (Pmode, XEXP (shadow_mem, 0)); Done, r204251. Tested against x64 and ARM. -Y

Re: PR C++/58708 - string literal operator templates broken

2013-10-31 Thread Ed Smith-Rowland
On 10/25/2013 10:40 AM, Jakub Jelinek wrote: On Fri, Oct 25, 2013 at 10:29:41AM -0400, Ed Smith-Rowland wrote: 2013-10-25 Edward Smith-Rowland <3dw...@verizon.net> PR c++/58708 * parser.c (make_string_pack): Discover non-const type and size of character and build parm

Re: PR C++/58708 - string literal operator templates broken

2013-10-31 Thread Jakub Jelinek
On Thu, Oct 31, 2013 at 08:34:55AM -0400, Ed Smith-Rowland wrote: > 2013-10-31 Edward Smith-Rowland <3dw...@verizon.net> > > PR c++/58708 > * parser.c (make_string_pack): Discover non-const type and size > of character and build parm pack with correct type and chars. > > gcc

[PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-10-31 Thread Dodji Seketeli
Hello, In this problem report, the compiler is fed a (bogus) translation unit in which some literals contains bytes whose value is zero. The preprocessor detects that and proceeds to emit diagnostics for that king of bogus literals. But then when the diagnostics machinery re-reads the input file

[PATCH] LRA: Fix incorrect register spill/reload

2013-10-31 Thread Robert Suchanek
Hello, When investigating regression with LRA enabled for mips16 I found incorrect spilling and reload of registers by callee.  In the case, one register was not saved, although used, and another one never used but saved/restored. The issue appears to be in setting registers ever lived and sub

Re: [PATCH, PR 10474] Split live-ranges of function arguments to help shrink-wrapping

2013-10-31 Thread Martin Jambor
On Thu, Oct 31, 2013 at 12:16:41AM +0100, Jakub Jelinek wrote: > On Fri, Oct 25, 2013 at 05:19:06PM +0200, Martin Jambor wrote: > > 2013-10-23 Martin Jambor > > > > PR rtl-optimization/10474 > > * ira.c (find_moveable_pseudos): Do not calculate dominance info > > nor df analysis. >

Re: C++14 digit separators..

2013-10-31 Thread Jason Merrill
OK. Jason

Re: [PATCH GCC]Simplify address expression in IVOPT

2013-10-31 Thread Yufeng Zhang
On 10/30/13 14:46, Richard Biener wrote: On Tue, Oct 29, 2013 at 10:18 AM, bin.cheng wrote: Hi, I noticed that IVOPT generates complex address expressions like below for iv base. &arr_base[0].y &arr[0] &MEM[p+o] It's even worse for targets support auto-increment addre

Re: [PATCH] Time profiler - phase 1

2013-10-31 Thread Andi Kleen
Martin Liška writes: > Hello, >I've cooperating with Jan on a new profile-based function > reordering stuff. This first patch introduces a new GCOV counter that > instruments each function call and stores the time of first run of a > function. I'm curious, do you have any numbers how much th

Re: C++ PATCH to deal with trivial but non-callable [cd]tors

2013-10-31 Thread Jason Merrill
On 10/25/2013 03:04 PM, Jason Merrill wrote: In C++ all classes have destructors, but we try to defer building the implicit declaration. My patch causes us to build those implicit declarations more often, which is probably a bit of a memory regression, We can still avoid doing this in C++98 mo

Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

2013-10-31 Thread Aldy Hernandez
PING On 10/18/13 13:48, Aldy Hernandez wrote: On 10/02/13 16:53, Jason Merrill wrote: Sorry for the delay, and thank you for the review. On 08/27/2013 04:03 PM, Aldy Hernandez wrote: + /* First, try to parse as an initialized declaration. See + cp_parser_condition, from whence the bulk

Re: [Patch] Fix canadian cross build on systems with no fenv.h

2013-10-31 Thread Jonathan Wakely
On 30 October 2013 17:17, Steve Ellcey wrote: > > Tested with both my canadian cross build and a standard cross build > targetting mips-mti-elf. > > OK for checkin? Yes, thanks.

RE: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-10-31 Thread Bernd Edlinger
Hi, if you want to read zero-chars, why don't you simply use fgetc, optionally replacing '\0' with ' ' in read_line? Bernd.

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-10-31 Thread Vladimir Makarov
On 10/31/2013 09:23 AM, Robert Suchanek wrote: > Hello, > > When investigating regression with LRA enabled for mips16 I found incorrect > spilling and reload of > registers by callee. In the case, one register was not saved, although used, > and another one never > used but saved/restored. > >

C++ PATCH for c++/58162 (wrong error with NSDMI, const and move ctor)

2013-10-31 Thread Jason Merrill
We're building up the full initialization for the non-static data member in cp_parser_late_parse_one_default_arg, so we don't need to do it again when we use the NSDMI. Tested x86_64-pc-linux-gnu, applying to trunk. commit a0065b92a8039a07eb0d5fa577b919e820d86590 Author: Jason Merrill Date:

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-10-31 Thread Jakub Jelinek
On Thu, Oct 31, 2013 at 03:36:07PM +0100, Bernd Edlinger wrote: > if you want to read zero-chars, why don't you simply use fgetc, > optionally replacing '\0' with ' ' in read_line? Because it is too slow? getline(3) would be much better for this purpose, though of course it is a GNU extension in

Re: C++ PATCH to deal with trivial but non-callable [cd]tors

2013-10-31 Thread Eric Botcazou
> I think a good way to check for any non-trivial methods would be to > check trivial_type_p in the front end and then see if there are any > !DECL_ARTIFICIAL decls in TYPE_METHODS. Revised patch attached, tested on x86-64/Linux. 2013-10-31 Eric Botcazou c-family/ * c-ada-spec.h (cpp

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-10-31 Thread Dodji Seketeli
Jakub Jelinek writes: > On Thu, Oct 31, 2013 at 03:36:07PM +0100, Bernd Edlinger wrote: >> if you want to read zero-chars, why don't you simply use fgetc, >> optionally replacing '\0' with ' ' in read_line? > > Because it is too slow? > > getline(3) would be much better for this purpose, though o

[gomp4 simd, RFC] Simple fix to override vectorization cost estimation.

2013-10-31 Thread Yuri Rumyantsev
Hi All, Here is a simple fix which allows to vectorize loop marked with 'pragma omp simd' even if cost model tells us that vectorization is not profitable. I checked that on simple test-case is works as expected. Is it Ok for trunk? ChangeLog: 2013-10-31 Yuri Rumyantsev * tree-vect-loop.c (

Re: [v3 patch] Extend smart ptr assertions to reject void*

2013-10-31 Thread Jonathan Wakely
On 30 October 2013 19:49, Jonathan Wakely wrote: > Because of the GNU extension that allows sizeof(void) we fail to > reject ill-formed programs. This patch fixes that. > > 2013-10-30 Jonathan Wakely > > * include/bits/shared_ptr (__shared_ptr): Assert non-void pointer. > * inclu

Re: [gomp4 simd, RFC] Simple fix to override vectorization cost estimation.

2013-10-31 Thread Jakub Jelinek
On Thu, Oct 31, 2013 at 07:02:28PM +0400, Yuri Rumyantsev wrote: > Here is a simple fix which allows to vectorize loop marked with > 'pragma omp simd' even if cost model tells us that vectorization is > not profitable. > I checked that on simple test-case is works as expected. > > Is it Ok for tru

[patch] optimize stack checking for leaf functions

2013-10-31 Thread Eric Botcazou
Given that we maintain a protection area of STACK_CHECK_PROTECT bytes during stack checking, there is no point in checking for leaf functions if: 1. the static frame size is lower than STACK_CHECK_PROTECT bytes, and 2. there is no dynamic frame allocation. The attached patch does that for the

Two C++ cleanup PATCHes

2013-10-31 Thread Jason Merrill
1) Some changes to constant initialization that were needed by an early version of the "trivial but deleted" patch. They aren't needed anymore, but still seem correct. 2) We had two functions for building cleanup calls, which is unnecessary duplication. Also, there's no point in limiting use

patch to fix mips16 LRA register shuffling

2013-10-31 Thread Vladimir Makarov
The following patch fixes a problem reported by Matt Fortune. LRA generated additional moves for frame pointer eliminated into stack pointer. LRA uses register number of the elimination result when matching constraints. But it did not substitute RTL operand itself and that resulted in EXTRA_

Re: C++ PATCH to deal with trivial but non-callable [cd]tors

2013-10-31 Thread Jason Merrill
On 10/31/2013 10:47 AM, Eric Botcazou wrote: I think a good way to check for any non-trivial methods would be to check trivial_type_p in the front end and then see if there are any !DECL_ARTIFICIAL decls in TYPE_METHODS. Revised patch attached, tested on x86-64/Linux. Looks good. Jason

Re: [PATCH 1/n] Add conditional compare support

2013-10-31 Thread Richard Henderson
On 10/31/2013 02:06 AM, Zhenqiang Chen wrote: > With two compares, we might swap the order of the two compares to get a > valid combination. This is what current ARM does (Please refer > arm_select_dominace_cc_mode, cmp_and, cmp_ior, and_scc_scc and ior_scc_scc). > To improve gen_ccmp_first, we nee

[PATCH 1/6] Convert gimple types from a union to C++ inheritance

2013-10-31 Thread David Malcolm
* Makefile.in (GIMPLE_H): Add dep on is-a.h. * coretypes.h (union gimple_statement_d): Remove declaration. (gimple): Convert from being a "union gimple_statement_d *" to a "struct gimple_statement_base *". (const_gimple): Likewise (with "const"). * gg

[PATCH 2/6] Hand-written port of various accessors within gimple.h

2013-10-31 Thread David Malcolm
* gimple.h (gimple_use_ops): Port from union to usage of dyn_cast. (gimple_set_use_ops): Port from union to usage of as_a. (gimple_set_vuse): Likewise. (gimple_set_vdef): Likewise. (gimple_call_internal_fn): Port from union to a static_cast, g

[PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-10-31 Thread David Malcolm
[Shamelessly hijacking Andrew's thread about gimple.h refactoring, since this seems on-topic for that, and I'm keen to hear from Andrew on how the following would interact with his work - I *think* our two cleanups are orthogonal. [This is a revised version of the patches sent as: http://gcc.gnu

[PATCH 4/6] Implement is_a_helper <>::test specializations for various gimple types

2013-10-31 Thread David Malcolm
* gimple.h (is_a_helper ::test): New. (is_a_helper ::test): New. (is_a_helper ::test): New. (is_a_helper ::test): New. --- gcc/gimple.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/gcc/gimple.h b/gcc/gimple.h index f258992..710

[PATCH 6/6] Update gdb hooks to reflect changes to gimple types

2013-10-31 Thread David Malcolm
gcc/ * gdbhooks.py (GimplePrinter.to_string): Update lookup of code field to reflect inheritance, rather than embedding of the base gimple type. --- gcc/gdbhooks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/gdbhooks.py b/gcc/gdbhooks.py index 5

[PATCH 5/6] Port various places from union access to subclass access.

2013-10-31 Thread David Malcolm
* gimple-streamer-in.c (input_gimple_stmt): Port from union access to use of as_a. * gimple.c (gimple_build_asm_1): Likewise. (gimple_build_try): Likewise. Also, return a specific subclass rather than just gimple. (gimple_build_resx): Port from union

Re: patch to fix PR58784 (ARM LRA crash)

2013-10-31 Thread Yvan Roux
(this time in plain text !) > Does this mean we can now turn on LRA for ARM state by default and > start looking at performance issues if any ? With the other patch for 58785 and a small one I've to post, we are even about to turn LRA on by default completely, as the compiler now bootstrap also i

Re: [C, C++, OpenMP] Add support for -fopenmp-simd

2013-10-31 Thread Jakub Jelinek
On Sun, Oct 27, 2013 at 10:45:57PM +0100, Tobias Burnus wrote: > The code is written such that when "-fopenmp" is used, > -f(no-)openmp-simd has no effect. The following "simd" pragmas are > listed in OpenMP 4.0 - and will all get translated into "#pragma omp > simd", only, with -fopenmp-simd: > #p

Re: [patch] make the libstdc++ pretty printers compatible with both Python 2 and Python3

2013-10-31 Thread Tom Tromey
> "Matthias" == Matthias Klose writes: Matthias> Starting with gdb 7.6, gdb can be linked with both Python 2.x Matthias> and Python 3.x. Therefore the pretty printers should be Matthias> compatible with both Python versions. Thanks for doing this. Matthias> -n = self.rbiter

[PATCH] Try to avoid vector mode punning in SET_DEST on i?86

2013-10-31 Thread Jakub Jelinek
Hi! On Wed, Oct 30, 2013 at 12:11:25PM +0100, Jakub Jelinek wrote: > > > the patch attempts to avoid gen_lowpart on the non-MEM lhs of the > > > unaligned > > > loads, which usually means combine will fail, by doing the load into a > > > temporary pseudo in that case and then doing a pseudo to ps

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-10-31 Thread Manuel López-Ibáñez
On 31 October 2013 05:46, Dodji Seketeli wrote: > +*/ > +static size_t > +string_length (const char* buf, size_t buf_size) > +{ > + for (int i = buf_size - 1; i > 0; --i) > +{ > + if (buf[i] != 0) > + return i + 1; > + > + if (buf[i - 1] != 0) > + return i; > +} > +

[patch] [arm] ARM Cortex-M3/M4 tuning

2013-10-31 Thread Joey Ye
Based on Julian's http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01006.html and * Merged with latest mainline and applied test * Only apply to Cortex-M3 and M4 * Set LOGICAL_OP_NON_SHORT_CIRCUIT to false Test: - Coremark on M3/M4 gained 5% - GCC make check with qemu Cortex-M3 resulting following e

Re: Aliasing: look through pointer's def stmt

2013-10-31 Thread Marc Glisse
On Wed, 30 Oct 2013, Richard Biener wrote: --- gcc/tree-ssa-alias.c(revision 204188) +++ gcc/tree-ssa-alias.c(working copy) @@ -567,20 +567,29 @@ void ao_ref_init_from_ptr_and_size (ao_ref *ref, tree ptr, tree size) { HOST_WIDE_INT t1, t2; ref->ref = NULL_TREE; if (TRE

RE: [PATCH] Workaround errata for the PMC-Sierra RM7000 cpu.

2013-10-31 Thread Moore, Catherine
> -Original Message- > From: Richard Sandiford [mailto:rdsandif...@googlemail.com] > Sent: Thursday, October 10, 2013 1:21 PM > To: Moore, Catherine > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Workaround errata for the PMC-Sierra RM7000 cpu. > > "Moore, Catherine" writes: > >>

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-10-31 Thread Jakub Jelinek
On Thu, Oct 31, 2013 at 04:00:01PM +0100, Dodji Seketeli wrote: > Jakub Jelinek writes: > > > On Thu, Oct 31, 2013 at 03:36:07PM +0100, Bernd Edlinger wrote: > >> if you want to read zero-chars, why don't you simply use fgetc, > >> optionally replacing '\0' with ' ' in read_line? > > > > Because

Re: [PATCH] LRA: Fix incorrect register spill/reload

2013-10-31 Thread David Edelsohn
> Vladimir Makarov wrote: > Robert, thanks for finding it and informing. You can commit the patch > into the trunk. Robert, Do you have GCC SVN access? If not, please ask one of us to commit your patch for you. Thanks, David

Re: [RFC] [Testsuite,ARM] Neon intrinsics executable tests

2013-10-31 Thread Christophe Lyon
Hi Ramana, >> More later I need to get back to something else and I need to play more with >> your original testsuite - but I'd like some discussion around some of these >> points anyway. >> Rob Savoye is going to have a look at how to integrate the tests in a more straightforward way (he knows d

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-10-31 Thread Basile Starynkevitch
On 10/31/2013 05:26 PM, David Malcolm wrote: [Shamelessly hijacking Andrew's thread about gimple.h refactoring, since this seems on-topic for that, and I'm keen to hear from Andrew on how the following would interact with his work - I *think* our two cleanups are orthogonal. [This is a revised v

[PATCH] New port committed: Andes nds32.

2013-10-31 Thread Chung-Ju Wu
Hi, all, Thanks for all who gave me suggestions, review comments, and approval to this new nds32 port for GCC trunk. The Andes nds32 port now is committed into trunk as Rev.204269: http://gcc.gnu.org/r204269 We also add items on wwwdoc for nds32 port contribution: htdocs/backends.html -- Re

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-10-31 Thread Marek Polacek
On Wed, Oct 30, 2013 at 09:10:30PM -0400, Jason Merrill wrote: > On 10/30/2013 12:15 PM, Marek Polacek wrote: > >On Wed, Oct 30, 2013 at 11:56:25AM -0400, Jason Merrill wrote: > >>Saving 'size' here doesn't help since it's already been used above. > >>Could you use itype instead of size here? > > >

Re: [gomp4 simd, RFC] Simple fix to override vectorization cost estimation.

2013-10-31 Thread Richard Biener
Jakub Jelinek wrote: >On Thu, Oct 31, 2013 at 07:02:28PM +0400, Yuri Rumyantsev wrote: >> Here is a simple fix which allows to vectorize loop marked with >> 'pragma omp simd' even if cost model tells us that vectorization is >> not profitable. >> I checked that on simple test-case is works as expe

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-31 Thread Uros Bizjak
On Wed, Oct 30, 2013 at 9:02 PM, Cong Hou wrote: > I have run check_GNU_style.sh on my patch. > > The patch is submitted. Thank you for your comments and help on this patch! I have committed a couple of fixes/improvements to your expander in i386.c. There is no need to check for the result of exp

Re: [PATCH] Try to avoid vector mode punning in SET_DEST on i?86

2013-10-31 Thread Richard Henderson
On 10/31/2013 09:49 AM, Jakub Jelinek wrote: > 2013-10-31 Jakub Jelinek > > * optabs.c (expand_vec_perm): Avoid vector mode punning > SUBREGs in SET_DEST. > * expmed.c (store_bit_field_1): Likewise. > * config/i386/sse.md (movdi_to_sse, vec_pack_sfix_trunc_v2df, >

Re: [C++ Patch / RFC] PR 29234

2013-10-31 Thread Paolo Carlini
... I understand that at this point likely this isn't 4.9 material anymore. Just wanted to add that in the meanwhile I noticed that my WIP patch fixes c++/56037 too, which in fact seems to me a slightly less uncommon kind of code and that I tidied a bit the comments and simplified the cp_parse

[committed] Add diagnostics for aligned clause restrictions

2013-10-31 Thread Jakub Jelinek
Hi! I've noticed I have missed diagnostics for invalid aligned clause arguments (the aligned clause support has been written before the restrictions were added to the standard). Tested on x86_64-linux, committed to trunk. 2013-10-31 Jakub Jelinek * c-typeck.c (c_finish_omp_clauses):

[v3 patch] define std::integer_sequence et al

2013-10-31 Thread Jonathan Wakely
Implement my N3658 proposal for C++14. I moved the existing _Build_index_tuple from to and re-used it for std::make_integer_sequence (so that if G++ one day provides an intrinsic to generate a parameter pack of integers [0, N) we only need to change one place to use it.) 2013-10-31 Jonathan Wa

RE: [PATCH] LRA: Fix incorrect register spill/reload

2013-10-31 Thread Robert Suchanek
Hi David, No, I do not have read/write SVN access. I know a person who could commit the patch for me, however, if you can commit it, I'd be grateful. Regards, Robert > Vladimir Makarov wrote: > Robert, thanks for finding it and informing. You can commit the patch > into the trunk. Rober

[PATCH] Support multiline GTY markers in Doxygen filter; add unittests

2013-10-31 Thread David Malcolm
It's possible to run GCC's sources through Doxygen by setting INPUT_FILTER = contrib/filter_gcc_for_doxygen within contrib/gcc.doxy and invoking doxygen on the latter file. The script filters out various preprocessor constructs from GCC sources before Doxygen tries to parse them.

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-31 Thread Cong Hou
This update makes it more safe. You showed me how to write better expand code. Thank you for the improvement! thanks, Cong On Thu, Oct 31, 2013 at 11:43 AM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 9:02 PM, Cong Hou wrote: >> I have run check_GNU_style.sh on my patch. >> >> The patch is

symtab_node is now a struct, not a pointer (was Re: [PATCH v2 4/6] Remove symtab_node and const_symtab_node typedefs.)

2013-10-31 Thread David Malcolm
On Tue, 2013-09-10 at 15:37 +0200, Jan Hubicka wrote: > > gcc/ > > > > * ipa-ref.h (symtab_node): Remove typedef to pointer type, as it > > clashes with the preferred name for the base class. > > (const_symtab_node): Remove redundant typedef. > > This is OK, too. > Actually it is not

Re: question about register pairs

2013-10-31 Thread DJ Delorie
> Seeing the patched code in its entirety like this, I notice that we > would use HARD_REGNO_NREGS for a regno that's not ok for the mode. > That can be avoided if we put a break into the if. And then the > !bad term in the loop condition becomes redundant. Although the > HARD_REGNO_NREGS defini

[PATCH] Fix for PR 58925

2013-10-31 Thread Iyer, Balaji V
Hello Everyone, Attached, please find a fix for PR 58925. The issue is summarized below. I will commit this patch tonight since it is trivial, obvious and all the change is in libcilkrts. If anyone has any objections please let me know and I am willing to fix them. Thanks, Balaji V.

PR 58834: __builtin_shuffle in a template

2013-10-31 Thread Marc Glisse
Hello, __builtin_shuffle with 2 arguments is represented as having 3 arguments, the second being 0, which isn't supported here. Bootstrap+testsuite on x86_64-unknown-linux-gnu. 2013-11-01 Marc Glisse PR c++/58834 gcc/cp/ * pt.c (value_dependent_expression_p): Handle null a

[PATCH] use stack vectors more

2013-10-31 Thread tsaunders
From: Trevor Saunders Hi, This patch is pretty dull, it just replaces a bunch of things of the form vec x; x.create (N); // N is a constant blah blah x.release (); by stack_vec x; blah blah Of course its even nicer than that in some of the cases with many early returns. bootstrapped and same t

Re: Rework c99status.html

2013-10-31 Thread Gerald Pfeifer
On Fri, 1 Nov 2013, Gerald Pfeifer wrote: > I don't have a recommendation to change or keep the current name, > however I'll note that changing the name of a single file is going > to be even simpler then the below which I just applied. And this addresses three pages to avoid the redirect I just p

[PATCH] Handling == or != comparisons that may affect range test optimization.

2013-10-31 Thread Cong Hou
(This patch is for the bug 58728: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58728) As in the bug report, consider the following loop: int foo(unsigned int n) { if (n != 0) if (n != 1) if (n != 2) if (n != 3) if (n != 4) return ++n; return n; } The range test optimization should

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-31 Thread Mike Stump
On Oct 31, 2013, at 1:47 AM, Bernhard Reutner-Fischer wrote: > On 30 October 2013 23:22, Mike Stump wrote: >> On Oct 30, 2013, at 3:14 PM, Bernhard Reutner-Fischer >> wrote: >>> On 30 October 2013 22:47, Mike Stump wrote: Was there a significant purpose for the added C++ comment?

[PATCH, rs6000] Fix rs6000_expand_vector_set for little endian

2013-10-31 Thread Bill Schmidt
Hi, Brooks Moses reported a bug with code that sets a single element of a vector to a given value and the rest of the vector to zero. This is implemented in rs6000_expand_vector_set, which uses a vperm instruction to place the nonzero value. As usual, we need to adjust the permute control vector

[Fwd: Re: [PATCH, rs6000] Correct handling of multiply high-part for little endian]

2013-10-31 Thread Bill Schmidt
Hi maintainers, I agree with David that duplicating this code is a bad approach. What he and I would both prefer is to add a target hook to account for an anomaly in the PowerPC architecture. Background: For historical reasons, our vperm instruction (which is produced for gen_vec_perm) has some