This update makes it more safe. You showed me how to write better expand code. Thank you for the improvement!
thanks, Cong On Thu, Oct 31, 2013 at 11:43 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Wed, Oct 30, 2013 at 9:02 PM, Cong Hou <co...@google.com> wrote: >> I have run check_GNU_style.sh on my patch. >> >> The patch is submitted. Thank you for your comments and help on this patch! > > I have committed a couple of fixes/improvements to your expander in > i386.c. There is no need to check for the result of > expand_simple_binop. Also, there is no guarantee that > expand_simple_binop will expand to the target. It can return different > RTX. Also, unhandled modes are now marked with gcc_unreachable. > > 2013-10-31 Uros Bizjak <ubiz...@gmail.com> > > * config/i386/i386.c (ix86_expand_sse2_abs): Rename function arguments. > Use gcc_unreachable for unhandled modes. Do not check results of > expand_simple_binop. If not expanded to target, move the result. > > Tested on x86_64-pc-linux-gnu and committed. > > Uros.
