On Thu, Oct 31, 2013 at 08:34:55AM -0400, Ed Smith-Rowland wrote: > 2013-10-31 Edward Smith-Rowland <3dw...@verizon.net> > > PR c++/58708 > * parser.c (make_string_pack): Discover non-const type and size > of character and build parm pack with correct type and chars. > > gcc/testsuite: > > 2013-10-31 Edward Smith-Rowland <3dw...@verizon.net> > > PR c++/58708 > *g++.dg/cpp1y/pr58708.C : New.
The testcase LGTM, the ChangeLog entry doesn't have space after * and has extra space before : (and both the PR and * g++.dg/ line should be indented by a single tab and no other spaces). For the C++ parser change I'm deferring it to Jason, if it has been already approved, the patch is ok, if not, Jason needs to ack it. Jakub