On Tue, 2013-09-10 at 15:37 +0200, Jan Hubicka wrote: > > gcc/ > > > > * ipa-ref.h (symtab_node): Remove typedef to pointer type, as it > > clashes with the preferred name for the base class. > > (const_symtab_node): Remove redundant typedef. > > This is OK, too. > Actually it is not only clash - it was really inconsistent to write > symtab_node node; > struct cgraph_node *cnode; > > It is good this inconsistency is gone.
I've (finally) committed this to trunk (as r204278), followed by the automated renaming patch (as r204279), having rechecked the bootstrap and regrtest on x86_64-unknown-linux-gnu (RHEL 6.4, in fact). So (at long last), the base class is symtab_node, with cgraph_node and varpool_node as C++ subclasses, and the "pointerness" of these types is consistent (i.e. none of them are pointers). Dave
