Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-02 Thread Andreas Krebbel
On Thu, Dec 01, 2011 at 11:39:36PM -0800, Teresa Johnson wrote: > To do this I leveraged the existing TARGET_LOOP_UNROLL_ADJUST target > hook, which was previously only defined for s390. I added one > additional call to this target hook, when unrolling for constant trip > count loops. Previously it

Re: [PATCH, PR 50622] Force a gimple operand in load_assign_lhs_subreplacements when necessary

2011-12-02 Thread Richard Guenther
On Thu, 1 Dec 2011, Martin Jambor wrote: > Hi, > > PR 50622 is an omission in load_assign_lhs_subreplacements, which > should force a gimple operand on a RHS of a gimple assignment if both > sides are new replacements of scalar types which are not gimple > registers, because they are partially mo

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread Richard Guenther
On Thu, Dec 1, 2011 at 11:13 PM, William J. Schmidt wrote: > Greetings, > > Bug 39976 reported a degradation to 200.sixtrack wherein a hot > single-block loop is broken into two blocks.  Investigation showed the > cause to be a redundant PHI statement in the block, which the > tree-outof-ssa logic

Re: Fix doloop bug with maximum-length loops

2011-12-02 Thread Richard Sandiford
Sorry for the slow response, still catching up. "Joseph S. Myers" writes: > This code for doing the increment in from_mode comes from the fix for > PR 37451 and the follow-up fix for PR 37782 > >

Re: [PATCH] PR c++/51289 - ICE with alias template for bound template

2011-12-02 Thread Dodji Seketeli
Dodji Seketeli writes: > Jason Merrill writes: > >> I guess let's check DECL_ORIGINAL_TYPE instead of TREE_TYPE for alias >> templates. > > Like the below that I am currently bootstrapping? Finally this is what passed bootstrap and testing on x86_64-unknown-linux-gnu against trunk. From: Dodji

Re: PR libgomp/51376 fix

2011-12-02 Thread Alan Modra
On Thu, Dec 01, 2011 at 12:36:08PM +0100, Jakub Jelinek wrote: > On Thu, Dec 01, 2011 at 09:58:08PM +1030, Alan Modra wrote: > > The GOMP_task change fixes a similar potential problem. Bootstrapped > > and regression tested powerpc-linux. OK to apply? > > > > PR libgomp/51376 > > * task.

Re: [PATCH] Fix early inliner inlining uninlinable functions

2011-12-02 Thread Richard Guenther
On Fri, 2 Dec 2011, Jan Hubicka wrote: > > > > Sure, but then you can still have the issue of an inconsistency. > > Thus, would you then remove the remaining asserts? > > > > I believe in the end the proper fix is to _not_ throw away > > cgraph edges all the time, but keep them up-to-date and th

Re: Ping Re: Fix doloop bug with maximum-length loops

2011-12-02 Thread Richard Guenther
On Fri, Dec 2, 2011 at 3:28 AM, Andrew Pinski wrote: > On Thu, Dec 1, 2011 at 6:08 PM, Joseph S. Myers > wrote: >> Ping.  This patch >> is pending >> review. >> > > From my point of view, reverting my patch is fine as the testcase > which

Re: [PATCH] Remove dead labels to increase superblock scope

2011-12-02 Thread Richard Sandiford
Tom de Vries writes: > On 27/11/11 23:59, Eric Botcazou wrote: >>> No, DELETED_LABEL notes still work just fine. It depends on how you >>> remove the label and replace it with a note, and Tom isn't showing >>> what he did, so... >> >> I agree that there is no obvious reason why just calling delet

Re: [Patch] Fix Bug 51162

2011-12-02 Thread Sameera Deshpande
On Wed, 2011-11-30 at 19:43 +, Jason Merrill wrote: > On 11/24/2011 05:42 AM, Sameera Deshpande wrote: > > - if (TREE_CODE (fn) == ADDR_EXPR) > > + if (fn != NULL && TREE_CODE (fn) == ADDR_EXPR) > > fn = TREE_OPERAND (fn, 0); > > - if (TREE_CODE (fn) == FUNCTION_DECL && decl_is_tm_clone

Re: [STORMY16] Hookize FUNCTION_VALUE_REGNO_P

2011-12-02 Thread Richard Earnshaw
On 30/11/11 19:19, Anatoly Sokolov wrote: > Hello. > > This patch removes obsolete FUNCTION_VALUE_REGNO_P macro from ARM back end > in the GCC and introduces equivalent TARGET_FUNCTION_VALUE_REGNO_P target > hook. > > Since the LIBCALL_VALUE macro should be poisoned in the future, this patc

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-02 Thread Bernd Schmidt
On 12/01/11 13:01, Ramana Radhakrishnan wrote: > Sergio: Other than a few minor tweaks to the Changelog it largely > looks obvious to me. > > Bernd, could you take another look at this since this is now shared > with the c6x backend ? Doesn't look like it would cause problems. I have no idea what

[PATCH] Fix varpool handling of register variables (PR47259)

2011-12-02 Thread Richard Guenther
This fixes a recent regression on the testcase of PR47259 where we bring local a global register variable during WPA time and then mangle its register name spec during ltrans. Oops. It doesn't make sense to bring "local" global register variables. Fixed by making varpool_externally_visible_p ret

Re: SH atomic asms in glibc and the stack pointer

2011-12-02 Thread Ulrich Drepper
On Tue, Nov 29, 2011 at 17:44, Kaz Kojima wrote: > Uli, could you please approve the libc patch? Has the gcc patch been committed?

RFC: ARM 64-bit shifts in NEON

2011-12-02 Thread Andrew Stubbs
Hi All, I'm trying to implement DImode shifts using ARM NEON instructions. This wouldn't be difficult in itself, but making it play nice with the existing implementation is causing me problems. I'd like a few suggestions/pointers/comments to help me get this right, please. The existing shift

Re: SH atomic asms in glibc and the stack pointer

2011-12-02 Thread Kaz Kojima
Ulrich Drepper wrote: > Has the gcc patch been committed? Yes, it has been committed as revision 181825 on gcc trunk. Regards, kaz

Re: Adjust omp-low test for alignment

2011-12-02 Thread Hans-Peter Nilsson
On Tue, 29 Nov 2011, Hans-Peter Nilsson wrote: > On Tue, 29 Nov 2011, Richard Henderson wrote: > > On 11/28/2011 08:49 PM, Hans-Peter Nilsson wrote: > > > On Sat, 26 Nov 2011, Richard Henderson wrote: > > >> The m68k-linux failure for the various omp atomic tests > > >> is due to the fact that BIG

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317)

2011-12-02 Thread Richard Guenther
On Thu, 1 Dec 2011, Jakub Jelinek wrote: > Hi! > > As discussed in the PR, in 4.7 we regressed some GDB testcases, because > previously unused addressable vars were first previously optimized into > non-addressable and only afterwards removed (which results in correct debug > stmts covering those

[PATCH] Re-write SSA operand checking

2011-12-02 Thread Richard Guenther
This rewrites SSA operand checking to basically check that the operand status is the same as if you'd do an update_stmt on the stmt. The current checking code does not properly verify that all stmts are properly updated as it misses missing and swapped operands for example (bugs like that I've fi

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317)

2011-12-02 Thread Michael Matz
Hi, On Fri, 2 Dec 2011, Richard Guenther wrote: > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > > > 2011-12-01 Jakub Jelinek > > > > PR debug/50317 > > * tree-ssa-dce.c (remove_dead_stmt): Add a debug stmt when removing > > as unnecessary a store to a

Re: [lra] patch mostly implementing pseudo live range split

2011-12-02 Thread Hans-Peter Nilsson
On Tue, 29 Nov 2011, Vladimir Makarov wrote: > 3. The patch rewrite the way of dealing with the secondary memory >moves in constraint pass of LRA. Previously we generated secondary >moves if macro SECONDARY_MEMORY_NEEDED says so. Unfortunately, the >macro is usually defined inaccurate

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread William J. Schmidt
On Fri, 2011-12-02 at 10:24 +0100, Richard Guenther wrote: > On Thu, Dec 1, 2011 at 11:13 PM, William J. Schmidt > wrote: > > Greetings, > > > > Bug 39976 reported a degradation to 200.sixtrack wherein a hot > > single-block loop is broken into two blocks. Investigation showed the > > cause to

Re: [RFC] Port libitm to powerpc

2011-12-02 Thread Iain Sandoe
On 1 Dec 2011, at 23:28, Iain Sandoe wrote: now I'm slightly confused - do we need to preserve if across the call or not? erm. not well phrased. I am trying to get a grasp on what determines the set of registers that should be saved. Initially, I was thinking that it was the "call-save

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread Michael Matz
Hi, On Fri, 2 Dec 2011, William J. Schmidt wrote: > > > - tree def = gimple_get_lhs (stmt); > > > + /* If this is a PHI, we only want to consider it if all of its > > > + arguments are SSA names (which are known to be defined in a > > > + single place). This avoids errors when dealing

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread William J. Schmidt
On Fri, 2011-12-02 at 14:59 +0100, Michael Matz wrote: > Hi, > > On Fri, 2 Dec 2011, William J. Schmidt wrote: > > > > > - tree def = gimple_get_lhs (stmt); > > > > + /* If this is a PHI, we only want to consider it if all of its > > > > + arguments are SSA names (which are known to be de

Re: [PATCH] Fix varpool handling of register variables (PR47259)

2011-12-02 Thread Jan Hubicka
Am Fri 02 Dec 2011 01:38:46 PM CET schrieb Richard Guenther : This fixes a recent regression on the testcase of PR47259 where we bring local a global register variable during WPA time and then mangle its register name spec during ltrans. Oops. indeed... (I am not in general sure how LTO sh

Re: [Patch] Fix Bug 51162

2011-12-02 Thread Jason Merrill
OK. Jason

[Ada] Implement iterator for multiset containers

2011-12-02 Thread Arnaud Charlet
This change implements a reversible iterator for multiset containers. An iterator can either be partial, visiting only some of the items in the container (in which case the start position is specified), or complete, visiting all of them. The iterator caches the start position during its construct

[Ada] Ada 2012: Derived types and partial views

2011-12-02 Thread Arnaud Charlet
This patch incorporates the support for AI95-0041. For the purposes of the rules for allowing allocated unconstrained objects, any ancestor that has a constrained partial view causes the rules to apply. In addition, in a generic body, 3.10.2(27.2/2) is checked assuming that any untagged fo

[Ada] Check preconditions for child iterator of multiway tree container

2011-12-02 Thread Arnaud Charlet
The iterator for visiting children of a node in a multiway tree must check the value of the Parent parameter to ensure that it is non-null, and that it actually designates a node in the tree. There were also several instances where cursor values returned by iterator operations were not well-formed

[Ada] Remove spurious warning in Alfa mode

2011-12-02 Thread Arnaud Charlet
The side effect removal machinery may generate illegal Ada code to avoid the usage of access types and 'reference in Alfa mode. Since this is legal code with respect to theorem proving, do not emit the warning. Tested on x86_64-pc-linux-gnu, committed on trunk 2011-12-02 Yannick Moy *

[Ada] Minor code reorganization

2011-12-02 Thread Arnaud Charlet
This patch does not modify the functionality of the compiler. It moves semantic routines from Sem_Util to Sem_Aux to have them available in ASIS. Tested on x86_64-pc-linux-gnu, committed on trunk 2011-12-02 Javier Miranda * sem_util.ads, sem_util.adb, sem_aux.ads, sem_aux.adb

[Ada] Generation of external and fully qualified names

2011-12-02 Thread Arnaud Charlet
This patch corrects a buffer issue which may lead to bogus expanded names at link time. The problem is initiated while creating the external name of a tagged type whose scope is an overloaded name. This places useless data in the Homonym_Numbers buffer which is then reused when building the qualifi

[Ada] Implement concrete iterators as a type hierarchy for multiway trees

2011-12-02 Thread Arnaud Charlet
The iterators for the multiway trees are now implemented as a type hierarchy. Iterating over a tree is the same as iterating over a subtree starting from the root, and so the tree iterator forwards the request to the subtree iterator. Tested on x86_64-pc-linux-gnu, committed on trunk 2011-12-02

Re: RTEMS Specific Ada Patch

2011-12-02 Thread Joel Sherrill
On 12/02/2011 01:48 AM, Arnaud Charlet wrote: The attached patch is necessary to let the gcc head compile Ada for *-*-rtems*. Other than terminals.c, the files impacted are RTEMS specific. OK to commit? OK Thanks. Committed. -- Joel Sherrill, Ph.D. Director of Research& Develop

Re: Adjust omp-low test for alignment

2011-12-02 Thread Mikael Pettersson
Hans-Peter Nilsson writes: > BTW, on the topic, I cringe whenever I > see futexes expressed as plain "int", they absolutely have to > have at least natural alignment which is not always true e.g. in > structs. People, please keep the atomic types > target-overridable in libraries. +1 for m

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-02 Thread Teresa Johnson
Thanks, Andreas. You are right in that fully peeling a loop is done by a different code path (peel_loops_completely() and earlier in the tree unroller). Teresa On Fri, Dec 2, 2011 at 12:54 AM, Andreas Krebbel wrote: > On Thu, Dec 01, 2011 at 11:39:36PM -0800, Teresa Johnson wrote: >> To do this

[PATCH][1/2] Remove CALL_CANNOT_INLINE_P

2011-12-02 Thread Richard Guenther
This removes the CALL_CANNOT_INLINE_P tree flag. As discussed in the thread about the duplicate edge/gimple stmt flag. Bootstrapped and tested on x86_64-unknown-linux-gnu. Richard. 2011-12-02 Richard Guenther * tree.h (CALL_CANNOT_INLINE_P): Remove. * tree-mudflap.c (mf_xfo

[PATCH] PRs c++/51239, c++/51180 - Better support for unbound alias template specialization

2011-12-02 Thread Dodji Seketeli
Hello, I have conflated the handling of two PRs here, because I think they are related. Consider this short example that illustrates the issue of PR c++/51239: struct S {}; template using head = T; template using x = head;//#1 In #1, we want to be able to represent 'head',

rs6000 options change for rtems.h

2011-12-02 Thread Joel Sherrill
Hi, I have been testing with this for almost a month. It is my attempt to follow the changes I think Joseph made to other rs6000 targets. If this change looks right, I would like to commit it. Test results have been posted for it. Thanks. 2011-12-02 Joel Sherrill * config/rs6000/rtems.

Re: [Patch] Increase array sizes in vect-tests to enable 256-bit vectorization

2011-12-02 Thread Richard Guenther
2011/12/2 Michael Zolotukhin : > Hi, > > This patch increases array sizes in tests from vect.exp suite, thus > enabling 256-bit vectorization where it's available. > > Ok for trunk? Shouldn't we add a variant for each testcase so that we still excercise both 128-bit and 256-bit vectorization paths

[PATCH][2/2] Remove gimple_call_cannot_inline

2011-12-02 Thread Richard Guenther
This is the 2nd piece of the stmt flag removal. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. I'll apply the short series tomorrow unless there are any objections or comments. Thanks, Richard. 2011-12-02 Richard Guenther * cgraph.c (cgraph_create_edge_1): Initializ

Re: rs6000 options change for rtems.h

2011-12-02 Thread Joseph S. Myers
On Fri, 2 Dec 2011, Joel Sherrill wrote: > 2011-12-02 Joel Sherrill > > * config/rs6000/rtems.h: Switch to using global_options_set > in SUBSUBTARGET_OVERRIDE_OPTIONS. Is it deliberate that you are removing the first part of each "if" condition (thus, no longer checking TARGET_HARD_FL

Re: rs6000 options change for rtems.h

2011-12-02 Thread Joel Sherrill
On 12/02/2011 10:38 AM, Joseph S. Myers wrote: On Fri, 2 Dec 2011, Joel Sherrill wrote: 2011-12-02 Joel Sherrill * config/rs6000/rtems.h: Switch to using global_options_set in SUBSUBTARGET_OVERRIDE_OPTIONS. Is it deliberate that you are removing the first part of each "if" conditio

Re: [Patch] Increase array sizes in vect-tests to enable 256-bit vectorization

2011-12-02 Thread Ira Rosen
gcc-patches-ow...@gcc.gnu.org wrote on 02/12/2011 06:23:25 PM: > Hi, > > This patch increases array sizes in tests from vect.exp suite, thus > enabling 256-bit vectorization where it's available. > > Ok for trunk? --- a/gcc/testsuite/gcc.dg/vect/slp-24.c +++ b/gcc/testsuite/gcc.dg/vect/slp-24.c

[v3] Fix libstdc++/51288 thinko

2011-12-02 Thread Paolo Carlini
Hi, this fixes a thinko in my recent fix for the PR: just be consistent with our other inserters. Testing x86_64-linux, will commit soon. Thanks, Paolo. /// 2011-12-02 Paolo Carlini * include/std/iomanip (put_money): Fix thinko, use __err local, like in, e

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread William J. Schmidt
Sorry for the previous brain-fart! Here's a revised patch. It seems like a fair amount of rip-up to avoid keeping the PHI state around between blocks, so I just check to ensure the PHI definitions occur in the same block before recording their equivalence. lookup_avail_expr may return a constant

Re: [Patch] Increase array sizes in vect-tests to enable 256-bit vectorization

2011-12-02 Thread Michael Zolotukhin
> > Shouldn't we add a variant for each testcase so that we still > excercise both 128-bit and 256-bit vectorization paths? These tests are still good to test 128-bit vectorization, the changes was made just to make sure that 256-bit vectorization is possible on the tests. Actually, It's just fir

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread Michael Matz
Hi, On Fri, 2 Dec 2011, William J. Schmidt wrote: > It seems like a fair amount of rip-up to avoid keeping the PHI state > around between blocks, so I just check to ensure the PHI definitions > occur in the same block before recording their equivalence. Then you should at least mix the BB num

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/02/11 10:40, Michael Matz wrote: > Hi, > > On Fri, 2 Dec 2011, William J. Schmidt wrote: > >> It seems like a fair amount of rip-up to avoid keeping the PHI >> state around between blocks, so I just check to ensure the PHI >> definitions occur

Re: rs6000 options change for rtems.h

2011-12-02 Thread Joseph S. Myers
On Fri, 2 Dec 2011, Joel Sherrill wrote: > On 12/02/2011 10:38 AM, Joseph S. Myers wrote: > > On Fri, 2 Dec 2011, Joel Sherrill wrote: > > > > > 2011-12-02 Joel Sherrill > > > > > > * config/rs6000/rtems.h: Switch to using global_options_set > > > in SUBSUBTARGET_OVERRIDE_OPTIONS. > >

Re: rs6000 options change for rtems.h

2011-12-02 Thread Joel Sherrill
On 12/02/2011 11:57 AM, Joseph S. Myers wrote: On Fri, 2 Dec 2011, Joel Sherrill wrote: On 12/02/2011 10:38 AM, Joseph S. Myers wrote: On Fri, 2 Dec 2011, Joel Sherrill wrote: 2011-12-02 Joel Sherrill * config/rs6000/rtems.h: Switch to using global_options_set in SUBSUBTARGET_O

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread William J. Schmidt
On Fri, 2011-12-02 at 10:52 -0700, Jeff Law wrote: > On 12/02/11 10:40, Michael Matz wrote: > > Hi, > > > > On Fri, 2 Dec 2011, William J. Schmidt wrote: > > > >> It seems like a fair amount of rip-up to avoid keeping the PHI > >> state around between blocks, so I just check to ensure the PHI >

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-02 Thread Sergio Durigan Junior
Bernd Schmidt writes: > On 12/01/11 13:01, Ramana Radhakrishnan wrote: >> Sergio: Other than a few minor tweaks to the Changelog it largely >> looks obvious to me. >> >> Bernd, could you take another look at this since this is now shared >> with the c6x backend ? > > Doesn't look like it would c

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/02/11 11:10, William J. Schmidt wrote: > >> >> I see a mention of creating equivalences for redundant PHIs? Are >> we just trying to determine that two PHIs are going to result in >> the same value? > > Jeff, see comment #37 in > http://gcc.

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-02 Thread Sergio Durigan Junior
Ramana Radhakrishnan writes: > Sergio: Other than a few minor tweaks to the Changelog it largely > looks obvious to me. Hello Ramana, Thanks for the review. Here is the updated version of the patch. I asked Tom Tromey to commit it for me, since I don't have write permission on the repository.

Re: [Patch,AVR] Was/Fix: error linking lto1 for target avr

2011-12-02 Thread Georg-Johann Lay
Denis Chertykov wrote: > 2011/11/29 Georg-Johann Lay : >> Ian Lance Taylor wrote: >>> Georg-Johann Lay writes: >>> So if a frontend can define address spaces and it is a generic feature, the question is how to get the name of an address space in a generic, language independent way.

[testsuite,committed] Fix gcc.c-torture/execute/vector-subscript-1.c

2011-12-02 Thread Georg-Johann Lay
http://gcc.gnu.org/viewcvs?view=revision&revision=181933 Committed the following, obvious fix to a test case that assumed sizeof(int) = 4: Johann --- trunk/gcc/testsuite/gcc.c-torture/execute/vector-subscript-1.c 2011/12/02 17:44:28181932 +++ trunk/gcc/testsuite/gcc.c-torture/ex

Re: [Patch] Increase array sizes in vect-tests to enable 256-bit vectorization

2011-12-02 Thread Ira Rosen
Michael Zolotukhin wrote on 02/12/2011 08:11:41 PM: > > > Please don't change initial values to 0, we want to check that everything > > works fine for non-zeros as well. > > There are several other occasions in the patch. > > Please check the update patch (attached). This is ok with me. Thanks

[C++ Patch] PR 51313

2011-12-02 Thread Paolo Carlini
Hi, here we ICE in C++11 mode in null_ptr_cst_p because integer_zerop is true for a NOP_EXPR, which TREE_OVERFLOW cannot handle. Thus the idea is using STRIP_NOPS in C++11 mode too: makes sense to me unless we have reasons of principle to exclude NOPs in that mode. Anyway, patch passes testin

[pph] Cleanup to support namespace aliases (1/2) (issue5434109)

2011-12-02 Thread Diego Novillo
This patch is part 1 of a cleanup needed to support namespace aliases. When processing a namespace aliase, we cannot access its binding level because it is NULL. Besides, it does not make sense to do anything with it, since the binding level for the original namespace would've been processed befo

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

2011-12-02 Thread davidxl
Have you uploaded the revised patch? David http://codereview.appspot.com/5416043/diff/1/gcc/config/i386/i386.c File gcc/config/i386/i386.c (right): http://codereview.appspot.com/5416043/diff/1/gcc/config/i386/i386.c#newcode10927 gcc/config/i386/i386.c:10927: + is later renamed to '' by ix8

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread William J. Schmidt
On Fri, 2011-12-02 at 11:28 -0700, Jeff Law wrote: > On 12/02/11 11:10, William J. Schmidt wrote: > > > >> > >> I see a mention of creating equivalences for redundant PHIs? Are > >> we just trying to determine that two PHIs are going to result in > >> the same value? > > > > Jeff, see comment

[pph] Cleanup to support namespace aliases (2/2) (issue5434110)

2011-12-02 Thread Diego Novillo
The second part of the cleanup prepares support for writing merge keys and merge bodies for structures other than ASTs. The problem we are having now is that when merging the bindings of namespace, the reader creates an empty binding level, but after the merging is done, we go on to create anothe

[PATCH] Fix AVX2 mulv32qi expander (PR target/51387)

2011-12-02 Thread Jakub Jelinek
Hi! As reported by Michael, vect-116.c testcase fails with -mavx2, the problem is that mulv32qi pattern computes wrong result, the second and third quarters of the vector are swapped compared to what it should contain. This is because we can't use vec_extract_even_odd for V32QI when we prepared t

Re: [PATCH] PRs c++/51239, c++/51180 - Better support for unbound alias template specialization

2011-12-02 Thread Gabriel Dos Reis
On Fri, Dec 2, 2011 at 9:51 AM, Dodji Seketeli wrote: > After talking with you offline, we settled on using the existing > BOUND_TEMPLATE_TEMPLATE_PARM tree to represent this new construct. > The alias template and its unbound arguments are stored in the > TYPE_TEMPLATE_INFO of the tree and its T

Re: [Patch.AVR,4.6] Fix PR51002

2011-12-02 Thread Georg-Johann Lay
Denis Chertykov wrote: > 2011/11/29 Georg-Johann Lay: >> For devices with 8-bit SP reading the high byte SP_H of SP will get garbage. >> >> The patch uses CLR instead of IN SP_H to "read" the high part of SP. >> >> There are two issues with this patch: >> >> == 1 == >> >> I cannot really test it be

[PATCH] Fold constant argument VEC_{PACK_{,FIX_}TRUNC,{UNPACK{,_FLOAT},WIDEN_MULT}_{LO,HI}}_EXPR

2011-12-02 Thread Jakub Jelinek
Hi! As I found during investigation of PR51387, e.g. on the attached testcase we generate pretty bad code (for f1 even with bigger N like 256 for avx2), because after vectorization cunroll unrolls the loops completely and we end up with lots of VEC_PACK_TRUNC_EXPR etc. expressions with VECTOR_CST

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread William J. Schmidt
On Fri, 2011-12-02 at 13:08 -0600, William J. Schmidt wrote: > > On Fri, 2011-12-02 at 11:28 -0700, Jeff Law wrote: > > On 12/02/11 11:10, William J. Schmidt wrote: > > > > > >> > > >> I see a mention of creating equivalences for redundant PHIs? Are > > >> we just trying to determine that two P

Go patch committed: Clean up merge.sh

2011-12-02 Thread Ian Lance Taylor
This patch to the libgo script merge.sh does the following: * Permit specifying a revision on the command line. * Add various new C files to the merge, reflecting their addition to the library. * Automatically converts the Unicode character · used in the master library C code to _ before mer

[PATCH] Improve debug info if tree DCE removes stores (PR debug/50317, fallout)

2011-12-02 Thread Jakub Jelinek
On Fri, Dec 02, 2011 at 02:27:40PM +0100, Richard Guenther wrote: > This change seems wrong. We are turning valid gimple > > # DEBUG D#2 => transfer.0 [with addres taken] > > into invalid one > > # DEBUG D#2 => transfer.0 [without address taken] > > once you update that stmt with update_stmt

libgo patch committed: Update to weekly.2011-11-01

2011-12-02 Thread Ian Lance Taylor
This patch updates the Go library to the weekly.2011-11-01 release (I know that was a month ago). This patch includes a change to the reflection string for the empty interface type to match a similar change to the other Go compiler; the change to gccgo was by Rémy Oudompheng. The patch is too lar

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-02 Thread Andi Kleen
Teresa Johnson writes: Interesting optimization. I would be concerned a little bit about compile time, does it make a measurable difference? > The attached patch detects loops containing instructions that tend to > incur high LCP (loop changing prefix) stalls on Core i7, and limits > their unrol

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

2011-12-02 Thread davidxl
http://codereview.appspot.com/5416043/diff/6001/gcc/config/i386/i386.c File gcc/config/i386/i386.c (right): http://codereview.appspot.com/5416043/diff/6001/gcc/config/i386/i386.c#newcode10881 gcc/config/i386/i386.c:10881: + '_function_patch_epilogue'. The backpointer section can be used to nav

RTEMS Go Patch

2011-12-02 Thread Joel Sherrill
Hi, This addresses all of the Go compilation issues on the head except one. Ian.. Is this OK to commit? Or do you have suggestions on how to make it more general? Thanks. 2011-12-02 Joel Sherrill * runtime/go-signal.c: Add conditional on SIGPROF. * runtime/mem_posix_memalign

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-02 Thread Xinliang David Li
; > > +/* Determine whether LOOP contains floating-point computation. */ > +bool > +loop_has_FP_comp(struct loop *loop) > +{ > +  rtx set, dest; This probably should be extended to detect other long latency operations in the future. > + > +  if (ix86_tune != PROCESSOR_COREI7_64 && > +      ix86_

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-02 Thread Xinliang David Li
On Fri, Dec 2, 2011 at 11:36 AM, Andi Kleen wrote: > Teresa Johnson writes: > > Interesting optimization. I would be concerned a little bit > about compile time, does it make a measurable difference? > >> The attached patch detects loops containing instructions that tend to >> incur high LCP (loo

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread William J. Schmidt
OK, one more version. This removes the basic block test and instead implements Michael's suggestion: On Fri, 2011-12-02 at 18:40 +0100, Michael Matz wrote: > But I wonder why it's not enough to just do a push/pop sequence on > avail_exprs_stack around your new PHI processing in dom_opt_enter_blo

Re: [Patch, i386] Limit unroll factor for certain loops on Corei7

2011-12-02 Thread Teresa Johnson
On Fri, Dec 2, 2011 at 11:36 AM, Andi Kleen wrote: > Teresa Johnson writes: > > Interesting optimization. I would be concerned a little bit > about compile time, does it make a measurable difference? I haven't measured compile time explicitly, but I don't it should, especially after I address yo

Re: Adjust omp-low test for alignment

2011-12-02 Thread Hans-Peter Nilsson
On Fri, 2 Dec 2011, Mikael Pettersson wrote: > but futexes must be 32-bit aligned (or at least not cross page > boundaries). Don't mix up futexes with hardware-mandated atomic alignment (except that preferably the letter should not be more strict). Linux futexes must be 32-bit aligned *for all ar

[gcov] Distinguish exceptional lines

2011-12-02 Thread Nathan Sidwell
I've committed this patch that adds support to gcov to distinguish unexecuted exceptional lines. Normally unexecuted lines are marked by '#'. This patch augments that so that lines of code that are only reachable by an exceptional path (a catch clause in C++), are marked by '=' (half a

Re: FW: [PATCH][Cilkplus] Low cost annotations implementation

2011-12-02 Thread H.J. Lu
On Fri, Dec 2, 2011 at 12:24 PM, Iyer, Balaji V wrote: > Hello Everyone, >    I found that patch 4 stepped on parts of patch 3. Here is the updated > patches (Please notice patch 4, 5 and 6 are replaced). > > Thanks, > > Balaji V. Iyer. > > > From: Iyer, B

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/02/11 12:27, William J. Schmidt wrote: > > Erm, wait. How are PHIs in different blocks going to have the > same incoming edges? (I was thinking of control dependence edges, > but these are just regular control flow incoming edges, right?) So

Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

2011-12-02 Thread William J. Schmidt
On Fri, 2011-12-02 at 13:46 -0700, Jeff Law wrote: > On 12/02/11 12:27, William J. Schmidt wrote: > > > > > Erm, wait. How are PHIs in different blocks going to have the > > same incoming edges? (I was thinking of control dependence edges, > > but these are just regular control flow incoming

[Patch, Fortran] PR 51378 Fix component-access check

2011-12-02 Thread Tobias Burnus
Found via Reinhold Bader's test suite: If a component is public, it remains public even if the extended type has PRIVATE. Build and regtested on x86-64-linux. OK for the trunk? Tobias 2011-12-02 Tobias Burnus PR fortran/51378 * symbol.c (gfc_find_component): Fix access check of parent co

[Patch, Fortran] Fix MOVE_ALLOC check

2011-12-02 Thread Tobias Burnus
This patches fixes my previous MOVE_ALLOC patch. The standard states for TO: "It shall be polymorphic if FROM is polymorphic." I somehow read this bijectively, but the it is actually allowed to have a nonpolymorphic FROM with a polymorphic TO. Thanks for Damian for finding this. Build and re

Re: [PATCH] Fix AVX2 mulv32qi expander (PR target/51387)

2011-12-02 Thread Richard Henderson
On 12/02/2011 11:18 AM, Jakub Jelinek wrote: > PR target/51387 > * config/i386/sse.md (mul3 with VI1_AVX2 iterator): For > V32QImode use { 0,2,..,14,32,34,..,46,16,18,..,30,48,50,..,62 } > permutation instead of extract even permutation. Ok. r~

Re: FW: [PATCH][Cilkplus] Low cost annotations implementation

2011-12-02 Thread H.J. Lu
On Fri, Dec 2, 2011 at 2:35 PM, Iyer, Balaji V wrote: > Hello H. J., >   Here are the fixed patches. I have numbered their order from 1 through 4. > The ChangeLog entries should be added to the beginning of ChangeLog, not in the middle. -- H.J.

[pph] Re-factor merge reads for lang_decl (issue5440087)

2011-12-02 Thread Diego Novillo
This patch adds support for doing merge reads of lang_decl by processing PPH_RECORD_START_MERGE_BODY records. I need it for the next patch that will emit the merge keys for namespaces. Tested on x86_64. Diego. * pph-in.c (pph_in_lang_decl_start): Rename from pph_in_ref_lang_decl.

Re: [RFC] Port libitm to powerpc

2011-12-02 Thread Richard Henderson
On 12/02/2011 05:37 AM, Iain Sandoe wrote: > Richard: things that I did, intentionally, differently (and I'm not sure are > correct). > > 1. I saved the CR > 2. Once the vrs are saved, I update the VRsave mask to reflect that. Don't update VRsave. This gives the OS license to clobber those regi

Re: [RFC] Port libitm to powerpc

2011-12-02 Thread Iain Sandoe
Hi Richard, On 2 Dec 2011, at 22:59, Richard Henderson wrote: On 12/02/2011 05:37 AM, Iain Sandoe wrote: Richard: things that I did, intentionally, differently (and I'm not sure are correct). 1. I saved the CR 2. Once the vrs are saved, I update the VRsave mask to reflect that. Don't upda

Re: [PATCH] Implement stap probe on ARM's unwinder

2011-12-02 Thread Richard Henderson
On 12/02/2011 04:25 AM, Bernd Schmidt wrote: > Doesn't look like it would cause problems. I have no idea what > builtin_frob_return_addr does but it appears to exist everywhere. It's for adjusting the return address in magic ways. E.g. Sparc pc+8 for structure returns, ARM low bit for thumb retu

libgo patch committed: Generate dependencies automatically

2011-12-02 Thread Ian Lance Taylor
This patch adds automatic dependency generation to the packages in libgo. This saves me from having to fix all the dependencies each time I import a new version of the library. As can be seen in this patch, I really need to learn how to use autogen. Bootstrapped and ran Go testsuite on x86_64-un

Re: rs6000 options change for rtems.h

2011-12-02 Thread Joseph S. Myers
On Fri, 2 Dec 2011, Joel Sherrill wrote: > OK. I obviously read too much into the other uses. > I did not intend to change semantics just account for > the change making this not compile. > > How does the the new version look? This version is OK. -- Joseph S. Myers jos...@codesourcery.com

[patch] PR51347 alias problem

2011-12-02 Thread Patrick Marlier
Hi, PR51347 shows up a problem due to the TM IPA rework. tree_function_versioning segfault because the cfg of old_decl (alias) is NULL. Indeed, an alias can get called but tm cg data are in the parent of the alias. Bootstrapped and regtested. Thanks, Patrick. ChangeLog 2011-12-02 Patrick

Re: [libstdc++] doc/xml/manual/abi.xml -- fix references to GCC as well as GNU/Linux

2011-12-02 Thread Jonathan Wakely
On 27 November 2011 00:24, Gerald Pfeifer wrote: > > On the way I spotted an odd reference to GCC.  Looking at the > overall document, it occurs to me that > >  - newer versions of GCC are not covered, and >  - references to GCC generally are of the form gcc-X.Y instead of GCC X.Y. > > Is this some

libgo patch committed: Update to weekly.2011-11-02

2011-12-02 Thread Ian Lance Taylor
I have updated the libgo library to the weekly.2011-11-02 release of the master library. The only changes in this patch are to switch from using the type os.Error to the new predeclared type error, and to add a new errors package providing a couple of convenience functions. This causes mechanical