On Fri, 2 Dec 2011, Joel Sherrill wrote: > On 12/02/2011 10:38 AM, Joseph S. Myers wrote: > > On Fri, 2 Dec 2011, Joel Sherrill wrote: > > > > > 2011-12-02 Joel Sherrill<joel.sherr...@oarcorp.com> > > > > > > * config/rs6000/rtems.h: Switch to using global_options_set > > > in SUBSUBTARGET_OVERRIDE_OPTIONS. > > Is it deliberate that you are removing the first part of each "if" > > condition (thus, no longer checking TARGET_HARD_FLOAT before setting > > rs6000_float_gprs, no longer checking rs6000_float_gprs before setting > > rs6000_spe, etc.)? > > > I patterned this after what was in other files. > It is done this way everywhere it is referenced. > > Should all of them be changed?
Not necessarily. I described how I think this sort of logic should work in <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49854>. I think that means something closer to the other headers than to rtems.h - but I don't think a semantic change should be mixed with a change that's just supposed to get things to build again. -- Joseph S. Myers jos...@codesourcery.com
