On Tue, 29 Nov 2011, Vladimir Makarov wrote: > 3. The patch rewrite the way of dealing with the secondary memory > moves in constraint pass of LRA. Previously we generated secondary > moves if macro SECONDARY_MEMORY_NEEDED says so. Unfortunately, the > macro is usually defined inaccurately.
I do not doubt that, but I think it would help if you mentioned what you see that is wrong, in particular if it's consistent among targets. For example, for MIPS (and I'd probably for other targets too if I looked) for an older gcc, I've seen calls with class == NO_REGS to the related function mips_secondary_reload_class due to MEMORY_MOVE_COST applied to a constant, which becomes a bit of a problem if it's used as-is as a first argument to reg_class_subset_p (the empty class being a subset of every class). brgds, H-P
