Re: [RFC] PR81358: Enable automatic linking of libatomic

2025-01-17 Thread Sam James
Prathamesh Kulkarni writes: >> -Original Message- >> From: Prathamesh Kulkarni >> Sent: 10 January 2025 09:48 >> To: Thomas Schwinge >> Cc: Tobias Burnus ; Joseph Myers >> ; Xi Ruoyao ; Matthew >> Malcomson ; gcc-patches@gcc.gnu.org; Tom de >> Vries >> Subject: RE: [RFC] PR81358: Enabl

Re: [PATCH] MAINTAINERS: Add myself to write after approval

2025-01-17 Thread Sam James
See https://gcc.gnu.org/gitwrite.html#authenticated.

[COMMITTED 1/2] doc: trivial grammar fix

2025-01-15 Thread Sam James
We say 'a constant .. expression' elsewhere. Fix the grammar. gcc/ChangeLog: * doc/extend.texi: Add 'a' for grammar fix. --- Committed as obvious. gcc/doc/extend.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 1e1b

[COMMITTED 2/2] doc: cleanup trailing whitespace

2025-01-15 Thread Sam James
gcc/ChangeLog: * doc/extend.texi: Cleanup trailing whitespace. --- Committed as obvious. gcc/doc/extend.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 84894efc2ea4..52ba78b80361 100644 --- a/gcc/doc/extend.te

Re: [PATCH] Annotate dbg_line_numbers table

2025-01-15 Thread Sam James
Richard Biener writes: > [...]. It also cuts the lines down to 10 entries. (This version doesn't ;)) > > static int dbg_line_numbers[1267] = { > /* 0 */ 161, 164, 173, 175, 178, 181, 183, 189, 197, 195, > /* 10 */ 199, 201, 205, 923, 921, 2060, 2071, 2052, 2058, 2063, > ... >

Re: [RFC/RFA] [PR tree-optimization/92539] Improve code and avoid Warray-bounds false positive

2025-01-09 Thread Sam James
Richard Biener writes: > On Wed, Jan 8, 2025 at 5:34 PM Qing Zhao wrote: >> >> >> >> > On Jan 7, 2025, at 07:29, Richard Biener >> > wrote: >> > >> > On Mon, Jan 6, 2025 at 5:40 PM Qing Zhao wrote: >> >> >> >> >> >> >> >>> On Jan 6, 2025, at 11:01, Richard Biener >> >>> wrote: >> >>> >> >>>

Re: [PATCH 1/2] testsuite: add testcase for fixed PR117546

2025-01-06 Thread Sam James
Jeff Law writes: > On 1/3/25 11:11 AM, Sam James wrote: >> Sam James writes: >> >>> PR117546 was fixed by Eric's r14-10693-gadab597af288d6 change, but >>> the testcase here is sufficiently different to be worth including >>> in torture/. >>

Re: [PATCH 1/2] testsuite: add testcase for fixed PR117546

2025-01-03 Thread Sam James
Sam James writes: > PR117546 was fixed by Eric's r14-10693-gadab597af288d6 change, but > the testcase here is sufficiently different to be worth including > in torture/. > > gcc/testsuite/ChangeLog: > PR ipa/117546 > * gcc.dg/torture/pr117546.c: New test. &

[PATCH 2/2] testsuite: add testcase for fixed PR98000

2025-01-03 Thread Sam James
gcc/testsuite/ChangeLog: PR ipa/98000 * g++.dg/ipa/pr98000.C: New test. --- gcc/testsuite/g++.dg/ipa/pr98000.C | 68 ++ 1 file changed, 68 insertions(+) create mode 100644 gcc/testsuite/g++.dg/ipa/pr98000.C diff --git a/gcc/testsuite/g++.dg/ipa/pr98000

[PATCH 1/2] testsuite: add testcase for fixed PR117546

2025-01-03 Thread Sam James
PR117546 was fixed by Eric's r14-10693-gadab597af288d6 change, but the testcase here is sufficiently different to be worth including in torture/. gcc/testsuite/ChangeLog: PR ipa/117546 * gcc.dg/torture/pr117546.c: New test. --- gcc/testsuite/gcc.dg/torture/pr117546.c | 84

Re: [PATCH] testsuite: torture: add LLVM testcase for DSE vs. -ftrivial-auto-var-init=

2025-01-03 Thread Sam James
Mike Stump writes: > On Jan 2, 2025, at 4:00 PM, Sam James wrote: >> >> This testcase came up in a recent LLVM bug report [0] for DSE vs >> -ftrivial-auto-var-init=. Add it to our testsuite given that area >> could do with better coverage. >> >> [0] http

Re: [PATCH v11] ada: fix timeval timespec on 32 bits archs with 64 bits time_t [PR114065]

2025-01-03 Thread Sam James
Marc Poulhiès writes: >>> Would it make sense to drop the "Glibc" here? Having "Glibc" means that >>> we end up with glibc specifics in files that are not glibc specific (e.g. >>> a-exetim__posix.adb or s-osinte__linux.ads). Are these particular macros >>> glibc specific? We need these to build w

Re: [PATCH v11] ada: fix timeval timespec on 32 bits archs with 64 bits time_t [PR114065]

2025-01-03 Thread Sam James
Marc Poulhiès writes: > Hello Nicolas, > >>> At first view, it seems possible and desirable to merge _posix and >>> _rtems, but working on this right now would be counter-productive. >>> >>> I suggest to apply patches 1-2 and fix PR114065 first. >>> >>> Then the cosmetic changes in patches 3-6 (a

Re: [patch, Fortran, doc] Mention generating C prototypes from Fortran

2025-01-03 Thread Sam James
Thomas Koenig writes: > Hello world, > > I noticed that there is no mention of automatically generating > C prototypes and declarations in the relevant section of > the docs, "Interoperability with C". This patch remedies that. > > OK for trunk? > > Best regards > > Thomas > > gcc/fortran/C

[PATCH] testsuite: torture: add LLVM testcase for DSE vs. -ftrivial-auto-var-init=

2025-01-02 Thread Sam James
This testcase came up in a recent LLVM bug report [0] for DSE vs -ftrivial-auto-var-init=. Add it to our testsuite given that area could do with better coverage. [0] https://github.com/llvm/llvm-project/issues/119646 gcc/testsuite/ChangeLog: * gcc.dg/torture/dse-trivial-auto-var-init.c:

Re: [PATCH] c: special-case some "bool" errors with C23 (v2) [PR117629]

2025-01-02 Thread Sam James
David Malcolm writes: > On Thu, 2025-01-02 at 18:33 +, Joseph Myers wrote: >> On Thu, 19 Dec 2024, David Malcolm wrote: >> >> > Here's an updated version of the patch. >> > >> > Changed in v2: >> > - distinguish between "bool" and "_Bool" when determining >> >   standard version >> > - more

Re: [PATCH] doc: cpp: fix version test example syntax

2025-01-01 Thread Sam James
Andrew Pinski writes: > On Wed, Jan 1, 2025, 9:38 AM Sam James wrote: > > gcc/ChangeLog: > > * doc/cpp.texi (Common Predefined Macros): Fix syntax. > > This looks obvious correct to me. Agreed, I'll push it now. > > Thanks, > Andrew > > -

[PATCH] doc: cpp: fix version test example syntax

2025-01-01 Thread Sam James
gcc/ChangeLog: * doc/cpp.texi (Common Predefined Macros): Fix syntax. --- gcc/doc/cpp.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/cpp.texi b/gcc/doc/cpp.texi index 970c0a393971..4b0f2d9bb857 100644 --- a/gcc/doc/cpp.texi +++ b/gcc/doc/cpp.texi @@ -1974

Re: [WIP 3/8] algol68: front-end misc files

2025-01-01 Thread Sam James
"Jose E. Marchesi" writes: > [...] > diff --git a/gcc/algol68/a68spec.cc b/gcc/algol68/a68spec.cc > new file mode 100644 > index 000..75766dd8c08 > --- /dev/null > +++ b/gcc/algol68/a68spec.cc > @@ -0,0 +1,212 @@ > +/* a68spec.c -- Specific flags and argument handling of the Algol 68 front

Re: [WIP 1/8] algol68: top-level, include/ and config/ changes

2025-01-01 Thread Sam James
"Jose E. Marchesi" writes: > This patch contains the changes to files in the GCC top-level > directory to introduce the Algol 68 front-end. > --- > MAINTAINERS |2 + > Makefile.def |3 + > Makefile.in | 1341 +- > Makefile.tpl

Re: [PATCH] testsuite: arm: Align function prototype and implementation

2024-12-27 Thread Sam James
Torbjörn SVENSSON writes: > Ok for trunk? > > -- > > The implementation of the functions in the test case expects there to be > a few arguments to the helper functions, but the prototype does not have > any arguments at all. Align these to avoid these errors: I'd just -std=gnu17 for these (give

Re: The COBOL front end, in 8 notes

2024-12-19 Thread Sam James
"James K. Lowden" writes: > On Thu, 12 Dec 2024 12:56:36 -0500 > "James K. Lowden" wrote: > >> The following 8 patches constitute the 80 files needed to build and >> document the COBOL front end. > [...] > * does not build on Darwin/macOS [Iain] > [...] > - 32-bit architectures are not a consid

Re: [PATCH] c: special-case some "bool" errors with C23 [PR117629]

2024-12-18 Thread Sam James
Sam James writes: > David Malcolm writes: > >> On Tue, 2024-11-26 at 16:35 -0500, Marek Polacek wrote: >>> On Mon, Nov 25, 2024 at 10:49:02PM -0500, David Malcolm wrote: >>> > This patch attempts to provide better error messages for >>> > code c

Re: [PATCH] c: special-case some "bool" errors with C23 [PR117629]

2024-12-18 Thread Sam James
David Malcolm writes: > On Tue, 2024-11-26 at 16:35 -0500, Marek Polacek wrote: >> On Mon, Nov 25, 2024 at 10:49:02PM -0500, David Malcolm wrote: >> > This patch attempts to provide better error messages for >> > code compiled with C23 that hasn't been updated for >> > "bool", "true", and "false"

Re: [PATCH] noncontiguous ifcombine: skip marking of non-SSA_NAMEs [PR117915]

2024-12-17 Thread Sam James
Alexandre Oliva writes: > When ifcombine_mark_ssa_name is called directly, rather than by > ifcombine_mark_ssa_name_walk, we need to check that name is an > SSA_NAME at the caller or in the function itself. For convenience and > safety, I'm moving the checks from _walk to the implementation prop

Re: The COBOL front end, in 8 notes

2024-12-14 Thread Sam James
David Malcolm writes: > On Thu, 2024-12-12 at 12:56 -0500, James K. Lowden wrote: >> The following 8 patches constitute the 80 files needed to build and >> document the COBOL front end.  They assume that following exist: >> >>     gcc/cobol/ChangeLog >>     libgcobol/ChangeLog >> >> The message

Re: The COBOL front end, in 8 notes

2024-12-14 Thread Sam James
"James K. Lowden" writes: > The following 8 patches constitute the 80 files needed to build and > document the COBOL front end. They assume that following exist: > > gcc/cobol/ChangeLog > libgcobol/ChangeLog > > The messages are grouped by files in a more or less logical order, > but gro

Re: [PATCH] c: special-case some "bool" errors with C23 [PR117629]

2024-12-13 Thread Sam James
Sam James writes: > David Malcolm writes: > >> This patch attempts to provide better error messages for >> code compiled with C23 that hasn't been updated for >> "bool", "true", and "false" becoming keywords (based on >>

[COMMITTED] i386: regenerate i386.opt.urls

2024-12-12 Thread Sam James
r15-6128-gfa878dc8c45fa3 missed the regeneration of the URL doc map, so regenerate it here to make the buildbots happy. gcc/ChangeLog: * config/i386/i386.opt.urls: Regenerate. --- Committed as obvious, as the buildbots kept emailing and thought it better to get it out of the way. gcc/co

Re: 'gcc/config/nvptx/gen-multilib-matches.sh': Support '--selftest'

2024-12-08 Thread Sam James
Thomas Schwinge writes: > Hi Sam! Hi! > > On 2024-12-06T09:34:32+0000, Sam James wrote: >> The script has #!/bin/sh shebang (and hence must have POSIX shell >> compatibility), but the patch introduces uses of the 'local' keyword >> which isn't in

Re: [PATCH] Fix type compatibility for types with flexible array member [PR113688,PR114014,PR117724]

2024-12-08 Thread Sam James
Martin Uecker writes: > Hi Richard, > > this is another version. It now adds an "ignore_size" flag > to gimple_canonical_types_compatible_p and uses this instead > of having the complicated special case for arrays at the > end. Also zero-sized members are now ignored again, except > if they are

Re: [PATCH v2] testsuite/gcc.dg/tree-ssa/pr111456-1.c: Handle fallout

2024-12-08 Thread Sam James
Hans-Peter Nilsson writes: > v2: oops, typo: component is tree-optimization, not tree-ssa. > Resent for the benefit of autotesters that don't yet > understand natural language. > > Forcing a fail and marking as xfail is IMHO better than > passing --param=logical-op-non-short-circuit=0 or #pragma

Re: [PATCH] c: special-case some "bool" errors with C23 [PR117629]

2024-12-06 Thread Sam James
David Malcolm writes: > This patch attempts to provide better error messages for > code compiled with C23 that hasn't been updated for > "bool", "true", and "false" becoming keywords (based on > a brief review of the Gentoo bug tracker links given at > https://gcc.gnu.org/pipermail/gcc/2024-Novem

Re: 3rd Ping: [Middle-end][PATCH v4 0/3][RFC]Provide more contexts for -Warray-bounds and -Wstringop-* warning messages

2024-12-06 Thread Sam James
Qing Zhao writes: > This is the 3rd ping of the Middle-end review for this patch. > Jeff, would you be able to take a look? (In part because I know you've had a lot of comments and feedback on the middle-end warnings before). The diagnostics bits are OK'd already. I've been running this on dist

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Sam James
Georg-Johann Lay writes: > Am 06.12.24 um 13:23 schrieb Sam James: >> Georg-Johann Lay writes: >> >>> This patch disables CRC lookup tables which consume quite some RAM. >> Given that -foptimize-crc is new, it may be useful to CC the pass >> authors in ca

Re: [PATCH] Fix incorrect line numbers in large files bug#108900

2024-12-06 Thread Sam James
Jeremy Bettis writes: > Patch to fix known bug from > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108900 > > diff -ur gcc-clean/gcc-14.2.0/libcpp/files.cc gcc-14.2.0/libcpp/files.cc > --- gcc-clean/gcc-14.2.0/libcpp/files.cc 2024-08-01 08:17:17.0 + > +++ gcc-14.2.0/libcpp/files.cc 20

Re: [patch,lra] PR116778 we need a full live range info after rematerialization

2024-12-06 Thread Sam James
Denis Chertykov writes: > The fix for PR116778: > Added Vlad to CC. > [...] > > diff --git a/gcc/lra-lives.cc b/gcc/lra-lives.cc > index 49134ade713..510f7d927ab 100644 > --- a/gcc/lra-lives.cc > +++ b/gcc/lra-lives.cc > @@ -62,9 +62,10 @@ int lra_hard_reg_usage[FIRST_PSEUDO_REGISTER]; > /* A

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Sam James
Georg-Johann Lay writes: > This patch disables CRC lookup tables which consume quite some RAM. Given that -foptimize-crc is new, it may be useful to CC the pass authors in case they have input. > > Ok for trunk? > > Johann

Re: [PATCH] AIX Build failure with default -std=gnu23.

2024-12-06 Thread Sam James
swamy sangamesh writes: > Dear Community, > > Please let me know if the attached patch is fine. For such patches, I recommend CCing the maintainers of relevant components. In this case, that's David Edelsohn, being the AIX maintainer (done it for you here). I can't approve it but I imagine the

Re: [PATCH] config: nvptx: fix bashisms with gen-copyright.sh use

2024-12-06 Thread Sam James
Thomas Schwinge writes: > Hi Sam and Tom! Hi! > > On 2024-12-06T09:13:40+0000, Sam James wrote: >> Providing parameters to `.` when sourcing is a bashism and not supported >> by POSIX shell which causes a build failure when compiling a toolchain >> for nvptx-none wi

Re: 'gcc/config/nvptx/gen-multilib-matches.sh': Support '--selftest' (was: 'gcc/config/nvptx/t-nvptx': Don't use the 'shell' function of 'make' (was: nvptx: Allow '--with-arch' to override the default

2024-12-06 Thread Sam James
Hi! The script has #!/bin/sh shebang (and hence must have POSIX shell compatibility), but the patch introduces uses of the 'local' keyword which isn't in POSIX. While many shells do have the 'local' keyword, its behaviour isn't portable across those either, which is why it's likely it'll never be

Re: 'gcc/config/nvptx/gen-multilib-matches.sh': Support '--selftest'

2024-12-06 Thread Sam James
Sam James writes: > Hi! > > The script has #!/bin/sh shebang (and hence must have POSIX shell > compatibility), but the patch introduces uses of the 'local' keyword > which isn't in POSIX. > > While many shells do have the 'local' keyword, its

[PATCH] config: nvptx: fix bashisms with gen-copyright.sh use

2024-12-06 Thread Sam James
Providing parameters to `.` when sourcing is a bashism and not supported by POSIX shell which causes a build failure when compiling a toolchain for nvptx-none with dash as /bin/sh. gen-copyright.sh takes a parameter for the format of copyright notice required. Switch that to using an environment v

Re: [Patch, fortran] PR117763 [15.0 regression] segmentation fault through allocatable char arrays (?)

2024-11-25 Thread Sam James
Jerry D writes: > On 11/25/24 3:09 AM, Paul Richard Thomas wrote: >> Hi All, >> The breakage was caused by the patch for PR109345. As it happens, >> this part of the patch was not required to fix the PR and looked to >> be a considerable simplification of the condition. Although correct >> that a

[PATCH] Sync top-level configure with binutils

2024-11-22 Thread Sam James
This syncs us with binutils/gdb's toplevel configure as of 987db70acefd0b223a8df2240d4e5ca544cc0a91. There's not much notable here, just gprofng (which is in binutils) being disabled for musl and a new target which got added on that side too. The only part which may look interesting is the basear

Re: [PING] [contrib] validate_failures.py: fix python 3.12 escape sequence warnings

2024-11-22 Thread Sam James
Jeff Law writes: > On 6/9/24 5:45 AM, Gabi Falk wrote: >> Hi, >> On Sat, Jun 08, 2024 at 03:34:02PM -0600, Jeff Law wrote: >>> On 5/14/24 8:12 AM, Gabi Falk wrote: Hi, This one still needs review: https://inbox.sourceware.org/gcc-patches/20240415233833.104460-1-gabif...@g

Re: [PATCH] wwwdocs: Align the DCO text for the GNU Toolchain to match community usage.

2024-11-22 Thread Sam James
Jason Merrill writes: > On 11/21/24 6:04 PM, Carlos O'Donell wrote: >> Adjust the DCO text to match the broader community usage including >> the Linux kernel use around "real names." >> These changes clarify what was meant by "real name" and that it is >> not required to be a "legal name" or any

Re: [PATCH v1] autoupdate: replace obsolete macros in libiberty

2024-11-22 Thread Sam James
Matthieu Longo writes: > Autoreconf-2.72 warns about obsolete macros. This patch aims at removing > the noise from a future upgrade to autoreconf-2.72 or later. This is in > no a way a complete patch allowing the upgrade to autoreconf-2.72. > > - AC_GNU_SOURCE by AC_USE_SYSTEM_EXTENSIONS > http

Re: [PATCH] wwwdocs: Align the DCO text for the GNU Toolchain to match community usage.

2024-11-22 Thread Sam James
Carlos O'Donell writes: > On 11/21/24 1:47 PM, Sam James wrote: >> Mark Wielaard writes: >> >>> Hi Carlos, >>> >>> On Thu, 2024-11-21 at 12:04 -0500, Carlos O'Donell wrote: >>>> Adjust the DCO text to match the broader commun

Re: [PATCH] wwwdocs: Align the DCO text for the GNU Toolchain to match community usage.

2024-11-21 Thread Sam James
Mark Wielaard writes: > Hi Carlos, > > On Thu, 2024-11-21 at 12:04 -0500, Carlos O'Donell wrote: >> Adjust the DCO text to match the broader community usage including >> the Linux kernel use around "real names." > > We made a similar change to switch from "real names" to "known > identifies" for

Re: [PATCH v6] forwprop: Try to blend two isomorphic VEC_PERM sequences

2024-11-21 Thread Sam James
The default on trunk is --enable-checking=yes,extra (when gcc/DEV-PHASE contains "experimental"), otherwise it's --enable-checking=release. I personally do most testing with --enable-checking=yes,rtl,extra but you can do less than that if you want to quickly get results. The minimum for testing p

Re: [PATCH] doc: mention STAGE1_CFLAGS

2024-11-20 Thread Sam James
Sam James writes: > STAGE1_CFLAGS can be used to accelerate the just-built stage1 compiler > which especially improves its performance on some of the large generated > files during bootstrap. It defaults to nothing (i.e. -O0). > > The downside is that if the native compiler is b

Re: [PATCH htdocs] bugs: mention ASAN too

2024-11-20 Thread Sam James
Sam James writes: > Request that reporters try `-fsanitize=address,undefined` rather than > just `-fsanitize=undefined` when reporting bugs. We get invalid bug > reports which ASAN would've caught sometimes, even if it's less often > than where UBSAN would help. > ---

Re: Should -fsanitize=bounds support counted-by attribute for pointers inside a structure?

2024-11-20 Thread Sam James
Martin Uecker writes: > Am Montag, dem 18.11.2024 um 17:55 + schrieb Qing Zhao: >> Hi, >> >> I am working on extending “counted_by” attribute to pointers inside a >> structure per our previous discussion. >> >> I need advice on the following question: >> >> Should -fsantize=bounds suppor

Re: [committed] c: Default to -std=gnu23

2024-11-17 Thread Sam James
Florian Weimer writes: > * Joseph Myers: > >> Change the default language version for C compilation from -std=gnu17 >> to -std=gnu23. A few tests are updated to remove local definitions of >> bool, true and false (where making such an unconditional test change >> seemed to make more sense than c

Re: [WIP RFC] libstdc++: add module std

2024-11-16 Thread Sam James
Jason Merrill writes: > On 10/18/24 11:21 AM, Patrick Palka wrote: >> On Fri, 18 Oct 2024, Jason Merrill wrote: >>> >>> Is it useful for std.cc to live in a subdirectory of c++23 as in this >>> patch, or >>> should it be in c++23 itself? Or elsewhere? >> IIUC the src/ subdirectory is for stuff

Re: [r15-5359 Regression] FAIL: g++.dg/tree-ssa/pr109442.C -std=gnu++26 scan-tree-dump-not optimized "_M_start" on Linux/x86_64

2024-11-16 Thread Sam James
I think this testcase was accidentally included in r15-5359-gcc33f880e553d1 but this problem can be ignored, as it is now fixed by r15-5361-gaac5c57ee16723. (TL;DR: just a git snafu and the problem is resolved AFAICT.)

[PATCH v2 2/2] testsuite: i386: adapt to -std=gnu23 default change

2024-11-15 Thread Sam James
r15-5327-g55e3bd376b2214 changes the default to -std=gnu23 but this test relies on unprototyped functions. Follow Joseph's advice in that commit and tweak the test accordingly. gcc/testsuite/ChangeLog: * gcc.target/i386/pr66891.c: Pass -std=gnu17. --- OK for trunk? v2 fixes the commit me

[PATCH 1/2] testsuite: graphite: adapt to -std=gnu23 default change

2024-11-15 Thread Sam James
r15-5327-g55e3bd376b2214 changes the default to -std=gnu23 but these tests now trigger -Wold-style-function-definition. Follow Joseph's advice in that commit and tweak the tests accordingly. gcc/testsuite/ChangeLog: * gcc.dg/graphite/id-15.c: Pass -Wold-style-function-definition.

[PATCH v2 1/2] testsuite: graphite: adapt to -std=gnu23 default change

2024-11-15 Thread Sam James
r15-5327-g55e3bd376b2214 changes the default to -std=gnu23 but these tests now trigger -Wold-style-definition. Follow Joseph's advice in that commit and tweak the tests accordingly. gcc/testsuite/ChangeLog: * gcc.dg/graphite/id-15.c: Pass -Wno-old-style-definition. * gcc.dg/graphi

Re: [PATCH 1/2] testsuite: graphite: adapt to -std=gnu23 default change

2024-11-15 Thread Sam James
> On 16 Nov 2024, at 03:28, Jeff Law wrote: > >  > >> On 11/15/24 8:16 PM, Sam James wrote: >> r15-5327-g55e3bd376b2214 changes the default to -std=gnu23 but these >> tests now trigger -Wold-style-function-definition. Follow Joseph's advice >> in th

Re: [PATCH 2/2] testsuite: i386: adapt to -std=gnu23 default change

2024-11-15 Thread Sam James
... with s/-function// and the commit message and ChangeLogs fixed, of course.

[PATCH 2/2] testsuite: i386: adapt to -std=gnu23 default change

2024-11-15 Thread Sam James
r15-5327-g55e3bd376b2214 changes the default to -std=gnu23 but this test now triggers -Wold-style-function-definition. Follow Joseph's advice in that commit and tweak the test accordingly. gcc/testsuite/ChangeLog: * gcc.target/i386/pr66891.c: Pass -Wold-style-function-definition. --- OK i

Re: tree-nested: Do not inline or clone functions with nested functions with VM return type [PR117164]

2024-11-14 Thread Sam James
Joseph Myers writes: > Bug 117164 is an ICE on an existing test with -std=gnu23 involving a > nested function returning a variable-size structure (and I think the > last bug needing to be resolved before switching to -std=gnu23 as the > default, as without fixing this would be a clear regression

[COMMITTED] gcc: regenerate configure

2024-11-14 Thread Sam James
r15-5257-g56ded80b96b0f6 didn't regenerate configure correctly. See https://inbox.sourceware.org/gcc-patches/zzzf69gorvpro...@zen.kayari.org/. gcc/ChangeLog: * configure: Regenerate. --- Pushed as obvious. gcc/configure | 14 -- 1 file changed, 8 insertions(+), 6 deletions(

Re: [PATCH] c++: Add __builtin_operator_{new,delete} support

2024-11-11 Thread Sam James
Jakub Jelinek writes: > On Mon, Nov 11, 2024 at 06:47:43PM +0000, Sam James wrote: >> > Bootstrapped/regtested successfully on x86_64-linux and i686-linux. >> >> Maybe tag PR110137 given it's very related (and of interest to people >> CC'd on the bu

Re: [PATCH] c++: Add __builtin_operator_{new,delete} support

2024-11-11 Thread Sam James
Jakub Jelinek writes: > On Fri, Nov 08, 2024 at 06:40:16PM +0100, Jakub Jelinek wrote: >> clang++ adds __builtin_operator_{new,delete} builtins which as documented >> work similarly to ::operator {new,delete}, except that it is an error >> if the called ::operator {new,delete} is not a replaceabl

[PATCH htdocs] bugs: mention ASAN too

2024-11-10 Thread Sam James
Request that reporters try `-fsanitize=address,undefined` rather than just `-fsanitize=undefined` when reporting bugs. We get invalid bug reports which ASAN would've caught sometimes, even if it's less often than where UBSAN would help. --- OK? htdocs/bugs/index.html | 2 +- 1 file changed, 1 ins

[PATCH] doc: mention STAGE1_CFLAGS

2024-11-10 Thread Sam James
STAGE1_CFLAGS can be used to accelerate the just-built stage1 compiler which especially improves its performance on some of the large generated files during bootstrap. It defaults to nothing (i.e. -O0). The downside is that if the native compiler is buggy, there's a greater risk of a failed bootst

Re: [PATCH 0/4] libsanitizer: merge from upstream

2024-11-06 Thread Sam James
Kito Cheng writes: > The patch set aims to update libsanitizer from upstream. The motivation is > that > RISC-V is changing the shadow offset for AddressSanitizer, and I also plan to > submit another patch set to add dynamic shadow offset support for GCC. > > This is my first time updating it, s

Re: [PATCH 2/2] doc: install: document UBSAN_OPTIONS

2024-11-06 Thread Sam James
Sam James writes: > Explain that 'bootstrap-ubsan' won't abort on errors by default and how > to override that by setting UBSAN_OPTIONS. > > gcc/ChangeLog: > PR other/116948 > > * doc/install.texi (Building a native compiler): Document UBSAN_OPTION

Re: Implement removal of malloc/free pairs with NULL check

2024-11-06 Thread Sam James
Sam James writes: > Alexander Monakov writes: > >> On Fri, 1 Nov 2024, Jan Hubicka wrote: >> >>> > I have a vague memory that one of the tests in SPEC has a loop that >>> > tries to malloc, doubling the size each time, until it fails. Would >>

Re: Implement removal of malloc/free pairs with NULL check

2024-11-05 Thread Sam James
Jan Hubicka writes: > [...] > The attached patch adds code to track size of allocated block and > disable the transformation when the block is not known to be smaller > then half of the address space by ranger. We can do the runtime check > discussed on the top of that. > > I have bootstrap®ress

Re: Implement removal of malloc/free pairs with NULL check

2024-11-01 Thread Sam James
Alexander Monakov writes: > On Fri, 1 Nov 2024, Jan Hubicka wrote: > >> > I have a vague memory that one of the tests in SPEC has a loop that >> > tries to malloc, doubling the size each time, until it fails. Would >> > the patch change the behavior of such a loop? >> >> If the resulting alloca

Re: [PATCH #3/7] introduce ifcombine_replace_cond

2024-11-01 Thread Sam James
Alexandre Oliva writes: > Refactor ifcombine_ifandif, moving the common code from the various > paths that apply the combined condition to a new function. BTW, forgive the possibly silly question, but I don't see any testcases for the series. Would it be possible to add any? > > > for gcc/Chan

Re: [PATCH] guality tests: Silence gdb debuginfod warning

2024-10-31 Thread Sam James
"H.J. Lu" writes: > When gdb defaults to use debuginfod, gdb warns guality tests: > > Spawning: gdb -nx -nw -quiet -batch -x pr36728-2.gdb ./pr36728-2.exe > spawn gdb -nx -nw -quiet -batch -x pr36728-2.gdb ./pr36728-2.exe > Breakpoint 1 at 0x4004ba: file > /export/gnu/import/git/gitlab/x86-gcc/g

[COMMITTED 3/3] testsuite: g++.dg: torture: fix PR111520 filename

2024-10-31 Thread Sam James
gcc/testsuite/ChangeLog: PR tree-optimization/111520 * g++.dg/torture/harden-comp-pr111520.cc: Move to... * g++.dg/torture/harden-comp-pr111520.C: ...here. --- Pushed as obvious. .../torture/{harden-comp-pr111520.cc => harden-comp-pr111520.C} | 0 1 file changed, 0 inse

[COMMITTED] testsuite: g++.dg: debug: fix test filenames

2024-10-31 Thread Sam James
gcc/testsuite/ChangeLog: PR debug/15736 PR debug/46240 * g++.dg/debug/pr15736.cc: Move to... * g++.dg/debug/pr15736.C: ...here. * g++.dg/debug/pr46240.cc: Move to... * g++.dg/debug/pr46240.C: ...here. --- Pushed as obvious. Probably the last one of t

[COMMITTED 1/3] testsuite: fixup pr66655.C

2024-10-31 Thread Sam James
In r15-4823-g14e2f3233bf0ef, I renamed pr66655_1.cc but neglected to update a dg-additional-sources reference. gcc/testsuite/ChangeLog: PR target/66655 * g++.dg/pr66655.C: Adjust filename in dg-additional-sources. --- Pushed as obvious. gcc/testsuite/g++.dg/pr66655.C | 2 +- 1 f

[COMMITTED 2/3] testsuite: g++.dg: fix PR90313 filename

2024-10-31 Thread Sam James
gcc/testsuite/ChangeLog: PR c++/90313 * g++.dg/torture/pr90313.cc: Move to... * g++.dg/torture/pr90313.C: ...here. --- Pushed as obvious. gcc/testsuite/g++.dg/torture/{pr90313.cc => pr90313.C} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename gcc/testsuite/g++.

[COMMITTED 1/3] testsuite: g++.dg: rename pr105820 test

2024-10-31 Thread Sam James
.c is used for C and .C is for C++. The test was being ignored before. gcc/testsuite/ChangeLog: PR tree-optimization/105820 * g++.dg/tree-ssa/pr105820.c: Move to... * g++.dg/tree-ssa/pr105820.C: ...here. --- Pushed as obvious. gcc/testsuite/g++.dg/tree-ssa/{pr105820.c =>

[COMMITTED 3/3] testsuite: g++.dg: rename pr66655 test

2024-10-31 Thread Sam James
The test was being ignored because dg.exp looks for .C in g++.dg/. gcc/testsuite/ChangeLog: PR target/66655 * g++.dg/pr66655_1.cc: Move to... * g++.dg/pr66655_1.C: ...here. --- Pushed as obvious. gcc/testsuite/g++.dg/{pr66655_1.cc => pr66655_1.C} | 0 1 file changed, 0 i

[COMMITTED 2/3] testsuite: g++.dg: rename pr42965 test

2024-10-31 Thread Sam James
.c is used for C and .C is for C++. The test was being ignored before. gcc/testsuite/ChangeLog: PR other/42965 * g++.dg/warn/unused-result1-Werror.c: Move to... * g++.dg/warn/unused-result1-Werror.C: ...here. --- Pushed as obvious. .../warn/{unused-result1-Werror.c => un

Re: Implement removal of malloc/free pairs with NULL check

2024-10-31 Thread Sam James
Jan Hubicka writes: > Hi, > this patch lets us to remove > void *mem = __builtin_malloc (s); > if (!mem) > __builtin_abort (); > __builtin_free (mem); > > Where we previously stopped on "if (!mem)" marking __builtin_malloc necessary. > This is done by matching such conditional in tree-s

[PATCH 2/2] doc: install: document UBSAN_OPTIONS

2024-10-31 Thread Sam James
Explain that 'bootstrap-ubsan' won't abort on errors by default and how to override that by setting UBSAN_OPTIONS. gcc/ChangeLog: PR other/116948 * doc/install.texi (Building a native compiler): Document UBSAN_OPTIONS. --- gcc/doc/install.texi | 4 +++- 1 file changed, 3 insertio

[PATCH 1/2] doc: install: document bootstrap-ubsan

2024-10-31 Thread Sam James
gcc/ChangeLog: PR other/116948 * doc/install.texi (Building a native compiler): Mention bootstrap-ubsan. --- gcc/doc/install.texi | 4 1 file changed, 4 insertions(+) diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index f19d55f76c3d..85896721a0ac 100644 --- a/gcc/

Re: [PATCH 0/3] Move some single-file LTO tests to torture

2024-10-31 Thread Sam James
Sam James writes: > Andrew pointed this out when committing those testsuite fixes earlier. We > may as well make these proper torture tests rather than having them > unnecessarily in the special lto/ dir which is meant for multiple files > really. > > Sam James (3): > t

Re: [PATCH 1/3] testsuite: move single-file LTO pr62026 test to torture

2024-10-31 Thread Sam James
Andrew Pinski writes: > On Fri, Oct 25, 2024 at 3:08 PM Sam James wrote: >> >> This only started being used recently in r15-4682-g03ff420aa0a916 and >> pinskia pointed out we may as well make it a proper torture test >> instead as it's a single file LTO tes

[PATCH] testsuite: fix c23-constexpr-2a.c test to use dg-do run

2024-10-31 Thread Sam James
The comment at the top of the test indicates it should be an execution test, but it was only using 'dg-do link'. Correct that. The only change in test results is as expected: ``` +PASS: gcc.dg/c23-constexpr-2a.c execution test ``` gcc/testsuite/ChangeLog: PR testsuite/117183 * gc

[PATCH] testsuite: add testcase for fixed PR106073

2024-10-30 Thread Sam James
This was fixed by r12-8835-ge8d5f3a1b5a583 which surely made it latent but richi points out it was likely an instance of PR90348. -fstack-reuse continues to be a menace, so let's add the testcase. gcc/testsuite/ChangeLog: PR middle-end/90348 PR tree-optimization/106073 * g

[committed] testsuite: fix syntax in Wstringop-overflow-59.c

2024-10-30 Thread Sam James
Fix quoting issues, escaping, and dg directive types. There were two issues here: 1) The incorrect quoting in an earlier dg-message was covering up that the syntax in the next part was wrong; 2) Fix dg-warning -> dg-message to correctly pick up the notes. Once 1) was fixed, this was exposed. With

Re: [PATCH v3 1/2][RFC] Provide more contexts for -Warray-bounds, -Wstringop-* warning messages due to code movements from compiler transformation [PR109071]

2024-10-30 Thread Sam James
David Malcolm writes: > On Wed, 2024-10-30 at 17:33 +0000, Sam James wrote: >> Qing Zhao writes: >> >> > > On Oct 30, 2024, at 10:48, David Malcolm >> > > wrote: >> > > >> > > On Wed, 2024-10-30 at 14:34 +, Sam James wrote

Re: [PATCH v3 2/2][RFC] Add debugging for move history.

2024-10-30 Thread Sam James
Qing Zhao writes: > gcc/ChangeLog: > > * diagnostic-move-history.cc (dump_move_history): New routine. > (dump_move_history_for): Likewise. > (debug_mv_h): Likewise. > * diagnostic-move-history.h (dump_move_history): New prototype. > (dump_move_history_for): Likewise.

Re: [PATCH v3 1/2][RFC] Provide more contexts for -Warray-bounds, -Wstringop-* warning messages due to code movements from compiler transformation [PR109071]

2024-10-30 Thread Sam James
Qing Zhao writes: > Control this with a new option -fdiagnostics-details. > > $ cat t.c > extern void warn(void); > static inline void assign(int val, int *regs, int *index) > { > if (*index >= 4) > warn(); > *regs = val; > } > struct nums {int vals[4];}; > > void sparx5_set (int *ptr, st

Re: [PATCH v3 0/2][RFC]Provide more contexts for -Warray-bounds warning messages

2024-10-30 Thread Sam James
Qing Zhao writes: > Hi, > > This is the 3rd version of the patch for fixing PR109071. > > Thanks a lot for San James's help to test the previous 2nd version of > the patch on a lot of packages in the wild and provide detailed analysis > and filed new bugs. (PR117179, PR117180, etc). Thank you Q

Re: [PATCH v3 1/2][RFC] Provide more contexts for -Warray-bounds, -Wstringop-* warning messages due to code movements from compiler transformation [PR109071]

2024-10-30 Thread Sam James
Qing Zhao writes: >> On Oct 30, 2024, at 10:48, David Malcolm wrote: >> >> On Wed, 2024-10-30 at 14:34 +, Sam James wrote: >>> Qing Zhao writes: >>> >>>> Control this with a new option -fdiagnostics-details. >>>> >>>

Re: [PATCH v3 1/2][RFC] Provide more contexts for -Warray-bounds, -Wstringop-* warning messages due to code movements from compiler transformation [PR109071]

2024-10-30 Thread Sam James
Qing Zhao writes: > Control this with a new option -fdiagnostics-details. > > [...] The patch doesn't apply for me on very latest trunk -- I think David's recent diag refactoring means it needs a slight rebase. Could you send that?

[PATCH] gcc: fix 'statements' comment typo

2024-10-28 Thread Sam James
gcc/ChangeLog: * opts-common.cc (prune_options): Fix typo. --- Pushed as obvious. gcc/opts-common.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/opts-common.cc b/gcc/opts-common.cc index 22774457bf0f..ac2e77b16590 100644 --- a/gcc/opts-common.cc +++ b/gcc/opts

Re: [PATCH] testsuite: add testcase for fixed PR107467

2024-10-28 Thread Sam James
Mike Stump writes: > On Oct 25, 2024, at 12:47 PM, Sam James wrote: >> >> PR107467 ended up being fixed by the fix for PR115110, but let's >> add the testcase on top. >> >> gcc/testsuite/ChangeLog: >> PR tree-optimization/107467 >>

Re: [PATCH] config: add -Werror=lto-type-mismatch,odr to bootstrap-lto*

2024-10-28 Thread Sam James
Sam James writes: > Sam James writes: > >> Add -Werror=lto-type-mismatch,odr to bootstrap-lto* configurations to >> help stop LTO breakage/correctness issues sneaking in. >> >> We discussed -Werror=strict-aliasing but it runs early and doesn't >> give b

  1   2   3   4   >