Harald Anlauf <anl...@gmx.de> writes:
> Sam,
>
> who approved the fortran testsuite changes?
We've been doing them as obvious by consensus since last year. I'm sorry
for the error.
>
> Am 27.03.25 um 14:28 schrieb Sam James:
>> These just fix inconsistent/unusual style to avoid noise when grepping
>> and also people picking up bad habits when they see it (as similar
>> mistakes can be harmful).
>
> This one should be reverted. The reason for the two spaces is actually
> explained in the testcase:
Yes, you're quite right (and done). I had it in a branch where I'd left
a poor comment for myself, even though I'd already handled other Fortran
cases like this specially. Apologies agian.
>
>> diff --git a/gcc/testsuite/gfortran.dg/cray_pointers_2.f90
>> b/gcc/testsuite/gfortran.dg/cray_pointers_2.f90
>> index 4351874825ed..a7e15bad850a 100644
>> --- a/gcc/testsuite/gfortran.dg/cray_pointers_2.f90
>> +++ b/gcc/testsuite/gfortran.dg/cray_pointers_2.f90
>> @@ -1,6 +1,6 @@
>> ! Using two spaces between dg-do and run is a hack to keep
>> gfortran-dg-runtest
>> ! from cycling through optimization options for this expensive test.
>> -! { dg-do run }
>> +! { dg-do run }
>> ! { dg-options "-O3 -fcray-pointer -fbounds-check -fno-inline" }
>> ! { dg-timeout-factor 4 }
>> !
>
> There was an attempt by Jerry some time ago to have a directive
> for not cycling through options, but this is not yet available.
Ah, PR28032.
>
> Thanks,
> Harald
thanks,
sam
