Christophe Lyon <christophe.l...@linaro.org> writes:
> Le dim. 30 mars 2025, 22:10, Sam James <s...@gentoo.org> a écrit :
>
> Jakub Jelinek <ja...@redhat.com> writes:
>
> > Hi!
> >
> > r15-8956 changed in the test:
> > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */
> > +/* { dg-final { scan-assembler-times "ldclr\t" 16 } */
> > which made it even worse than before, when the directive has
> > been silently ignored because it didn't match the regex for
> > directives. Now it matches it but is unbalanced.
> > So now I'm getting
> > ERROR: tcl error sourcing
>
> /builddir/build/BUILD/gcc-15.0.1-build/gcc-15.0.1-20250329/gcc/testsuite/gcc.target/aarch64/aarch64.exp.
> > ERROR: tcl error code NONE
> > ERROR: unmatched open brace in list
> > while executing
> > "foreach op $tmp {
> > verbose "Processing option: $op" 3
> > set status [catch $op errmsg]
> > if { $status != 0 } {
> > if { 0 && [info exists errorInfo] } {..."
> > (procedure "saved-dg-test" line 76)
> > invoked from within
> > "saved-dg-test
>
> /builddir/build/BUILD/gcc-15.0.1-build/gcc-15.0.1-20250329/gcc/testsuite/gcc.target/aarch64/atomic-inst-ldlogic.c
> {}
> { -ansi -pedantic-e..."
> > ("eval" body line 1)
> > invoked from within
> > etc.
> >
> > The following patch fixes it and adds space after all the
> > other scan-assembler-times counts in the file.
> >
> > Tested on x86_64-linux -> aarch64-linux cross, committed to
> > trunk as obvious.
>
> Thank you! I'm sorry, I thought I'd caught that one. I'll take extra
> care with the next round (which won't be until after release now).
>
> Doesn't the new dg-lint tool take care of that?
It doesn't yet catch everything, but my plan is to enhance it for cases
which it doesn't (once sorted through the existing stuff it finds),
indeed.
thanks,
sam
