Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

Hello All: Addressed below review comments in the version 11 of the patch. Please review and please let me know if its ok for trunk. Thanks & Regards Ajit On 22/10/23 12:56 am, rep.dot@gmail.com wrote: > On 21 October 2023 01:56:16 CEST, Vineet Gupta wrote: >> On 10/19/23 23:50, Ajit Agarwa

[PATCH V11] ree: Improve ree pass using defined abi interfaces

Hello Vineet, Jeff and Bernhard: This version 11 of the patch uses abi interfaces to remove zero and sign extension elimination. Bootstrapped and regtested on powerpc-linux-gnu. In this version (version 11) of the patch following review comments are incorporated. a) Removal of hard code zero_e

Re: [PATCH] vect: Cost adjacent vector loads/stores together [PR111784]

Hi Richard, on 2023/10/20 06:12, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi, >> >> As comments[1][2], this patch is to change the costing way >> on some adjacent vector loads/stores from costing one by >> one to costing them together with the total number once. >> >> It helps to fix the

[PATCH v1] RISC-V: Remove unnecessary asm check for binop constraint

From: Pan Li The vsetvl asm check is unnecessary for the binop constraint. We should be focus for constrait and leave the vsetvl test to the vsetvl pass. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/binop_vv_constraint-1.c: Remove the vsetvl asm check from func body.

Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE

On Sun, Oct 22, 2023 at 4:03 PM wrote: > > On 22 October 2023 21:45:12 CEST, Jeff Law wrote: > > > > > >On 10/22/23 10:09, Andrew Pinski wrote: > >> On Sun, Oct 22, 2023 at 12:47 AM Florian Weimer wrote: > >>> > >>> Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. > >>> Definin

Re: [PATCH v4] libgfortran: Replace mutex with rwlock

Hi Lipeng, Sure, as your comments, in the patch V6, I added 3 test cases with OpenMP to test different cases in concurrency respectively: 1. find and create unit very frequently to stress read lock and write lock. 2. only access the unit which exist in cache to stress read lock. 3. access the sa

[PATCH v1 1/1] gcc: config: microblaze: fix cpu version check

There is a microblaze cpu version 10.0 included in versal. If the minor version is only a single digit, then the version comparison will fail as version 10.0 will appear as 100 compared to version 6.00 or 8.30 which will calculate to values 600 and 830. The issue can be seen when using the '-mcpu=

Re: [MAINTAINERS/KERNEL SUMMIT] Trust and maintenance of file systems

On Tue, Sep 12, 2023 at 5:53 AM Richard Biener via Gcc-patches wrote: > > On Thu, Sep 7, 2023 at 2:32 PM Segher Boessenkool > wrote: > > > > On Thu, Sep 07, 2023 at 02:23:00PM +0300, Dan Carpenter wrote: > > > On Thu, Sep 07, 2023 at 06:04:09AM -0500, Segher Boessenkool wrote: > > > > On Thu, Sep

Re: [PATCH 0/2] RISC-V: Define not broken prefetch builtins

On 2023/09/27 6:38, Jeff Law wrote: > > > On 9/22/23 01:11, Tsukasa OI wrote: >> Hello, >> >> As I explained earlier: >> , >> the builtin function for RISC-V "__builtin_riscv_zicbop_cbo_prefetchi" is >> completely broken.  Instead

[PING][PATCH v4] [tree-optimization/110279] Consider FMA in get_reassociation_width

Hello and Ping, Thanks, Di > -Original Message- > From: Di Zhao OS > Sent: Monday, October 9, 2023 12:40 AM > To: Richard Biener > Cc: gcc-patches@gcc.gnu.org > Subject: RE: [PATCH v4] [tree-optimization/110279] Consider FMA in > get_reassociation_width > > Attached is a new version of

[PATCH][WIP] libiberty: Support for relocation output

This patch teaches libiberty to output X86-64 Relocations. >From d3b2d168369e76a6fac2b3b3cbd591ccf22ea8ea Mon Sep 17 00:00:00 2001 From: Rishi Raj Date: Mon, 23 Oct 2023 06:22:44 +0530 Subject: [PATCH 1/3] Extended libiberty to output X86_64 relocations Signed-off-by: Rishi Raj --- include/sim

Re: [PATCH v1] RISC-V: Remove unnecessary asm check for rounding autovec

LGTM. Thanks. juzhe.zh...@rivai.ai From: pan2.li Date: 2023-10-23 10:39 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v1] RISC-V: Remove unnecessary asm check for rounding autovec From: Pan Li The vsetvl asm check is unnecessary for the rounding functio

[PATCH v1] RISC-V: Remove unnecessary asm check for rounding autovec

From: Pan Li The vsetvl asm check is unnecessary for the rounding function autovec. These rounding test cases should focus on the rounding insn sequence. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/autovec/unop/bswap16-0.c: Remove the vsetvl check. * gcc.target/riscv

Re: Re: [PATCH] RISC-V: Fix AVL_TYPE attribute of tuple mode mov

Hi, Jeff. (define_insn_and_split "*mov_" [(set (match_operand:VT 0 "reg_or_mem_operand" "=vr,vr, m") (match_operand:VT 1 "reg_or_mem_operand" " vr, m,vr")) (clobber (match_scratch:P 2 "=X,&r,&r")) (clobber (match_scratch:P 3 "=X,&r,&r")) (clobber (match_scratch:P 4 "=X,&r,&r"))

RE: [PATCH] RISC-V: Fix AVL_TYPE attribute of tuple mode mov

Committed, thanks Jeff. Pan -Original Message- From: Jeff Law Sent: Monday, October 23, 2023 10:24 AM To: Juzhe-Zhong ; gcc-patches@gcc.gnu.org Cc: kito.ch...@gmail.com; kito.ch...@sifive.com; rdapp@gmail.com Subject: Re: [PATCH] RISC-V: Fix AVL_TYPE attribute of tuple mode mov O

Re: [PATCH] RISC-V: Fix AVL_TYPE attribute of tuple mode mov

On 10/22/23 16:46, Juzhe-Zhong wrote: The tuple mode mov pattern doesn't have avl_type so it is invalid attribute. gcc/ChangeLog: * config/riscv/vector.md: Fix avl_type attribute of tuple mov. Presumably you got a fault or something similar trying to compute the avl_type attr when

[gccwwwdocs PATCH] gcc-13/14: Mention Intel new ISA and march support

Hi all, This patch mentions recent update for x86-64 backend, including ISAs enabled update on previous introduced CPU and newly introduced options/ISAs/CPUs. Ok for wwwdocs? Thx, Haochen --- htdocs/gcc-13/changes.html | 8 htdocs/gcc-14/changes.html | 19 +++ 2 files

[PATCH v1] LoongArch: Fix vfrint-releated comments in lsxintrin.h and lasxintrin.h

The comment of vfrint-related intrinsic functions does not match the return value type in definition. This patch fixes these comments. gcc/ChangeLog: * config/loongarch/lasxintrin.h (__lasx_xvftintrnel_l_s): Fix comments. (__lasx_xvfrintrne_s): Ditto. (__lasx_xvfrintrne_d)

RE: RE: [PATCH v1] RISC-V: Bugfix for merging undefined tmp register in math

Committed, thanks Juzhe. Pan From: juzhe.zh...@rivai.ai Sent: Monday, October 23, 2023 9:44 AM To: Li, Pan2 ; gcc-patches Cc: Wang, Yanzhang ; kito.cheng Subject: Re: RE: [PATCH v1] RISC-V: Bugfix for merging undefined tmp register in math OK。 LGTM。 juzhe.zh

Re: [PATCH] RISC-V: Prohibit combination of 'E' and 'H'

On 10/21/23 19:33, Tsukasa OI wrote: Hmm, I generally agree with your opinion and I made a board file for DejaGnu (running qemu-riscv64) to run "make check-gcc RUNTESTFLAGS='--target_board=riscv-sim riscv.exp'" because it already contains many execute tests (and annoys me if I don't do that)

Go patch committed: Remove the traverse_assignments code

This patch to the Go frontend removes the traverse_assignments support. The last caller was removed in https://go.dev/cl/18261 in 2016. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian a6e74b0b3316f3f0b2096d6a175c31bed58ae4ed diff --git a/gcc/go/gofrontend/MER

Go patch committed: Remove name_ field from Type_switch_statement

This patch to the Go frontend removes the name_ field from the Type_switch_statement class. It's not used for anything. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian 1a1fba1e25779247a4969789885ce80b7b4a2359 diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofr

Go patch committed: pass Gogo to more passes

This patch to the G frontend passes a pointer to the Gogo IR to the determine types pass and the type verification pass. This is a straight refactoring that does not change the compiler behavior. This is in preparation for future CLs that rearrange the pass ordering. This introduces one new call

Re: RE: [PATCH v1] RISC-V: Bugfix for merging undefined tmp register in math

OK。 LGTM。 juzhe.zh...@rivai.ai From: Li, Pan2 Date: 2023-10-23 09:42 To: juzhe.zh...@rivai.ai; gcc-patches CC: Wang, Yanzhang; kito.cheng Subject: RE: [PATCH v1] RISC-V: Bugfix for merging undefined tmp register in math Yes, it is required by the second cvt. The unmasked elements keep the ori

RE: [PATCH v1] RISC-V: Bugfix for merging undefined tmp register in math

Yes, it is required by the second cvt. The unmasked elements keep the original values. Pan From: juzhe.zh...@rivai.ai Sent: Monday, October 23, 2023 9:35 AM To: Li, Pan2 ; gcc-patches Cc: Li, Pan2 ; Wang, Yanzhang ; kito.cheng Subject: Re: [PATCH v1] RISC-V: Bugfix for merging undefined tmp

Re: [PATCH v1] RISC-V: Bugfix for merging undefined tmp register in math

UNARY_OP_TAMU_FRM_DYN = UNARY_OP_TAMU | FRM_DYN_P, UNARY_OP_TAMU_FRM_RUP = UNARY_OP_TAMU | FRM_RUP_P, UNARY_OP_TAMU_FRM_RDN = UNARY_OP_TAMU | FRM_RDN_P, Are they still necessary ? juzhe.zh...@rivai.ai From: pan2.li Date: 2023-10-23 09:26 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang

Re: [PATCH-1v4, expand] Enable vector mode for compare_by_pieces [PR111449]

Committed as r14-4835. https://gcc.gnu.org/g:f08ca5903c7a02b450b93143467f70b9fd8e0085 Thanks Gui Haochen 在 2023/10/20 16:49, Richard Sandiford 写道: > HAO CHEN GUI writes: >> Hi, >> Vector mode instructions are efficient for compare on some targets. >> This patch enables vector mode for compare

Re:[pushed] [PATCH] LoongArch: Define macro CLEAR_INSN_CACHE.

Pushed to r14-4836. 在 2023/10/20 下午3:15, Lulu Cheng 写道: LoongArch's microstructure ensures cache consistency by hardware. Due to out-of-order execution, ibar is required to ensure the visibility of the store (invalidated icache) executed by this CPU before ibar (to the instance). ibar will not i

[PATCH v1] RISC-V: Bugfix for merging undefined tmp register in math

From: Pan Li For math function autovec, there will be one step like rtx tmp = gen_reg_rtx (vec_int_mode); emit_vec_cvt_x_f (tmp, op_1, mask, UNARY_OP_TAMU_FRM_DYN, vec_fp_mode); The MU will leave the tmp (aka dest register) register unmasked elements unchanged and it is undefined here. This pat

RE: [PATCH v4] libgfortran: Replace mutex with rwlock

> > > Hi Thomas, > > > > > > > > Hi Lipeng, > > > > > > > May I know any comment or concern on this patch, thanks for your > > > > time > > > > 😄 > > > > > > Thanks for your patience in getting this reviewed. > > > > > > A few remarks / questions. > > > > > > Which strategy is used in this impleme

Re: [PATCH 2/5] LoongArch: Use explicit relocs for GOT access when -mexplicit-relocs=auto and LTO during a final link with linker plugin

在 2023/10/21 下午4:42, Xi Ruoyao 写道: On Sat, 2023-10-21 at 15:32 +0800, chenglulu wrote: +  /* If we are performing LTO for a final link, and we have the linker + plugin so we know the resolution of the symbols, then all GOT + references are binding to external symbols or preemptable sym

[PATCH 2/5] Support for CodeView debugging format

This patch and the following add initial support for Microsoft's CodeView debugging format, as used by MSVC, to mingw targets. Note that you will need a recent version of binutils for this to be useful. The best way to view the output is to run Microsoft's cvdump.exe, found in their microsoft-pdb

[PATCH 4/5] Output line numbers in CodeView section

Outputs the DEBUG_S_LINES block in the CodeView .debug$S section, which maps between line numbers and addresses. You'll need a fairly recent version of GAS for the .secidx directive to be recognized. --- gcc/dwarf2codeview.cc | 303 ++ gcc/dwarf2codeview.h

[PATCH 3/5] Output file checksums in CodeView section

Outputs the file name and MD5 hash of the main source file into the CodeView .debug$S section, along with that of any #include'd files. --- gcc/dwarf2codeview.cc | 254 ++ gcc/dwarf2codeview.h | 1 + gcc/dwarf2out.cc | 3 + 3 files changed, 258 ins

[PATCH 5/5] Output S_COMPILE3 symbol in CodeView debug section

Outputs the S_COMPILE3 symbol in the CodeView .debug$S debug section. The DEBUG_S_SYMBOLS block added here makes up pretty much everything that isn't data structures or line numbers; we add the S_COMPILE3 symbol here to start it off. This is a descriptive bit, the most interesting part of which is

[PATCH 1/5] Remove obsolete debugging formats from names list

STABS and xcoff have been removed, but are still in debug_type_names, which ought to match debug_type_masks. This results in the following minor bug with GCC 13: $ x86_64-pc-linux-gnu-gcc -gvms -c tmp.c cc1: error: target system does not support the ‘dwarf-2’ debug format --- gcc/opts.cc | 4 ++--

[PATCH] RISC-V: Fix AVL_TYPE attribute of tuple mode mov

The tuple mode mov pattern doesn't have avl_type so it is invalid attribute. gcc/ChangeLog: * config/riscv/vector.md: Fix avl_type attribute of tuple mov. --- gcc/config/riscv/vector.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/config/riscv/vector.md b/g

[Committedv2] aarch64: [PR110986] Emit csinv again for `a ? ~b : b`

After r14-3110-g7fb65f10285, the canonical form for `a ? ~b : b` changed to be `-(a) ^ b` that means for aarch64 we need to add a few new insn patterns to be able to catch this and change it to be what is the canonical form for the aarch64 backend. A secondary pattern was needed to support a zero_e

[PATCH] Use error_mark_node after error in convert

While working on PR c/111903, I Noticed that convert will convert integer_zero_node to that type after an error instead of returning error_mark_node. >From what I can tell this was the old way of not having error recovery since other places in this file does return error_mark_node and the places I

Re: Darwin: Replace environment runpath with embedded [PR88590]

Thanks a lot Alexandre for the review! FX

[committed] d: Merge upstream dmd f4be7f6f7b.

Hi, This patch merges the D front-end with upstream dmd f4be7f6f7b. Synchronizing with the upstream development branch as of 2023-10-22. D front-end changes: - Fix bootstrap failure with i686-darwin9. ``` Undefined symbols for architecture i386: "gendocfile", reference

[pushed] objc++: type/expr tsubst conflation [PR111920]

Bootstrapped and regtested on x86_64-pc-linux-gnu, pushed to trunk as obvious. -- >8 -- After r14-4796-g3e3d73ed5e85e7, tsubst_copy_and_build (now named tsubst_expr) no longer dispatches to tsubst for type trees, and callers have to do it themselves if appropriate. This patch makes some overlook

Re: [PATCH] libstdc++ Add cstdarg to freestanding

"Paul M. Bendixen" writes: > Updated patch, added the requested files, hopefully wrote the commit better. LGTM. Jonathan? -- Arsen Arsenović signature.asc Description: PGP signature

Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE

On 22 October 2023 21:45:12 CEST, Jeff Law wrote: > > >On 10/22/23 10:09, Andrew Pinski wrote: >> On Sun, Oct 22, 2023 at 12:47 AM Florian Weimer wrote: >>> >>> Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. >>> Defining the macro avoids an implicit function declaration. >>

Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE

On 10/22/23 10:09, Andrew Pinski wrote: On Sun, Oct 22, 2023 at 12:47 AM Florian Weimer wrote: Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. Defining the macro avoids an implicit function declaration. This does not help targets that don't use glibc though. Note for bu

Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE

On Sun, Oct 22, 2023 at 12:47 AM Florian Weimer wrote: > > Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. > Defining the macro avoids an implicit function declaration. This does not help targets that don't use glibc though. Note for builtins testsuite there is a lib-fputs.c fi

Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE

On 10/22/23 01:47, Florian Weimer wrote: Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. Defining the macro avoids an implicit function declaration. gcc/testsuite/ * gcc.c-torture/execute/builtins/fputs.c (_GNU_SOURCE): Define. OK jeff

Re: [PATCH] gcc.c-torture/execute/builtins/pr93262-chk.c: Remove return statement

On 10/22/23 01:46, Florian Weimer wrote: The main_test function returns void, so return with an expression is a constraint violation. The test case still fails with this change applied before the fix for PR 93262 in r14-4813. gcc/testsuite/ * gcc.c-torture/execute/builtins/pr93262-c

Re: [PATCH] wwwdocs: gcc-14: mark amdgcn fiji deprecated

Hi Andrew, On Fri, 20 Oct 2023, Andrew Stubbs wrote: >> Additionally, I wonder whether "Fiji" should be changed to "Fiji >> (gfx803)" in the first line and whether the  "," should be removed in >> "The ... configuration ... , and no longer includes". > Fair enough, how's this version? (I like the

Re: [PATCH v23 31/33] libstdc++: Optimize std::is_pointer compilation performance

Hi Patrick, There is an issue with the code in libstdc++-v3/include/bits/cpp_type_traits.h. Specifically, Clang 16 does not accept the code, while Clang 17 does. Given that we aim to support the last two versions of Clang, we need to ensure that Clang 16 accepts this code. Can you please advise on

[PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE

Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. Defining the macro avoids an implicit function declaration. gcc/testsuite/ * gcc.c-torture/execute/builtins/fputs.c (_GNU_SOURCE): Define. --- gcc/testsuite/gcc.c-torture/execute/builtins/fputs.c | 1 + 1 file ch

[PATCH] gcc.c-torture/execute/builtins/pr93262-chk.c: Remove return statement

The main_test function returns void, so return with an expression is a constraint violation. The test case still fails with this change applied before the fix for PR 93262 in r14-4813. gcc/testsuite/ * gcc.c-torture/execute/builtins/pr93262-chk.c (main_test): Remove unnecessary r