Re: [PATCH] PowerPC: Don't assume all targets have GLIBC

On Fri, Oct 30, 2020 at 06:39:16PM -0500, Segher Boessenkool wrote: > On Fri, Oct 30, 2020 at 06:50:30PM -0400, Michael Meissner wrote: > > On Fri, Oct 30, 2020 at 03:54:06PM -0500, Segher Boessenkool wrote: > > > But, time will fix all problems here. So, okay for trunk. Thanks! > > > > Note, I

Re: [committed] libstdc++: Use double for unordered container load factors [PR 96958]

On 31/10/20 00:23 +, Jonathan Wakely wrote: These calculations were changed to use long double nearly ten years ago in order to get more precision than float: https://gcc.gnu.org/pipermail/libstdc++/2011-September/036420.html However, double should be sufficient, whlie being potentially fast

[r11-4578 Regression] FAIL: gcc.target/i386/zero-scratch-regs-31.c (test for excess errors) on Linux/x86_64

On Linux/x86_64, d10f3e900b0377b4760a090b0f90371bcef01686 is the first bad commit commit d10f3e900b0377b4760a090b0f90371bcef01686 Author: qing zhao Date: Fri Oct 30 20:41:38 2020 +0100 Add -fzero-call-used-regs option and zero_call_used_regs function attributes. caused FAIL: gcc.target/

[committed] libstdc++: Use double for unordered container load factors [PR 96958]

These calculations were changed to use long double nearly ten years ago in order to get more precision than float: https://gcc.gnu.org/pipermail/libstdc++/2011-September/036420.html However, double should be sufficient, whlie being potentially faster than long double, and not requiring soft FP cal

[committed] libstdc++: Fix some more warnings in test

libstdc++-v3/ChangeLog: * testsuite/23_containers/vector/bool/modifiers/insert/31370.cc: Avoid -Wcatch-value warnings. Tested powerpc64le-linux. Committed to trunk. commit d1e5d82af819025df9d9a81e8c591690e299924a Author: Jonathan Wakely Date: Fri Oct 30 10:47:25 2020 libs

[committed] libstdc++: Implement P2017R1 "Conditionally borrowed ranges"

This makes some range adaptors model the borrowed_range concept if they are adapting a borrowed range. This hasn't been added to the C++23 working paper yet, but it has been approved by LWG, and the recommendation is to treat it as a defect report for C++20 as well. libstdc++-v3/ChangeLog:

Re: [PATCH] PowerPC: Don't assume all targets have GLIBC

On Fri, Oct 30, 2020 at 06:50:30PM -0400, Michael Meissner wrote: > On Fri, Oct 30, 2020 at 03:54:06PM -0500, Segher Boessenkool wrote: > > But, time will fix all problems here. So, okay for trunk. Thanks! > > Note, I discovered the ABI is not set to ELFv2 at the time the test is done, > so > I

Re: [patch] Fixing ppc64 test failure after patch dealing with scratches in IRA

Hi! On Fri, Oct 30, 2020 at 03:19:12PM -0400, Vladimir Makarov wrote: >   The following patch fixes failures for test p9-extract-2.c on > ppc64.  The failures are a result of committing patch dealing with insn > scratches in IRA.  The pseudo corresponding the 1st scratch in the > following insn ge

Re: [PATCH] PowerPC: Don't assume all targets have GLIBC

On Fri, Oct 30, 2020 at 03:54:06PM -0500, Segher Boessenkool wrote: > But, time will fix all problems here. So, okay for trunk. Thanks! Note, I discovered the ABI is not set to ELFv2 at the time the test is done, so I removed that part of the test. This is the patch I committed: >From f03851e1

Re: [PATCH] Treat { 0 } specially for structs with the designated_init attribute.

Joseph Myers writes: > I've tested and committed the first patch. Great, thanks! > The second one introduces some test failures: > > [...] > > Could you investigate those and send versions of the second and third > patches that don't introduce any test regressions? I've also found a more serio

Re: [PATCH] libstdc++: Don't initialize from *this inside some views [PR97600]

On 30/10/20 11:11 -0400, Patrick Palka via Libstdc++ wrote: This works around a subtle issue where instantiating the begin()/end() member of some views (as part of return type deduction) inadvertently requires computing the satisfaction value of range. This is problematic because the constraint

RE: [PATCH] rs6000, vector integer multiply/divide/modulo instructions

On Fri, 2020-10-30 at 17:05 -0400, David Edelsohn wrote: > On Fri, Oct 30, 2020 at 4:07 PM Carl Love wrote: > > > diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10- > > runnable.c b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10- > > runnable.c > > new file mode 100644 > > index 0

Re: [PATCH] rs6000, vector integer multiply/divide/modulo instructions

On Fri, Oct 30, 2020 at 4:07 PM Carl Love wrote: > diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c > new file mode 100644 > index 000..549bc742d12 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/power

Re: [PATCH] PowerPC: Don't assume all targets have GLIBC

On Fri, Oct 30, 2020 at 04:00:30PM -0400, Michael Meissner wrote: > On Fri, Oct 30, 2020 at 01:52:13PM -0500, Segher Boessenkool wrote: > > On Fri, Oct 30, 2020 at 01:21:34PM -0400, Michael Meissner wrote: > > > David reminded me that not all targets support GLIBC. This patch should > > > fix my

Re: [PATCH] c++: Disable -Winit-list-lifetime in unevaluated operand [PR97632]

On 10/29/20 10:35 PM, Marek Polacek wrote: Jon suggested turning this warning off when we're not actually evaluating the operand. This patch does that. Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? OK. gcc/cp/ChangeLog: PR c++/97632 * init.c (build_new_1): Di

Re: [PATCH v2] c++: Implement -Wvexing-parse [PR25814]

On 10/29/20 11:00 PM, Marek Polacek wrote: On Thu, Oct 29, 2020 at 02:25:33PM -0400, Jason Merrill via Gcc-patches wrote: On 10/29/20 2:11 PM, Marek Polacek wrote: On Thu, Oct 29, 2020 at 11:17:37AM -0400, Jason Merrill via Gcc-patches wrote: On 10/28/20 7:40 PM, Marek Polacek wrote: On Wed,

Re: [PATCH] c++: Tweaks for value_dependent_expression_p.

On 10/29/20 10:36 PM, Marek Polacek wrote: We may not call value_dependent_expression_p on expressions that are not potential constant expressions, otherwise value_d could crash, as I saw recently (in C++98). So beef up the checking in i_d_e_p. This revealed a curious issue: when we have __PRET

[PATCH] rs6000, vector integer multiply/divide/modulo instructions

GCC maintainers: The following patch adds new builtins for the vector integer multiply, divide and modulo operations. The builtins are: vec_mulh(), vec_div(), vec_dive(), vec_mod() for signed and unsigned integers and long long integers. Support for signed and unsigned long long integers the e

Re: [PATCH] i386: Cleanup i386/i386elf.h and align it's return convention with the SVR4 ABI

> As observed a number of years ago in the following thread, i386/i386elf.h has > not been > kept up to date: > > https://gcc.gnu.org/pipermail/gcc/2013-August/209981.html > > This patch does the following cleanup: > > 1. The return convention now follows the i386 and x86_64 SVR4 ABIs again. As >

Re: [PATCH] PowerPC: Don't assume all targets have GLIBC

On Fri, Oct 30, 2020 at 01:52:13PM -0500, Segher Boessenkool wrote: > On Fri, Oct 30, 2020 at 01:21:34PM -0400, Michael Meissner wrote: > > David reminded me that not all targets support GLIBC. This patch should > > fix my > > previous committed patch not to use TARGET_GLIBC_MAJOR or TARGET_GLIBC

Re: [PATCH] aarch64: Add backend support for expanding __builtin_memset

Sudakshina Das writes: >> > + >> > + /* "Cast" the *dst to the correct mode. */ >> > + *dst = adjust_address (*dst, mode, 0); >> > + /* Emit the memset. */ >> > + emit_move_insn (*dst, reg); >> > + /* Move the pointer forward. */ >> > + *dst = aarch64_progress_pointer (*dst); } >> > + >>

Re: [PATCH][middle-end][i386][version 6]Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-gpr-arg|all-arg|used-gpr|all-gpr|used|all]

FYI. I just committed the patch to gcc11 as: https://gcc.gnu.org/pipermail/gcc-cvs/2020-October/336263.html Qing

Re: [PATCH] i386: Set the stack usage to 0 for naked functions

> -fstack-usage raises a "stack usage computation not supported for this target" > warning when it encounters a naked function because the prologue returns early > for naked function on i386. This patch sets the stack usage to zero for naked > function, following the fix done for Arm by Eric Botcaz

[patch] Fixing ppc64 test failure after patch dealing with scratches in IRA

  The following patch fixes failures for test p9-extract-2.c on ppc64.  The failures are a result of committing patch dealing with insn scratches in IRA.  The pseudo corresponding the 1st scratch in the following insn get unexpected register class (general regs) and unexpected insn alternative (th

[committed] avoid creating inverted ranges in access_ref::add_offset (PR 97556)

access_ref::add_offset() works hard to restore the property that the lower bound of a range is less than or equal to its upper bound. But by capping the upper bound to at most PTRDIFF_MAX without also considering the lower bound, it allows the latter to exceed the value of the former, thus violat

[committed] patch to deal with insn scratches in global RA

 The following patch implements taking insn scratch requirements into account in global RA (IRA).  Before the patch IRA simply ignored insn scratches.  Only LRA took the scratches into account and assigned hard registers to scratches if neccessary.  In some cases it resulted in spilling pseudos wh

ipa-cp: New debug counters for IPA-CP

Hi, Martin Liška has been asking me to add debug counters to the IPA-CP pass so that testcase reductions are easier. The pass already has one for the bit value propagation, so this patch adds one for value_range propagation and one for the actual constant propagation. Passed bootstrap and testin

Re: [PATCH] PowerPC: Don't assume all targets have GLIBC

On Fri, Oct 30, 2020 at 01:21:34PM -0400, Michael Meissner wrote: > David reminded me that not all targets support GLIBC. This patch should fix > my > previous committed patch not to use TARGET_GLIBC_MAJOR or TARGET_GLIBC_MINOR > unless they are defined. > + This support is only in little endi

Re: [PATCH] Fix gnu-versioned-namespace build

On 30/10/20 18:51 +0100, François Dumont wrote: On 30/10/20 2:37 pm, Jonathan Wakely wrote: On 30/10/20 13:23 +, Jonathan Wakely wrote: On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc

Re: [PATCH] rs6000, Add bcd builtings listed in appendix B of the ABI

Hi! On Fri, Oct 30, 2020 at 09:36:13AM -0700, Carl Love wrote: > On Wed, 2020-10-28 at 20:43 -0400, David Edelsohn wrote: > > Better, but please use > > > > /* { dg-require-effective-target int128 } */ > > > > not "target int128" in the selector. Segher and I both agree that > > it's cleaner an

RE: [PATCH] aarch64: Add backend support for expanding __builtin_memset

Hi Richard Thank you for the review. Please find my comments inlined. > -Original Message- > From: Richard Sandiford > Sent: 30 October 2020 15:03 > To: Sudakshina Das > Cc: gcc-patches@gcc.gnu.org; Kyrylo Tkachov ; > Richard Earnshaw > Subject: Re: [PATCH] aarch64: Add backend support

Re: [PATCH] Fix gnu-versioned-namespace build

On 30/10/20 2:37 pm, Jonathan Wakely wrote: On 30/10/20 13:23 +, Jonathan Wakely wrote: On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the fix i

Re: [PATCH] rs6000, Add bcd builtings listed in appendix B of the ABI

On Fri, Oct 30, 2020 at 12:36 PM Carl Love wrote: > > David: > > On Wed, 2020-10-28 at 20:43 -0400, David Edelsohn wrote: > > Better, but please use > > > > /* { dg-require-effective-target int128 } */ > > > > not "target int128" in the selector. Segher and I both agree that > > it's cleaner and

[PATCH] PowerPC: Don't assume all targets have GLIBC

PowerPC: Don't assume all targets have GLIBC. David reminded me that not all targets support GLIBC. This patch should fix my previous committed patch not to use TARGET_GLIBC_MAJOR or TARGET_GLIBC_MINOR unless they are defined. I have done a bootstrap on a little endian power9 system and it was f

Re: [nvptx, committed] Force vl32 if calling vector-partitionable routines

Hi Tom! On 2019-01-07T20:11:59+0100, Tom de Vries wrote: > [nvptx] Force vl32 if calling vector-partitionable routines > > With PTX_MAX_VECTOR_LENGTH set to larger than PTX_WARP_SIZE, routines can be > called from offloading regions with vector-size set to larger than warp size. > OTOH, vector-pa

RE: [PATCH] rs6000, Add bcd builtings listed in appendix B of the ABI

David: On Wed, 2020-10-28 at 20:43 -0400, David Edelsohn wrote: > Better, but please use > > /* { dg-require-effective-target int128 } */ > > not "target int128" in the selector. Segher and I both agree that > it's cleaner and more readable. The selector (the target part on the > dg-do line) s

Re: [PATCH 6/9] [nvptx] Force vl32 if calling vector-partitionable routines -- test-cases

On 10/30/20 5:16 PM, Thomas Schwinge wrote: > Hi Tom! > > While working on something completely different, I had to dig deeper, and > noticed a thing there, and deeper, and notice another thing, and deeper, > and noticed this other thing here... (So, business as usual...) ;-) > > On 2019-01-12T

Re: [PATCH 6/9] [nvptx] Force vl32 if calling vector-partitionable routines -- test-cases

Hi Tom! While working on something completely different, I had to dig deeper, and noticed a thing there, and deeper, and notice another thing, and deeper, and noticed this other thing here... (So, business as usual...) ;-) On 2019-01-12T23:21:28+0100, Tom de Vries wrote: > --- /dev/null > +++

[Patch, committed] – was: [Patch] testsuite: Avoid TCL errors when rootme or ASAN/TSAN/UBSAN is not available

I have now committed it as obvious. Tobias On 19.10.20 18:03, Tobias Burnus wrote: [...] On 10/19/20 11:46 AM, Tobias Burnus wrote: In a --disable-libsanitizer build, I see errors such as: g++.sum:ERROR: can't read "asan_saved_library_path": no such variable [...] - Mentor G

Re: [PATCH v7] genemit.c (main): split insn-emit.c for compiling parallelly

Jojo R writes: > Jojo > 在 2020年10月27日 +0800 PM10:14，Richard Sandiford ，写道： >> Jojo R writes: >> > gcc/ChangeLog: >> > >> > * genemit.c (main): Print 'split line'. >> > * Makefile.in (insn-emit.c): Define split count and file >> > >> > --- >> > gcc/Makefile.in | 19 + >> > gcc/genemit.c | 1

[PATCH] libstdc++: Don't initialize from *this inside some views [PR97600]

This works around a subtle issue where instantiating the begin()/end() member of some views (as part of return type deduction) inadvertently requires computing the satisfaction value of range. This is problematic because the constraint range requires the begin()/end() member to be callable. But i

Re: [PATCH] aarch64: Add backend support for expanding __builtin_memset

Sudakshina Das writes: > diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h > index > 00b5f8438863bb52c348cfafd5d4db478fe248a7..bcb654809c9662db0f51fc1368e37e42969efd29 > 100644 > --- a/gcc/config/aarch64/aarch64.h > +++ b/gcc/config/aarch64/aarch64.h > @@ -1024,16 +1024,18

[PATCH] i386: Set the stack usage to 0 for naked functions

-fstack-usage raises a "stack usage computation not supported for this target" warning when it encounters a naked function because the prologue returns early for naked function on i386. This patch sets the stack usage to zero for naked function, following the fix done for Arm by Eric Botcazou: ht

Re: [PATCH][middle-end][i386][version 6]Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-gpr-arg|all-arg|used-gpr|all-gpr|used|all]

> On Oct 30, 2020, at 4:54 AM, Richard Sandiford > wrote: > > Qing Zhao writes: >> @@ -3996,22 +3996,19 @@ with a named @code{target} must be @code{static}. >> @cindex @code{zero_call_used_regs} function attribute >> >> The @code{zero_call_used_regs} attribute causes the compiler to zero >>

Re: Revert "[nvptx, libgomp] Update pr85381-{2,4}.c test-cases" [PR89713, PR94392] (was: [PATCH][RFC] c/94392 - only enable -ffinite-loops for C++)

On Fri, Oct 30, 2020 at 03:09:31PM +0100, Thomas Schwinge wrote: > On 2020-04-03T13:34:18+0200, Jakub Jelinek wrote: > > Dunno about OpenACC, but OpenMP loops guarantee finiteness, as the number of > > iterations must be computable before the loop and must fit into the type in > > which that count

Re: [PATCH] Fix gnu-versioned-namespace build

On 30/10/20 13:38 +, Jonathan Wakely wrote: On 30/10/20 13:23 +, Jonathan Wakely wrote: On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the f

Re: Revert "[nvptx, libgomp] Update pr85381-{2, 4}.c test-cases" [PR89713, PR94392] (was: [PATCH][RFC] c/94392 - only enable -ffinite-loops for C++)

Hi! Frederik stumbled over a related thing. On 2020-04-03T12:36:29+0200, Richard Biener wrote: > On Fri, 3 Apr 2020, Thomas Schwinge wrote: >> On 2020-04-02T11:12:48+0200, Richard Biener wrote: >> > On Wed, 1 Apr 2020, Jason Merrill wrote: >> > >> >> On 4/1/20 9:36 AM, Richard Biener wrote: >>

Re: [PATCH][AArch64] ACLE intrinsics: get low/high half from BFloat16 vector

Dennis Zhang writes: > diff --git a/gcc/config/aarch64/aarch64-simd-builtins.def > b/gcc/config/aarch64/aarch64-simd-builtins.def > index 332a0b6b1ea..39ebb776d1d 100644 > --- a/gcc/config/aarch64/aarch64-simd-builtins.def > +++ b/gcc/config/aarch64/aarch64-simd-builtins.def > @@ -719,6 +719,9 @@

Re: [PATCH, OpenMP 5.0] Implement structure element mapping changes in 5.0

On Mon, Oct 26, 2020 at 09:10:08AM +0100, Jakub Jelinek via Gcc-patches wrote: > Yes, it is a QoI and it is important not to regress about that. > Furthermore, the more we diverge from what the spec says, it will be harder > for us to implement, not just now, but in the future too. > What I wrote a

Re: [RFC] Add support for the "retain" attribute utilizing SHF_GNU_RETAIN

On Mon, Oct 26, 2020 at 07:08:06PM +, Pedro Alves via Gcc-patches wrote: > On 10/6/20 12:10 PM, Jozef Lawrynowicz wrote: > > > Should "used" apply SHF_GNU_RETAIN? > > === > > Another talking point is whether the existing "used" attribute should > > apply the SHF

Re: [PATCH] calls.c:can_implement_as_sibling_call_p REG_PARM_STACK_SPACE check

On Fri, Oct 30, 2020 at 09:21:09AM +, Richard Sandiford wrote: > Alan Modra via Gcc-patches writes: > > This moves an #ifdef block of code from calls.c to > > targetm.function_ok_for_sibcall. Only two targets, x86 and rs6000, > > define REG_PARM_STACK_SPACE or OUTGOING_REG_PARM_STACK_SPACE ma

Re: [RFC, testsuite] Add dg-save-linenr

Hi Jakub! On 2020-10-30T12:40:02+0100, Jakub Jelinek wrote: > On Fri, Oct 30, 2020 at 12:34:57PM +0100, Thomas Schwinge wrote: >> On 2017-05-22T18:55:29+0200, Tom de Vries wrote: >> > On 05/16/2017 03:12 PM, Rainer Orth wrote: >> >> [...], but the new proc ['dg-line'] needs documenting in source

Re: [PATCH] Fix gnu-versioned-namespace build

On 30/10/20 13:23 +, Jonathan Wakely wrote: On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the fix in sstream-inst.cc. The change for src/c++20

Re: [PATCH 1/5] [PR target/96342] Change field "simdlen" into poly_uint64

"yangyang (ET)" writes: > Although Richard mentioned in the PR that poly_uint64 will naturally > decay to a uint64_t in i386 target files, it seems that operation /= is not > supported yet, so I change "clonei->simdlen /= GET_MODE_BITSIZE (TYPE_MODE > (base_type));" into "clonei->simdle

Re: [PATCH] Fix gnu-versioned-namespace build

On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the fix in sstream-inst.cc. The change for src/c++20/sstream-inst.cc is OK to commit. It would probab

[Patch + RFC][contrib] gcc-changelog/git_commit.py: Check for missing description

In terms of issues, it seems as if Ubuntu 20.04.1 LTS has a too old unidiff – I copied the check from test_email.py and applied it to git_email.py – otherwise, nearly all tests fail. Still, I do see some fails – I have attached the fails I got. (fails.log, second attachment) Independent of that,

Re: [PING] [PATCH] S/390: Do not turn maybe-uninitialized warnings into errors

On Fri, Oct 30, 2020 at 11:09 AM Stefan Schulze Frielinghaus via Gcc-patches wrote: > > On Wed, Oct 28, 2020 at 11:34:53AM -0600, Jeff Law wrote: > > > > On 10/28/20 11:29 AM, Stefan Schulze Frielinghaus wrote: > > > On Wed, Oct 28, 2020 at 08:39:41AM -0600, Jeff Law wrote: > > >> On 10/28/20 3:38

[PATCH] Fix gnu-versioned-namespace build

The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the fix in sstream-inst.cc.     libstdc++: Fix gnu-version-namespace buid     libstdc++-v3/ChangeLog     * include/std/charconv (from_chars): Define only i

Re: [PATCH] arm: Fix multiple inheritance thunks for thumb-1 with -mpure-code

On 29/10/2020 19:18, Richard Earnshaw via Gcc-patches wrote: > On 28/10/2020 18:10, Christophe Lyon via Gcc-patches wrote: >> On Wed, 28 Oct 2020 at 18:44, Richard Earnshaw >> wrote: >>> >>> On 27/10/2020 15:42, Richard Earnshaw via Gcc-patches wrote: On 26/10/2020 10:52, Christophe Lyon via

Re: [PATCH] libstdc++: Implement C++20 features for

Hi Jonathan, > On 29/10/20 21:06 +0100, Rainer Orth wrote: >>Tightening the patterns as in the attached patch at least allows >>libstdc++.so.6 to link on i386-pc-solaris2.11; full bootstrap still >>running. However, I can't tell if this is really correct. > > I think we want this attached patch i

[PATCH] tree-optimization/97623 - avoid excessive insert iteration for hoisting

This avoids requiring insert iteration for back-to-back hoisting opportunities as seen in the added testcase. For the PR at hand this halves the number of insert iterations retaining only the hard to avoid PRE / hoist insert back-to-backs. Bootstrap and regtest running on x86_64-unknown-linux-gnu

Re: [RFC, testsuite] Add dg-save-linenr

On Fri, Oct 30, 2020 at 12:34:57PM +0100, Thomas Schwinge wrote: > Hi! > > On 2017-05-22T18:55:29+0200, Tom de Vries wrote: > > On 05/16/2017 03:12 PM, Rainer Orth wrote: > >> [...], but the new proc ['dg-line'] needs documenting in sourcebuild.texi. > > > > Attached patch adds the missing docume

Re: [Patch] Fortran: Update omp atomic for OpenMP 5

On Thu, Oct 29, 2020 at 06:05:41PM +0100, Tobias Burnus wrote: > gcc/fortran/ChangeLog: > > * dump-parse-tree.c (show_omp_clauses): Handle atomic clauses. > (show_omp_node): Call it for atomic. > * gfortran.h (enum gfc_omp_atomic_op): Add GFC_OMP_ATOMIC_UNSET, > remove GFC_

Re: [RFC, testsuite] Add dg-save-linenr

Hi! On 2017-05-22T18:55:29+0200, Tom de Vries wrote: > On 05/16/2017 03:12 PM, Rainer Orth wrote: >> [...], but the new proc ['dg-line'] needs documenting in sourcebuild.texi. > > Attached patch adds the missing documentation. OK to expand that with the attached patch to "Document that 'linenumv

[PATCH] tree-optimization/97626 - handle SCCs properly in SLP stmt analysis

This makes sure to roll-back the whole SCC when we fail stmt analysis, otherwise the optimistic visited treatment breaks down with different entries. Rollback is easy when tracking additions to visited in a vector which also makes the whole thing cheaper than the two hash-sets used before. Bootst

Re: libgomp testsuite: tell warning from error diagnostics, etc. [PR80219, PR85303]

On Fri, Oct 30, 2020 at 12:22:31PM +0100, Thomas Schwinge wrote: > Turns out that GCC PR85303 "[testsuite, libgomp] dg-message not > supported" is the very same problem as (the libgomp aspect of) GCC > PR80219 "relative line numbers only working if gcc_{error,warning}_prefix > defined" (see rationa

libgomp testsuite: tell warning from error diagnostics, etc. [PR80219, PR85303]

Hi! Turns out that GCC PR85303 "[testsuite, libgomp] dg-message not supported" is the very same problem as (the libgomp aspect of) GCC PR80219 "relative line numbers only working if gcc_{error,warning}_prefix defined" (see rationale in there). OK to push the attached patch for "libgomp testsuite:

Re: [Patch, Fortran] PR 92793 - fix column used for error diagnostic

Hi Thomas, On 30.10.20 11:47, Thomas Schwinge wrote: Fixed by introducing a new function; now one only needs to make sure that no new code will re-introduce "lb->location":-) ... another*existing instance* of this problem. ... gfc_set_backend_locus (locus * loc) { gfc_current_backend

[committed] openmp: Use FIELD_TGT_EMPTY once more

Hi! I have noticed one extra spot which should be using the FIELD_TGT_EMPTY macro (defined to (~(size_t) 0)), but didn't. Fixed thusly, committed to trunk. 2020-10-30 Jakub Jelinek * target.c (gomp_map_vars_internal): Use FIELD_TGT_EMPTY macro even in field_tgt_clear initiali

Re: [Patch, Fortran] PR 92793 - fix column used for error diagnostic

Hi! On 2020-10-30T11:35:15+0100, I wrote: > On 2019-12-04T14:37:55+0100, Tobias Burnus wrote: >> As reported internally by Frederik, gfortran currently passes >> LOCATION_COLUMN == 0 to the middle end. The reason for that is how >> parsing works – gfortran reads the input line by line. >> >> For

Re: [Patch, Fortran] PR 92793 - fix column used for error diagnostic

Hi! On 2019-12-04T14:37:55+0100, Tobias Burnus wrote: > As reported internally by Frederik, gfortran currently passes > LOCATION_COLUMN == 0 to the middle end. The reason for that is how > parsing works – gfortran reads the input line by line. > > For internal error diagnostic (fortran/error.c),

Re: [PATCH] libstdc++: Fix the default constructor of ranges::__detail::__box

On 29/10/20 19:48 -0400, Patrick Palka via Libstdc++ wrote: On Thu, 29 Oct 2020, Patrick Palka wrote: The class template semiregular-box of [range.semi.wrap] is specified to value-initialize the underlying object whenever its type is default- initializable. Our primary template for __detail::_

[PATCH][pushed] gcc-changelog: Handle situations like '* tree-vect-slp.c (): '

I've just pusted that. contrib/ChangeLog: * gcc-changelog/git_commit.py: Handle empty groups in file description. * gcc-changelog/test_email.py: New test. * gcc-changelog/test_patches.txt: Likewise. --- contrib/gcc-changelog/git_commit.py| 7 + contrib/g

Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions emitted at -O3

xiezhiheng writes: >> -Original Message- >> From: Richard Sandiford [mailto:richard.sandif...@arm.com] >> Sent: Monday, October 26, 2020 9:03 PM >> To: xiezhiheng >> Cc: Richard Biener ; gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH PR94442] [AArch64] Redundant ldp/stp instructions >> em

Re: [PING] [PATCH] S/390: Do not turn maybe-uninitialized warnings into errors

On Wed, Oct 28, 2020 at 11:34:53AM -0600, Jeff Law wrote: > > On 10/28/20 11:29 AM, Stefan Schulze Frielinghaus wrote: > > On Wed, Oct 28, 2020 at 08:39:41AM -0600, Jeff Law wrote: > >> On 10/28/20 3:38 AM, Stefan Schulze Frielinghaus via Gcc-patches wrote: > >>> On Mon, Oct 05, 2020 at 02:02:57PM

Re: [PATCH][middle-end][i386][version 6]Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-gpr-arg|all-arg|used-gpr|all-gpr|used|all]

Qing Zhao writes: > @@ -3996,22 +3996,19 @@ with a named @code{target} must be @code{static}. > @cindex @code{zero_call_used_regs} function attribute > > The @code{zero_call_used_regs} attribute causes the compiler to zero > -a subset of all call-used registers at function return according to

[PATCH] tree-optimization/97633 - fix SLP scheduling of single-node cycles

This makes sure to update backedges in single-node cycles. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-10-30 Richard Biener PR tree-optimization/97633 * tree-vect-slp.c (): Update backedges in single-node cycles. Optimize processing of externals

Re: [PATCH] SLP vectorize across PHI nodes

On Fri, 30 Oct 2020, Richard Sandiford wrote: > Richard Biener writes: > > On Wed, 28 Oct 2020, Christophe Lyon wrote: > > > >> On Wed, 28 Oct 2020 at 11:27, Christophe Lyon > >> wrote: > >> > > >> > On Tue, 27 Oct 2020 at 13:18, Richard Biener wrote: > >> > > > >> > > This makes SLP discovery

[PATCH v8] genemit.c (main): split insn-emit.c for compiling parallelly

gcc/ChangeLog: * genemit.c (main): Print 'split line'. * Makefile.in (insn-emit.c): Define split count and file --- gcc/Makefile.in | 33 +++ gcc/genemit.c | 104 +--- 2 files changed, 89 insertions(+), 48 deletions(-) d

Re: [PATCH v7] genemit.c (main): split insn-emit.c for compiling parallelly

Jojo 在 2020年10月27日 +0800 PM10:14，Richard Sandiford ，写道： > Jojo R writes: > > gcc/ChangeLog: > > > > * genemit.c (main): Print 'split line'. > > * Makefile.in (insn-emit.c): Define split count and file > > > > --- > > gcc/Makefile.in | 19 + > > gcc/genemit.c | 104

Re: [PATCH] SLP vectorize across PHI nodes

Richard Biener writes: > On Wed, 28 Oct 2020, Christophe Lyon wrote: > >> On Wed, 28 Oct 2020 at 11:27, Christophe Lyon >> wrote: >> > >> > On Tue, 27 Oct 2020 at 13:18, Richard Biener wrote: >> > > >> > > This makes SLP discovery detect backedges by seeding the bst_map with >> > > the node to b

[committed] aarch64: Fix PR96998 and restore code quality in combine

This patch fixes a bug in the AArch64 backend. Currently, we accept an odd sign_extract representation of addresses, but don't accept that same odd form of address as an LEA. This is the cause of PR96998. In the testcase given in the PR, combine produces: (insn 9 8 10 3 (set (mem:SI (plus:DI (sig

Re: [PATCH] calls.c:can_implement_as_sibling_call_p REG_PARM_STACK_SPACE check

Alan Modra via Gcc-patches writes: > This moves an #ifdef block of code from calls.c to > targetm.function_ok_for_sibcall. Only two targets, x86 and rs6000, > define REG_PARM_STACK_SPACE or OUTGOING_REG_PARM_STACK_SPACE macros > that might vary depending on the called function. Macros like > UNI

[RS6000] Adjust testcases for power10 instructions V3

And now waking up to what you meant by the lvsl-lvsr.c \s comment, plus a revised ppc-ne0-1.c scan-assembler. I think this covers all previous review corrections. Regression tested powerpc64-linux power7 and powerpc64le-linux power10. OK? * lib/target-supports.exp (check_effective_targe

[committed] openmp: Fix handling of allocate clause on taskloop

Hi! This patch fixes gimplification of allocate clause on taskloop - puts allocate on inner taskloop only if there is allocate clause, because otherwise the data sharing clauses are only on the task construct in the construct sandwich. Bootstrapped/regtested on x86_64-linux and i686-linux, commi

Re: [PATCH] [tree-optimization] Fix for PR96701

On Fri, Oct 30, 2020 at 3:38 AM Eugene Rozenfeld via Gcc-patches wrote: > > This patch adds a pattern for folding > > x >> x > > to > > 0 > > as described in PR96701. > > > Without this patch the x86_64-pc-linux-gnu code generated for this function > > > > int > > foo

[committed] openmp: Handle non-static data members in allocate clause and other C++ allocate fixes

Hi! This allows specification of non-static data members in allocate clause like it can be specified in other privatization clauses and adds a new testcase that covers also handling of that clause in templates. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2020-10-3

Re: [EXTERNAL] Re: [PATCH] [tree-optimization] Fix for PR97223

On Thu, Oct 29, 2020 at 8:45 PM Eugene Rozenfeld wrote: > > Thank you for the review Richard! > > I re-worked the patch based on your suggestions. I combined the two patterns. > Neither one requires a signedness check as long as the type of the 'add' has > overflow wrap semantics. > > I had to m

Re: New modref/ipa_modref optimization passes

On Thu, 29 Oct 2020, Jan Hubicka wrote: > > Hi, > > this is patch I am using to fix the assumed_alias_type.f90 failure by > > simply arranging alias set 0 for the problematic array descriptor. > > > > I am not sure this is the best option, but I suppose it is better than > > setting all array des

[PATCH] Adjust gcc.dg/vect/bb-slp-pr65935.c

This adjusts the testcase to allow splitting up the group for larger vector sizes and thus printing the splat message multiple times. Pushed. 2020-10-30 Richard Biener * gcc.dg/vect/bb-slp-pr65935.c: Adjust. --- gcc/testsuite/gcc.dg/vect/bb-slp-pr65935.c | 2 +- 1 file changed, 1 ins