Hi Jakub!
On 2020-10-30T12:40:02+0100, Jakub Jelinek <ja...@redhat.com> wrote:
> On Fri, Oct 30, 2020 at 12:34:57PM +0100, Thomas Schwinge wrote:
>> On 2017-05-22T18:55:29+0200, Tom de Vries <tom_devr...@mentor.com> wrote:
>> > On 05/16/2017 03:12 PM, Rainer Orth wrote:
>> >> [...], but the new proc ['dg-line'] needs documenting in sourcebuild.texi.
>> >
>> > Attached patch adds the missing documentation.
>>
>> OK to expand that with the attached patch to "Document that 'linenumvar'
>> in 'dg-line' may contain Tcl syntax"? (Hooray for embedded Tcl! --
>> Don't hurt me; I (later) have a use case where this does make things
>> easier.)
>
> Is it desirable though?
I hear you.
> I mean if we ever decide to switch from dejagnu to something else,
> adding parsing of our dg-* grammar is not that hard, and while we rely
> on some tcl details already (e.g. the {}s vs. ""s for regular expressions
> etc.), allowing arbitrary embedded tcl will make that effort even harder.
(It's not much, but note that there already are some more "arbitrary"
Tcl-y idioms in the testsuite.)
I had considered the point you're making, but it's already many years
(decades?) that we (meaning: some?) would like to switch away from
DejaGnu (to what else -- QMTest apparently isn't it?) -- so, this isn't
going to happen next week. If we then ever port to something else, I'm
sure the new system will be likewise expressive/extensible. Thus I
decided to use the convenience now, and defer the potential (minor,
compared to the overall effort) complication until then.
Grüße
Thomas
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander
Walter
