[PATCH][AMDGCN] Skip test gcc/testsuite/gcc.dg/asm-4.c

2019-12-04 Thread Harwath, Frederik
Hi, the inline assembly "p" modifier ("An operand that is a valid memory address is allowed", cf. https://gcc.gnu.org/onlinedocs/gcc/Simple-Constraints.html#Simple-Constraints) is not supported on AMD GCN. This causes an ICE during the compilation of gcc.dg/asm-4.c. We should skip the test for t

libbacktrace patch committed: Declare test1 in edtest.c with noclone

2019-12-04 Thread Ian Lance Taylor
This libbacktrace patch adds the noclone attribute to the version of test1 in edtest.c, to correspond to other versions of test1. Bootstrapped and ran libbacktrace tests on x86_64-pc-linux-gnu. Committed to mainline. Ian 2019-12-04 Ian Lance Taylor * edtest.c (test1): Add noclone attribute. I

Re: [PATCH 01/13] Add support for gang local storage allocation in shared memory

2019-12-04 Thread Julian Brown
Hi! On Fri, 15 Nov 2019 13:41:11 -0800 Julian Brown wrote: > This patch provides support for gang local storage allocation in > shared memory. It is mostly identical to the version posted > previously, with one cosmetic fix (a duplicated identical condition): > > https://gcc.gnu.org/ml/gcc-patc

libbacktrace patch committed: Simplify DWARF section handling

2019-12-04 Thread Ian Lance Taylor
This libbacktrace patch simplifies the DWARF section handling. This is in preparation for DWARF 5 support, as DWARF 5 requires us to read more sections. Bootstrapped and ran libbacktrace and Go tests on x86_64-pc-linux-gnu. Committed to mainline. Ian 2019-12-04 Ian Lance Taylor * internal.

Re: [PATCH] Enable mask operation for 128/256-bit vector VCOND_EXPR under avx512f (PR92686)

2019-12-04 Thread Hongtao Liu
On Wed, Dec 4, 2019 at 4:22 PM Jakub Jelinek wrote: > > On Wed, Dec 04, 2019 at 10:07:05AM +0800, Hongtao Liu wrote: > > Changelog > > gcc/ > > PR target/92686 > > * config/i386/sse.md > > (*_cmp3, > > *_cmp3, > > *_ucmp3, > > *_ucmp3): New. > > * config/i

Re: [PATCH] extend -Wstringop-overflow to allocated objects (PR 91582)

2019-12-04 Thread Martin Sebor
On 12/2/19 10:06 AM, Jeff Law wrote: On 11/8/19 3:11 PM, Martin Sebor wrote: Unless it's used with _FORTIFY_SOURCE, -Wstringop-overflow doesn't consider out-of-bounds accesses to objects allocated by alloca, malloc, other functions declared with attribute alloc_size, or even VLAs with variable b

[PATCH] libstdc++: Define pretty printer for comparison categories

2019-12-04 Thread Jonathan Wakely
* python/libstdcxx/v6/printers.py (StdCmpCatPrinter): New printer. * testsuite/libstdc++-prettyprinters/cxx20.cc: New test. Tested x86_64-linux, committed to trunk. commit b41a87d7889f2399d4c1a0c626a656ba384e71a8 Author: Jonathan Wakely Date: Thu Dec 5 00:24:58 2019 +

[PATCH] libstdc++: Implement spaceship for std::array (P1614R2)

2019-12-04 Thread Jonathan Wakely
As done for std::pair, this defines operator<=> as a non-member function template and does not alter operator==, as expected to be proposed as the resolution to an unpublished LWG issue. Instead of calling std::lexicographical_compare_three_way the <=> overload is implemented by hand to take adva

Re: PowerPC V9 patches, Add the PCREL_OPT optimization

2019-12-04 Thread Alan Modra
On Wed, Dec 04, 2019 at 05:16:05PM -0600, Segher Boessenkool wrote: > > pla 9,ext_symbol@pcrel # add (0),1 for optional operands > > pla does not have optional operands like that? It does, just like load/store insns. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] add -Wmismatched-tags (PR 61339)

2019-12-04 Thread Jason Merrill
On 12/3/19 4:49 PM, Martin Sebor wrote: On 8/5/19 4:30 PM, Jason Merrill wrote: On Mon, Aug 5, 2019 at 5:50 PM Martin Sebor wrote: On 8/5/19 1:25 PM, Jason Merrill wrote: On 8/1/19 7:35 PM, Martin Sebor wrote: On 8/1/19 12:09 PM, Jason Merrill wrote: On 7/22/19 12:34 PM, Martin Sebor wrote

Re: [wwwdocs] Document some more C++20 support in libstdc++

2019-12-04 Thread Jonathan Wakely
I forgot about , so I actually committed this patch instead. commit 46f60e0689384ba6e58a9896b5831969940ac74b Author: Jonathan Wakely Date: Wed Dec 4 23:26:45 2019 + Document some more C++20 support in libstdc++ diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html ind

[wwwdocs] Document some more C++20 support in libstdc++

2019-12-04 Thread Jonathan Wakely
Committed. commit feb29e18726065475769568bf46860fada5c4257 Author: Jonathan Wakely Date: Wed Dec 4 23:26:45 2019 + Document some more C++20 support in libstdc++ diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index afbcd067..dadd3f22 100644 --- a/htdocs/gcc-10/c

Fix C handling of use of lvalues of incomplete types (PR c/36941, PR c/88827)

2019-12-04 Thread Joseph Myers
Bug 88827 points out that GCC should not be rejecting C code that dereferences a pointer to an incomplete type in the case that uses &* to take the address of the resulting lvalue, because no constraint is violated in that case (other than for C90 when the incomplete type is unqualified void, which

Re: PowerPC V9 patches, Add the PCREL_OPT optimization

2019-12-04 Thread Segher Boessenkool
Hi Alan, Thanks for looking, and for the corrections :-) On Thu, Dec 05, 2019 at 09:26:09AM +1030, Alan Modra wrote: > On Mon, Dec 02, 2019 at 06:07:23PM -0600, Segher Boessenkool wrote: > > Is that "paddi" syntax correct? I think you might mean > > "paddi 9,0,ext_symbol,1", aka "pla 9,ext_symbo

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Segher Boessenkool
On Wed, Dec 04, 2019 at 03:53:30PM -0600, Peter Bergner wrote: > On 12/4/19 2:50 PM, Segher Boessenkool wrote: > > It would be nice to keep *some* dfp test(s) to make sure we don't ICE. > > If we disabled all such tests already, like with this patch, we wouldn't > > have ICEd or seen this problem.

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Segher Boessenkool
On Wed, Dec 04, 2019 at 03:40:25PM -0600, Peter Bergner wrote: > On 12/4/19 2:47 PM, Iain Sandoe wrote: > > Peter Bergner wrote: > >> > >> Why isn't just testing check_effective_target_dfp enough to disable the > >> tests on Darwin, --disable-decimal-float, etc.? > > > > … It should be a better s

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Segher Boessenkool
On Wed, Dec 04, 2019 at 08:47:49PM +, Iain Sandoe wrote: > Peter Bergner wrote: > >On 12/4/19 1:16 PM, Segher Boessenkool wrote: > >>This isn't run from powerpc.exp, so it needs to still do that first check. > >>And it's up to the Darwin maintainers whether they want that second part > >>(ther

Re: [ PATCH ] [ C++ ] Implementing P0767 - deprecate POD

2019-12-04 Thread JeanHeyd Meneide
Dear Jonathan, Done! re-patched, below. Best, JeanHeyd 2019-12-03 JeanHeyd "ThePhD" Meneide * include/bits/c++config: Add new _GLIBCXX20_DEPRECATED macro. * include/std/type_traits: Deprecate is_pod with message. * testuite/20_util/is_pod/deprecated-2a.cc (new): t

Re: PowerPC V9 patches, Add the PCREL_OPT optimization

2019-12-04 Thread Alan Modra
On Mon, Dec 02, 2019 at 06:07:23PM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Nov 15, 2019 at 07:17:34PM -0500, Michael Meissner wrote: > > This series of patches adds the PCREL_OPT optimization for the PC-relative > > support in the PowerPC compiler. > > > > This optimization convert a s

Re: [C++ PATCH] c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.

2019-12-04 Thread Marek Polacek
On Tue, Dec 03, 2019 at 01:43:26PM -0500, Jason Merrill wrote: > On 12/3/19 1:40 PM, Jason Merrill wrote: > > On 12/3/19 12:49 PM, Marek Polacek wrote: > > > On Tue, Dec 03, 2019 at 02:07:02AM -0500, Jason Merrill wrote: > > > > On 12/2/19 5:09 PM, Marek Polacek wrote: > > > > > On Mon, Dec 02, 201

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Peter Bergner
On 12/4/19 2:50 PM, Segher Boessenkool wrote: > It would be nice to keep *some* dfp test(s) to make sure we don't ICE. > If we disabled all such tests already, like with this patch, we wouldn't > have ICEd or seen this problem. That can be a separate test of course > (and could be outside gcc.targ

Add -fpartial-profile-training

2019-12-04 Thread Jan Hubicka
Hi, with recent fixes to proile updating I noticed that we get more regressions compared to gcc 9 at Firefox testing. This is because Firefox train run is not covering all the benchmarks and gcc 9, thanks to updating bugs sometimes optimize code for speed even if it was not trained. While in gener

Re: [ PATCH ] [ C++ ] Implementing P0767 - deprecate POD

2019-12-04 Thread Jonathan Wakely
On 03/12/19 20:30 -0500, JeanHeyd Meneide wrote: This patch implements deprecate POD for the C++ Standard Library, Thanks. bringing libstdc++ that much closer to 2020 conformance 🎉! N.B. adding the attribute is not required for conformance. +#if defined(__DEPRECATED) && (__cplusplus > 201

Re: [PATCH] Freestanding proposal P0829

2019-12-04 Thread Jonathan Wakely
On 03/12/19 23:38 +0100, Paul M. Bendixen wrote: Hello I've made an implementation of P0829 and tested it with gcc for avr. This is great, thanks! What's the status of libstdc++ for AVR? If I understand correctly, it doesn't build by default when GCC is configured for AVR. Are you overriding t

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Peter Bergner
On 12/4/19 2:47 PM, Iain Sandoe wrote: > Peter Bergner wrote: >> >> Why isn't just testing check_effective_target_dfp enough to disable the >> tests on Darwin, --disable-decimal-float, etc.? > > … It should be a better solution - I will confirm this. Thanks for checking. The nice thing about th

Re: [PATCH 06/49] timevar.h: add auto_client_timevar class

2019-12-04 Thread David Malcolm
On Wed, 2019-12-04 at 10:27 -0700, Tom Tromey wrote: > > > > > > "Martin" == Martin Sebor writes: > > > + private: > > > + // Private to disallow copies. > > > + auto_client_timevar (const auto_client_timevar &); > > Martin> I don't know why it's important to disallow making copies of > Martin>

Re: [PATCH] PR85678: Change default to -fno-common

2019-12-04 Thread Jeff Law
On 12/4/19 2:03 PM, Joseph Myers wrote: > On Wed, 4 Dec 2019, Jeff Law wrote: > >>> So what normally happens with the numerous new warnings/errors in GCC >>> releases? I suppose that could cause package failures too. Would it be >>> feasible >>> to override the options for any failing packages? >

Re: [PATCH] PR85678: Change default to -fno-common

2019-12-04 Thread Joseph Myers
On Wed, 4 Dec 2019, Jeff Law wrote: > > So what normally happens with the numerous new warnings/errors in GCC > > releases? I suppose that could cause package failures too. Would it be > > feasible > > to override the options for any failing packages? > Usually we're talking about a few dozen pac

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Segher Boessenkool
On Wed, Dec 04, 2019 at 01:56:45PM -0600, Peter Bergner wrote: > On 12/4/19 1:16 PM, Segher Boessenkool wrote: > > Why do you need/want the check_effective_target_dfp test? If for example > > this is to prevent ICEs, that is no good, that is *hiding* problems. > > > > I suspect it is to stop the

Re: [C++ Patch] Improve build_functional_cast locations

2019-12-04 Thread Jason Merrill
On 12/4/19 11:44 AM, Paolo Carlini wrote: Hi, this exemplifies in a compact way the kind of change we can implement for the other casts too: near the end of cp_parser_functional_cast instead of using the combined_loc only for the returned cp_expr we can also pass it to build_functional_cast.

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Iain Sandoe
Peter Bergner wrote: On 12/4/19 1:16 PM, Segher Boessenkool wrote: This isn't run from powerpc.exp, so it needs to still do that first check. And it's up to the Darwin maintainers whether they want that second part (there are many more tests and testsuites that disable *-darwin* while that i

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Peter Bergner
On 12/4/19 1:16 PM, Segher Boessenkool wrote: > For future patches: it is much easier to review if you make the big, > mechanical move a separate (earlier) patch. Will do. >> I have also >> included a small patch to disable running the powerpc/dfp/ tests even for >> powerpc*-linux when --disab

Re: [PATCH 00/49] RFC: Add a static analysis framework to GCC

2019-12-04 Thread Martin Sebor
On 11/15/19 6:22 PM, David Malcolm wrote: This patch kit introduces a static analysis pass for GCC that can diagnose various kinds of problems in C code at compile-time (e.g. double-free, use-after-free, etc). I haven't looked at the analyzer bits in any detail yet so I have just some very high

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

2019-12-04 Thread Segher Boessenkool
Hi! [ This email was refused by the ML, too big, but I'll keep all non- mechanical parts of the patch in this reply, for the archives. ] On Wed, Dec 04, 2019 at 10:01:05AM -0600, Peter Bergner wrote: > The following patch fixes the last bug in PR92661, which is an ICE while > defining a builtin t

Re: [PATCH 23/49] analyzer: logging support

2019-12-04 Thread Martin Sebor
On 11/15/19 6:23 PM, David Malcolm wrote: This patch adds a logging framework to the analyzer which handles hierarchical messages (showing the nested structure of the calls). This code is largely based on that in the "jit" subdirectory (with a few changes). An alternative would be to generalize

Re: [PATCH 21/49] analyzer: command-line options

2019-12-04 Thread Martin Sebor
On 11/15/19 6:23 PM, David Malcolm wrote: This patch contains the command-line options for the analyzer. Some of the -Wanalyzer- options sounds like they control similar warnings as existing options (e.g., -Wanalyzer-null-argument sounds like -Wnonnull and -Wanalyzer-null-dereference like -Wnu

Re: [PATCH 20/49] analyzer: new builtins

2019-12-04 Thread Martin Sebor
On 11/15/19 6:23 PM, David Malcolm wrote: gcc/ChangeLog: * builtins.def (BUILT_IN_ANALYZER_BREAK): New builtin. (BUILT_IN_ANALYZER_DUMP): New builtin. (BUILT_IN_ANALYZER_DUMP_EXPLODED_NODES): New builtin. (BUILT_IN_ANALYZER_DUMP_NUM_HEAP_REGIONS): New builtin.

Re: [PATCH 15/49] Add ordered_hash_map

2019-12-04 Thread Martin Sebor
On 11/15/19 6:23 PM, David Malcolm wrote: This patch adds an ordered_hash_map template, which is similar to hash_map, but preserves insertion order. gcc/ChangeLog: * Makefile.in (OBJS): Add ordered-hash-map-tests.o. * ordered-hash-map-tests.cc: New file. * ordered-hash-ma

Re: [PATCH 11/49] Add diagnostic_metadata and CWE support

2019-12-04 Thread Martin Sebor
On 11/15/19 6:22 PM, David Malcolm wrote: This patch adds support for associating a diagnostic with an optional diagnostic_metadata object, so that plugins can add extra data to their diagnostics (e.g. mapping a diagnostic to a taxonomy or coding standard such as from CERT or MISRA). Currently t

Re: [PATCH 06/49] timevar.h: add auto_client_timevar class

2019-12-04 Thread Tom Tromey
> "Martin" == Martin Sebor writes: >> + private: >> + // Private to disallow copies. >> + auto_client_timevar (const auto_client_timevar &); Martin> I don't know why it's important to disallow making copies of Martin> these classes (they look safe to copy) but usually it goes Martin> along

Re: [PATCH] PR85678: Change default to -fno-common

2019-12-04 Thread Jeff Law
On 12/4/19 8:24 AM, Wilco Dijkstra wrote: > Hi Jeff, > >>> I've noticed quite significant package failures caused by the revision. >>> Would you please consider documenting this change in porting_to.html >>> (and in changes.html) for GCC 10 release? >> >> I'm not in the office right now, but figur

Re: [PATCH 10/49] Add -fdiagnostics-nn-line-numbers

2019-12-04 Thread Martin Sebor
On 11/15/19 6:22 PM, David Malcolm wrote: This patch implements -fdiagnostics-nn-line-numbers, a new option which makes diagnostic_show_locus print "NN" rather than specific line numbers when printing the left margin. This is intended purely to make it easier to write certain kinds of DejaGnu te

Re: [PATCH 10/49] Add -fdiagnostics-nn-line-numbers

2019-12-04 Thread Martin Sebor
On 11/15/19 6:22 PM, David Malcolm wrote: This patch implements -fdiagnostics-nn-line-numbers, a new option which makes diagnostic_show_locus print "NN" rather than specific line numbers when printing the left margin. This is intended purely to make it easier to write certain kinds of DejaGnu te

Re: [PATCH 09/49] gimple const-correctness fixes

2019-12-04 Thread Martin Sebor
On 11/15/19 6:22 PM, David Malcolm wrote: This patch converts various "gimple *" to "const gimple *" and similar fixes for gimple subclasses, adding is_a_helper for gimple subclasses to support the const form of as_a, and adding a few "const" overloads of accessors. This is enough to make pp_gim

Re: [PATCH 04/49] sbitmap.h: add operator const sbitmap & to auto_sbitmap

2019-12-04 Thread Martin Sebor
On 11/15/19 6:22 PM, David Malcolm wrote: gcc/ChangeLog: * sbitmap.h (auto_sbitmap): Add operator const sbitmap &. --- gcc/sbitmap.h | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/sbitmap.h b/gcc/sbitmap.h index a33175d..3c5b0a4 100644 --- a/gcc/sbitmap.h +++ b/gcc/sbitmap.h @

[C++ Patch] Improve build_functional_cast locations

2019-12-04 Thread Paolo Carlini
Hi, this exemplifies in a compact way the kind of change we can implement for the other casts too: near the end of cp_parser_functional_cast instead of using the combined_loc only for the returned cp_expr we can also pass it to build_functional_cast. Tested x86_64-linux. Thanks, Paolo.

Re: [PATCH 06/49] timevar.h: add auto_client_timevar class

2019-12-04 Thread Martin Sebor
On 11/15/19 6:22 PM, David Malcolm wrote: This patch adds a class "auto_client_timevar", similar to auto_timevar, but for plugins to use on their own timing items that aren't in timevar.def gcc/ChangeLog: * timevar.h (class auto_client_timevar): New class. --- gcc/timevar.h | 33 ++

Re: [PATCH 05/49] vec.h: add auto_delete_vec

2019-12-04 Thread Martin Sebor
On 11/15/19 6:22 PM, David Malcolm wrote: This patch adds a class auto_delete_vec, a subclass of auto_vec that deletes all of its elements on destruction; it's used in many places later in the kit. This is a crude way for a vec to "own" the objects it points to and clean up automatically (essen

Re: [PATCH] Enable ICE-after-error with -fchecking

2019-12-04 Thread Jakub Jelinek
On Wed, Dec 04, 2019 at 03:20:59PM +0100, Richard Biener wrote: > Currently IL verification errors trigger "confused by earlier errors" > messages with a release compiler but compiling with -fchecking. > That is because those use error() before internal_error. > > This precludes useful things like

[PATCH 7/7] [analyzer] Add -Wanalyzer-unsafe-call-within-signal-handler

2019-12-04 Thread David Malcolm
This patch adds another new experimental state machine, this time for tracking bad calls made from within a signal handler. Example of output: ../../src/demos/signal.c: In function ‘custom_logger’: ../../src/demos/signal.c:15:5: warning: call to ‘fprintf’ from within signal handler [CWE-479] [-W

[PATCH 6/7] [analyzer] Expose state_change_event in evdesc::state_change

2019-12-04 Thread David Malcolm
gcc/ChangeLog: * analyzer/analyzer.h (class state_change_event): Forward decl. * analyzer/checker-path.cc (state_change_event::get_desc): Pass *this to evdesc::state_change ctor. * analyzer/pending-diagnostic.h (evdesc::state_change::state_change): Add a

[PATCH 3/7] [analyzer] Generalize rewind_info_t to exploded_edge::custom_info_t

2019-12-04 Thread David Malcolm
This patch generalizes the optional rewind_info_t associated with an exploded_edge (for handling longjmp) into a subclass of a new exploded_edge::custom_info_t abstract base class, so that other kinds of custom edges can be supported (e.g. to support signal handlers being called, or possibly to sup

[PATCH 4/7] [analyzer] Support global states and custom transitions

2019-12-04 Thread David Malcolm
This patch generalizes the state machine code to support "global" states as well as per-expression states. It also adds a custom_transition hook for state machines that need to make non-standard transitions (e.g. calling into a signal handler). gcc/ChangeLog: * analyzer/checker-path.cc (s

[PATCH 5/7] [analyzer] Support custom events

2019-12-04 Thread David Malcolm
This patch adds a custom_event subclass for diagnostics that need non-standard events (e.g. signal handlers). gcc/ChangeLog: * analyzer/checker-path.cc (event_kind_to_string): Handle EK_CUSTOM. (custom_event::get_desc): New vfunc implementation. * analyzer/checker-path (cla

[PATCH 1/7] [analyzer] Support paths for callbacks

2019-12-04 Thread David Malcolm
This patch extends the path-printing support to cope with paths for signal-handlers, popping the stack to a new entrypoint, with events outside any function. gcc/testsuite/ChangeLog: * gcc.dg/plugin/diagnostic-test-paths-4.c: New test. * gcc.dg/plugin/diagnostic_plugin_test_paths.c

[PATCH 0/7] [analyzer] Add checking for unsafe calls within signal handlers

2019-12-04 Thread David Malcolm
This patch kit adds a new warning: -Wanalyzer-unsafe-call-within-signal-handler to the analyzer branch. A colorized example of the output can be seen here: https://dmalcolm.fedorapeople.org/gcc/2019-12-04/signal.c.html Currently it only detects calls to "fprintf". This is a new feature beyon

[PATCH 2/7] [analyzer] More test coverage

2019-12-04 Thread David Malcolm
gcc/testsuite/ChangeLog: * gcc.dg/analyzer/data-model-1.c: Include . (test_53): New function. --- gcc/testsuite/gcc.dg/analyzer/data-model-1.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gcc/testsuite/gcc.dg/analyzer/data-model-1.c b/gcc/testsuite/gcc.dg/analyzer/dat

Re: [PATCH] PR85678: Change default to -fno-common

2019-12-04 Thread Wilco Dijkstra
Hi Jeff, >> I've noticed quite significant package failures caused by the revision. >> Would you please consider documenting this change in porting_to.html >> (and in changes.html) for GCC 10 release? > > I'm not in the office right now, but figured I'd chime in.  I'd estimate > 400-500 packages a

[committed] Remove stray comma in primary_constraint_error.

2019-12-04 Thread Marek Polacek
This fixes cp/parser.c:27134:20: warning: comma at end of enumerator list Applying to trunk. 2019-12-04 Marek Polacek * parser.c (enum primary_constraint_error): Remove stray comma. diff --git gcc/cp/parser.c gcc/cp/parser.c index fb030022627..10ff01666b9 100644 --- gcc/cp/parser.c +

Re: [Patch, Fortran] PR 92793 - fix column used for error diagnostic

2019-12-04 Thread Harwath, Frederik
Hi Tobias, On 04.12.19 14:37, Tobias Burnus wrote: > As reported internally by Frederik, gfortran currently passes LOCATION_COLUMN > == 0 to the middle end. The reason for that is how parsing works – gfortran > reads the input line by line. > > For internal error diagnostic (fortran/error.c), t

[PATCH] Enable ICE-after-error with -fchecking

2019-12-04 Thread Richard Biener
Currently IL verification errors trigger "confused by earlier errors" messages with a release compiler but compiling with -fchecking. That is because those use error() before internal_error. This precludes useful things like emergency IL dump in dump files. Thus the following - change CHECKING_

[Patch, Fortran] PR 92793 - fix column used for error diagnostic

2019-12-04 Thread Tobias Burnus
As reported internally by Frederik, gfortran currently passes LOCATION_COLUMN == 0 to the middle end. The reason for that is how parsing works – gfortran reads the input line by line. For internal error diagnostic (fortran/error.c), the column location was corrected –  but not for locations pa

Ping Re: Fix libdecnumber handling of non-canonical BID significands (PR middle-end/91226)

2019-12-04 Thread Joseph Myers
Ping. This patch is pending review. -- Joseph S. Myers jos...@codesourcery.com

Re: Fix VIEW_CONVERT_EXPRs for VECTOR_BOOLEAN_TYPE_Ps

2019-12-04 Thread Richard Biener
On Wed, Dec 4, 2019 at 11:48 AM Richard Sandiford wrote: > > In r278410 I added code to handle VIEW_CONVERT_EXPRs between > variable-length vectors. This included support for decoding > a VECTOR_BOOLEAN_TYPE_P with subbyte elements. > > However, it turns out that we were already mishandling such

Re: [PATCH 00/49] RFC: Add a static analysis framework to GCC

2019-12-04 Thread Richard Biener
On Tue, Dec 3, 2019 at 5:52 PM David Malcolm wrote: > > On Wed, 2019-11-20 at 11:18 +0100, Richard Biener wrote: > > On Tue, Nov 19, 2019 at 11:02 PM David Malcolm > > wrote: > > > > > The checker is implemented as a GCC plugin. > > > > > > > > > > The patch kit adds support for "in-tree" plugins

[PATCH] Handle non-constants in VN partial-def support

2019-12-04 Thread Richard Biener
This improves on the existing partial-def support by allowing shadowed non-constant partial defs. Step 1 to really support non-constant partial-defs which would help Skia. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-12-04 Richard Biener * tree-ssa-s

Re: [Patch, Fortran] PR92754 - fix an issue with resolving intrinsic functions

2019-12-04 Thread Janne Blomqvist
On Tue, Dec 3, 2019 at 6:41 PM Tobias Burnus wrote: > > The problem here is that one gets two symbols - one inside the block and > one outside and they do not really agree whether one has a function or a > variable – which later gives an ICE. As sym->module was "(intrinsic)" > and FL_VARIABLE, one

[PATCH] 2nd try for firefox VN ICE fix

2019-12-04 Thread Richard Biener
Bootstrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2019-12-04 Richard Biener * tree-ssa-sccvn.c (vn_reference_lookup_3): Properly guard empty CTOR and memset partial-def registering. Take advantage of fancy offset analysis in memset handling. Index:

Re: [Ada] Gigi support for OpenACC pragmas

2019-12-04 Thread Ghjuvan Lacambre
On 2019-12-04, 10:29:04, Thomas Schwinge wrote: --- gcc/ada/gcc-interface/trans.c +++ gcc/ada/gcc-interface/trans.c @@ -1309,6 +1533,274 @@ Pragma_to_gnu (Node_Id gnat_node) + case Name_Copy: + map_kind = GOMP_MAP_FORCE_TOFROM; + gnu_clauses = Iterate_Acc_C

[PATCH] Fix profile name files without -fprofile-dir.

2019-12-04 Thread Martin Liška
Hello. As mentioned in here https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971#c7, we should not mangle profile data and note files unless -fprofile-dir is used (and an absolute path is used). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I'll install the patch if there

Fix VIEW_CONVERT_EXPRs for VECTOR_BOOLEAN_TYPE_Ps

2019-12-04 Thread Richard Sandiford
In r278410 I added code to handle VIEW_CONVERT_EXPRs between variable-length vectors. This included support for decoding a VECTOR_BOOLEAN_TYPE_P with subbyte elements. However, it turns out that we were already mishandling such bool vectors for fixed-length vectors: we treated each element as a s

Re: Add a new combine pass

2019-12-04 Thread Oleg Endo
On Tue, 2019-12-03 at 12:05 -0600, Segher Boessenkool wrote: > On Tue, Dec 03, 2019 at 10:33:48PM +0900, Oleg Endo wrote: > > On Mon, 2019-11-25 at 16:47 -0600, Segher Boessenkool wrote: > > > > > > > > - sh (that's sh4-linux): > > > > > > > > > > /home/segher/src/kernel/net/ipv4/af_inet.c: In fu

Re: [PATCH][AArch64] Add support for fused compare and branch

2019-12-04 Thread Richard Sandiford
Wilco Dijkstra writes: > Hi Richard, > >> But what uses CMP_BRANCH after the patch? It looked like you renamed >> all existing uses and didn't add any new ones. > > My next patch will be adding uses of it now I've done some benchmarking > to decide when to turn it on. > >>> + && reg_referenc

[PATCH] Initialize a BB count in switch lowering.

2019-12-04 Thread Martin Liška
Hello. The patch is about missing initialization of a profile count. Honza investigated with a new profile sanity patch he's been preparing. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Patch is pre-approved by Honza. Martin gcc/ChangeLog: 2019-12-03 Martin Liska

Re: [Ada] Gigi support for OpenACC pragmas

2019-12-04 Thread Thomas Schwinge
Hi Tobias! On 2019-12-04T10:39:30+0100, Tobias Burnus wrote: > I have another question: Why does the original email not appear at > https://gcc.gnu.org/ml/gcc-patches/2019-12/ or in my inbox? I do see > three other Ada emails posted around the same time but not this one. > On 12/4/19 10:29 AM,

Re: Ping: [C++ PATCH] Opt out of GNU vector extensions for built-in SVE types

2019-12-04 Thread Richard Sandiford
Jason Merrill writes: > On 12/3/19 7:39 AM, Richard Sandiford wrote: >> Jason Merrill writes: >>> On 11/29/19 5:59 AM, Richard Sandiford wrote: Ping Richard Sandiford writes: > This is the C++ equivalent of r277950, which prevented the > use of the GNU vector extensions wi

Re: [Ada] Gigi support for OpenACC pragmas

2019-12-04 Thread Tobias Burnus
Hi, I have another question: Why does the original email not appear at https://gcc.gnu.org/ml/gcc-patches/2019-12/ or in my inbox? I do see three other Ada emails posted around the same time but not this one. On 12/4/19 10:29 AM, Thomas Schwinge wrote: On 2018-12-03T10:50:44-0500, Pierre-Mar

Re: [PATCH] Some further match.pd optimizations with nop_convert (PR tree-optimization/92734)

2019-12-04 Thread Richard Biener
On Wed, 4 Dec 2019, Jakub Jelinek wrote: > Hi! > > The following optimizations also can't handle nop conversions between the > inner and outer addition/subtraction, and even -fwrapv doesn't help there, > only simplify-rtx.c is able to do something about those. > > Implemented thusly, bootstrappe

Re: [Ada] Gigi support for OpenACC pragmas

2019-12-04 Thread Thomas Schwinge
Hi! On 2018-12-03T10:50:44-0500, Pierre-Marie de Rodat wrote: > Matching front-end bits to support Acc_Kernels, Acc_Parallel, > Acc_Loop and Acc_Data. Interesting. :-) I have not reviewed this properly, but just stumbled over the following: > --- gcc/ada/gcc-interface/trans.c > +++ gcc/ada/g

[PATCH] Some further match.pd optimizations with nop_convert (PR tree-optimization/92734)

2019-12-04 Thread Jakub Jelinek
Hi! The following optimizations also can't handle nop conversions between the inner and outer addition/subtraction, and even -fwrapv doesn't help there, only simplify-rtx.c is able to do something about those. Implemented thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk

[PATCH] Fix ICE with OpenMP host teams (PR fortran/92756)

2019-12-04 Thread Jakub Jelinek
Hi! In OpenMP 4.5, the gomp/teams1.f90 code was invalid and diagnosed in the middle-end. In OpenMP 5.0, it is valid and the diagnostics in the middle-end has been removed, but the Fortran side hasn't been adjusted and so the middle-end ICEs on it. The following patch just does the minimal FE cha

Re: [PATCH] Enable mask operation for 128/256-bit vector VCOND_EXPR under avx512f (PR92686)

2019-12-04 Thread Jakub Jelinek
On Wed, Dec 04, 2019 at 10:07:05AM +0800, Hongtao Liu wrote: > Changelog > gcc/ > PR target/92686 > * config/i386/sse.md > (*_cmp3, > *_cmp3, > *_ucmp3, > *_ucmp3): New. > * config/i386/i386.c (ix86_print_operand): New operand substitution. > * config