On Wed, Dec 04, 2019 at 03:53:30PM -0600, Peter Bergner wrote: > On 12/4/19 2:50 PM, Segher Boessenkool wrote: > > It would be nice to keep *some* dfp test(s) to make sure we don't ICE. > > If we disabled all such tests already, like with this patch, we wouldn't > > have ICEd or seen this problem. That can be a separate test of course > > (and could be outside gcc.target/powerpc/dfp/). > > Sure, I can add a test in gcc.target/powerpc/ that uses both a builtin > and an overloaded builtin to make sure we don't ICE when DFP is disabled.
Great, thanks! > > OTOH, if you add this check, we can lose the > > > > /* { dg-require-effective-target powerpc_p9vector_ok } */ > > /* { dg-skip-if "" { powerpc*-*-aix* } } */ > > > > from all the dtstsfi-* tests, etc. (Well, no, need to keep the p9 part). > > Agreed on not needing the dg-skip-if tests. Not only on the powerpc/dfp/ > tests, but we should be able to remove them from the DFP tests that are > in gcc.target/powerpc/ too. Yup. > > Making such changes to the testsuite needs testing on *all* subtargets :-( > > Right. I'll come up with a patch and hopefully Iain and David can test > on Darwin and AIX and I can test on Linux with --enable-decimal-float > and --disable-decimal-float. That should cover the major subtargets and > if it works there, I'd expect it to work on the minor subtargets too. Sure, this is just testsuite, that will work fine. As long as there is a plan :-) Segher