On Wed, Dec 04, 2019 at 03:40:25PM -0600, Peter Bergner wrote: > On 12/4/19 2:47 PM, Iain Sandoe wrote: > > Peter Bergner <berg...@linux.ibm.com> wrote: > >> > >> Why isn't just testing check_effective_target_dfp enough to disable the > >> tests on Darwin, --disable-decimal-float, etc.? > > > > … It should be a better solution - I will confirm this. > > Thanks for checking. The nice thing about this solution (if it works > for Darwin and the other targets) is that if you eventually add DFP > support, then these tests will just automatically start being run for > you. Otherwise, you'll have to hunt through the DFP tests looking for > a dg-skip-if darwin test.
Yes, and most of those skip-if do not document *why* it is disabled, either! Segher
