Re: [RFA][PATCH] Minor fix to aliasing machinery

2013-11-08 Thread Marc Glisse
On Wed, 6 Nov 2013, Richard Biener wrote: So the only thing that remains is the mem_ref_offset thing and yes, I guess I'd prefer to use double-ints because we deal with bit offsets in the end. Here it is (bootstrap+testsuite on x86_64-unknown-linux-gnu). It feels rather artificial to do this s

PATCH: PR other/59055: gcc.texinfo warnings

2013-11-08 Thread H.J. Lu
There are 2 almost idential menus. The only difference is one doesn't have * Option Summary:: Brief list of all options, without explanations. * Submodel Options::Specifying minor hardware or convention * variations, such as 68010 vs 68020. * Code Gen Options::

Fix 32-bit __atomic_*_16 problems (hopefully)

2013-11-08 Thread Joseph S. Myers
I hope this patch will fix the issues people have seen with atomics tests failing on 32-bit architectures with missing __atomic_*_16 (or at least replace them by different problems). I'm running tests on x86_64-unknown-linux-gnu; perhaps someone seeing the 32-bit problems could test it there? 201

PATCH: PR other/59055: gcc.texinfo warnings

2013-11-08 Thread H.J. Lu
bugreport.texi has @menu * Criteria: Bug Criteria. Have you really found a bug? * Reporting: Bug Reporting. How to report a bug effectively. * Known: Trouble.Known problems. * Help: Service. Where to ask for help. @end menu That means include order should be bugreport.

PATCH: PR other/59055: gcc.texinfo warnings

2013-11-08 Thread H.J. Lu
doc/extend.texi has * Pointer Bounds Checker builtins:: Built-in functions for Pointer Bounds Checker. * Cilk Plus Builtins:: Built-in functions for the Cilk Plus language extension. * Other Builtins:: Other built-in functions. * Target Builtins:: Built-in functions specific to particul

Re: [PATCH] decide edge's hotness when there is profile info

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 10:58 PM, Teresa Johnson wrote: > +static void > +drop_profile (struct cgraph_node *node, bool hot) > +{ > + struct function *fn = DECL_STRUCT_FUNCTION (node->decl); > + > + if (dump_file) > +fprintf (dump_file, > + "Dropping 0 profile for %s/%i. %s based o

Re: [PATCH] decide edge's hotness when there is profile info

2013-11-08 Thread Teresa Johnson
On Tue, Nov 5, 2013 at 6:02 AM, Teresa Johnson wrote: > Ping. > Thanks, Teresa > I updated the patch to include the follow-on work to apply call counts to 0-weight functions using the estimated frequencies when inlining. This helps avoid 0-weight blocks of inlined code which are particularly bad

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 10:46 PM, Jeff Law wrote: > Also note that other patches have gone in recently which include those files > for exactly the same reason. I assume you're referring to tree-ssa-reassoc.c? It's the only new one I could find since I cleaned rtl.h out from almost all tree-* files

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-11-08 Thread Jeff Law
On 11/08/13 10:45, pins...@gmail.com wrote: On Nov 8, 2013, at 9:20 AM, Steven Bosscher wrote: On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: Here is what I applied in the end; Jeff told me just to remove the testcase. I added the comment trying to explain why it was the opposite or

Re: [PATCH] Reducing number of alias checks in vectorization.

2013-11-08 Thread Dominique Dhumieres
> Thank you for the report. I have submitted a bug fix patch waiting to > be reviewed. The patch fixes the fortran failures (tested on gfortran an libgomp only). Thanks, Dominique

Re: [PATCH, libatomic]: Add config/x86/fenv.c

2013-11-08 Thread Joseph S. Myers
On Fri, 8 Nov 2013, Uros Bizjak wrote: > On Fri, Nov 8, 2013 at 2:13 PM, Joseph S. Myers > wrote: > > >> Can we introduce a target-dependant source here, in the same way as > > > > Sure, that seems a reasonable thing to do. I think putting a file fenv.c > > in an appropriate subdirectory of li

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Joseph S. Myers
On Fri, 8 Nov 2013, Rong Xu wrote: > A question about inhibit_libc. > When inhibit_libc is defined, we provide dummy functions for all the > __gcov_* methods. > Is it purposely to minimize the footprint? inhibit_libc is for use in bootstrap builds when libc headers aren't available - for buildin

Re: patch to fix PR58784 (ARM LRA crash)

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 10:13 PM, Steven Bosscher wrote: > On Thu, Nov 7, 2013 at 10:42 AM, Yvan Roux wrote: > This store_minmaxsi insn is not recognized because > optimize_function_for_size_p() is false. The problem is in the place > where this insn was created. Trying to figure that out now... L

Re: Update soft-fp from glibc

2013-11-08 Thread Joseph S. Myers
On Fri, 8 Nov 2013, Uros Bizjak wrote: > Hello! > > > I've applied this patch to update libgcc's copy of soft-fp from > > glibc. There are lots of coding standards fixes, but also various bug > > fixes; I've added testcases for various of the fixed bugs illustrating > > them for __float128. > >

Re: [GOOGLE] tune loop scale factor for AutoFDO

2013-11-08 Thread Dehao Chen
As discussed offline, will commit this patch first, and think of other smoothing algorithm to prevent profile insanity. Dehao On Fri, Nov 8, 2013 at 9:32 AM, Xinliang David Li wrote: > On Fri, Nov 8, 2013 at 6:23 AM, Dehao Chen wrote: >> AutoFDO sometimes has 0 profile in the loop's entry block

Re: patch to fix PR58784 (ARM LRA crash)

2013-11-08 Thread Steven Bosscher
On Thu, Nov 7, 2013 at 10:42 AM, Yvan Roux wrote: > Hi, > > I've tested LRA on ARM in several configuration and it occurs that > only one regression is observed in Fortran for targets A15 and A9 in > hard and soft fp amd Thumb mode enabled by default (ARMv5 is clean). > The failing test case is gf

Re: [PATCH] Bug fix for PR59050

2013-11-08 Thread Cong Hou
Yes, I think so. The bug is that the arguments of tree_int_cst_compare() may not be constant integers. This patch should take care of it. thanks, Cong On Fri, Nov 8, 2013 at 12:06 PM, H.J. Lu wrote: > On Fri, Nov 8, 2013 at 10:34 AM, Cong Hou wrote: >> http://gcc.gnu.org/bugzilla/show_bug.cg

Re: [PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

2013-11-08 Thread Vladimir Makarov
On 11/6/2013, 11:26 AM, Martin Jambor wrote: So, Vlad, Steven, do you think that this time I have re-computed all that is necessary? Do you think the patch is OK? It is ok for me. Thanks. Thanks a lot and sorry for the breakage, Only who does nothing does not make mistakes. 2013-11-04 M

RE: [PATCH] Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-08 Thread Iyer, Balaji V
> -Original Message- > From: Iain Sandoe [mailto:i...@codesourcery.com] > Sent: Friday, November 8, 2013 3:28 PM > To: Iyer, Balaji V > Cc: Bernhard Reutner-Fischer; Jakub Jelinek; Joseph S. Myers; Tobias Burnus; > gcc patches; Mike Stump > Subject: Re: [PATCH] Testsuite / Cilk Plus: Incl

Re: [PATCH] Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-08 Thread Iain Sandoe
hi Balaji, On 8 Nov 2013, at 10:01, Mike Stump wrote: > On Nov 8, 2013, at 4:09 AM, Bernhard Reutner-Fischer > wrote: >> On 6 November 2013 08:04, Jakub Jelinek wrote: >>> On Wed, Nov 06, 2013 at 02:24:01AM +, Iyer, Balaji V wrote: Fixed patch is attached. The responses to your que

Re: [PATCH] Bug fix for PR59050

2013-11-08 Thread H.J. Lu
On Fri, Nov 8, 2013 at 10:34 AM, Cong Hou wrote: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59050 > > This is my bad. I forget to check the test result for gfortran. With > this patch the bug should be fixed (tested on x86-64). > > > thanks, > Cong > > > diff --git a/gcc/ChangeLog b/gcc/ChangeL

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Rong Xu
On Fri, Nov 8, 2013 at 11:30 AM, Xinliang David Li wrote: > On Fri, Nov 8, 2013 at 11:21 AM, Rong Xu wrote: >> On Fri, Nov 8, 2013 at 11:02 AM, Xinliang David Li >> wrote: >>> On Fri, Nov 8, 2013 at 10:48 AM, Rong Xu wrote: On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li wrote:

Re: [rl78] Use canonical const_int for one_cmplqi2

2013-11-08 Thread DJ Delorie
> This patch just changes a QImode (const_int 255) to (const_int -1), > since the canonical form is to sign-extend. As things stand the pattern > trips a new assert added on the wide-int branch. Ok. Thanks!

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
On Fri, Nov 8, 2013 at 11:21 AM, Rong Xu wrote: > On Fri, Nov 8, 2013 at 11:02 AM, Xinliang David Li wrote: >> On Fri, Nov 8, 2013 at 10:48 AM, Rong Xu wrote: >>> On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li >>> wrote: in libgcov-driver.c > /* Flag when the profile has alre

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Rong Xu
On Fri, Nov 8, 2013 at 11:02 AM, Xinliang David Li wrote: > On Fri, Nov 8, 2013 at 10:48 AM, Rong Xu wrote: >> On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li >> wrote: >>> in libgcov-driver.c >>> /* Flag when the profile has already been dumped via __gcov_dump(). */ static int gc

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
On Fri, Nov 8, 2013 at 10:56 AM, Rong Xu wrote: > A question about inhibit_libc. > When inhibit_libc is defined, we provide dummy functions for all the > __gcov_* methods. > Is it purposely to minimize the footprint? > I'm thinking to allow some codes that are independent of libc (and its > header

Re: [PATCH] Add gimple subclasses for every gimple code (was Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3))

2013-11-08 Thread David Malcolm
On Wed, 2013-11-06 at 22:32 -0700, Jeff Law wrote: > [ Just a note, of this reply is meant for Michael and other parts for > David, hopefully the audience is clear from the context. ] > > On 11/06/13 21:56, David Malcolm wrote: > > On Wed, 2013-11-06 at 16:32 +0100, Michael Matz wrote: > >> Hi, >

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
On Fri, Nov 8, 2013 at 10:48 AM, Rong Xu wrote: > On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li wrote: >> in libgcov-driver.c >> >>> /* Flag when the profile has already been dumped via __gcov_dump(). */ >>> static int gcov_dump_complete; >> >>> inline void >>> set_gcov_dump_complete (void)

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Rong Xu
A question about inhibit_libc. When inhibit_libc is defined, we provide dummy functions for all the __gcov_* methods. Is it purposely to minimize the footprint? I'm thinking to allow some codes that are independent of libc (and its headers) under this. Is it OK? -Rong On Fri, Nov 8, 2013 at 10:48

Re: [PATCH] Reducing number of alias checks in vectorization.

2013-11-08 Thread Cong Hou
Thank you for the report. I have submitted a bug fix patch waiting to be reviewed. thanks, Cong On Fri, Nov 8, 2013 at 5:26 AM, Dominique Dhumieres wrote: > According to http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00197.html > revision 204538 is breaking several tests. On x86_64-apple-dar

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
> 1) I don't think you need in_mem flag. For in memory merge, the source != > NULL. discard this comment. David > > > > > > > On Thu, Nov 7, 2013 at 3:34 PM, Rong Xu wrote: >> On Thu, Nov 7, 2013 at 9:40 AM, Joseph S. Myers >> wrote: >>> On Thu, 7 Nov 2013, Rong Xu wrote: >>> Thanks Jose

Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.

2013-11-08 Thread Jason Merrill
On 10/31/2013 05:47 AM, Adam Butcher wrote: + become_template = true; + push_deferring_access_checks (dk_deferred); Why is this call here? I don't see anything in the rest of the function that would trigger an access check, or a matching pop. + /* Create a distinct

[PATCH] Bug fix for PR59050

2013-11-08 Thread Cong Hou
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59050 This is my bad. I forget to check the test result for gfortran. With this patch the bug should be fixed (tested on x86-64). thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 90b01f2..e62c672 100644 --- a/gcc/ChangeLog +++ b/gcc/Chan

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Rong Xu
On Fri, Nov 8, 2013 at 10:22 AM, Xinliang David Li wrote: > in libgcov-driver.c > >> /* Flag when the profile has already been dumped via __gcov_dump(). */ >> static int gcov_dump_complete; > >> inline void >> set_gcov_dump_complete (void) >>{ > > gcov_dump_complete = 1; >>} > >>inline void >>r

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-08 Thread Xinliang David Li
in libgcov-driver.c > /* Flag when the profile has already been dumped via __gcov_dump(). */ > static int gcov_dump_complete; > inline void > set_gcov_dump_complete (void) >{ > gcov_dump_complete = 1; >} >inline void >reset_gcov_dump_complete (void) >{ > gcov_dump_complete = 0; >} These sh

Re: Fix for PR 59039

2013-11-08 Thread H.J. Lu
On Fri, Nov 8, 2013 at 8:48 AM, Iyer, Balaji V wrote: > Hello Everyone, > Attached, please find a patch that will fix a crash in a function in > libcilkrts when optimization was turned on. The issue was that the longjump > and setjmp were called in the same function. This patch should f

Re: [PATCH] Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 4:09 AM, Bernhard Reutner-Fischer wrote: > On 6 November 2013 08:04, Jakub Jelinek wrote: >> On Wed, Nov 06, 2013 at 02:24:01AM +, Iyer, Balaji V wrote: >>>Fixed patch is attached. The responses to your question are given below. >>> Is this patch OK? > May i suggest

Merge from GCC mainline to gccgo branch

2013-11-08 Thread Ian Lance Taylor
I merged GCC mainline revision 204583 to the gcgo branch. Ian

Re: RFC: simd enabled functions (omp declare simd / elementals)

2013-11-08 Thread Aldy Hernandez
On 11/07/13 09:09, Martin Jambor wrote: I am glad this is becoming a useful infrastructure rather than just a part of IPA-SRA. Note that while ipa_combine_adjustments is not used from anywhere and thus probably buggy anyway, it should in theory be able to process new_param adjustments too. Can

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-11-08 Thread pinskia
> On Nov 8, 2013, at 9:20 AM, Steven Bosscher wrote: > >> On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: >> Here is what I applied in the end; Jeff told me just to remove the >> testcase. I added the comment trying to explain why it was the >> opposite order of PHI-opt. >> >> Thanks, >

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 6:20 PM, Steven Bosscher wrote: > On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: >> Here is what I applied in the end; Jeff told me just to remove the >> testcase. I added the comment trying to explain why it was the >> opposite order of PHI-opt. >> >> Thanks, >> Andr

Go patch committed: Avoid bogus init loop error

2013-11-08 Thread Ian Lance Taylor
Code like this type S struct { F int } var V = S{F: 1} var F = V.F could trigger an incorrect "variable initializer refers to itself" error because the Go frontend would confuse itself into thinking that the "F" in the composite literal was the same as the global variable "F", rather th

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 16:03, Jonathan Wakely wrote: > On 8 November 2013 15:41, Jonathan Wakely wrote: >> On 8 November 2013 14:51, Daniel Krügler wrote: >>> I have fully not grasped for which T the specializations of >>> __has_contiguous_iter are intended to be used, >> >> Currently, only std::contai

Re: [GOOGLE] tune loop scale factor for AutoFDO

2013-11-08 Thread Xinliang David Li
On Fri, Nov 8, 2013 at 6:23 AM, Dehao Chen wrote: > AutoFDO sometimes has 0 profile in the loop's entry block because the > debug info are lost and unrecoverable. Is that a separate problem to track and fix? Also is it better to do a round of loop profiling smoothing after auto profile annotati

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-11-08 Thread Steven Bosscher
On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: > Here is what I applied in the end; Jeff told me just to remove the > testcase. I added the comment trying to explain why it was the > opposite order of PHI-opt. > > Thanks, > Andrew Pinski > > ChangeLog: > * tree-ssa-ifcombine.c: Include rtl.

[PATCH, libatomic]: Add config/x86/fenv.c

2013-11-08 Thread Uros Bizjak
On Fri, Nov 8, 2013 at 2:13 PM, Joseph S. Myers wrote: >> Can we introduce a target-dependant source here, in the same way as > > Sure, that seems a reasonable thing to do. I think putting a file fenv.c > in an appropriate subdirectory of libatomic/config will result in it being > found automati

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Joern Rennecke
On 8 November 2013 15:50, Steven Bosscher wrote: > Even with the gimple opts disabled, a const-const comparison would > normally be folded by the RTL expanders. Well, in this spirit, attached is another way to address the RTL side of the problem. As mention in the PR, the tree side of the problem

Re: [PATCH][ARM] Add break in handling of comparisons in rtx costs function

2013-11-08 Thread Ramana Radhakrishnan
On 11/08/13 13:34, Kyrill Tkachov wrote: Hi all, In arm_new_rtx_costs we need a break; statement after handling the comparisons cases. Otherwise we fall through and compute garbage. This small patch adds that. Tested arm-none-eabi on qemu. Ok for trunk? Ok - thanks. Ramana

Fix for PR 59039

2013-11-08 Thread Iyer, Balaji V
Hello Everyone, Attached, please find a patch that will fix a crash in a function in libcilkrts when optimization was turned on. The issue was that the longjump and setjmp were called in the same function. This patch should fix that issue. The change is not in the compiler side but only

Re: [PATCH] fixincludes: use $(FI) instead of fixincl@EXEEXT@

2013-11-08 Thread Bruce Korb
Sure. Looks good to me. Thanks On Fri, Nov 8, 2013 at 2:57 AM, Bernhard Reutner-Fischer wrote: > On 4 April 2013 22:20, Bruce Korb wrote: >> Except as noted below, fine by me. >> >> On 04/04/13 12:56, Bernhard Reutner-Fischer wrote: >>> Bootstrapped and regtested on x86_64-unknown-linux-gnu an

Re: Update soft-fp from glibc

2013-11-08 Thread Uros Bizjak
Hello! > I've applied this patch to update libgcc's copy of soft-fp from > glibc. There are lots of coding standards fixes, but also various bug > fixes; I've added testcases for various of the fixed bugs illustrating > them for __float128. Is there really no way to get those "missing prototypes

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 4:45 PM, Teresa Johnson wrote: > For example, from mcf with -freorder-blocks-and-partition: > > main: > .LFB40: > .cfi_startproc > ... > jne .L27 < jump to main's text.unlikely > ... > .cfi_endproc > .section

[PATCH] Commonize repeated code into function

2013-11-08 Thread Jeff Law
This has been on my todo list for a little while now. Over time I've written the loop to delete a jump threading path several times. It's just 3 lines of code, but I hate repeating it all over the place. This pulls those trivial 3 lines into a function and calls it from the appropriate pla

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-11-08 Thread Teresa Johnson
On Fri, Nov 8, 2013 at 8:14 AM, Steven Bosscher wrote: > On Fri, Nov 8, 2013 at 4:45 PM, Teresa Johnson wrote: >> On Tue, May 14, 2013 at 3:47 PM, Steven Bosscher wrote: >> I'd like to revisit this old patch from Sri to generate a label for >> the split out cold section, now that all the patches t

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 4:45 PM, Teresa Johnson wrote: > On Tue, May 14, 2013 at 3:47 PM, Steven Bosscher wrote: > I'd like to revisit this old patch from Sri to generate a label for > the split out cold section, now that all the patches to fix the > failures and insanities from -freorder-blocks-and

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 15:41, Jonathan Wakely wrote: > On 8 November 2013 14:51, Daniel Krügler wrote: >> I have fully not grasped for which T the specializations of >> __has_contiguous_iter are intended to be used, > > Currently, only std::container iterators passed to a basic_regex > constructor, but

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Jeff Law
On 11/08/13 07:45, Steven Bosscher wrote: On Fri, Nov 8, 2013 at 3:40 PM, Joern Rennecke wrote: bootstrapped / regtested on i686-pc-linux-gnu. Not a very elaborate description of the patch, eh? :-) This is IMHO not OK without at least an explanation of why the comparison of two const_ints is

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 4:41 PM, Jakub Jelinek wrote: > On Fri, Nov 08, 2013 at 04:32:09PM +0100, Steven Bosscher wrote: >> On Fri, Nov 8, 2013 at 4:18 PM, Joern Rennecke wrote: >> > On 8 November 2013 14:45, Steven Bosscher wrote: >> >> This is IMHO not OK without at least an explanation of why the

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition

2013-11-08 Thread Teresa Johnson
On Tue, May 14, 2013 at 3:47 PM, Steven Bosscher wrote: > On Wed, Apr 24, 2013 at 12:58 AM, Sriraman Tallam wrote: >> Hi, >> >> This patch generates labels for cold function parts that are split when >> using the option -freorder-blocks-and-partition. The cold label name >> is generated by suff

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
On 8 November 2013 14:51, Daniel Krügler wrote: > I have fully not grasped for which T the specializations of > __has_contiguous_iter are intended to be used, Currently, only std::container iterators passed to a basic_regex constructor, but in theory the trait could get moved to another header and

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Jakub Jelinek
On Fri, Nov 08, 2013 at 04:32:09PM +0100, Steven Bosscher wrote: > On Fri, Nov 8, 2013 at 4:18 PM, Joern Rennecke wrote: > > On 8 November 2013 14:45, Steven Bosscher wrote: > >> This is IMHO not OK without at least an explanation of why the > >> comparison of two const_ints is not folded. Better y

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 4:18 PM, Joern Rennecke wrote: > On 8 November 2013 14:45, Steven Bosscher wrote: >> This is IMHO not OK without at least an explanation of why the >> comparison of two const_ints is not folded. Better yet would be to fix >> that underlying problem. We should not present such

Re: [PATCH] make has_gate and has_execute useless

2013-11-08 Thread Trevor Saunders
On Fri, Nov 08, 2013 at 10:37:00AM +0100, Richard Biener wrote: > On Thu, Nov 7, 2013 at 5:00 PM, wrote: > > From: Trevor Saunders > > > > Hi, > > > > This is the result of seeing what it would take to get rid of the has_gate > > and > > has_execute flags on pass_data. It turns out not much,

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Joern Rennecke
On 8 November 2013 14:45, Steven Bosscher wrote: > This is IMHO not OK without at least an explanation of why the > comparison of two const_ints is not folded. Better yet would be to fix > that underlying problem. We should not present such non-sense to the > RTL parts of the middle end. Which pa

some prep work to make JUMP_TABLE_DATA a non-active_insn_p object

2013-11-08 Thread Steven Bosscher
Hello, I'd like to make JUMP_TABLE_DATA a non-active insn before the end of stage1. Most of the work required for this is pretty simple. It involves finding and fixing the few places where insns are walked across basic block boundaries and ignoring barriers. Ah, the madness of that! :-) Fortunatel

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Joern Rennecke
On 8 November 2013 14:45, Steven Bosscher wrote: > Also would need a test case. As is mentioned in the PR, we already have a test case, which shows a regression.

Re: RFA: Fix PR middle-end/59049

2013-11-08 Thread Steven Bosscher
On Fri, Nov 8, 2013 at 3:40 PM, Joern Rennecke wrote: > bootstrapped / regtested on i686-pc-linux-gnu. Not a very elaborate description of the patch, eh? :-) This is IMHO not OK without at least an explanation of why the comparison of two const_ints is not folded. Better yet would be to fix that

[patch 4/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
As I suggested yesterday on the libstdc++ list, this adds an overload for string and vector iterators to extract a raw pointer and re-use the _Compiler specialization, so that std::regex(".") and std::regex(std::string(".")) and std::regex(std::vector(1, '.')) only instantiate _Compiler once. 2013

Re: [patch 4/4] std::regex refactoring

2013-11-08 Thread Daniel Krügler
2013/11/8 Jonathan Wakely : > As I suggested yesterday on the libstdc++ list, this adds an overload > for string and vector iterators to extract a raw pointer and re-use > the _Compiler specialization, so that std::regex(".") > and std::regex(std::string(".")) and std::regex(std::vector(1, > '.'))

RFA: Fix PR middle-end/59049

2013-11-08 Thread Joern Rennecke
bootstrapped / regtested on i686-pc-linux-gnu. 2013-11-08 Joern Rennecke PR middle-end/59049 * expmed.c (emit_cstore): Avoid generating a comparison of two VOIDmode constants. Index: gcc/expmed.c === --- gc

[patch 2/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
This removes the redundant _CharT template parameters that can be obtained from the _Traits parameters. It also adds the __compile_nfa function to create a _Compiler (deducing its template arguments) and get the _NFA from it. 2013-11-08 Jonathan Wakely * include/bits/regex_automaton.h

[patch 3/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
This removes some more redundant _CharT template parameters. 2013-11-08 Jonathan Wakely * include/bits/regex_compiler.h (__detail::_AnyMatcher, __detail::_CharMatcher, __detail::_BracketMatcher): Remove redundant _CharT template parameters. * include/bits/regex_

[patch 1/4] std::regex refactoring

2013-11-08 Thread Jonathan Wakely
This creates new base classes for the parts of _State and _NFA which are not dependent on template parameters, and replaces some copies with moves. 2013-11-08 Jonathan Wakely * include/bits/regex_automaton.h (__detail::_State): Split non-dependent parts into new _State_base.

[GOOGLE] tune loop scale factor for AutoFDO

2013-11-08 Thread Dehao Chen
AutoFDO sometimes has 0 profile in the loop's entry block because the debug info are lost and unrecoverable. E.g. if (a) if (b) for () {} This patch checks if the scale factor is 0, then use the normal scale. Bootstrapped and passed regression test and performance test. OK for google-4_8

Re: [PATCH] Vectorization using elemental functions

2013-11-08 Thread Aldy Hernandez
On 11/08/13 07:10, Jakub Jelinek wrote: Hi! Here is an updated version of the patch I've posted yesterday. The changes since then are that the expander can now handle the CONSTRUCTORs this patch creates (although we probably want to add some vec_concat optab and at least improve handling of conc

Re: [PATCH] Add gimple subclasses for every gimple code (was Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3))

2013-11-08 Thread Michael Matz
Hi, On Thu, 7 Nov 2013, Alec Teal wrote: > > > subclass, by adding empty subclasses derived from the GSS_-based > > > subclasses as appropriate (I don't bother for gimple codes that already > > > have their own subclass due to having their own GSS layout). I also > > > copied the comments from g

[PATCH] Vectorization using elemental functions

2013-11-08 Thread Jakub Jelinek
Hi! Here is an updated version of the patch I've posted yesterday. The changes since then are that the expander can now handle the CONSTRUCTORs this patch creates (although we probably want to add some vec_concat optab and at least improve handling of concatenation of two half sized vectors into o

Re: [PATCH GCC]Refactor force_expr_to_var_cost and handle type conversion

2013-11-08 Thread Richard Biener
On Fri, Nov 8, 2013 at 2:41 PM, bin.cheng wrote: > Hi, > This patch refactors force_expr_to_var_cost and handles type conversion > along with other tree nodes. It is split from the patch posted at > http://gcc.gnu.org/ml/gcc-patches/2013-11/msg00546.html > Bootstrap and test with the patch loweri

[PATCH GCC]Refactor force_expr_to_var_cost and handle type conversion

2013-11-08 Thread bin.cheng
Hi, This patch refactors force_expr_to_var_cost and handles type conversion along with other tree nodes. It is split from the patch posted at http://gcc.gnu.org/ml/gcc-patches/2013-11/msg00546.html Bootstrap and test with the patch lowering address expressions on x86/x86_64/arm. Is it OK? Thanks

[PATCH][ARM] Add break in handling of comparisons in rtx costs function

2013-11-08 Thread Kyrill Tkachov
Hi all, In arm_new_rtx_costs we need a break; statement after handling the comparisons cases. Otherwise we fall through and compute garbage. This small patch adds that. Tested arm-none-eabi on qemu. Ok for trunk? Thanks, Kyrill 2013-11-08 Kyrylo Tkachov * config/arm/arm.c (arm_new_

Re: Implement C11 _Atomic

2013-11-08 Thread Dominique Dhumieres
> I doubt the patch affects Fortran (there are language-independent changes, > but they are fairly small and shouldn't affect code not using _Atomic > qualifiers). The Fortran failures seem related to revision 204538. Dominique

Re: [PATCH] Reducing number of alias checks in vectorization.

2013-11-08 Thread Dominique Dhumieres
According to http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00197.html revision 204538 is breaking several tests. On x86_64-apple-darwin* the failures I have looked at are of the kind /opt/gcc/work/gcc/testsuite/gfortran.dg/typebound_operator_9.f03: In function 'nabla2_cart2d': /opt/gcc/work/gcc

Re: Implement C11 _Atomic

2013-11-08 Thread Joseph S. Myers
On Fri, 8 Nov 2013, Dominique Dhumieres wrote: > This revision may also causes the failures of > gfortran.dg/typebound_operator_9.f03 and > FAIL: gfortran.fortran-torture/execute/forall_1.f90. I doubt the patch affects Fortran (there are language-independent changes, but they are fairly small a

Re: Implement C11 _Atomic

2013-11-08 Thread Joseph S. Myers
On Fri, 8 Nov 2013, Uros Bizjak wrote: > Can we introduce a target-dependant source here, in the same way as Sure, that seems a reasonable thing to do. I think putting a file fenv.c in an appropriate subdirectory of libatomic/config will result in it being found automatically by the existing s

Re: Implement C11 _Atomic

2013-11-08 Thread Dominique Dhumieres
The tests introduced in revision 204544 fail with -m32 (see http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00213.html or http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg00526.html ). This revision may also causes the failures of gfortran.dg/typebound_operator_9.f03 and FAIL: gfortran.fortran-tor

[PATCH] Fix PR59047

2013-11-08 Thread Richard Biener
The following fixes PR59047 - data-ref and bitfields. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. Index: gcc/tree-predcom.c === *** gcc/tree-predcom.c (revision 204561) --- gcc/tree-predcom.c (

Re: [patch libgcc]: Solve issue about too early released libgcc's DLL

2013-11-08 Thread Corinna Vinschen
Hi, On Nov 8 04:36, Kai Tietz wrote: > Hello, > > this issue was discussed on cygwin's ML some time ago. For shared > libgcc-DLL use it might happen that the DLL is released too early, so > we need to perform an explicit load of it for increasing the > load-count. By this we make sure that the

Re: [PATCH] Add a new option "-ftree-bitfield-merge" (patch / doc inside)

2013-11-08 Thread Richard Biener
> Hello, > This is new patch version. > Comments from Bernhard Reutner-Fischer review applied. > Also, test case bitfildmrg2.c modified - it is now execute test. > > > Example: > > Original code: >D.1351; >D.1350; >D.1349; > D.1349_2 = p1_1(D)->f1; > p2_3(D)->f1 = D.1349_2; > D

Re: [PATCH] RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-08 Thread Bernhard Reutner-Fischer
On 6 November 2013 08:04, Jakub Jelinek wrote: > On Wed, Nov 06, 2013 at 02:24:01AM +, Iyer, Balaji V wrote: >> Fixed patch is attached. The responses to your question are given below. >> Is this patch OK? >> >> Here is the ChangeLog entry: >> >> +2013-11-05 Balaji V. Iyer >> + >> +

Recent Go patch broke Solaris bootstrap

2013-11-08 Thread Rainer Orth
The recent Go patch (couldn't find the submission on gcc-patches) broke Solaris bootstrap: on Solaris 10/x86 I get /vol/gcc/src/hg/trunk/local/libgo/go/net/fd_unix.go:414:72: error: reference to undefined identifier 'syscall.F_DUPFD_CLOEXEC' r0, _, e1 := syscall.Syscall(syscall.SYS_FCNTL, uint

Re: [patch] safe iterator simplification

2013-11-08 Thread Jonathan Wakely
On 7 November 2013 21:00, François Dumont wrote: > > * include/debug/safe_iterator.h (_BeforeBeginHelper<>::_S_Is): > Take only a const safe iterator reference. > (_BeforeBeingHelper<>::_S_Is_beginnest): Likewise. There's a typo here, "Being" not "Begin" > Ok to commit ? Yes, with th

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 2:35 AM, Mingjie Xing wrote: > Oops, if it is not a bug, please close the report > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57258 Well, I've stated my position. I can be swayed by a good argument, if someone has one. I'd give people a chance to weigh in if they can think

Re: [PATCH] fixincludes: use $(FI) instead of fixincl@EXEEXT@

2013-11-08 Thread Bernhard Reutner-Fischer
On 4 April 2013 22:20, Bruce Korb wrote: > Except as noted below, fine by me. > > On 04/04/13 12:56, Bernhard Reutner-Fischer wrote: >> Bootstrapped and regtested on x86_64-unknown-linux-gnu and >> x86_64-mine-linux-uclibc without regressions, ok for trunk? >> >> fixincludes/ChangeLog: >> >> 2013-

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-11-08 Thread James Greenhalgh
> On Tue, Nov 5, 2013 at 9:58 AM, Cong Hou wrote: > > Thank you for your detailed explanation. > > > > Once GCC detects a reduction operation, it will automatically > > accumulate all elements in the vector after the loop. In the loop the > > reduction variable is always a vector whose elements ar

Re: Some wide-int review comments

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 2:30 AM, Richard Sandiford wrote: > From gcse.c: > > --- wide-int-base/gcc/gcc/gcse.c 2013-11-05 13:09:32.148376180 + > +++ wide-int/gcc/gcc/gcse.c 2013-11-05 13:07:28.431495118 + > @@ -1997,6 +1997,13 @@ prune_insertions_deletions (int n_elems) > bitmap_c

Re: [ARM, AArch64] Make aarch-common.c files more robust.

2013-11-08 Thread Ramana Radhakrishnan
On 11/06/13 09:45, James Greenhalgh wrote: Hi, This patch is a respin of the aarch-common improvements to use a generic search to find SETs and the variety of shifts, rather than relying on the hope that we will find something well formed. I've bootstrapped the patch on a chromebook with -mcpu

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Mike Stump
On Nov 8, 2013, at 2:25 AM, Bin.Cheng wrote: > Thanks for elaborating. The warning message is actually for no-use of > variable, and it has few things to do with whether it's accessed or > not. I disagree. If you examine why the warning was put in, you realize it was put in so that lazy progra

Re: [C] Fix PR57258: unused variable warning is emitted for volatile variables

2013-11-08 Thread Mingjie Xing
Oops, if it is not a bug, please close the report http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57258 Thanks, Mingjie 2013/11/8 Richard Biener : > On Fri, Nov 8, 2013 at 10:39 AM, Mike Stump wrote: >> >> On Nov 8, 2013, at 1:32 AM, Bin.Cheng wrote: >> >>> On Fri, Nov 8, 2013 at 5:03 PM, Mike Stum

Some wide-int review comments

2013-11-08 Thread Richard Sandiford
Some comments from looking through the diff with the merge point, ignoring wide-int.h and wide-int.cc. A few more to follow in the form of patchses. dwarf2out.c has: +case CONST_WIDE_INT: + if (mode == VOIDmode) + mode = GET_MODE (rtl); + + if (mode != V

Re: [PATCH 2/3] libstdc++-v3: ::tmpnam depends on uClibc SUSV4_LEGACY

2013-11-08 Thread Bernhard Reutner-Fischer
On 11 April 2013 14:18, Paolo Carlini wrote: > Hi, > > > On 04/11/2013 02:04 PM, Bernhard Reutner-Fischer wrote: >> >> I would have expected that somebody would tell me that omitting ::tmpnam >> violates 27.9.2 from the spec but noone yelled at me yet? > > Frankly, I didn't because the targets I

  1   2   >