> On Nov 8, 2013, at 9:20 AM, Steven Bosscher <stevenb....@gmail.com> wrote: > >> On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: >> Here is what I applied in the end; Jeff told me just to remove the >> testcase. I added the comment trying to explain why it was the >> opposite order of PHI-opt. >> >> Thanks, >> Andrew Pinski >> >> ChangeLog: >> * tree-ssa-ifcombine.c: Include rtl.h and tm_p.h. > > Eh, why??? > > The file has this comment: > > 25 /* rtl is needed only because arm back-end requires it for > 26 BRANCH_COST. */ > 27 #include "rtl.h" > 28 #include "tm_p.h" > > Can you please clarify why this is not something to be fixed in the > ARM back end?
Really BRANCH_COST should be a target hook rather than a macro which should fix this issue. fold-const.c has the same include for the same reason. I thought I had saw a patch which changes it into a hook. Next week if I get time, I will do that. I knew it was the wrong direction which is why I added a comment. Thanks, Andrew > > You're taking the easy way out here, but it's a step in the wrong > direction from modularity point of view. > > Ciao! > Steven
