Re: [Patch, testsuite] fix target/PR49614

2011-09-08 Thread Richard Guenther
On Thu, Sep 8, 2011 at 8:02 PM, Mike Stump wrote: > On Sep 8, 2011, at 1:19 AM, Iain Sandoe wrote: >> gcc.dg/vmx/gcc-bug-i.c is failing for powerpc*-*-* >> with: >> Excess errors: /opt/gcc/work/gcc/testsuite/gcc.dg/vmx/gcc-bug-i.c:16:22: >> warning: always_inline function might not be inlinable [

Re: [PATCH 1/7] Linemap infrastructure for virtual locations

2011-09-08 Thread Jason Merrill
On 09/08/2011 06:32 AM, Dodji Seketeli wrote: Below is the updated patch. OK. Jason

Re: [PATCH 1/7] Linemap infrastructure for virtual locations

2011-09-08 Thread Jason Merrill
On 09/08/2011 06:32 AM, Dodji Seketeli wrote: I have a question about this. It seems to me that adding the whitespace there improves the consistency of the code base, and I thought that it was allowed to make those changes if there are tangent to other meaningful changes done in that area. If e

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-09-08 Thread Jason Merrill
On 09/08/2011 05:54 PM, Dodji Seketeli wrote: Jason Merrill writes: Don't you want to say "This warning is also enabled by @option{-Wunused}, which is enabled by @option{-Wall}."? For the sake of consistency, I followed the pattern used for the other -Wunused-* options in that same file. O

[Patch][Master] Finish function using absolute value not #define value

2011-09-08 Thread Iyer, Balaji V
Hello Everyone, In several places, I found that finish_function was using an absolute integer as input parameter instead of these #defines #define SF_DEFAULT 0 /* No flags. */ #define SF_PRE_PARSED1 /* The function declaration has al

[PATCH][Cilkplus] Patch to fix Template type inside cilk_for

2011-09-08 Thread Iyer, Balaji V
Hello Everyone, This patch is for the Cilk Plus branch GCC C++ compiler. It will fix the following cases of cilk_for (where 'T' is a template type) _Cilk_for ( T ii = ; ii ; ii <+/->= ) Thanks, Balaji V. Iyer. template_cilk_for_patch Description: template_cilk_for_pat

RE: [PATCH, testsuite] Avoid architecture options conflict for case pr42894.c

2011-09-08 Thread Terry Guo
Hello, Is it ok to commit? BR, Terry > -Original Message- > From: Terry Guo [mailto:terry@arm.com] > Sent: Monday, August 29, 2011 9:40 AM > To: 'gcc-patches@gcc.gnu.org' > Subject: RE: [PATCH, testsuite] Avoid architecture options conflict for > case pr42894.c > > Ping. > > BR, >

[v3] libstdc++/50336

2011-09-08 Thread Paolo Carlini
Hi, tested x86_64-linux, committed to mainline. Thanks, Paolo. / 2011-09-09 Paolo Carlini PR libstdc++/50336 * include/bits/streambuf_iterator.h (class istreambuf_iterator): Implement LWG 445 in C++0x mode. * testsuite/24_iterators/istream

Re: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-08 Thread Cary Coutant
Ping? http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html -cary include/ChangeLog:        PR 40831        * demangle.h (enum demangle_component_type): Add        DEMANGLE_COMPONENT_CLONE. libiberty/ChangeLog:        PR 40831        * cp-demangle.c (d_make_comp): Add new component type.  

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-09-08 Thread Dodji Seketeli
Jason Merrill writes: > On 09/08/2011 04:50 PM, Dodji Seketeli wrote: >> Is this be OK for trunk when PR preprocessor/7263 gets in, assuming it >> passes bootstrap and tests on trunk at that moment? > > Yes, except... > >> --- a/gcc/doc/invoke.texi >> +++ b/gcc/doc/invoke.texi >> @@ -3505,6 +3505

Re: [cxx-mem-model] merge from trunk @ 178608

2011-09-08 Thread Andrew MacLeod
On 09/08/2011 04:01 PM, Aldy Hernandez wrote: Nothing to report. I fixed the minor hiccups in previous patches. Bootstrapped and regtested. Sweet. Thanx. Andrew

Re: [PATCH] Fix PR c/50332 (FAIL: gcc.dg/attr-invalid.c)

2011-09-08 Thread Dodji Seketeli
Jason Merrill writes: > On 09/08/2011 04:38 PM, Dodji Seketeli wrote: >> +typedef int ATSYM(type) ATTR; /* used attribute is no more > > "no longer" > > OK with that change. Thanks, I am about to commit this: commit 8c9ae9337b04d05ae89aeea0723d41119e713b41 Author: Dodji Seketeli Date: Thu Se

[Ada] Fix ACATS failures on PowerPC/Linux

2011-09-08 Thread Eric Botcazou
This fixes the 6 ACATS failures present at -O2 on PowerPC/Linux: FAIL: cd1009a FAIL: cd1009i FAIL: cd1c03a FAIL: cd2a21c FAIL: cd2a24a FAIL: cd2a32a The problem is a very aggressive SCCVN pass looking through a special view conversion we build in gigi. The optimization relies exclus

Re: [PATCH] Fix PR c/50332 (FAIL: gcc.dg/attr-invalid.c)

2011-09-08 Thread Jason Merrill
On 09/08/2011 04:38 PM, Dodji Seketeli wrote: +typedef int ATSYM(type) ATTR; /* used attribute is no more "no longer" OK with that change. Jason

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-09-08 Thread Jason Merrill
On 09/08/2011 04:50 PM, Dodji Seketeli wrote: Is this be OK for trunk when PR preprocessor/7263 gets in, assuming it passes bootstrap and tests on trunk at that moment? Yes, except... --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -3505,6 +3505,7 @@ To suppress this warning use the @s

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-09-08 Thread Dodji Seketeli
Jason Merrill writes: > I think -Wunused and -Wall should imply -Wunused-local-typedefs unless > the user specifies -Wno-unused-local-typedefs. Dodji Seketeli writes: > I actually first tried this (actually adding it to -Wall -extra and > -Wunused) and found out the following issue. > > A typ

[PATCH] Fix PR c/50332 (FAIL: gcc.dg/attr-invalid.c)

2011-09-08 Thread Dodji Seketeli
Hello, To support -Wunused-local-typedefs we mark used typedef decls as being used. Logically, __attribute__((used)) is no more ignored on typedef decls. I forgot to adjust the relevant test of the test suite. My testing should have caught that, but it somehow felt below my radar. Sorry for tha

[cxx-mem-model] merge from trunk @ 178608

2011-09-08 Thread Aldy Hernandez
Nothing to report. I fixed the minor hiccups in previous patches. Bootstrapped and regtested.

[patch, fortran] Further fixes for PR 49479

2011-09-08 Thread Thomas Koenig
Hello world, this patch fixes the same kind of problems that PR 49479 addressed, by applying the same kind of fix to another class of function. I have not bothered to find a test case. Regression-tested. OK for trunk and (after a few days) for 4.6? Thomas 2011-09-08 Thomas Koenig

[commit] Fix PR50318 - ICE optimizing widening multiply-and-accumulate

2011-09-08 Thread Andrew Stubbs
This patch fixes PR50318 in which the compiler fails with a bad gimple expression. The problem was caused by a cut-and-paste error. I don't understand why it wasn't caught in testing, but it's fixed now. Committed as obvious. Andrew 2011-09-08 Andrew Stubbs PR tree-optimization/50318

Re: [v3] constexpr tuple

2011-09-08 Thread Marc Glisse
On Thu, 8 Sep 2011, Christopher Jefferson wrote: This might be totally insane, but I believe that: tuple_cat(tuple_cat(A,B), C) always equivalent to tuple_cat(A,B,C); That's a fine way to find the return type, but for code, doesn't it generate many copies? I think I'd forward_as_tuple and us

Re: [PATCH] check_cfg assert fix

2011-09-08 Thread Bernd Schmidt
On 09/06/11 23:56, Maxim Kuvyrkov wrote: > I agree. I would rather remove the entirety of haifa-sched.c: > check_cfg(); scheduler is not the right place for checking > consistency of CFG. Check_cfg() was useful for debugging scheduler > patches, but now it is more of maintainance overhead. > > D

[pph] Fix token dumping within a window (issue4991046)

2011-09-08 Thread Diego Novillo
When dumping a range of tokens, I was not properly counting the tokens to be dumped, which resulted in empty output when dumping a range of tokens in the middle of a large array. I also reduced the size of the window to print. It was too large to be useful. Tested on x86_64. Committed to branc

Re: [PATCH, i386]: Implement AVX2 all-ones load using vpcmpeqd insn

2011-09-08 Thread Uros Bizjak
On Thu, Sep 8, 2011 at 8:26 PM, Uros Bizjak wrote: > Hello! > > 2011-09-08  Uros Bizjak   > >        * config/i386/i386.c (standard_sse_constant_p): Handle AVX2 modes. >        (standard_sse_constant_opcode) : Change vpcmpeqd template. > > testsuite/ChangeLog: > > 2011-09-08  Uros Bizjak   > >    

[PATCH, i386]: Implement AVX2 all-ones load using vpcmpeqd insn

2011-09-08 Thread Uros Bizjak
Hello! 2011-09-08 Uros Bizjak * config/i386/i386.c (standard_sse_constant_p): Handle AVX2 modes. (standard_sse_constant_opcode) : Change vpcmpeqd template. testsuite/ChangeLog: 2011-09-08 Uros Bizjak * gcc.target/i386/all_one_m256i.c: New test. Tested on x86_64-p

Re: [v3] constexpr tuple

2011-09-08 Thread Christopher Jefferson
On 8 Sep 2011, at 18:34, Paolo Carlini wrote: > On 09/07/2011 07:44 AM, Daniel Krügler wrote: >> Is tuple_cat now considered conforming? >> No, see: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50159 > By the way, Daniel, I was considering giving that issue a try, if you have > tips (or ev

[Patch,AVR]: Fix PR 43746

2011-09-08 Thread Georg-Johann Lay
This patch adds support for named progmem sections. The problem with the current implementation is that all progmem stuff is put into .progmem.data and thus no -gc-sections will have effect or constant merging cannot merge constants/strings in progmem. This patch avoids the hard coded .progmem.da

Re: [Patch, testsuite] fix target/PR49614

2011-09-08 Thread Mike Stump
On Sep 8, 2011, at 1:19 AM, Iain Sandoe wrote: > gcc.dg/vmx/gcc-bug-i.c is failing for powerpc*-*-* > with: > Excess errors: /opt/gcc/work/gcc/testsuite/gcc.dg/vmx/gcc-bug-i.c:16:22: > warning: always_inline function might not be inlinable [-Wattributes] > this is because the function in question

Re: RFA: MN10300: Fix splitting AND insns

2011-09-08 Thread Jeff Law
This is fine after adding a function comment for mn10300_split_and_operand_count; it appears rth forgot it and documenting how the sign of the return value is used would make this easier to understand. - Original Message - From: "Nick Clifton" To: l...@redhat.com, aol...@redhat.com C

Re: Vector Comparison patch

2011-09-08 Thread Uros Bizjak
On Thu, Sep 8, 2011 at 2:41 PM, Richard Guenther wrote: >> All the rest is adjusted in the new version of the patch you can find >> in the attachment. >> >> ChangLog >> >> >> 20011-09-06 Artjoms Sinkarovs >> >>      gcc/ >>      * expr.c (do_store_flag): Expand vector comparison by >>      build

Re: [v3] constexpr tuple

2011-09-08 Thread Paolo Carlini
On 09/07/2011 07:44 AM, Daniel Krügler wrote: Is tuple_cat now considered conforming? No, see: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50159 By the way, Daniel, I was considering giving that issue a try, if you have tips (or even more ;) about the implementation of the C++11 conforming tup

Re: Add unwind information to mips epilogues

2011-09-08 Thread Richard Sandiford
Richard Henderson writes: > On 09/08/2011 03:08 PM, Richard Sandiford wrote: >> Bernd Schmidt writes: >>> @@ -10227,17 +10236,30 @@ mips_expand_prologue (void) >>> emit_insn (gen_blockage ()); >>> } >>> >>> -/* Emit instructions to restore register REG from slot MEM. */ >>> +/* Emit ins

Re: PR middle-end/48660: Assigning to BLKmode RESULT_DECL

2011-09-08 Thread Richard Sandiford
Michael Matz writes: >> if (TREE_CODE (from) == CALL_EXPR && ! aggregate_value_p (from, from) >> && COMPLETE_TYPE_P (TREE_TYPE (from)) >> && TREE_CODE (TYPE_SIZE (TREE_TYPE (from))) == INTEGER_CST >> && ! (((TREE_CODE (to) == VAR_DECL || TREE_CODE (to) == PARM_DECL) >>

Re: [PATCH, ARM] Unaligned accesses for packed structures [1/2]

2011-09-08 Thread Richard Earnshaw
On 26/08/11 17:39, Julian Brown wrote: > On Thu, 25 Aug 2011 18:31:21 +0100 > Julian Brown wrote: > >> On Thu, 25 Aug 2011 16:46:50 +0100 >> Julian Brown wrote: >> >>> So, OK to apply this version, assuming testing comes out OK? (And >>> the followup patch [2/2], which remains unchanged?) >> >>

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-09-08 Thread H.J. Lu
On Wed, Sep 7, 2011 at 12:57 PM, Dodji Seketeli wrote: > Jason Merrill writes: > >> On 09/07/2011 02:01 PM, Dodji Seketeli wrote: >>> + >>>   /* Process declarations and variables for C compiler. >> >> Blank line at the top of the file? > > Oops, I noticed it and changed it in the aggregated patc

Re: [Patch, fortran] [0/4] gfc_ss structs initialization small refactoring

2011-09-08 Thread Mikael Morin
On Tuesday 06 September 2011 09:23:11 Tobias Burnus wrote: > http://gcc.gnu.org/ml/fortran/2011-08/threads.html#00264 > > Mikael Morin wrote: > > the 4 follow-up patches try to refactor some common code > > initializing gfc_ss structs. > > Regression-tested (the 4 patches together only) on x86_64-

Re: Add unwind information to mips epilogues

2011-09-08 Thread Richard Henderson
On 09/08/2011 03:08 PM, Richard Sandiford wrote: > Bernd Schmidt writes: >> @@ -10227,17 +10236,30 @@ mips_expand_prologue (void) >> emit_insn (gen_blockage ()); >> } >> >> -/* Emit instructions to restore register REG from slot MEM. */ >> +/* Emit instructions to restore register REG fr

Re: [PATCH][ARM] Generic tuning

2011-09-08 Thread Richard Earnshaw
On 27/08/11 13:48, Andrew Stubbs wrote: > On 26/08/11 17:18, Joseph S. Myers wrote: >> Again, arm-tables.opt is generated - so the log entry should just be >> >> * config/arm/arm-tables.opt: Regenerate. >> >> and the file should be what you get from regeneration. > > Changelog entry updated.

Re: PR middle-end/48660: Assigning to BLKmode RESULT_DECL

2011-09-08 Thread Michael Matz
Hi, On Thu, 8 Sep 2011, Richard Sandiford wrote: > if (TREE_CODE (from) == CALL_EXPR && ! aggregate_value_p (from, from) > && COMPLETE_TYPE_P (TREE_TYPE (from)) > && TREE_CODE (TYPE_SIZE (TREE_TYPE (from))) == INTEGER_CST > && ! (((TREE_CODE (to) == VAR_DECL || TREE_CODE (to)

Re: Add unwind information to mips epilogues

2011-09-08 Thread Richard Sandiford
Bernd Schmidt writes: > On 09/08/11 16:08, Richard Sandiford wrote: >> Also, this: >> >> @@ -10442,7 +10495,7 @@ mips_expand_epilogue (bool sibcall_p) >> } >>else >> { >> - unsigned int regno; >> + rtx pat; >> >>/* When generating MIPS16 code, the normal >>

Re: Add unwind information to mips epilogues

2011-09-08 Thread Bernd Schmidt
On 09/08/11 16:08, Richard Sandiford wrote: > Also, this: > > @@ -10442,7 +10495,7 @@ mips_expand_epilogue (bool sibcall_p) > } >else > { > - unsigned int regno; > + rtx pat; > > /* When generating MIPS16 code, the normal >mips_for_each_saved_g

Re: [C++ Patch] PR 50324

2011-09-08 Thread Jason Merrill
OK. Jason

Ping^2: PR 50113/50061: Fix ABI breakage from emit_library_call_value_1 patch

2011-09-08 Thread Richard Sandiford
Ping for this patch to emit_library_call_value_1: http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00735.html which fixes a bootstrap failure on MIPS since: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg02341.html Tested on mips64-linux-gnu, mips-sgi-irix6.5 (by Rainer) and on both big and l

Re: Add unwind information to mips epilogues

2011-09-08 Thread Richard Sandiford
Bernd Schmidt writes: > @@ -10227,17 +10236,30 @@ mips_expand_prologue (void) > emit_insn (gen_blockage ()); > } > > -/* Emit instructions to restore register REG from slot MEM. */ > +/* Emit instructions to restore register REG from slot MEM. Also update > + the cfa_restores list. *

Re: Add unwind information to mips epilogues

2011-09-08 Thread Richard Sandiford
Bernd Schmidt writes: > Testing with the shrink-wrapping patch added reveals a problem with the > mips16 "save" insn: sometimes we store registers that shouldn't be > considered saved registers; we have to clear RTX_FRAME_RELATED_P for > these. Testing in progress with mips-elf, "ips16/arch=mips32

Re: [PATCH][Cilkplus] _Cilk_spawn inside contructor and destructor

2011-09-08 Thread H.J. Lu
On Wed, Sep 7, 2011 at 9:28 PM, Iyer, Balaji V wrote: > Hello Everyone, >        This patch is for the Cilk Plus C++ compiler. It will allow users to > use _Cilk_spawn inside constructors and destructors. > > Thanks, > I checked it in for you. -- H.J.

Re: [PATCH][Cilkplus] Local Label inside Cilk_for fix

2011-09-08 Thread H.J. Lu
On Wed, Sep 7, 2011 at 8:30 PM, Iyer, Balaji V wrote: > Hello Everyone, >    Local label inside a _Cilk_for was giving an error in the C++ > Compiler of Cilk Plus GCC branch. This patch should fix that. > > Thanks, I checked it in for you. -- H.J.

Re: [PATCH, Atom] Improve AGU stalls avoidance optimization

2011-09-08 Thread H.J. Lu
On Tue, Sep 6, 2011 at 10:54 AM, Ilya Enkovich wrote: > 2011/9/6 Uros Bizjak : >> >> Please merge your new splitters with corresponding LEA patterns. >> >> OK with this change. >> >> Thanks, >> Uros. >> > > Fixed. Could please someone check it in if it's OK now? > > Thanks, > Ilya > --- > gcc/ > >

Re: [PATCH] Fix PR19831, remove malloc/free pairs

2011-09-08 Thread Richard Guenther
On Thu, 8 Sep 2011, Richard Guenther wrote: > > This implements removal of malloc/free pairs when allowed for a > subset of all possible cases. The idea is to identify possible > candidates (we free the return value of an allocation call) and > for them do not make the allocation function necess

Re: Vector Comparison patch

2011-09-08 Thread Richard Guenther
On Thu, Sep 8, 2011 at 2:41 PM, Richard Guenther wrote: > On Wed, Sep 7, 2011 at 3:15 PM, Artem Shinkarov > wrote: >> On Tue, Sep 6, 2011 at 3:56 PM, Richard Guenther >> wrote: >>> On Tue, Sep 6, 2011 at 4:50 PM, Artem Shinkarov >>> wrote: Here is a new version of the patch which considers

PR middle-end/48660: Assigning to BLKmode RESULT_DECL

2011-09-08 Thread Richard Sandiford
PR 48660 is about an ICE on code like: template struct val { char a[N]; }; class Base { public: virtual val<2> get2() const = 0; }; class Derived : public virtual Base { public: virtual val<2> get2() const { return foo->get2(); } Base *foo; }; Base* make() { retu

Re: Vector Comparison patch

2011-09-08 Thread Richard Guenther
On Wed, Sep 7, 2011 at 3:15 PM, Artem Shinkarov wrote: > On Tue, Sep 6, 2011 at 3:56 PM, Richard Guenther > wrote: >> On Tue, Sep 6, 2011 at 4:50 PM, Artem Shinkarov >> wrote: >>> Here is a new version of the patch which considers the changes from >>> 2011-09-02  Richard Guenther >>> >>> >>> Cha

[PATCH] Fix PR19831, remove malloc/free pairs

2011-09-08 Thread Richard Guenther
This implements removal of malloc/free pairs when allowed for a subset of all possible cases. The idea is to identify possible candidates (we free the return value of an allocation call) and for them do not make the allocation function necessary because of the free. If nothing else made the allo

[C++ Patch] PR 50324

2011-09-08 Thread Paolo Carlini
Hi, seems just one of these straightforward cases where we don't propagate the complain argument thoroughly enough. Tested x86_64-linux. Ok for mainline? Thanks, Paolo. / /cp 2011-09-08 Paolo Carlini PR c++/50324 * typeck2.c (digest_init_r): Call complete_type

Re: [PATCH, PR 50287] Do not create SSA names for unused non-register parameters in IPA-split

2011-09-08 Thread Richard Guenther
On Wed, Sep 7, 2011 at 7:18 PM, Martin Jambor wrote: > Hi, > > the patch below should fix PR 50287 (and its many duplicates) by > simply never attempting to create new default-defs for unused > non-register parameters and using their DECL when calling the split > function.  Note that all of this i

[Patch, testsuite] fix target/PR49614

2011-09-08 Thread Iain Sandoe
gcc.dg/vmx/gcc-bug-i.c is failing for powerpc*-*-* with: Excess errors: /opt/gcc/work/gcc/testsuite/gcc.dg/vmx/gcc-bug-i.c: 16:22: warning: always_inline function might not be inlinable [- Wattributes] this is because the function in question is declared: static DO_INLINE int inline_me(vector s

[PATCH, SMS] Minor misc. fixes

2011-09-08 Thread Revital Eres
Hello, The attached patch contains minor fixes. Currently testing and bootstrap on ppc64-redhat-linux enabling SMS on loops with SC 1. OK for mainline once testing completes? Thanks, Revital Changelog * modulo-sched.c (optimize_sc): Call remove_node_from_ps outside of gcc_ass

Re: [PATCH][1/n] Fix parts of PR19831

2011-09-08 Thread Richard Guenther
On Wed, 7 Sep 2011, Andrew Pinski wrote: > On Wed, Sep 7, 2011 at 7:31 AM, Richard Guenther wrote: > > In practice the patch will do something about alloca at most, > > unless, of course, you have a memleak that you don't use ;) > > I think we have "alloca (0);" being required still and aligning

Re: ARM: Emit conditions in push_multi

2011-09-08 Thread Ramana Radhakrishnan
> New patch below. Tested on arm-eabi sim with a few multilibs. OK. Ramana