On Thu, Sep 8, 2011 at 8:02 PM, Mike Stump <mikest...@comcast.net> wrote: > On Sep 8, 2011, at 1:19 AM, Iain Sandoe wrote: >> gcc.dg/vmx/gcc-bug-i.c is failing for powerpc*-*-* >> with: >> Excess errors: /opt/gcc/work/gcc/testsuite/gcc.dg/vmx/gcc-bug-i.c:16:22: >> warning: always_inline function might not be inlinable [-Wattributes] >> this is because the function in question is declared: >> static DO_INLINE int inline_me(vector signed short data) ; >> where: >> #define DO_INLINE __attribute__ ((always_inline)) >> so, unless __attribute__ ((always_inline)) is intended to imply "inline", >> the fix below is proposed, >> OK for trunk? > > I'd like an inline person to comment on this.
A function not declared inline with an always_inline attribute is a bug. So, the patch looks ok to me. Richard.