Go patch committed: Use backend interface for variables

2011-04-18 Thread Ian Lance Taylor
This patch to the Go frontend uses the backend interface for variables. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2011-04-18 Ian Lance Taylor * go-gcc.cc: Include "go-c.h". (class Bvariable): Define. (Gcc_backend::init_s

Re: PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode on for plugin files

2011-04-18 Thread Laurynas Biveinis
On 04/11/2011 04:35 AM, Basile Starynkevitch wrote: > 2011-04-11 Basile Starynkevitch > > * gengtype.h (struct input_file_st): Add inpisplugin field. > (type_fileloc): New function. > * gengtype.c > (write_typed_struct_alloc_def): Add gcc_assert. > (write_typed_al

Re: Fix gengtype-state string hashtable

2011-04-18 Thread Laurynas Biveinis
2011/4/17 Nicola Pero : > While reading GCC code, I noticed that in gengtype-state.c > the equality function in a string hashtable is set to strcmp. > > But that returns 0 (ie, false for hashtable.c) when the strings > are equal!  I can't see how that hashtable would ever work.  Do > we have any te

Re: Fix PR48675: 20_util/hash/chi2_quality.cc timeout for simulator targets

2011-04-18 Thread Paolo Carlini
Hi, > Ok to commit, trunk as well as older branches? Ok. Thanks, Paolo

Fix PR48675: 20_util/hash/chi2_quality.cc timeout for simulator targets

2011-04-18 Thread Hans-Peter Nilsson
See PR48675 for details. It also mentions a secondary issue, a performance regression introduced in 172607:172613 after an improvement introduced in 172417:172431. If you look at the test, it has this nice line, // { dg-options "-std=gnu++0x -DSAMPLES=1" { target simulator } } (the default SA

Re: Improve stack layout heuristic.

2011-04-18 Thread Easwaran Raman
On Mon, Apr 18, 2011 at 5:58 AM, Michael Matz wrote: > > Hi, > > [FWIW I can't approve patches, but some feedback nevertheless] > > On Sun, 17 Apr 2011, Easwaran Raman wrote: > > >  This patch impoves the heuristic used in assigning stack location to > > stack variables.  Currently, if there are 3

[v3] Implement is_nothrow_*_constructible, is_copy_constructible, is_move_constructible

2011-04-18 Thread Paolo Carlini
Hi, the below implements a few traits - among which those necessary for move_if_noexcept, obviously forthcoming, at this point - per the FDIS and fixes is_nothrow_constructible vs the issue noticed at the end of the audit trail of 48531: Daniel clarified that, per the FDIS anyway (seems a co

[pph] Namespaces, step 1. Trace formatting. (issue4433054)

2011-04-18 Thread Lawrence Crowl
First stab at getting namespaces working with PPH. This change will put top-level namespaces into the global namespace. It does not, however, appear to their members in any place useful. Some tuning of tracing output. Index: gcc/cp/ChangeLog.pph 2011-04-18 Lawrence Crowl * pph.c (p

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-18 Thread Jan Hubicka
> > Hi! > > > > If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically > > adjusted, but none of the callers are prepared to handle that. > > Thus, this patch makes devirtualization give up in those cases. > > > > Bootstrapped/regtested on x86_64-linux and i686-linux, trunk and 4.6. >

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-18 Thread Jan Hubicka
> Hi! > > If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically > adjusted, but none of the callers are prepared to handle that. > Thus, this patch makes devirtualization give up in those cases. > > Bootstrapped/regtested on x86_64-linux and i686-linux, trunk and 4.6. > On the trunk

C++ PATCH for c++/48569 (ICE on void())

2011-04-18 Thread Jason Merrill
Another problem caused by the switch to using build_value_init in build_functional_cast. We need to handle void specifically. Tested x86_64-pc-linux-gnu, applied to trunk. commit 43c47963012ad752079f8fd368083feea263236e Author: Jason Merrill Date: Mon Apr 18 16:20:15 2011 -0700 PR c

Re: [google] Avoid reading struct member from structure generated by different gcc version (issue4446047)

2011-04-18 Thread Diego Novillo
On Mon, Apr 18, 2011 at 17:24, Richard Guenther wrote: > On Mon, Apr 18, 2011 at 9:59 PM,   wrote: >> LGTM >> >> >> http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c >> File gcc/libgcov.c (right): >> >> http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c#newcode155 >> gcc/libgcov.c

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-18 Thread H.J. Lu
On Mon, Apr 18, 2011 at 2:40 PM, Jakub Jelinek wrote: > Hi! > > If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically > adjusted, but none of the callers are prepared to handle that. > Thus, this patch makes devirtualization give up in those cases. > > Bootstrapped/regtested on x86_64

C++ PATCH for c++/48537 (ICE with value-initialization of union with deleted ctor)

2011-04-18 Thread Jason Merrill
The check for UNION_TYPE predates the C++0x extension of unions to allow members with constructors; now we can have a union that needs non-trivial initialization. Tested x86_64-pc-linux-gnu, applying to trunk and 4.6. commit 019dffcf98bb95ebbcb9180d76293b899d674ecf Author: Jason Merrill Date:

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-18 Thread Jason Merrill
On 04/18/2011 02:40 PM, Jakub Jelinek wrote: If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically adjusted, but none of the callers are prepared to handle that. Well, it means that we do dynamic adjustment at runtime. If we're able to do devirtualization, we should be able to fi

Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-18 Thread Richard Guenther
On Mon, Apr 18, 2011 at 11:40 PM, Jakub Jelinek wrote: > Hi! > > If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically > adjusted, but none of the callers are prepared to handle that. > Thus, this patch makes devirtualization give up in those cases. > > Bootstrapped/regtested on x86_6

[patch] Fix PR lto/48148

2011-04-18 Thread Eric Botcazou
Hi, this is the assembler error during an LTO bootstrap: cc1.ltrans8.s: Assembler messages: cc1.ltrans8.s:249143: Error: symbol `.Ldebug_info0' is already defined In the assembly file: .Letext0: .file 93 "/home/eric/svn/gcc/gcc/c-parser.c" .section.debug_info,"",@progbit

[PATCH] Fix incorrect devirtualization (PR middle-end/48661)

2011-04-18 Thread Jakub Jelinek
Hi! If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically adjusted, but none of the callers are prepared to handle that. Thus, this patch makes devirtualization give up in those cases. Bootstrapped/regtested on x86_64-linux and i686-linux, trunk and 4.6. On the trunk the testcase ICE

[PATCH] Stop in note_eh_region_may_contain_throw after ERT_MUST_NOT_THROW (PR tree-optimization/48611)

2011-04-18 Thread Jakub Jelinek
Hi! My understanding is that RT_MUST_NOT_THROW regions shouldn't ever propagate exceptions to outer regions, they'd terminate the program instead. So, we don't need to mark outer regions as possibly needing to handle throw. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 201

[PATCH] Fix ICE on omp for with type dependent pointer iterator (PR c++/48632)

2011-04-18 Thread Jakub Jelinek
Hi! When the omp for iterator is known to be a pointer, even when it is type dependent there is no point in assuming it might be a class iterator, and by not calling cp_parser_omp_for_incr we can avoid troubles with using PLUS_EXPR when POINTER_PLUS_EXPR ought to be used (similarly for MINUS_EXPR

[patch] Fix PR lto/48492 (bis)

2011-04-18 Thread Eric Botcazou
Hi, this is the second ICE during an LTO bootstrap with Ada enabled: the assertion at dwarf2out.c:11422 fails: 11422 gcc_assert (AT_ref (a)->die_offset); It's again a fallout of the DW_TAG_GNU_call_site patch: (gdb) p debug_dwarf_die(die) DIE 1022787: DW_TAG_GNU_call_site (0x7f

Re: [PATCH] passes.texi: fill crossref nodes (GCC Internals)

2011-04-18 Thread Gerald Pfeifer
Hi there, On Sun, 11 Jul 2010, crq...@gmail.com wrote: > From: "Dennis, CHENG Renquan" > > Tested with "make info pdf". it seems your patch fell through the cracks. Sorry about that! I have now reviewed it, adjusted the ChangeLog entry, and committed it to the current development head as well

turn lto back on for darwin9*

2011-04-18 Thread Mike Stump
This turns lto back on for all darwin9 releases... 2011-04-18 Jack Howarth PR lto/48086 * configure.ac: Re-enable LTO on *-apple-darwin9*. * configure: Regenerate. 2011-04-18 Jack Howarth PR lto/48086 * configure.ac: Re-enable LTO on *-apple-darwin9

Re: [google] Avoid reading struct member from structure generated by different gcc version (issue4446047)

2011-04-18 Thread Richard Guenther
On Mon, Apr 18, 2011 at 9:59 PM, wrote: > LGTM > > > http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c > File gcc/libgcov.c (right): > > http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c#newcode155 > gcc/libgcov.c:155: filename? filename : "", e, v); > Better split it into two d

Re: [c++] Remove redundant inline check

2011-04-18 Thread Richard Guenther
On Mon, Apr 18, 2011 at 9:02 PM, Mark Mitchell wrote: > On 4/18/2011 11:47 AM, Jan Hubicka wrote: > >> Bootstrapped/regtested x86_64-linux, OK? >> >>       * cp/semantics.c (finish_goto_stmt): Do set UNINLINABLE flag on >> computed >>       gotos. > > Provided that we have this check elsewhere in

Re: PATCH: PR middle-end/48440: [4.7 Regression] FAIL: gcc.c-torture/compile/labels-3.c

2011-04-18 Thread Richard Guenther
On Mon, Apr 18, 2011 at 7:52 PM, Steve Ellcey wrote: > On Sat, 2011-04-16 at 00:49 +0200, Michael Matz wrote: > >> Callers of expand_expr are expected to deal with the situation that the >> returned object doesn't have the desired mode, hence I think it's okay for >> expand_expr to return a DImode

Re: Allow more PowerPC sibling calls

2011-04-18 Thread Mike Stump
On Apr 18, 2011, at 10:24 AM, David Edelsohn wrote: >> This patch does affect darwin, not only in removing what are now >> redundant insn patterns, but also (a) and (b) above. Would someone >> please run a bootstrap and regression test on darwin for me? I don't >> have a machine handy to confirm

Re: [PATCH, Fortran] A tweak to fortran -> call graph interface

2011-04-18 Thread Tobias Burnus
Martin Jambor wrote: It seems to me that fortran can call cgraph_create_node directly without checking for its existence first. Bootstrapped and tested on x86_64-linux without any problems, tests on i686 in progress. The patch is OK. Tobias 2011-03-18 Martin Jambor * trans-decl.c

Re: [Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-18 Thread Steve Kargl
On Mon, Apr 18, 2011 at 11:41:33PM +0300, Janne Blomqvist wrote: > Hi, > > the attached patch replaces gfc_getmem with calls to xcalloc (from > libiberty). Apart from reducing duplicated code, calloc is better than > malloc + memset, as the allocator knows that the kernel always gives > out zeroed

Re: [PATCH] doubled words

2011-04-18 Thread Jim Meyering
Diego Novillo wrote: ... > Feel free to commit any of the patches in this series of typo fixes > you just posted. Thanks. Done, with this: From 7d5f43492809f2d96149853941bc8e0a9e7ecd10 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 18 Apr 2011 22:31:36 +0200 Subject: [PATCH] fix doubled-

Re: Even more inliner cleanups

2011-04-18 Thread H.J. Lu
On Mon, Apr 18, 2011 at 11:44 AM, Jan Hubicka wrote: > Hi, > this patch is result of another pass through ipa-inline.c cleaning up > confused and outdated comments. > > I also fixed accounting of growth caused by the small function inlining. > We do not want to base it on program size before flatt

[Patch, fortran] Use xcalloc instead of gfc_getmem

2011-04-18 Thread Janne Blomqvist
Hi, the attached patch replaces gfc_getmem with calls to xcalloc (from libiberty). Apart from reducing duplicated code, calloc is better than malloc + memset, as the allocator knows that the kernel always gives out zeroed pages so in some cases it can avoid memset'in the area. Regtested on x86_64

Re: [PATCH v4] Re: avoid useless if-before-free tests

2011-04-18 Thread Jim Meyering
Tom Tromey wrote: >> "Jim" == Jim Meyering writes: > > Jim> Since v3, I've rebased these and moved the fortran changes to precede > Jim> these (changing gfc_free to free introduced a few more instances > Jim> that this transformation deals with). As mentioned before, the > Jim> conditional-re

Re: [PATCH v4] Re: avoid useless if-before-free tests

2011-04-18 Thread Tom Tromey
> "Jim" == Jim Meyering writes: Jim> Since v3, I've rebased these and moved the fortran changes to precede Jim> these (changing gfc_free to free introduced a few more instances Jim> that this transformation deals with). As mentioned before, the Jim> conditional-removing transformation was do

Re: [google] Avoid reading struct member from structure generated by different gcc version (issue4446047)

2011-04-18 Thread davidxl
LGTM http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c File gcc/libgcov.c (right): http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c#newcode155 gcc/libgcov.c:155: filename? filename : "", e, v); Better split it into two different printfs as the format is different -- otherwise

[PATCH v4] Re: avoid useless if-before-free tests

2011-04-18 Thread Jim Meyering
Since v3, I've rebased these and moved the fortran changes to precede these (changing gfc_free to free introduced a few more instances that this transformation deals with). As mentioned before, the conditional-removing transformation was done mechanically with two manual corrections. One to deal

[PATCH, i386]: Macroize movmsk/maskmov insns

2011-04-18 Thread Uros Bizjak
Hello! Attached patch macroizes movmsk and maskmov instructions. As an added bonus, it also implements maskmovdqu tests, so "%%%" comment can be removed. 2011-04-18 Uros Bizjak * config/i386/i386.h (SSE_VEC_FLOAT_MODE_P): Remove. (AVX_FLOAT_MODE_P): Ditto. (AVX128_VEC

Re: [PATCH] doubled words

2011-04-18 Thread Diego Novillo
On Mon, Apr 18, 2011 at 11:40, Jim Meyering wrote: > Mike Stump wrote: >> On Apr 16, 2011, at 4:04 AM, Gerald Pfeifer wrote: >>> On Fri, 15 Apr 2011, Mike Stump wrote: I think these are obvious. >>> >>> Which means that you can commit them without getting explicit approval >> >> Well, techni

Re: [c++] Remove redundant inline check

2011-04-18 Thread Mark Mitchell
On 4/18/2011 11:47 AM, Jan Hubicka wrote: > Bootstrapped/regtested x86_64-linux, OK? > > * cp/semantics.c (finish_goto_stmt): Do set UNINLINABLE flag on computed > gotos. Provided that we have this check elsewhere in the compiler and are therefore confident we won't accidentally inli

Re: [pph] Macro Validation Correction (issue4425041)

2011-04-18 Thread Diego Novillo
On Mon, Apr 18, 2011 at 14:58, Lawrence Crowl wrote: > On 4/16/11, Diego Novillo wrote: >> On Apr 14, 2011 Lawrence Crowl wrote: >> > +/* Make sure the bitfield directive_index in include/cpplib.h is large >> > +   enough to index the entire table.  */ >> > + >> > +unsigned char too_many_directi

Re: [pph] Macro Validation Correction (issue4425041)

2011-04-18 Thread Lawrence Crowl
On 4/16/11, Diego Novillo wrote: > On Apr 14, 2011 Lawrence Crowl wrote: > > Unfortunately, five bits are not sufficient for the alternate > > use of cpp_hashnode.directive_index as a named operator index. > > So, I have reverted the number of bits from five back to seven. > > As a result, we now

Re: [PATCH] doubled words

2011-04-18 Thread Mike Stump
On Apr 18, 2011, at 8:40 AM, Jim Meyering wrote: > If you hadn't said anything, I would have committed those typo fixes > by now, based on what I perceived as your review/approval and on my > reading of this part of http://gcc.gnu.org/svnwrite.html: > >Free for all > >The following change

Re: PR 47793 - Support relative paths using -fprofile-generate (issue4434055)

2011-04-18 Thread Martin Thuresson
On Mon, Apr 18, 2011 at 10:48 AM, Martin Thuresson wrote: > This is slightly updated from my previous patch proposal. The test now > correctly work if multiple tests are executed in parallell. Forgot to mention that this patch has been bootstrapped without regression on x86_64 and should be consi

Re: [PATCH] doubled words

2011-04-18 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Mon, Apr 18, 2011 at 05:40:03PM CEST: > Mike Stump wrote: > > On Apr 16, 2011, at 4:04 AM, Gerald Pfeifer wrote: > >> On Fri, 15 Apr 2011, Mike Stump wrote: > >>> I think these are obvious. > >> > >> Which means that you can commit them without getting explicit appr

[c++] Remove redundant inline check

2011-04-18 Thread Jan Hubicka
Hi, the test whether function contains computed goto is re-done by tree-inline (and re-done after optimization, so it is bit more sensitive). There is also nothing language specific in this. Bootstrapped/regtested x86_64-linux, OK? * cp/semantics.c (finish_goto_stmt): Do set UNINLINABL

Even more inliner cleanups

2011-04-18 Thread Jan Hubicka
Hi, this patch is result of another pass through ipa-inline.c cleaning up confused and outdated comments. I also fixed accounting of growth caused by the small function inlining. We do not want to base it on program size before flattening, but afterwards. Just like always inlines are not (and shou

Re: Unreviewed build, lto, doc patches

2011-04-18 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Apr 18, 2011 at 08:23:37PM CEST: > * Rainer Orth wrote on Mon, Apr 18, 2011 at 12:16:57PM CEST: > > [build, doc] Cleanup --enable-threads support > > http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00735.html > > > > This one needs build and doc maintainers

[PATCH] Change rclass argument type in memory_move_cost function from enum reg_class to reg_class_t.

2011-04-18 Thread Anatoly Sokolov
Hello. This patch change memory_move_cost function to stop using back end specific type 'enum reg_class' in favor to reg_class_t. Also this allow do small cleanup in ia64_register_move_cost function. The patch has been bootstrapped on and regression tested on x86_64-unknown-linux-gnu and ia

Re: Unreviewed build, lto, doc patches

2011-04-18 Thread Ralf Wildenhues
* Rainer Orth wrote on Mon, Apr 18, 2011 at 12:16:57PM CEST: > The following patches have remained unreviewed for more than a week: > > [build, lto] Check plugin linker for level of plugin support > http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00226.html > > This one primarily needs

Re: [build, doc] Remove --enable-threads=solaris support

2011-04-18 Thread Ralf Wildenhues
Hi Rainer, * Rainer Orth wrote on Mon, Mar 21, 2011 at 12:55:23PM CET: > 2011-03-20 Rainer Orth > > gcc: > * gthr-solaris.h: Remove. > * gthr.h (_SOLARIS_THREADS): Don't include gthr-solaris.h, remove. > * config/sol2.h (CPP_SUBTARGET_SPEC): Remove -threads support. >

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-04-18 Thread Ralf Wildenhues
Hello Rainer, * Rainer Orth wrote on Mon, Apr 04, 2011 at 06:15:28PM CEST: > Here's a patch that does this. I'm not at all happy with the patch > since it partially duplicates the logic to determine linker version > numbers. While this could (and probably should) be generalized along > the lines

Re: Unreviewed build, lto, doc patches

2011-04-18 Thread Gerald Pfeifer
On Mon, 18 Apr 2011, Rainer Orth wrote: > [build, doc] Cleanup --enable-threads support > http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00735.html > > This one needs build and doc maintainers. The doc side is fine once the build side is approved. Thanks, Gerald

Re: PATCH: PR middle-end/48440: [4.7 Regression] FAIL: gcc.c-torture/compile/labels-3.c

2011-04-18 Thread Steve Ellcey
On Sat, 2011-04-16 at 00:49 +0200, Michael Matz wrote: > Callers of expand_expr are expected to deal with the situation that the > returned object doesn't have the desired mode, hence I think it's okay for > expand_expr to return a DImode code_label rtx. Meaning we have to deal > with it. The

PR 47793 - Support relative paths using -fprofile-generate (issue4434055)

2011-04-18 Thread Martin Thuresson
This is slightly updated from my previous patch proposal. The test now correctly work if multiple tests are executed in parallell. 2011-04-17 Martin Thuresson * gcc/doc/invoke.tex: Document support for relative profile paths. * gcc/testsuite/gcc.dg/pr47793.c: New test.

Get rid of warning in dwarf2out.c

2011-04-18 Thread Eric Botcazou
Compiling dwarf2out.c with older versions of GCC yields a warning because is_redundant_typedef has a prototype without the 'inline' keyboard and a declaration with it, and is called from another function in-between. The attached patchlet adds 'inline' to the prototype, as is done for other func

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-18 Thread Georg-Johann Lay
Georg-Johann Lay schrieb: > This is a port of an old patch of mine that got integrated in some > avr-gcc distributions. > > Linking against __do_copy_data resp. __do_clear_bss is only needed if > there is actually stuff in .[ro]data resp. .bss. This saves some space > on tiny targets. > > Regress

Re: [Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-18 Thread Anatoly Sokolov
Hi. +/* To track if code will use .bss and/or .data */ +static int avr_need_clear_bss_p = 0; +static int avr_need_copy_data_p = 0; Change type avr_need_clear_bss_p and avr_need_copy_data_p vars to bool. -#define ASM_OUTPUT_COMMON(STREAM, NAME, SIZE, ROUNDED)\ -do {\ - fputs (

Re: [libgo] Fix __go_append declaration

2011-04-18 Thread Ian Lance Taylor
Rainer Orth writes: > An IRIX 6.5 bootstrap over the weekend broke in libgo: > > /vol/gcc/src/hg/trunk/local/libgo/runtime/go-append.c:22:1: error: > conflicting types for '__go_append' > /vol/gcc/src/hg/trunk/local/libgo/runtime/go-append.c:18:1: note: previous > declaration of '__go_append' w

Re: Allow more PowerPC sibling calls

2011-04-18 Thread Nathan Froyd
On Sat, Apr 09, 2011 at 12:21:46PM +0930, Alan Modra wrote: > a) Allow sibling calls via function pointer. At the time >rs6000_function_ok_for_sibcall was written, I don't think access to >arg types of function pointer calls was available in the target >hook/macro. > > + /* Functi

Re: Allow more PowerPC sibling calls

2011-04-18 Thread David Edelsohn
On Fri, Apr 8, 2011 at 10:51 PM, Alan Modra wrote: > This patch enables sibling calls for powerpc in a few more cases, and > fixes bugs exposed by that change.  We now > a) Allow sibling calls via function pointer.  At the time >   rs6000_function_ok_for_sibcall was written, I don't think access t

[libgo] Reduce fmt_test.TestScanInts recursion depth (PR go/48553)

2011-04-18 Thread Rainer Orth
As described in the PR, fmt FAILs on targets without split-stack support (anything but Linux, it seems) since the 32-bit TestScanInts tests overflows the default thread stack of 1 MB. To avoid this, I've reduced the recursion depth from 1000 to 800 which lets the test pass. Rainer 2011-

[Patch,AVR]: PR18145: do_copy_data & do_clear_bss only if needed

2011-04-18 Thread Georg-Johann Lay
This is a port of an old patch of mine that got integrated in some avr-gcc distributions. Linking against __do_copy_data resp. __do_clear_bss is only needed if there is actually stuff in .[ro]data resp. .bss. This saves some space on tiny targets. Regression-tested for C Johann 2011-04-18 Geor

Re: [build] Avoid ld -v error message with Sun ld on SPARC

2011-04-18 Thread Rainer Orth
David, > Thanks Rainer, if you cons up a patch to add the ".align" directive I'll ACK > that as well. here's the patch that I've been testing over the weekend. It caused no change for HAVE_AS_SPARC_GOTDATA_OP on anything but Solaris 10 with gas and Sun ld, where HAVE_AS_SPARC_GOTDATA_OP is 1 now

[PATCH, Fortran] A tweak to fortran -> call graph interface

2011-04-18 Thread Martin Jambor
Hi, this is a ping of a patch from the big cgraph_removal series that has not got in yet (http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00523.html). I'd like some Fortran reviewers to have a look, the fewer the calls to cgraph_get_create_node the better. Thanks a lot, Martin ---

Re: [patch] make default linker --hash-style configurable option

2011-04-18 Thread Paul Pluzhnikov
Ping? Ping? On Mon, Apr 11, 2011 at 11:00 AM, Paul Pluzhnikov wrote: > Ping? -- Paul Pluzhnikov

Re: [Patch, Fortran] PR 18918 - coarray diagnostic fixes

2011-04-18 Thread Daniel Kraft
On 04/18/11 18:34, Tobias Burnus wrote: Encountered them when testing IMAGE_INDEX. Build and regtested on x86-64-linux. OK for the trunk? Ok. Thanks! Daniel -- http://www.pro-vegan.info/ -- Done: Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz To go: Hea-Mon-Pri

[wwwdocs] PATCH for Re: GCC 4.4.6 Released

2011-04-18 Thread Gerald Pfeifer
On Mon, 18 Apr 2011, Jakub Jelinek wrote: > The GNU Compiler Collection version 4.4.6 has been released. And the GCC 4.4 status adjusted as follows... Gerald Index: index.html === RCS file: /cvs/gcc/wwwdocs/htdocs/index.html,v retri

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-18 Thread Denis Chertykov
2011/4/18 Denis Chertykov : > 2011/4/18 Georg-Johann Lay : > Few years ago I have played with early splitting of anything possible > (move,add,sub,and,...). The results was very bad. > It's happened because flow of splitted insns (8bits insns) becomes > unreadable for most of GCC optimisation passe

[Patch, Fortran] PR 18918 - coarray diagnostic fixes

2011-04-18 Thread Tobias Burnus
Encountered them when testing IMAGE_INDEX. Build and regtested on x86-64-linux. OK for the trunk? Tobias 2011-04-18 Tobias Burnus PR fortran/18918 * array.c (gfc_match_array_ref): Check for too many codimensions. * check.c (gfc_check_image_index): Check number of elements in SUB argument

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-18 Thread Jim Meyering
Janne Blomqvist wrote: > On Mon, Apr 18, 2011 at 18:08, Jim Meyering wrote: >> I've rebased and divided/reordered these changes as you suggested. >> Here are the fortran parts.  I'll post the other parts separately. >> Parts 1 and 3 are manual.  Part 2 is the big mechanical change with >> two man

Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.

2011-04-18 Thread Denis Chertykov
2011/4/18 Georg-Johann Lay : > Denis Chertykov schrieb: >> 2011/4/17 Denis Chertykov : >>> 2011/4/15 Georg-Johann Lay : Finally, I exposed alternative #3 of the insns to the register allocator, because it is not possible to distinguish between overlapping or non-overlapping regs, and

RE: [AVR] Couple of tweaks

2011-04-18 Thread Weddington, Eric
> -Original Message- > From: Eric Botcazou [mailto:ebotca...@adacore.com] > Sent: Monday, April 18, 2011 4:57 AM > To: gcc-patches@gcc.gnu.org > Subject: [AVR] Couple of tweaks > > Hi, > > attached is a couple of tweaks to the AVR back-end that we have in our > tree: > > 1. libgcc can

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-18 Thread Janne Blomqvist
On Mon, Apr 18, 2011 at 18:08, Jim Meyering wrote: > I've rebased and divided/reordered these changes as you suggested. > Here are the fortran parts.  I'll post the other parts separately. > Parts 1 and 3 are manual.  Part 2 is the big mechanical change with > two manual adjustments: > >  [PATCH 1

Re: [PATCH 4/4] Devirtualization based on global objects

2011-04-18 Thread Martin Jambor
Hi, On Fri, Apr 15, 2011 at 05:38:50PM +0200, Richard Guenther wrote: > On Fri, 15 Apr 2011, Martin Jambor wrote: > > > Hi, > > > > this is the patch that actually speeds up astar (together with the > > previous one). It implements devirtualization based on global > > objects. In the past we h

Re: Remove vtable_method field in cgraph_node

2011-04-18 Thread Jan Hubicka
> On Mon, 18 Apr 2011, Jan Hubicka wrote: > > > > Ah, no. We _did_ that in CCP but now we only adjust the OBJ_TYPE_REF > > > expr in CCP and defer to fold_stmt to eventually "devirtualize" it. > > > See PR45878. Then rev.165435 was necessary, as we dropped OBJ_TYPE_REF > > > for the non-devirtua

[testsuite] Disable gcc.dg/guality and gfortran.dg/guality on Tru64 UNIX (PR testsuite/48251)

2011-04-18 Thread Rainer Orth
As already done for the g++.dg/guality driver, I'm also disabling the remaining guality testsuites on Tru64 UNIX: the gcc.dg one doesn't even start: gdb: took too long to attach and the gfortran tests either fail or are unsupported. It seems gdb on this platform is in a miserable state right now

Re: [PATCH 3/4] Simple relaxation of dynamic type change detection routine

2011-04-18 Thread Martin Jambor
Hi, On Fri, Apr 15, 2011 at 05:28:49PM +0200, Richard Guenther wrote: > On Fri, 15 Apr 2011, Martin Jambor wrote: > > > Hi, > > > > in order to speed up astar, I had to persuade the function that > > decides whether a statement potentially modifies the dynamic type of > > an object by storing a

Re: [PATCH 2/4] Handle calls to ancestor objects in IPA-CP devirtualization

2011-04-18 Thread Martin Jambor
Hi, On Fri, Apr 15, 2011 at 05:26:44PM +0200, Richard Guenther wrote: > On Fri, 15 Apr 2011, Martin Jambor wrote: > > > Hi, > > > > early inlining can create virtual calls based on the part of an object > > that represents an ancestor. This patch makes ipa-prop analysis able > > to recognize su

Re: [PATCH] doubled words

2011-04-18 Thread Jim Meyering
Mike Stump wrote: > On Apr 16, 2011, at 4:04 AM, Gerald Pfeifer wrote: >> On Fri, 15 Apr 2011, Mike Stump wrote: >>> I think these are obvious. >> >> Which means that you can commit them without getting explicit approval > > Well, technically, it means nothing... It only means something if the >

[testsuite] Remove dg-do run from gcc.dg/vect/pr48377.c

2011-04-18 Thread Rainer Orth
The gcc.dg/vect/pr48377.c execution test is currently failing on Solaris 8/x86 and Solaris/SPARC. On Solaris 8/x86, this happens because the test is compiled with -msse2, but the OS cannot execute SSE2 insns. This is usually taken care of by vect.exp, which only runs the tests as compile tests if

Re: Remove vtable_method field in cgraph_node

2011-04-18 Thread Richard Guenther
On Mon, 18 Apr 2011, Jan Hubicka wrote: > > Ah, no. We _did_ that in CCP but now we only adjust the OBJ_TYPE_REF > > expr in CCP and defer to fold_stmt to eventually "devirtualize" it. > > See PR45878. Then rev.165435 was necessary, as we dropped OBJ_TYPE_REF > > for the non-devirtualized call a

Re: Remove vtable_method field in cgraph_node

2011-04-18 Thread Jan Hubicka
> Ah, no. We _did_ that in CCP but now we only adjust the OBJ_TYPE_REF > expr in CCP and defer to fold_stmt to eventually "devirtualize" it. > See PR45878. Then rev.165435 was necessary, as we dropped OBJ_TYPE_REF > for the non-devirtualized call as well. As both cases were because Hmm, sounds

Re: [testsuite, fortran] Compile gfortran.dg/fmt_g0_5.f08 with -mieee

2011-04-18 Thread Janne Blomqvist
On Mon, Apr 18, 2011 at 17:59, Rainer Orth wrote: > The new gfortran.dg/fmt_g0_5.f08 test fails on Tru64 UNIX at runtime > with > > Floating point exception > > but passes if compiled with -mieee. > > The following patch implements this, tested with the appropriate runtest > invocation. > > Ok fo

Re: RFA: Gimple calls to "internal" functions

2011-04-18 Thread Richard Guenther
On Mon, Apr 18, 2011 at 3:37 PM, Richard Sandiford wrote: > Richard Guenther writes: >>> +/* Expand a call to internal function FN.  ARGS is an array of the >>> +   function's arguments and LHS is where the result should be stored.  */ >>> + >>> +void >>> +expand_internal_call (enum internal_fn f

Re: [PATCH v3] Re: avoid useless if-before-free tests

2011-04-18 Thread Jim Meyering
Janne Blomqvist wrote: > On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: >> Janne Blomqvist wrote: >>> On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: Relative to v2, I've added libgo/ to the list of exempt directories and added this recently discussed gfc_free patch, at the

[testsuite, fortran] Compile gfortran.dg/fmt_g0_5.f08 with -mieee

2011-04-18 Thread Rainer Orth
The new gfortran.dg/fmt_g0_5.f08 test fails on Tru64 UNIX at runtime with Floating point exception but passes if compiled with -mieee. The following patch implements this, tested with the appropriate runtest invocation. Ok for mainline? Rainer 2011-04-18 Rainer Orth * gfo

Re: [PATCH, ARM] PR47855 Compute attr "length" for some thumb2 insns, 2/3

2011-04-18 Thread Richard Earnshaw
On Mon, 2011-04-18 at 22:17 +0800, Carrot Wei wrote: > On Mon, Apr 18, 2011 at 9:33 PM, Richard Earnshaw wrote: > > > > On Sat, 2011-04-16 at 12:34 +0800, Carrot Wei wrote: > >> Hi Richard > >> > >> Thank you for the detailed explanation. It sounds like an inherent > >> difficulty of rtl passes.

Re: Repeat main vect.exp tests with -flto

2011-04-18 Thread Rainer Orth
Richard, >> I think you need to make sure that the target supports lto, >> cf. check_effective_target_lto. > > Good point. How's this? Tested as before. looks good, thanks. Rainer > > Richard > > > gcc/testsuite/ > * gcc.dg/vect/vect.exp: Run the main tests twice, one with -flt

Re: Repeat main vect.exp tests with -flto

2011-04-18 Thread Richard Sandiford
Rainer Orth writes: >> +foreach flags {"" "-flto"} { >> +dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/pr*.\[cS\]]] \ >> +$flags $DEFAULT_VECTCFLAGS >> +dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/vect-*.\[cS\]]] \ >> +$flags $DEFAULT_VECTCFLAGS >> +dg-runtest [

[testsuite] Require LTO support in gcc.dg/ipa/pr48195.c

2011-04-18 Thread Rainer Orth
The new gcc.dg/ipa/pr48195.c testcase fails on Tru64 UNIX: FAIL: gcc.dg/ipa/pr48195.c (test for excess errors) Excess errors: cc1: error: LTO support has not been enabled in this configuration Fixed as follows. Tested with the appropriate runtest invocation, installed on mainline. Raine

[PATCH] Testcase for PR46364

2011-04-18 Thread Richard Guenther
Committed to trunk and the 4.6 branch. Richard. 2011-04-18 Richard Guenther PR middle-end/46364 * g++.dg/torture/pr46364.C: New testcase. Index: gcc/testsuite/g++.dg/torture/pr46364.C === --- gcc/testsuite/g++.d

[testsuite] Skip obj-c++.dg/dwarf-2.mm on Tru64 UNIX

2011-04-18 Thread Rainer Orth
obj-c++.dg/dwarf-2.mm fails on Tru64 UNIX since the target doesn't support DWARF-2: FAIL: obj-c++.dg/dwarf-2.mm -fgnu-runtime (test for excess errors) Excess errors: /vol/gcc/src/hg/trunk/local/gcc/testsuite/obj-c++.dg/dwarf-2.mm:1:0: error: target system does not support the "dwarf-2" debug form

Re: [PATCH, ARM] PR47855 Compute attr "length" for some thumb2 insns, 2/3

2011-04-18 Thread Carrot Wei
On Mon, Apr 18, 2011 at 9:33 PM, Richard Earnshaw wrote: > > On Sat, 2011-04-16 at 12:34 +0800, Carrot Wei wrote: >> Hi Richard >> >> Thank you for the detailed explanation. It sounds like an inherent >> difficulty of rtl passes. Then the only opportunity is ldrb/strb >> instructions because they

[libgo] Fix __go_append declaration

2011-04-18 Thread Rainer Orth
An IRIX 6.5 bootstrap over the weekend broke in libgo: /vol/gcc/src/hg/trunk/local/libgo/runtime/go-append.c:22:1: error: conflicting types for '__go_append' /vol/gcc/src/hg/trunk/local/libgo/runtime/go-append.c:18:1: note: previous declaration of '__go_append' was here make[4]: *** [go-append.l

[PATCH] Fix uncanonical integer csts

2011-04-18 Thread Richard Guenther
This fixes up upper_bound_in_type and lower_bound_in_type which build non-canonical integer csts for sizetype. Bootstrapped and tested on x86_64-unknown-linux-gnu, installed. Richard. 2011-04-18 Richard Guenther * tree.c (upper_bound_in_type): Build properly canonicalized IN

Re: RFA: Gimple calls to "internal" functions

2011-04-18 Thread Richard Sandiford
Richard Guenther writes: >> +/* Expand a call to internal function FN.  ARGS is an array of the >> +   function's arguments and LHS is where the result should be stored.  */ >> + >> +void >> +expand_internal_call (enum internal_fn fn, tree lhs, tree *args) >> +{ >> +  internal_fn_expanders[(int) f

Re: [PATCH, ARM] PR47855 Compute attr "length" for some thumb2 insns, 2/3

2011-04-18 Thread Richard Earnshaw
On Sat, 2011-04-16 at 12:34 +0800, Carrot Wei wrote: > Hi Richard > > Thank you for the detailed explanation. It sounds like an inherent > difficulty of rtl passes. Then the only opportunity is ldrb/strb > instructions because they never affect cc registers. There are also some comparison operat

Re: [PATCH] Fix PR48650

2011-04-18 Thread Nathan Froyd
On Mon, Apr 18, 2011 at 12:46:52PM +0200, Richard Guenther wrote: > STRING_CST is now derived from tree_typed but we still clear a > tree_common sized chunk. Nathan, maybe grep for other sizeof()s > around the tree? Ouch, thanks for fixing. I grepped for 'struct tree_common' and turned up a few

[PATCH] Avoid regressing with the PR48248 change

2011-04-18 Thread Richard Guenther
This avoids changing -P output with the PR48248 fix which appearantly breaks Chrome (with has bogus assumptions on gcc -E -P output). For 4.7 I think we should instead go with the 2nd patch and make -P output smaller (which is the whole reason for this code path). Thus, first patch is for the 4.

Re: [pph] Macro Validation Correction (issue4425041)

2011-04-18 Thread Tom Tromey
> "Diego" == Diego Novillo writes: >> Unfortunately, five bits are not sufficient for the alternate use of >> cpp_hashnode.directive_index as a named operator index.  So, I have reverted >> the number of bits from five back to seven.  As a result, we now have 34 bits >> in small fields, and t

  1   2   >