LGTM
http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c File gcc/libgcov.c (right): http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c#newcode155 gcc/libgcov.c:155: filename? filename : "", e, v); Better split it into two different printfs as the format is different -- otherwise double : will be printed. http://codereview.appspot.com/4446047/