Hi, Martin,
On May 26, 2020, Martin Liška wrote:
>> I've long used the following syntax to start ChangeLog entries:
>>
>> for /ChangeLog
> Ah, it's new for me.
>>
>> It was introduced over 20 years ago, with the (so far never formally
>> released) GNU CVS-Utilities. Among other goodies, th
On 5/26/20 7:31 AM, Alexandre Oliva wrote:
On May 25, 2020, Martin Liška wrote:
On 5/21/20 5:14 PM, Rainer Orth wrote:
* In changelog_location, you allow only (among others) "a/b/c/" and
"\ta/b/c/". Please also accept the "a/b/c:" and "\ta/b/c:" forms
here: especially the second seems quite
On May 25, 2020, Martin Liška wrote:
> On 5/21/20 5:14 PM, Rainer Orth wrote:
>> * In changelog_location, you allow only (among others) "a/b/c/" and
>> "\ta/b/c/". Please also accept the "a/b/c:" and "\ta/b/c:" forms
>> here: especially the second seems quite common.
> Ok, I believe these forma
On Mon, May 25, 2020 at 12:48 AM Martin Liška wrote:
>
> On 5/23/20 12:14 AM, Ian Lance Taylor wrote:
> > Sure, I can wait. Thanks for looking at it.
>
> Hello.
>
> Thank you for patience. There's a patch that fixes that,
> I'm going to install it.
Thanks. I was able to push my change to master
On 5/21/20 5:14 PM, Rainer Orth wrote:
* In changelog_location, you allow only (among others) "a/b/c/" and
"\ta/b/c/". Please also accept the "a/b/c:" and "\ta/b/c:" forms
here: especially the second seems quite common.
Ok, I believe these formats are supported as well. Feel free to ment
On 5/23/20 12:14 AM, Ian Lance Taylor wrote:
Sure, I can wait. Thanks for looking at it.
Hello.
Thank you for patience. There's a patch that fixes that,
I'm going to install it.
Martin
>From 76e18b91250f265a37d85063860fb38aa8f6aac3 Mon Sep 17 00:00:00 2001
From: Martin Liska
Date: Mon, 25 M
On Fri, May 22, 2020 at 12:48 PM Jakub Jelinek wrote:
>
> On Fri, May 22, 2020 at 12:37:29PM -0700, Ian Lance Taylor wrote:
> > Thanks for looking into this.
> >
> > Unfortunately, my push is still failing. I'm not sure why.
> >
> > remote: *** ChangeLog format failed:
> > remote: ERR: cannot fin
On Fri, May 22, 2020 at 12:37:29PM -0700, Ian Lance Taylor wrote:
> Thanks for looking into this.
>
> Unfortunately, my push is still failing. I'm not sure why.
>
> remote: *** ChangeLog format failed:
> remote: ERR: cannot find a ChangeLog location in message
> remote:
> remote: Please see: htt
On Fri, May 22, 2020 at 4:11 AM Jakub Jelinek wrote:
>
> On Fri, May 22, 2020 at 12:04:10PM +0100, Richard Earnshaw wrote:
> > >> The directories in question are
> > >>
> > >> gcc/go/gofrontend
> > >> libgo
> > >> gcc/testsuite/go.test/test
> > >
> > > The script has:
> > > ignored_prefixes = [
>
On Fri, May 22, 2020 at 12:04:10PM +0100, Richard Earnshaw wrote:
> >> The directories in question are
> >>
> >> gcc/go/gofrontend
> >> libgo
> >> gcc/testsuite/go.test/test
> >
> > The script has:
> > ignored_prefixes = [
> > 'gcc/d/dmd/',
> > 'gcc/go/frontend/',
>
> The directory is gcc
On 22/05/2020 05:57, Jakub Jelinek wrote:
> On Thu, May 21, 2020 at 03:12:21PM -0700, Ian Lance Taylor via Gcc wrote:
>> Hi, this unfortunately breaks gccgo development. Significant parts of
>> the gccgo sources are simply copied from other repositories. Those
>> other repositories do not use Cha
On 5/22/20 6:57 AM, Jakub Jelinek wrote:
so perhaps it just misses gcc/testsuite/go.test/test ?
Hello.
I've just added the location to ignored locations.
Or what exact files you've changed in your script?
@Ian: Please send us patch with git format-patch.
@Jakub: Can you please sync up the
On Thu, May 21, 2020 at 03:12:21PM -0700, Ian Lance Taylor via Gcc wrote:
> Hi, this unfortunately breaks gccgo development. Significant parts of
> the gccgo sources are simply copied from other repositories. Those
> other repositories do not use ChangeLog files. The git commit hook
> should not
On Tue, May 19, 2020 at 2:26 AM Martin Liška wrote:
>
> We've just installed server git hooks that verify git messages
> for a correct ChangeLog format. For a limited time period, please
> still apply ChangeLog changes to the corresponding ChangeLog files.
> We'll use it for comparison of auto-gen
On 5/21/20 11:01 PM, Jason Merrill wrote:
Why? What is the use of requiring ChangeLog entries at all for these changes?
I must confirm a common test-suite ChangeLog entry is something like:
$ grep ':' gcc/testsuite/ChangeLog | sed 's/.*://' | sort | uniq -c | sort -n |
tac | head -n 15
63
On Thu, May 21, 2020 at 4:27 PM Martin Liška wrote:
> On 5/21/20 9:51 PM, Jason Merrill wrote:
> > Modified. Adjustments to expected errors in testcases don't seem to me
> worth documenting in a ChangeLog.
>
> I see. As Jakub mentioned, I would keep the hook stricter for now.
>
Why? What is th
On 5/21/20 9:51 PM, Jason Merrill wrote:
Modified. Adjustments to expected errors in testcases don't seem to me worth
documenting in a ChangeLog.
I see. As Jakub mentioned, I would keep the hook stricter for now.
Martin
On Thu, May 21, 2020 at 2:58 PM Martin Liška wrote:
> On 5/21/20 8:52 PM, Jason Merrill wrote:
> > Was there a decision somewhere to require ChangeLog entries for all
> testcase changes now, as the hook is enforcing? They were optional before.
>
> Right now we ignore newly added test-case, these
On 5/21/20 8:52 PM, Jason Merrill wrote:
Was there a decision somewhere to require ChangeLog entries for all testcase
changes now, as the hook is enforcing? They were optional before.
Right now we ignore newly added test-case, these don't have to be mentioned.
Can you please attach the patch
On Thu, May 21, 2020 at 02:52:37PM -0400, Jason Merrill wrote:
> Was there a decision somewhere to require ChangeLog entries for all
> testcase changes now, as the hook is enforcing? They were optional before.
>
> remote: *** ChangeLog format failed:
> remote: ERR: changed file not mentioned in a
Was there a decision somewhere to require ChangeLog entries for all
testcase changes now, as the hook is enforcing? They were optional before.
remote: *** ChangeLog format failed:
remote: ERR: changed file not mentioned in a
ChangeLog:"gcc/testsuite/g++.dg/parse/error33.C"
On Thu, May 21, 2020 a
Hi Martin,
>> two comments:
>>
>> * Can you please avoid the use grey highlighting in that section? Black
>>script on a grey background is already hard to read for someone with
>>reasonable vision. I suspect it will be much harder for
>>vision-impaired people.
>
> You are right, I fi
On 5/21/20 5:14 PM, Rainer Orth wrote:
Hi Martin,
We've just installed server git hooks that verify git messages
for a correct ChangeLog format. For a limited time period, please
still apply ChangeLog changes to the corresponding ChangeLog files.
We'll use it for comparison of auto-generated Ca
Hi Martin,
> We've just installed server git hooks that verify git messages
> for a correct ChangeLog format. For a limited time period, please
> still apply ChangeLog changes to the corresponding ChangeLog files.
> We'll use it for comparison of auto-generated CangeLog entries.
>
> The format is
On 20/05/2020 10:27, Jakub Jelinek via Gcc wrote:
> On Wed, May 20, 2020 at 11:19:49AM +0200, Thomas Koenig wrote:
>> Hm, one question: I find the r11-1234 type commit to be much more
>> readable, in ChangeLog files and everywhere else.
>>
>> Would it be possible to have that format instead of
>> "
On Wed, May 20, 2020 at 11:19:49AM +0200, Thomas Koenig wrote:
> Hm, one question: I find the r11-1234 type commit to be much more
> readable, in ChangeLog files and everywhere else.
>
> Would it be possible to have that format instead of
> "cherry picked from commit $HEX_SOUP" ?
I think if you g
On 5/20/20 11:19 AM, Thomas Koenig wrote:
Hm, one question: I find the r11-1234 type commit to be much more
readable, in ChangeLog files and everywhere else.
Would it be possible to have that format instead of
"cherry picked from commit $HEX_SOUP" ?
I'm not aware of how to do it.
Please let's
Hm, one question: I find the r11-1234 type commit to be much more
readable, in ChangeLog files and everywhere else.
Would it be possible to have that format instead of
"cherry picked from commit $HEX_SOUP" ?
On 5/20/20 12:20 AM, Jonathan Wakely wrote:
Or this one that actually adds the closing parenthesis
Thank you, it's definitely an improvement.
There's final version of the patch I've just applied.
Martin
>From a55c1018c9d7c53b643203e7f71b06953fae86a1 Mon Sep 17 00:00:00 2001
From: Jonathan Wak
On 5/14/20 2:42 PM, Martin Liška wrote:
Hello.
I'm sending patch candidate that adds 2 new git aliases:
- gcc-backport - simple alias to 'git cherry-pick -x'
- gcc-revert - it similarly appends '(this reverts commit
365e3cde4978c6a7dbfa50865720226254c016be)'
to a reverted commit message
The sc
On Tue, 19 May 2020 at 23:19, Jonathan Wakely wrote:
>
> On Tue, 19 May 2020 at 11:44, Martin Liška wrote:
> >
> > Hello.
> >
> > We've just installed server git hooks that verify git messages
> > for a correct ChangeLog format. For a limited time period, please
> > still apply ChangeLog changes
On Tue, 19 May 2020 at 11:44, Martin Liška wrote:
>
> Hello.
>
> We've just installed server git hooks that verify git messages
> for a correct ChangeLog format. For a limited time period, please
> still apply ChangeLog changes to the corresponding ChangeLog files.
> We'll use it for comparison of
Hello.
We've just installed server git hooks that verify git messages
for a correct ChangeLog format. For a limited time period, please
still apply ChangeLog changes to the corresponding ChangeLog files.
We'll use it for comparison of auto-generated CangeLog entries.
The format is documented her
On 5/14/20 6:47 PM, Joseph Myers wrote:
On Thu, 14 May 2020, Martin Liška wrote:
On 5/13/20 7:53 PM, Joseph Myers wrote:
On Wed, 13 May 2020, Martin Liška wrote:
I'm sending the gcc-changelog relates scripts which should be added to
contrib
folder. The patch contains:
- git_check_commit.py -
On Thu, 14 May 2020, Martin Liška wrote:
> On 5/13/20 7:53 PM, Joseph Myers wrote:
> > On Wed, 13 May 2020, Martin Liška wrote:
> >
> > > I'm sending the gcc-changelog relates scripts which should be added to
> > > contrib
> > > folder. The patch contains:
> > > - git_check_commit.py - checking s
On 5/13/20 7:53 PM, Joseph Myers wrote:
On Wed, 13 May 2020, Martin Liška wrote:
I'm sending the gcc-changelog relates scripts which should be added to contrib
folder. The patch contains:
- git_check_commit.py - checking script that verifies git message format
We need a documentation patch to
Hello.
I'm sending patch candidate that adds 2 new git aliases:
- gcc-backport - simple alias to 'git cherry-pick -x'
- gcc-revert - it similarly appends '(this reverts commit
365e3cde4978c6a7dbfa50865720226254c016be)'
to a reverted commit message
The script normally parses content of a git mes
On Wed, 13 May 2020, Martin Liška wrote:
> I'm sending the gcc-changelog relates scripts which should be added to contrib
> folder. The patch contains:
> - git_check_commit.py - checking script that verifies git message format
We need a documentation patch to contribute.html or gitwrite.html that
On 5/13/20 3:24 PM, Richard Earnshaw wrote:
I've just realized this doesn't give us an easy way to mark changes for
the root-level ChangeLog file, unless, perhaps "@@ CL ." works?
This works fine:
'ChangeLog:'
as seen for instance here:
commit 9ad3c1d81c129fc76594b9df5b798c380cbf03ee
Author:
On 13/05/2020 12:05, Martin Liška wrote:
> Hi.
>
> I'm sending the gcc-changelog relates scripts which should be added to
> contrib
> folder. The patch contains:
> - git_check_commit.py - checking script that verifies git message format
> - git_update_version.py - a replacement of
> maintainer-scr
The scripts were just installed to master except the git alias.
I'm sending that in a separate patch. Now the alias can be used
from any subfolder in a gcc git repository.
Martin
>From eb47191e8d8cbbda285c4df7eb2d1e98091edab9 Mon Sep 17 00:00:00 2001
From: Martin Liska
Date: Wed, 13 May 2020 14:
On 5/13/20 1:05 PM, Martin Liška wrote:
I suggest to use native 'git revert XYZ' and 'git cherry-pick -x XYZ'.
I've prepared a working version of Revert format:
https://github.com/marxin/gcc-changelog/tree/cherry-pick
So using git cherry-pick -x HASH one gets something like:
$ cat patches-art
Hi.
I'm sending the gcc-changelog relates scripts which should be added to contrib
folder. The patch contains:
- git_check_commit.py - checking script that verifies git message format
- git_update_version.py - a replacement of
maintainer-scripts/update_version_git which
bumps DATESTAMP and gener
43 matches
Mail list logo
