On Fri, May 22, 2020 at 12:48 PM Jakub Jelinek <ja...@redhat.com> wrote: > > On Fri, May 22, 2020 at 12:37:29PM -0700, Ian Lance Taylor wrote: > > Thanks for looking into this. > > > > Unfortunately, my push is still failing. I'm not sure why. > > > > remote: *** ChangeLog format failed: > > remote: ERR: cannot find a ChangeLog location in message > > remote: > > remote: Please see: https://gcc.gnu.org/codingconventions.html#ChangeLogs > > remote: > > remote: error: hook declined to update refs/heads/master > > To git+ssh://gcc.gnu.org/git/gcc > > ! [remote rejected] master -> master (hook declined) > > error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc' > > > > > > I've attached the output of "git format-patch -k 1 --stdout", in case > > that helps. > > Bet the script first looks for the ChangeLog entry and only considers the > ignored prefixes if it finds files in the patch that are not mentioned in > the ChangeLog entry. So, if you say modified gcc/go/whatever.cc and had > ChangeLog entry for that and not for the files you've changed, it would be > ok. > > So, I think before emitting the above message, it should look through the > patch and if it finds all files in ignored prefixes, it should just not to > do anything. > > We'll need it e.g. for the DATESTAMP bump job too which only modifies those > files too and doesn't write ChangeLog entry for that. > > I'm sorry but I don't know the script well enough to fix it quickly, will > defer to Martin as the author. > > Can you wait with the commit until Monday? If not, I could just temporarily > disable this for your commit.
Sure, I can wait. Thanks for looking at it. Ian
