Re: [PATCH] drm/msm: Expose DRIVER_SYNCOBJ_TIMELINE

2025-02-25 Thread Akhil P Oommen
On 2/26/2025 4:22 AM, Rob Clark wrote: > From: Rob Clark > > Initially we didn't want to expose the cap, as it would expose a bug > in the vk driver (turnip) with older mesa versions. This was fixed over > a year ago (and cherry-picked to stable release branches at the time), > see https://gitla

Re: [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()

2025-02-25 Thread Abhinav Kumar
On 2/24/2025 11:30 PM, Dan Carpenter wrote: If msm_gem_address_space_create() fails, then return right away. Otherwise it leads to a Oops when we dereference "aspace" on the next line. Fixes: 2d215d440faa ("drm/msm: register a fault handler for display mmu faults") Signed-off-by: Dan Carpente

[PATCH] drm/msm: Expose DRIVER_SYNCOBJ_TIMELINE

2025-02-25 Thread Rob Clark
From: Rob Clark Initially we didn't want to expose the cap, as it would expose a bug in the vk driver (turnip) with older mesa versions. This was fixed over a year ago (and cherry-picked to stable release branches at the time), see https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25981.

Re: [PATCH 10/11] drm/bridge: anx7625: update bridge_ops and sink detect logic

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 07:58:24PM +0200, Dmitry Baryshkov wrote: > On Tue, Feb 25, 2025 at 05:48:23PM +0530, Ayushi Makhija wrote: > > The anx7625_link_bridge() checks if a device is a not a panel > > bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT to > > the bridge operations. However,

Re: [PATCH 00/11] Add DSI display support for SA8775P target

2025-02-25 Thread Rob Herring (Arm)
On Tue, 25 Feb 2025 17:48:13 +0530, Ayushi Makhija wrote: > This series enables the support for DSI to DP bridge ports > (labled as DSI0 and DSI1) of the Qualcomm's SA8775P Ride platform. > > SA8775P SoC has DSI controller v2.5.1 and DSI PHY v4.2. > The Ride platform is having ANX7625 DSI to DP

[PATCH v2] drm/msm/a6xx: Fix stale rpmh votes from GPU

2025-02-25 Thread Akhil P Oommen
It was observed on sc7180 (A618 gpu) that GPU votes for GX rail and CNOC BCM nodes were not removed after GPU suspend. This was because we skipped sending 'prepare-slumber' request to gmu during suspend sequence in some cases. So, make sure we always call prepare-slumber hfi during suspend. Also, c

[PATCH] drm/msm/a6xx: Fix stale rpmh votes from GPU

2025-02-25 Thread Akhil P Oommen
It was observed on sc7180 (A618 gpu) that GPU votes for GX rail and CNOC BCM nodes were not removed after GPU suspend. This was because we skipped sending 'prepare-slumber' request to gmu during suspend sequence in some cases. So, make sure we always call prepare-suspend hfi during suspend. Also, c

Re: [PATCH 04/11] drm/msm/dsi: add DSI PHY configuration on SA8775P

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:48:17PM +0530, Ayushi Makhija wrote: > The SA8775P SoC uses the 5nm (v4.2) DSI PHY driver with > different enable regulator load. > > Signed-off-by: Ayushi Makhija > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h |

Re: [PATCH 11/11] drm/bridge: anx7625: change the gpiod_set_value API

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:48:24PM +0530, Ayushi Makhija wrote: > Use gpiod_set_value_cansleep() instead of gpiod_set_value() > to fix the below call trace in the boot log: > > [5.690534] Call trace: > [5.690536] gpiod_set_value+0x40/0xa4 > [5.690540] anx7625_runtime_pm_resume+0xa0/0

Re: [PATCH 10/11] drm/bridge: anx7625: update bridge_ops and sink detect logic

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:48:23PM +0530, Ayushi Makhija wrote: > The anx7625_link_bridge() checks if a device is a not a panel > bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT to > the bridge operations. However, on port 1 of the anx7625 > bridge, any device added is always treated as a

Re: [PATCH 09/11] drm/bridge: anx7625: enable HPD interrupts

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:48:22PM +0530, Ayushi Makhija wrote: > When device enters the suspend state, it prevents > HPD interrupts from occurring. To address this, > add an additional PM runtime vote during bridge > attach for DisplayPort. This vote is removed on > bridge detach. Well.. You can

Re: [PATCH 08/11] arm64: dts: qcom: sa8775p-ride: enable Display serial interface

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:48:21PM +0530, Ayushi Makhija wrote: > Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. > > Signed-off-by: Ayushi Makhija > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +- > 1 file changed, 64 insertions(+), 2 deletions(-) Ple

Re: [PATCH v5 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2025-02-25 Thread Lyude Paul
On Tue, 2025-02-25 at 13:29 +0200, Jani Nikula wrote: > On Fri, 21 Feb 2025, Dmitry Baryshkov wrote: > > On Mon, Feb 03, 2025 at 12:57:55PM +0200, Abel Vesa wrote: > > > Looking at both i915 and nouveau DP drivers, both are setting the first > > > LTTPR (if found) in transparent mode first and the

Re: [PATCH 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:48:20PM +0530, Ayushi Makhija wrote: > Add anx7625 DSI to DP bridge device nodes. > > Signed-off-by: Ayushi Makhija > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 136 - > 1 file changed, 135 insertions(+), 1 deletion(-) > Missing dp-connect

Re: [PATCH 05/11] drm/msm/dsi: add DSI support for SA8775P

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 05:48:18PM +0530, Ayushi Makhija wrote: > Add DSI Controller v2.5.1 support for SA8775P SoC. > > Signed-off-by: Ayushi Makhija > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 18 ++ > drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > 2 files changed, 19 insertions(+

Re: [PATCH v5 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2025-02-25 Thread Dmitry Baryshkov
On Mon, 03 Feb 2025 12:57:55 +0200, Abel Vesa wrote: > Looking at both i915 and nouveau DP drivers, both are setting the first > LTTPR (if found) in transparent mode first and then in non-transparent > mode, just like the DP v2.0 specification mentions in section 3.6.6.1. > > Being part of the sta

Re: [PATCH 03/11] dt-bindings: display: msm: document DSI controller and phy on SA8775P

2025-02-25 Thread Rob Herring (Arm)
On Tue, 25 Feb 2025 17:48:16 +0530, Ayushi Makhija wrote: > Document DSI controller and phy on SA8775P platform. > > Signed-off-by: Ayushi Makhija > --- > .../display/msm/qcom,sa8775p-mdss.yaml| 170 ++ > 1 file changed, 170 insertions(+) > My bot found errors running

Re: [PATCH v2 3/7] drm/msm/mdp4: register the LVDS PLL as a clock provider

2025-02-25 Thread Konrad Dybcio
On 20.02.2025 12:14 PM, Dmitry Baryshkov wrote: > The LVDS/LCDC controller uses pixel clock coming from the multimedia > controller (mmcc) rather than using the PLL directly. Stop using LVDS > PLL directly and register it as a clock provider. Use lcdc_clk as a > pixel clock for the LCDC. > > Signe

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-02-25 Thread Tomi Valkeinen
Hi, On 21/02/2025 11:19, Thomas Zimmermann wrote: Hi Am 20.02.25 um 11:53 schrieb Tomi Valkeinen: Hi, On 20/02/2025 12:05, Thomas Zimmermann wrote: Hi Am 20.02.25 um 10:18 schrieb Tomi Valkeinen: [...] + * Color modes of 10, 12, 15, 30 and 64 are only supported for use by + * legacy user s

Re: [PATCH 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-02-25 Thread Krzysztof Kozlowski
On 25/02/2025 13:18, Ayushi Makhija wrote: > + pinctrl-0 = <&dsi0_int_pin>, > + <&dsi0_cbl_det_pin>, > + <&dsi1_int_pin>, > + <&dsi1_cbl_det_pin>; > + pinctrl-names = "default"; > + > +

Re: [PATCH 08/11] arm64: dts: qcom: sa8775p-ride: enable Display serial interface

2025-02-25 Thread Konrad Dybcio
On 25.02.2025 1:18 PM, Ayushi Makhija wrote: > Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. > > Signed-off-by: Ayushi Makhija > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +- > 1 file changed, 64 insertions(+), 2 deletions(-) > > diff --git a/arch/

Re: [PATCH 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-02-25 Thread Konrad Dybcio
On 25.02.2025 1:18 PM, Ayushi Makhija wrote: > Add anx7625 DSI to DP bridge device nodes. > > Signed-off-by: Ayushi Makhija > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 136 - > 1 file changed, 135 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qco

Re: [PATCH 06/11] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes

2025-02-25 Thread Konrad Dybcio
On 25.02.2025 1:18 PM, Ayushi Makhija wrote: > Add device tree nodes for the DSI0 and DSI1 controllers > with their corresponding PHYs found on Qualcomm SA8775P SoC. > > Signed-off-by: Ayushi Makhija > --- [...] > + assigned-clocks = <&dispcc0 > MDSS_DISP_CC_MDSS_BY

[PATCH 08/11] arm64: dts: qcom: sa8775p-ride: enable Display serial interface

2025-02-25 Thread Ayushi Makhija
Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. Signed-off-by: Ayushi Makhija --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +- 1 file changed, 64 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/

[PATCH 11/11] drm/bridge: anx7625: change the gpiod_set_value API

2025-02-25 Thread Ayushi Makhija
Use gpiod_set_value_cansleep() instead of gpiod_set_value() to fix the below call trace in the boot log: [5.690534] Call trace: [5.690536] gpiod_set_value+0x40/0xa4 [5.690540] anx7625_runtime_pm_resume+0xa0/0x324 [anx7625] [5.690545] __rpm_callback+0x48/0x1d8 [5.690549] rpm

[PATCH 05/11] drm/msm/dsi: add DSI support for SA8775P

2025-02-25 Thread Ayushi Makhija
Add DSI Controller v2.5.1 support for SA8775P SoC. Signed-off-by: Ayushi Makhija --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 18 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/d

[PATCH 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-02-25 Thread Ayushi Makhija
Add anx7625 DSI to DP bridge device nodes. Signed-off-by: Ayushi Makhija --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 136 - 1 file changed, 135 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.

[PATCH 10/11] drm/bridge: anx7625: update bridge_ops and sink detect logic

2025-02-25 Thread Ayushi Makhija
The anx7625_link_bridge() checks if a device is a not a panel bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT to the bridge operations. However, on port 1 of the anx7625 bridge, any device added is always treated as a panel bridge, preventing connector_detect function from being called. T

[PATCH 03/11] dt-bindings: display: msm: document DSI controller and phy on SA8775P

2025-02-25 Thread Ayushi Makhija
Document DSI controller and phy on SA8775P platform. Signed-off-by: Ayushi Makhija --- .../display/msm/qcom,sa8775p-mdss.yaml| 170 ++ 1 file changed, 170 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/de

[PATCH 04/11] drm/msm/dsi: add DSI PHY configuration on SA8775P

2025-02-25 Thread Ayushi Makhija
The SA8775P SoC uses the 5nm (v4.2) DSI PHY driver with different enable regulator load. Signed-off-by: Ayushi Makhija --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 27 +++

[PATCH 02/11] dt-bindings: msm: dsi-controller-main: document the SA8775P DSI CTRL

2025-02-25 Thread Ayushi Makhija
Document the DSI CTRL on the SA8775P Platform. Signed-off-by: Ayushi Makhija --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetre

[PATCH 01/11] dt-bindings: display: msm-dsi-phy-7nm: document the SA8775P DSI PHY

2025-02-25 Thread Ayushi Makhija
Document the DSI PHY on the SA8775P Platform. Signed-off-by: Ayushi Makhija --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/d

[PATCH 09/11] drm/bridge: anx7625: enable HPD interrupts

2025-02-25 Thread Ayushi Makhija
When device enters the suspend state, it prevents HPD interrupts from occurring. To address this, add an additional PM runtime vote during bridge attach for DisplayPort. This vote is removed on bridge detach. Signed-off-by: Ayushi Makhija --- drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++

[PATCH 00/11] Add DSI display support for SA8775P target

2025-02-25 Thread Ayushi Makhija
This series enables the support for DSI to DP bridge ports (labled as DSI0 and DSI1) of the Qualcomm's SA8775P Ride platform. SA8775P SoC has DSI controller v2.5.1 and DSI PHY v4.2. The Ride platform is having ANX7625 DSI to DP bridge chip from Analogix. Ayushi Makhija (11): dt-bindings: displa

[PATCH 06/11] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes

2025-02-25 Thread Ayushi Makhija
Add device tree nodes for the DSI0 and DSI1 controllers with their corresponding PHYs found on Qualcomm SA8775P SoC. Signed-off-by: Ayushi Makhija --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 183 +- 1 file changed, 182 insertions(+), 1 deletion(-) diff --git a/arch/arm64

Re: [PATCH v5 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2025-02-25 Thread Jani Nikula
On Fri, 21 Feb 2025, Dmitry Baryshkov wrote: > On Mon, Feb 03, 2025 at 12:57:55PM +0200, Abel Vesa wrote: >> Looking at both i915 and nouveau DP drivers, both are setting the first >> LTTPR (if found) in transparent mode first and then in non-transparent >> mode, just like the DP v2.0 specificatio

Re: [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()

2025-02-25 Thread Dmitry Baryshkov
On Tue, Feb 25, 2025 at 10:30:26AM +0300, Dan Carpenter wrote: > If msm_gem_address_space_create() fails, then return right away. > Otherwise it leads to a Oops when we dereference "aspace" on the next > line. > > Fixes: 2d215d440faa ("drm/msm: register a fault handler for display mmu > faults")