[Freeciv-Dev] [bug #21932] nuke self destructs own city after tech loss

2014-07-12 Thread anonymous
Follow-up Comment #8, bug #21932 (project freeciv): This bug is no longer present in version 2.5. Using Explode Nuclear you can point and click the destination tile but will now just get the message 'didn't find a route to the destination' and nothing happens. Using Goto behaves as before - it is

[Freeciv-Dev] [patch #4934] Use macros for uclass_index() and utype_class()

2014-07-12 Thread Emmet Hikory
URL: Summary: Use macros for uclass_index() and utype_class() Project: Freeciv Submitted by: persia Submitted on: Sat 12 Jul 2014 04:32:21 PM JST Category: general Priority: 5 -

[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements

2014-07-12 Thread pepeto
Follow-up Comment #2, patch #4931 (project freeciv): Patch #4926, comment 1: I said since bug #20361, there were a SINGLE_MOVE cost hack except for pf_fuel_map. Actually, this was not right. This hack was present there too and I forgot to remove it in patch #4889. This part my be moved to patch #

[Freeciv-Dev] [patch #4933] reduce the number of calls to normalize_map_pos()

2014-07-12 Thread pepeto
Follow-up Comment #2, patch #4933 (project freeciv): I have got better results when profiling. Without the patch: 10.48269.30 269.30 6034611504 0.00 0.00 normalize_map_pos 7.72467.57 198.27 1074190408 0.00 0.00 pf_normal_map_iterate 7.02647.97 180.40 20983

[Freeciv-Dev] [bug #21950] Game crash with popup message "Exhausted city and unit numbers!"

2014-07-12 Thread Jacob Nevins
Follow-up Comment #6, bug #21950 (project freeciv): #define IDENTITY_NUMBER_SIZE (1+((MAX_UINT16 << 2) + 3)) What is the +3 for? ___ Reply to this item at: ___

[Freeciv-Dev] [bug #21576] gtk2 client assert with multiplayer ruleset

2014-07-12 Thread Jacob Nevins
Follow-up Comment #15, bug #21576 (project freeciv): Although curiously it doesn't show up here. It's r24342 on S2_4. ___ Reply to this item at:

[Freeciv-Dev] [patch #4934] Use macros for uclass_index() and utype_class()

2014-07-12 Thread Marko Lindqvist
Update of patch #4934 (project freeciv): Planned Release: 2.6.0 => 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #1: We've committed other recent low-risk (i.e. all but unit/city hash rewrite) optimizations to st

[Freeciv-Dev] [bug #21950] Game crash with popup message "Exhausted city and unit numbers!"

2014-07-12 Thread Marko Lindqvist
Follow-up Comment #7, bug #21950 (project freeciv): > #define IDENTITY_NUMBER_SIZE (1+((MAX_UINT16 << 2) + 3)) > What is the +3 for? The two lowest bits that MAX_UINT16 << 2 leaves cleared. It really should be written as binary (11) to make code more readable, but I don't think there's portable

[Freeciv-Dev] [bug #22299] Server allows to move to transport tile even if it cannot load into

2014-07-12 Thread pepeto
Update of bug #22299 (project freeciv): Status:None => Ready For Test Planned Release: => 2.5.0, 2.6.0 ___ Follow-up Comment #1: Fix attached for tr

[Freeciv-Dev] [bug #21576] gtk2 client assert with multiplayer ruleset

2014-07-12 Thread Marko Lindqvist
Follow-up Comment #16, bug #21576 (project freeciv): > Although curiously it doesn't show up here. Comment not showing up here and ticket open when it should be closed. While it's possible that I forget to close some ticket sometimes, this one seems like gna has had issues (and rolled back removi

[Freeciv-Dev] [bug #21950] Game crash with popup message "Exhausted city and unit numbers!"

2014-07-12 Thread Jacob Nevins
Follow-up Comment #8, bug #21950 (project freeciv): > The two lowest bits that MAX_UINT16 << 2 leaves cleared. Oh, of course. ___ Reply to this item at: ___ Mess

[Freeciv-Dev] Missing commits in tickets (was: [bug #21576] gtk2 client assert with multiplayer ruleset)

2014-07-12 Thread Jacob Nevins
Marko Lindqvist writes: > Follow-up Comment #16, bug #21576 (project freeciv): > > > Although curiously it doesn't show up here. > > Comment not showing up here and ticket open when it should be closed. While > it's possible that I forget to close some ticket sometimes, this one seems > like gna

[Freeciv-Dev] [patch #4935] Set HasNoZOC on some air units: AWACS, missiles, and bombers

2014-07-12 Thread Jacob Nevins
URL: Summary: Set HasNoZOC on some air units: AWACS, missiles, and bombers Project: Freeciv Submitted by: jtn Submitted on: Sat 12 Jul 2014 11:01:38 BST Category: rulesets Prior

[Freeciv-Dev] [bug #21950] Game crash with popup message "Exhausted city and unit numbers!"

2014-07-12 Thread pepeto
Follow-up Comment #9, bug #21950 (project freeciv): (MAX_UINT16 << 2 | 0x3), ((MAX_UINT16 << 2) | ((1 << 2) - 1)), or even (MAX_UINT16 << 2 | 0xff) would be more readable I think. ___ Reply to this item at:

[Freeciv-Dev] [patch #4872] [metaticket] Help updates for 2.6.0

2014-07-12 Thread Jacob Nevins
Follow-up Comment #1, patch #4872 (project freeciv): Generalised extras need some sorting out. e.g. noted in bug #22167: > On a related note, when looking critically at the extras help, > I notice the lack of Pollution and Fallout (the code looks like > it supports this, with call to add "* Can

[Freeciv-Dev] [bug #22167] River listed under "Terrain Alterations" in help

2014-07-12 Thread Jacob Nevins
Update of bug #22167 (project freeciv): Status:None => Ready For Test Assigned to:None => jtn ___ Follow-up Comment #4: > For all unbuildab

[Freeciv-Dev] [patch #4818] classic/experimental/multiplayer: set HasNoZOC on non-military units (Explorers, etc)

2014-07-12 Thread Jacob Nevins
Update of patch #4818 (project freeciv): Status:None => Ready For Test Assigned to:None => jtn Summary: classic/experimental/multiplayer: set HasNoZOC on Explorers, etc => classic/e

[Freeciv-Dev] [patch #4935] Set HasNoZOC on some air units: AWACS, missiles, and bombers

2014-07-12 Thread Jacob Nevins
Update of patch #4935 (project freeciv): Status:None => Ready For Test Assigned to:None => jtn ___ Additional Item Attachment: File name: t

[Freeciv-Dev] [bug #22260] AI never forgets tech_want

2014-07-12 Thread Jacob Nevins
Update of bug #22260 (project freeciv): Summary: tech_want never zeroed (not even initialized) => AI never forgets tech_want ___ Follow-up Comment #9: Renamed to reflect that this isn't a lack-of-initialisation bug, rather

[Freeciv-Dev] [bug #22302] Setting init_city_radius_sq =15 does not work in version 2.5

2014-07-12 Thread Jacob Nevins
Update of bug #22302 (project freeciv): Category: client-gtk-2.0 => client Operating System: Microsoft Windows => Any ___ Follow-up Comment #3: I can reproduce thi

[Freeciv-Dev] [bug #22313] "Burgundic" and "Burgundian" legend confusingly similar

2014-07-12 Thread Jacob Nevins
URL: Summary: "Burgundic" and "Burgundian" legend confusingly similar Project: Freeciv Submitted by: jtn Submitted on: Sat 12 Jul 2014 13:30:48 BST Category: rulesets Severity:

[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements

2014-07-12 Thread Emmet Hikory
Follow-up Comment #3, patch #4931 (project freeciv): Aha, so patch #4926 doesn't actually finish cleaning up the SINGLE_MOVE hack, and so seeing a very similar section being removed in this patch caused me to raise a false positive. My apologies for the noise (I tend to test patches in isolation,

[Freeciv-Dev] [bug #22314] QT client strings unsuitable for i18n

2014-07-12 Thread Jacob Nevins
URL: Summary: QT client strings unsuitable for i18n Project: Freeciv Submitted by: jtn Submitted on: Sat 12 Jul 2014 13:36:29 BST Category: client-qt Severity: 3 - Normal

[Freeciv-Dev] [patch #4933] reduce the number of calls to normalize_map_pos()

2014-07-12 Thread Emmet Hikory
Follow-up Comment #3, patch #4933 (project freeciv): Interesting. Possibly bad luck on my part, or differences between gprof and oprofile. If this patch produces a nearly 10% improvement in total runtime for some initial conditions, perhaps it should also be applied to 2.5.

[Freeciv-Dev] [bug #22315] QT client refers to "CMA" rather than "city governor"

2014-07-12 Thread Jacob Nevins
URL: Summary: QT client refers to "CMA" rather than "city governor" Project: Freeciv Submitted by: jtn Submitted on: Sat 12 Jul 2014 13:38:17 BST Category: client-qt Severity: 3

[Freeciv-Dev] [patch #4936] Tart up civ2civ3 help

2014-07-12 Thread Jacob Nevins
URL: Summary: Tart up civ2civ3 help Project: Freeciv Submitted by: jtn Submitted on: Sat 12 Jul 2014 13:48:32 BST Category: rulesets Priority: 5 - Normal Statu

[Freeciv-Dev] [patch #3793] [metaticket] Help updates for 2.5.0

2014-07-12 Thread Jacob Nevins
Update of patch #3793 (project freeciv): Depends on: => patch #4936 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #4936] Tart up civ2civ3 help

2014-07-12 Thread Jacob Nevins
Update of patch #4936 (project freeciv): Assigned to:None => jtn ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #22302] Setting init_city_radius_sq =15 does not work in version 2.5

2014-07-12 Thread Jacob Nevins
Follow-up Comment #4, bug #22302 (project freeciv): Patch #4389 used a squared value where a linear one should have been used in canvas_to_city_pos(). I haven't worked out the complete fix yet. ___ Reply to this item at:

[Freeciv-Dev] [bug #22302] Setting init_city_radius_sq =15 does not work in version 2.5

2014-07-12 Thread Jacob Nevins
Update of bug #22302 (project freeciv): Status:None => In Progress Assigned to:None => jtn ___ Reply to this item at:

[Freeciv-Dev] [patch #4933] reduce the number of calls to normalize_map_pos()

2014-07-12 Thread pepeto
Follow-up Comment #4, patch #4933 (project freeciv): I think the most of the gain is visible in late game (when the AI begins to build fueled units). It may explain why results could be so different. ___ Reply to this item at:

[Freeciv-Dev] [bug #21950] Game crash with popup message "Exhausted city and unit numbers!"

2014-07-12 Thread pepeto
Follow-up Comment #10, bug #21950 (project freeciv): And if we are supposed to add 1, why not using (1 << 18)? ___ Reply to this item at: ___ Message posté via/

[Freeciv-Dev] [bug #22302] City map UI broken with init_city_radius_sq =15 in version 2.5

2014-07-12 Thread Jacob Nevins
Update of bug #22302 (project freeciv): Status: In Progress => Ready For Test Summary: Setting init_city_radius_sq =15 does not work in version 2.5 => City map UI broken with init_city_radius_sq =15 in version 2.5 __

[Freeciv-Dev] [bug #22302] City map UI broken with init_city_radius_sq =15 in version 2.5

2014-07-12 Thread Jacob Nevins
Update of bug #22302 (project freeciv): Planned Release:2.5.0, 2.6.0 => 2.5.0-beta1, 2.6.0 ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [bug #22197] City dialog map not refreshed after changing governor

2014-07-12 Thread Jacob Nevins
Update of bug #22197 (project freeciv): Summary: Some errors in beta0 of freeciv2.5 => City dialog map not refreshed after changing governor ___ Follow-up Comment #3: >> 2. Changing the governor from max production to max

[Freeciv-Dev] [bug #22149] Set "Enemy_Citizens_Unhappy_Pct" in classic ruleset?

2014-07-12 Thread Jacob Nevins
Update of bug #22149 (project freeciv): Status:None => Need Info Planned Release: => 2.5.0, 2.6.0 Summary: "Enemy_Citizens_Unhappy_Pct" is not setted => Set "Enemy_Citizens_Unhappy_Pct"

[Freeciv-Dev] [bug #22047] Crash in gtk_text_layout_get_cursor_locations() on "Connect to network game"

2014-07-12 Thread Jacob Nevins
Update of bug #22047 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #4: Cannot reproduce on

[Freeciv-Dev] [bug #22316] UTF-8 trouble with repeated "Connect to network game" / "Cancel"

2014-07-12 Thread Jacob Nevins
URL: Summary: UTF-8 trouble with repeated "Connect to network game" / "Cancel" Project: Freeciv Submitted by: jtn Submitted on: Sat 12 Jul 2014 15:18:19 BST Category: client-gtk-2.0

[Freeciv-Dev] [bug #22316] UTF-8 trouble with repeated "Connect to network game" / "Cancel"

2014-07-12 Thread Jacob Nevins
Additional Item Attachment, bug #22316 (project freeciv): File name: repeated_connect_utf8_trouble.png Size:377 KB ___ Reply to this item at: ___ Message sent v

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated "Connect to network game" / "Cancel"

2014-07-12 Thread Jacob Nevins
Update of bug #22048 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #10: > Opened bug #2210

[Freeciv-Dev] [bug #21575] GTK2 client crash at startup

2014-07-12 Thread Jacob Nevins
Update of bug #21575 (project freeciv): Status:None => Duplicate Open/Closed:Open => Closed ___ Follow-up Comment #2: > May be the same a

[Freeciv-Dev] [bug #22050] Recursive transport problems

2014-07-12 Thread pepeto
Update of bug #22050 (project freeciv): Status: Need Info => In Progress ___ Reply to this item at: ___ Message post

[Freeciv-Dev] [bug #22187] Client allows attempted violation of embarks/disembarks restrictions

2014-07-12 Thread pepeto
Update of bug #22187 (project freeciv): Status: Fixed => In Progress Assigned to: pepeto => None Open/Closed: Closed => Open __

[Freeciv-Dev] [bug #22317] Path-finding unable to handle recursive transports restrictions

2014-07-12 Thread pepeto
URL: Summary: Path-finding unable to handle recursive transports restrictions Project: Freeciv Submitted by: pepeto Submitted on: sam. 12 juil. 2014 16:57:31 CEST Category: None

[Freeciv-Dev] [bug #22050] Recursive transport problems

2014-07-12 Thread pepeto
Update of bug #22050 (project freeciv): Depends on: => bugs #22187 ___ Reply to this item at: ___ Message post

[Freeciv-Dev] [bug #22050] Recursive transport problems

2014-07-12 Thread pepeto
Update of bug #22050 (project freeciv): Depends on: => bugs #22317 ___ Reply to this item at: ___ Message post

[Freeciv-Dev] [bug #22317] Path-finding unable to handle recursive transports restrictions

2014-07-12 Thread Emmet Hikory
Follow-up Comment #1, bug #22317 (project freeciv): Why? Isn't this handled inside unit_list_iterate(ptile->units, punit) in pf_move_scope? or is the problem that units fail to notionally load for amphibious pathfinding? ___ Reply to this

[Freeciv-Dev] [bug #22318] Nation translation domain not read properly by client

2014-07-12 Thread Jacob Nevins
URL: Summary: Nation translation domain not read properly by client Project: Freeciv Submitted by: jtn Submitted on: Sat 12 Jul 2014 16:06:27 BST Category: None Severity: 3 - No

[Freeciv-Dev] [bug #22318] Nation translation domain not read properly by client

2014-07-12 Thread Jacob Nevins
Update of bug #22318 (project freeciv): Status: In Progress => Ready For Test ___ Additional Item Attachment: File name: trunk-S2_5-nation-translation-domain.patch Size:1 KB

[Freeciv-Dev] [bug #22319] Experimental ruleset Triremes can't move up rivers on trunk

2014-07-12 Thread Jacob Nevins
URL: Summary: Experimental ruleset Triremes can't move up rivers on trunk Project: Freeciv Submitted by: jtn Submitted on: Sat 12 Jul 2014 16:24:03 BST Category: None Severity:

[Freeciv-Dev] [bug #22319] Experimental ruleset Triremes can't move up rivers on trunk

2014-07-12 Thread Jacob Nevins
Additional Item Attachment, bug #22319 (project freeciv): File name: exp-trireme-25.sav.bz2 Size:14 KB ___ Reply to this item at: ___ Message sent via/b

[Freeciv-Dev] [patch #4934] Use macros for uclass_index() and utype_class()

2014-07-12 Thread Emmet Hikory
Follow-up Comment #2, patch #4934 (project freeciv): Conveniently the same patch applies, builds, and runs for all targeted branches. ___ Reply to this item at: __

[Freeciv-Dev] [patch #4927] Avoid selecting Fighters as useful AI units

2014-07-12 Thread Emmet Hikory
Update of patch #4927 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22319] Experimental ruleset Triremes can't move up rivers on trunk

2014-07-12 Thread Emmet Hikory
Follow-up Comment #1, bug #22319 (project freeciv): Oh, interesting. It seems that is_native_move() isn't prepared to handle the case of moving from a native tile (for non-road reasons) to a destination tile that is native because of a road which is not an acceptable connecting road. Neither bug

[Freeciv-Dev] [patch #4562] Soundtrack 0.1

2014-07-12 Thread mqtx
Follow-up Comment #11, patch #4562 (project freeciv): I remastered the old tracks and uploaded new ones at http://soundcloud.com/mqtx There's an arrow facing down next to the tracks that allows free public downloads. Thanks for adding them to the mqtx modpack!

[Freeciv-Dev] [patch #4650] Split single input xx.po file into translations/*/xx.po

2014-07-12 Thread Jacob Nevins
Follow-up Comment #10, patch #4650 (project freeciv): > This ticket is for (a) redoing the S2_4 import I've now done this. This also deals with the backlog of S2_4 updates that I had not yet brought to later branches; all newer branches that have not yet been worked on should now have the latest

[Freeciv-Dev] [bug #22320] Lua compilation tries to use _setjmp() when configure has only checked _longjmp()

2014-07-12 Thread Marko Lindqvist
URL: Summary: Lua compilation tries to use _setjmp() when configure has only checked _longjmp() Project: Freeciv Submitted by: cazfi Submitted on: Sat 12 Jul 2014 10:40:28 PM EEST Category: boo

[Freeciv-Dev] [bug #22320] Lua compilation tries to use _setjmp() when configure has only checked _longjmp()

2014-07-12 Thread Marko Lindqvist
Follow-up Comment #1, bug #22320 (project freeciv): - S2_4 version (file #21380) ___ Additional Item Attachment: File name: _SetJmpCheck-S2_4.patchSize:0 KB ___ Reply to th

[Freeciv-Dev] [bug #20723] Enabling multiple luasql backends broken on S2_5 & trunk

2014-07-12 Thread Jacob Nevins
Follow-up Comment #5, bug #20723 (project freeciv): I want to fix this properly for 2.5.0 rather than have a regression. Can anyone help? However, failing that, we could make configure disallow multiple luasql backends. ___ Reply to this i

[Freeciv-Dev] [task #7668] Tracking release 2.5.0

2014-07-12 Thread Jacob Nevins
Update of task #7668 (project freeciv): Dependency Removed: => task #7760 ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [bug #22321] tech_bulb_sum uninitialized in tech_upkeep_calc()

2014-07-12 Thread Marko Lindqvist
URL: Summary: tech_bulb_sum uninitialized in tech_upkeep_calc() Project: Freeciv Submitted by: cazfi Submitted on: Sat 12 Jul 2014 11:41:41 PM EEST Category: general Severity: 3

[Freeciv-Dev] 2.5.0-beta1 and 2.4.3 plans

2014-07-12 Thread Jacob Nevins
Hello folks, We don't seem to have any pressing reasons not to ship the first beta for 2.5.0, so I plan to try to get the tarball out either next weekend (19-20 July) or, failing that, at the end of July. Current draft release notes are here: =-=-=-=-=-

[Freeciv-Dev] [patch #4459] Requirement range "Traderoutes"

2014-07-12 Thread Emmet Hikory
Update of patch #4459 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4937] Really assert tech is in valid range

2014-07-12 Thread Emmet Hikory
URL: Summary: Really assert tech is in valid range Project: Freeciv Submitted by: persia Submitted on: Sun 13 Jul 2014 07:03:36 AM JST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #4938] Consolidate server precalcs and cache population

2014-07-12 Thread Emmet Hikory
URL: Summary: Consolidate server precalcs and cache population Project: Freeciv Submitted by: persia Submitted on: Sun 13 Jul 2014 07:13:03 AM JST Category: general Priority: 5

[Freeciv-Dev] [patch #4939] Use const for more sorts of requirement checks

2014-07-12 Thread Emmet Hikory
URL: Summary: Use const for more sorts of requirement checks Project: Freeciv Submitted by: persia Submitted on: Sun 13 Jul 2014 07:18:09 AM JST Category: general Priority: 5 -

[Freeciv-Dev] [patch #4940] Rewrite universal_fulfills_requirement()

2014-07-12 Thread Emmet Hikory
URL: Summary: Rewrite universal_fulfills_requirement() Project: Freeciv Submitted by: persia Submitted on: Sun 13 Jul 2014 07:39:18 AM JST Category: general Priority: 5 - Normal

[Freeciv-Dev] [task #7751] Tracking release 2.5.0-beta1

2014-07-12 Thread Jacob Nevins
Update of task #7751 (project freeciv): Depends on: => task #7813 ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [task #7813] Windows packages for 2.5.0-beta1

2014-07-12 Thread Jacob Nevins
URL: Summary: Windows packages for 2.5.0-beta1 Project: Freeciv Submitted by: jtn Submitted on: Sun 13 Jul 2014 00:24:38 BST Should Start On: Sat 19 Jul 2014 00:00:00 BST Should be Finished on: Fri

[Freeciv-Dev] [patch #4940] Rewrite universal_fulfills_requirement()

2014-07-12 Thread Marko Lindqvist
Follow-up Comment #1, patch #4940 (project freeciv): > so the callers may use a locally-scoped universal, rather than > a malloc()'d universals_u, What prevented thay previously? From the patch it seems that the function did not made any assumptions if the pointer received was dynamically allocat

[Freeciv-Dev] [bug #22322] Unqualified female ruler titles

2014-07-12 Thread Jacob Nevins
Update of bug #22322 (project freeciv): Summary: Unqualified female ruler names => Unqualified female ruler titles ___ Reply to this item at: ___

[Freeciv-Dev] [bug #22322] Unqualified female ruler names

2014-07-12 Thread Jacob Nevins
URL: Summary: Unqualified female ruler names Project: Freeciv Submitted by: jtn Submitted on: Sun 13 Jul 2014 00:46:34 BST Category: rulesets Severity: 3 - Normal

[Freeciv-Dev] [patch #4938] Consolidate server precalcs and cache population

2014-07-12 Thread Emmet Hikory
Follow-up Comment #1, patch #4938 (project freeciv): MIssed the sanity check assert complaints in earlier testing of this. Updated patch populates caches subject to sanity check before doing the sanity check. (file #21386) ___ Additional I

[Freeciv-Dev] [patch #4885] Revised logic for AI improvement consideration and improvement redundancy

2014-07-12 Thread Emmet Hikory
Follow-up Comment #2, patch #4885 (project freeciv): I decided to try this a different and more general way, but the result doesn't actually work. Barracks III isn't made redundant by Airport anymore (which is good), but now Women's Suffrage isn't making Police Station redundant (which is bad).

[Freeciv-Dev] [bug #22322] Unqualified female ruler titles

2014-07-12 Thread Jacob Nevins
Update of bug #22322 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #1: Also attached the patch I used to find instances of this in nations. I'm half inclined to check

[Freeciv-Dev] [patch #4924] adv_want typedef

2014-07-12 Thread Marko Lindqvist
Update of patch #4924 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #4923] Tech effects cache

2014-07-12 Thread Marko Lindqvist
Update of patch #4923 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #4738] Ruleset defined culture victory criteria

2014-07-12 Thread Marko Lindqvist
Update of patch #4738 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #22303] svnrev/gitrev version number word "modified" not translatable

2014-07-12 Thread Marko Lindqvist
Update of bug #22303 (project freeciv): Planned Release: 2.4.3, 2.5.0, 2.6.0 => 2.4.3, 2.5.0-beta2, 2.6.0 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #22311] Threaded AI mishandles NoBonus road types

2014-07-12 Thread Marko Lindqvist
Update of bug #22311 (project freeciv): Planned Release:2.5.0, 2.6.0 => 2.5.0-beta1, 2.6.0 ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [bug #21629] civ2 - barb cities can't build anything due to waste

2014-07-12 Thread Marko Lindqvist
Update of bug #21629 (project freeciv): Planned Release: 2.4.3, 2.5.0, 2.6.0 => 2.4.3, 2.5.0-beta1, 2.6.0 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #22320] Lua compilation tries to use _setjmp() when configure has only checked _longjmp()

2014-07-12 Thread Marko Lindqvist
Update of bug #22320 (project freeciv): Planned Release: 2.4.3, 2.5.0, 2.6.0 => 2.4.3, 2.5.0-beta1, 2.6.0 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #21550] Make function of timeout / "off" label in UI more obvious somehow

2014-07-12 Thread Marko Lindqvist
Update of bug #21550 (project freeciv): Planned Release: 2.4.3, 2.5.0, 2.6.0 => 2.4.3, 2.5.0-beta1, 2.6.0 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #4920] C11 Static assert

2014-07-12 Thread Marko Lindqvist
Update of patch #4920 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #22319] Experimental ruleset Triremes can't move up rivers on trunk

2014-07-12 Thread Emmet Hikory
Update of bug #22319 (project freeciv): Category:None => general Status:None => Ready For Test Assigned to:None => persia __

[Freeciv-Dev] [patch #4941] Alien Thick Mountains infra changes

2014-07-12 Thread Marko Lindqvist
URL: Summary: Alien Thick Mountains infra changes Project: Freeciv Submitted by: cazfi Submitted on: Sun 13 Jul 2014 04:18:16 AM EEST Category: rulesets Priority: 5 - Normal

[Freeciv-Dev] [bug #21950] Game crash with popup message "Exhausted city and unit numbers!"

2014-07-12 Thread Marko Lindqvist
Follow-up Comment #11, bug #21950 (project freeciv): > And if we are supposed to add 1, why not using (1 << 18)? Actually there's no longer specific need to have it as 2^y. The reason it was 2^16 was that then any value could fit to uint16, but it's not necessary to make it exactly 4 times as big

[Freeciv-Dev] [bug #21950] Game crash with popup message "Exhausted city and unit numbers!"

2014-07-12 Thread Marko Lindqvist
Update of bug #21950 (project freeciv): Planned Release: 2.4.3, 2.5.0, 2.6.0 => 2.4.3, 2.5.0-beta1, 2.6.0 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #22323] Trunk build failure in Qt client

2014-07-12 Thread Emmet Hikory
URL: Summary: Trunk build failure in Qt client Project: Freeciv Submitted by: persia Submitted on: Sun 13 Jul 2014 10:38:38 AM JST Category: client-qt Severity: 3 - Normal

[Freeciv-Dev] [patch #4941] Alien Thick Mountains infra changes

2014-07-12 Thread Emmet Hikory
Follow-up Comment #1, patch #4941 (project freeciv): For trunk, the slightly easier to build Thick Mountain road could be implemented as a (slower) integrating road, to indicate that landfill on an undrillable mountain is slow, perhaps allowing a faster road once "Burrowing" is known. Even with a

[Freeciv-Dev] [patch #4940] Rewrite universal_fulfills_requirement()

2014-07-12 Thread Emmet Hikory
Update of patch #4940 (project freeciv): Status: Ready For Test => In Progress ___ Follow-up Comment #2: I'm not sure anything prevented using a locally scoped variable before, but whenever I tried to

[Freeciv-Dev] [patch #4940] Rewrite universal_fulfills_requirement()

2014-07-12 Thread Marko Lindqvist
Follow-up Comment #3, patch #4940 (project freeciv): > I'm not sure anything prevented using a locally scoped variable > before, But making the change to your existing patch to use pointers instead of value should now be trivial. Just take the pointer instead of value in, and change callers to pa

[Freeciv-Dev] [bug #22323] Trunk build failure in Qt client

2014-07-12 Thread Marko Lindqvist
Update of bug #22323 (project freeciv): Planned Release: => 2.6.0 ___ Follow-up Comment #1: Emergency fix to be applied immediately attahed. I'll leave the ticket open for proper C++ imple

[Freeciv-Dev] [patch #4900] Make three attempts of map generation

2014-07-12 Thread Marko Lindqvist
Update of patch #4900 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #4940] Rewrite universal_fulfills_requirement()

2014-07-12 Thread Emmet Hikory
Follow-up Comment #4, patch #4940 (project freeciv): Yes, but the switch statement is unfortunate, and probably causes more of a slowdown than whether we pass a pointer or a struct containing an enum and a pointer. My thought is to replace all the callers with macros that call a common (callback-

[Freeciv-Dev] [patch #4926] Properly account for attack move costs in pathfinding

2014-07-12 Thread Emmet Hikory
Update of patch #4926 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [task #7751] Tracking release 2.5.0-beta1

2014-07-12 Thread Marko Lindqvist
Update of task #7751 (project freeciv): Dependency Removed: => patch #3539 ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [patch #4928] Introduce savegame3.c

2014-07-12 Thread Marko Lindqvist
Follow-up Comment #1, patch #4928 (project freeciv): Patch. Copy savegame2.c as savegame3.c and savegame2.h as savegame3.h before applying (file #21397) ___ Additional Item Attachment: File name: Savegame3.patch.bz2Size:15 KB