Update of patch #4940 (project freeciv):
Status: Ready For Test => In Progress
_______________________________________________________
Follow-up Comment #2:
I'm not sure anything prevented using a locally scoped variable before, but
whenever I tried to do that, I got lost (with either compilation failures or
runtime issues). The method I propose is mostly just easier for me to
comprehend, and for ease of extension, I think all the callers ought have the
same format (ideally we can collapse
these into a single function in the future, perhaps with macros for access
convenience).
Thinking about this in terms of optimisation, the introduction of the runtime
switch to determine fulfills is another source of slowness, as compared to the
previous implementation. I think I'll try to find another way to reduce the
apparent complexity of extending this to new requirement kinds that doesn't
have the same performance impact.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?4940>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
