It will be more than helpful, if you can provides tcpdumps.
On Tue, Sep 26, 2017 at 8:51 AM, Julian K. wrote:
> Hi,
>
> I was debugging a lot to figure out that checksum offloading for outgoing
> IPv6 packets may lead to invalid checksums. It is reproducible with certain
> payloads and many of my
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D12453#258240, @rwatson wrote:
> This seems generally sensible.
>
> I'm not quite sure about keeping the "Non-standard RSS hash types" comment,
as M_HASHTYPE_OPAQUE is basically intended to be a catch-all for any othe
sepherosa_gmail.com created this revision.
Herald added a subscriber: ae.
REVISION DETAIL
https://reviews.freebsd.org/D12455
AFFECTED FILES
sys/net/rss_config.c
sys/net/rss_config.h
CHANGE DETAILS
diff --git a/sys/net/rss_config.h b/sys/net/rss_config.h
--- a/sys/net/rss_config.h
+++ b/sy
sepherosa_gmail.com created this revision.
REVISION SUMMARY
Add comment to explain the IPV6_EX suffix. The confusion about
these RSS hash type probably stems from the facts that they were
never widely implemented by hardwares.
REVISION DETAIL
https://reviews.freebsd.org/D12453
AFF
>
> I seem to recall it was something some chipsets supported? I forget the
> details.
>
>
>
> -adrian
>
>
> On 30 August 2017 at 00:07, Sepherosa Ziehau wrote:
>>
>> IPv4 UDP with extended headers o_O? Or
Hi all,
I am on the way to cleanup the UDP_IPV4_EX bit. The only effective
consumer of this undefined RSS hash type is ixl.
So I took a bit close look at it, then I have several question about
its hash type configuration:
ixl_set_rss_pctypes(). It tries to set hash for IPV6 fragment, if
RSS_IP
, UDP_IPV6 and UDP_IPV6_EX. I am going to
whack UDP_IPV4_EX and update various comment. I will setup a review
soon.
Thanks,
sephe
>
> Robert
>
> On 2 Sep 2017, at 00:43, Adrian Chadd wrote:
>
> Hi,
>
> I seem to recall it was something some chipsets supported? I forget th
IPv4 UDP with extended headers o_O? Or it was just a mistake.
Thanks,
sephe
--
Tomorrow Will Never Die
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubs
On Wed, Apr 19, 2017 at 10:39 AM, Somayajulu, David
wrote:
> Sorry what I meant to ask was, whether it is O.K to call taskqueue_drain(),
> when an MTX_DEF lock is grabbed prior to calling taskqueue_drain().
>
You will hit WITNESS, if the drain needs to wait; that's probably the
best case. If th
On Wed, Mar 8, 2017 at 8:25 PM, Kevin Bowling wrote:
> Right off the bat, FreeBSD doesn't really understand NUMA in any sufficient
> capacity. Unfortunately at companies like the one I work at, we take that
> to mean "OK buy a high bin CPU and only populate one socket" which serves
> us well and
On Tue, Mar 7, 2017 at 11:10 PM, Kajetan Staszkiewicz
wrote:
> Dnia poniedziałek, 6 marca 2017 16:06:03 CET Sepherosa Ziehau pisze:
>> On Thu, Mar 2, 2017 at 10:02 PM, Kajetan Staszkiewicz
>>
>> wrote:
>> > To whom it might concern:
>> >
>> > Well,
On Thu, Mar 2, 2017 at 10:02 PM, Kajetan Staszkiewicz
wrote:
> To whom it might concern:
>
> Well, at least it does concern me. Why is support for multiple interrupts and
> queues not enabled on bce(4)?
>
> Whole block of code is surrounded with #ifdef 0 ... #endif
>
> https://github.com/freebsd/f
On Fri, Mar 3, 2017 at 6:00 AM, Gleb Smirnoff wrote:
> On Sun, Feb 26, 2017 at 11:37:59PM +0800, Sepherosa Ziehau wrote:
> S> r314268 -> solisten
> S>
> S> 1KB:
> S> Performance (reqs/s)
> S> 77916.71 -> 26240.37
> S> Latency average
> S&g
Did you compile and installed GENERIC-NODEBUG kernel for the CURRENT test?
On Tue, Feb 28, 2017 at 10:13 AM, Caraballo-vega, Jordan A.
(GSFC-6062)[COMPUTER SCIENCE CORP]
wrote:
> As a summarywe have a Dell R530 with a Chelsio T580 cardwith -CURRENT.
>
> In an attempt to reduce the time the syste
On Mon, Feb 27, 2017 at 9:36 AM, Sepherosa Ziehau wrote:
> On Sat, Feb 25, 2017 at 11:56 PM, Slawa Olhovchenkov wrote:
>> On Sat, Feb 25, 2017 at 11:09:29PM +0800, Sepherosa Ziehau wrote:
>>
>>> > Can I use per-connection Lua script (for delays and url generation)?
On Sat, Feb 25, 2017 at 11:56 PM, Slawa Olhovchenkov wrote:
> On Sat, Feb 25, 2017 at 11:09:29PM +0800, Sepherosa Ziehau wrote:
>
>> > Can I use per-connection Lua script (for delays and url generation)?
>> > Not per-thread. I am need to emulate many client connect
On Mon, Feb 27, 2017 at 1:37 AM, Gleb Smirnoff wrote:
> On Sun, Feb 26, 2017 at 11:37:59PM +0800, Sepherosa Ziehau wrote:
> S> Just got enough time to do some benchmark. The configuration is
> S> pretty simple, one server box w/ 2x82599, two client boxes w/ 1x82599,
> S>
On Thu, Feb 23, 2017 at 7:27 AM, Gleb Smirnoff wrote:
> On Tue, Feb 21, 2017 at 09:58:45AM +0100, Julien Charbon wrote:
> J> > T> 1) The patch worked pretty okay, but the idea of separate file type is
> J> > T>abandoned. With current filedescriptor code it is almost impossible
> J> > T>to
On Fri, Feb 24, 2017 at 9:13 PM, Slawa Olhovchenkov wrote:
> On Thu, Feb 23, 2017 at 06:36:36PM +0300, Slawa Olhovchenkov wrote:
>
>> On Thu, Feb 23, 2017 at 11:40:21AM +0800, Sepherosa Ziehau wrote:
>>
>> > On Thu, Feb 23, 2017 at 7:27 AM, Gleb Smirnoff wrote:
>&g
On Thu, Feb 23, 2017 at 7:27 AM, Gleb Smirnoff wrote:
> On Tue, Feb 21, 2017 at 09:58:45AM +0100, Julien Charbon wrote:
> J> > T> 1) The patch worked pretty okay, but the idea of separate file type is
> J> > T>abandoned. With current filedescriptor code it is almost impossible
> J> > T>to
On Sat, Jan 28, 2017 at 3:37 AM, Gleb Smirnoff wrote:
> Andrew,
>
> On Thu, Jan 26, 2017 at 08:24:43PM +0300, Andrew Rybchenko wrote:
> A> I'd like to double-check that it is intended/known limitation on ifmedia
> A> status callback to be non-sleepable.
> A> The limitation is imposed by usage of
sepherosa_gmail.com accepted this revision.
REVISION DETAIL
https://reviews.freebsd.org/D9345
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: decui_microsoft.com, hselasky, cem, np, kmacy, kib, honzhan_microsoft.com,
howard0su_gmail.com, jhb, ae, delphij,
On Tue, Jan 24, 2017 at 3:00 PM, Xiaoye Sun wrote:
> I'm using the typical intel 10 Gbps nic.
> Does ethtool have related configuration command?
You can check Intel's spec on their website for the chip you use.
They have very good documentation. IIRC, the default behavior is to
round-robin TX qu
On Tue, Jan 24, 2017 at 4:09 AM, Xiaoye Sun wrote:
> Hi,
>
> In my application, there are multiple tx queues in the OS, and the netmap
> program uses one tx queue. I wondering if I can give the netmap tx queue
> higher priority so that the NIC always sends the packets from this queue if
> netmap p
sepherosa_gmail.com added a comment.
If no objection comes, we plan to commit this earlier next week.
REVISION DETAIL
https://reviews.freebsd.org/D8963
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: decui_microsoft.com, hselasky, cem, np, kmacy, kib, h
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: jhb, decui_microsoft.com.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D9058
AFFECTED FILES
share/man/man4/alc.4
sys/dev/alc/if_alc.c
sys/dev/alc/if_alc
sepherosa_gmail.com abandoned this revision.
REVISION DETAIL
https://reviews.freebsd.org/D8904
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com,
honzhan_microsoft.com, howard0su_gmail.com, adrian, bz
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D8904#185970, @karels wrote:
> I think the change is a step in the right direction. Certainly, "ifconfig
xxN down" followed by an implicit UP should not cause any change to the routing
table. Does anyone know why the "
On Fri, Dec 30, 2016 at 11:34 PM, David Belle-Isle wrote:
> Hi,
>
> Can anyone tell me how to set the weight of a ring from the indirection
> table on FreeBSD? My plan is to yank out a TX ring and to use it solely
> with netmap to receive packets but want to make sure the kernel won't be
> receivi
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D8905#185507, @jhb wrote:
> I would suggest rewording the message a bit to something like:
>
> Defer if_up() until after the interface's if_ioctl method is called.
>
> This ensures the interface is initialize
sepherosa_gmail.com updated the summary for this revision.
REVISION DETAIL
https://reviews.freebsd.org/D8905
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com,
honzhan_microsoft.com, howard0su_gmail.c
sepherosa_gmail.com added reviewers: glebius, gnn, rwatson.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D8963
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: decui_microsoft.com, hselasky, sepherosa_
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D8904#184430, @hrs wrote:
> The cause is that the prefix route was removed by in_scrubprefix() in the
PRC_IFDOWN handler and never reinstalled upon PRC_IFUP because the
reinstallation is done only for ifa passed to SIOC
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com,
honzhan_microsoft.com, howard0su_gmail.com, adrian, hiren, bz, gnn, glebius,
karels.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION SUMMARY
So if_{down,up}
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com,
honzhan_microsoft.com, howard0su_gmail.com, adrian, bz, gnn, hiren, glebius,
rwatson, karels.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION SUMMARY
This
On Sat, Dec 3, 2016 at 3:36 PM, Chris Torek wrote:
>>... Dropping the lock is entirely the wrong thing to do -- as
>>you note, if we do, then the bridge members can change out from
>>under us. The only path forward is to use an sx lock, but ...
> [snip]
>>In code paths that modify the list of br
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: glebius, adrian, gnn, bz.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION SUMMARY
So that everyone in this task have consistent view of link state.
REVISION DETAIL
https://reviews.freebsd.org/D8
sepherosa_gmail.com added a comment.
I plan to commit this next Monday, if no objection comes.
REVISION DETAIL
https://reviews.freebsd.org/D7710
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, glebius, bz, gnn, rwatson, araujo, bms
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: glebius, bz, gnn, rwatson, araujo, bms.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D7710
AFFECTED FILES
sys/net/ethernet.h
CHANGE DETAILS
diff --git a/s
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: hselasky, glebius, bz, gnn, rwatson.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION SUMMARY
While I'm here, sort the RNDIS status in ascending order.
REVISION DETAIL
https://reviews.freebsd.org
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D7592#157754, @hselasky wrote:
> Just make sure the code builds, amd64, i386, arm.
>
> --HPS
Yeah, sure.
REVISION DETAIL
https://reviews.freebsd.org/D7592
EMAIL PREFERENCES
https://reviews.freebsd.org/set
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: hselasky, glebius, bz, gnn, rwatson.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D7593
AFFECTED FILES
sys/dev/usb/net/if_urndis.c
sys/net/rndis.h
CHANGE
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D7592
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, hselasky, glebius, rwatson, bz, gnn, adrian
Cc: freebsd-net-list
___
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: rrs, gallatin, hselasky, np.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
Herald added a reviewer: transport.
REVISION SUMMARY
Obtained from: rrs, gallatin
REVISION DETAIL
https://reviews.freebsd
We have an optimized wrk here:
https://github.com/sepherosa/wrk
It greatly reduces the # of kqueue syscalls and avoids unnecessary
setsockopt etc. BTW, how many concurrent connections and threads are
you testing w/? Did you reduce the MSL on your client machines?
Default local port range probabl
On Thu, Aug 4, 2016 at 3:55 PM, Adrian Chadd wrote:
> [snip]
>
> I've updated the wiki with this TODO list. How's it look?
>
> https://wiki.freebsd.org/NetworkRSS
Pretty much what had been discussed on the mail-list. Good summary.
Thanks,
sephe
--
Tomorrow Will Never Die
_
sepherosa_gmail.com updated this revision to Diff 19032.
sepherosa_gmail.com added a comment.
Don't create entry for segments cant be further aggregated/delayed.
Noticed-by: hps
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D7415?vs=19031&id=19032
REVISION DETAIL
https://reviews
sepherosa_gmail.com added inline comments.
INLINE COMMENTS
> hselasky wrote in tcp_lro.c:852
> Should there be added:
>
> if (force_flush)
>
> return (TCP_LRO_CANNOT);
>
> If no match is found in the list?
Ah, yeah, it was in the original patch from rrs, got lost by me :P
REVISION DETAIL
sepherosa_gmail.com added reviewers: hiren, bz.
REVISION DETAIL
https://reviews.freebsd.org/D7415
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, rrs, gallatin, hselasky, np, glebius, #transport,
hiren, bz
Cc: freebsd-net-list
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: rrs, gallatin, hselasky, np, glebius.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
Herald added a reviewer: transport.
REVISION SUMMARY
This keeps the segments/ACK/FIN delivery order.
Before t
On Fri, Jul 22, 2016 at 6:39 AM, Adrian Chadd wrote:
> hi,
>
> Cool! Yeah, the RSS bits thing can be removed, as it's just doing a
> bitmask instead of a % operator to do mapping. I think we can just go
> to % and if people need the extra speed from a power-of-two operation,
> they can reintroduce
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6689#148473, @sepherosa_gmail.com wrote:
> In https://reviews.freebsd.org/D6689#148252, @rrs wrote:
>
> > These look fine and familiar ;-)
> >
> > I think a hash table as an option to sorting is probably a good th
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6689#148252, @rrs wrote:
> These look fine and familiar ;-)
>
> I think a hash table as an option to sorting is probably a good thing :D
Yeah, and I got pretty exiting performance improvement and noticeable la
diff --git a/sys/netinet/tcp_lro.h b/sys/netinet/tcp_lro.h
--- a/sys/netinet/tcp_lro.h
+++ b/sys/netinet/tcp_lro.h
@@ -40,6 +40,7 @@
struct lro_entry {
LIST_ENTRY(lro_entry) next;
+ LIST_ENTRY(lro_entry) hash_next;
struct mbuf *m_head;
struct mbuf *m_tail;
union {
@@ -95,6 +96,8 @@
u
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6689#142118, @gallatin wrote:
> Looks good in terms of not killing perf. for the sorted case, and I'm fine
with it as-is. However, maybe an else would be better than a goto?
Yeah, sure, I can move the bucket
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6689#141127, @hselasky wrote:
> > Well, as I said the VM does not have the luxury to do sorting :)
>
> Can you test the existing "tcp_lro_flush_all()" in combination with
"tcp_lro_queue_mbuf()" and compare it to your
sepherosa_gmail.com updated this revision to Diff 17347.
sepherosa_gmail.com added a comment.
Address hps's cache pollution concern for queue_mbuf path. Similar approach
was in the patch obtained from rrs.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D6689?vs=17214&id=17347
REVIS
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
diff --git a/sys/netinet/tcp_lro.h b/sys/netinet/tcp_lro.h
--- a/sys/netinet/tcp_lro.h
+++ b/sys/netinet/tcp_lro.h
@@ -40,6 +40,7 @@
struct lro_entry {
LIST_ENTRY(lro_entry) next;
+ LIST_ENTRY(lro_entry) hash_next;
struct mbuf *m_head;
struct mbuf *m_tail;
union {
@@ -95,6 +96,8 @@
u
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
diff --git a/sys/sys/mbuf.h b/sys/sys/mbuf.h
--- a/sys/sys/mbuf.h
+++ b/sys/sys/mbuf.h
@@ -316,30 +316,41 @@
*
* Most NICs support RSS, which provides ordering and explicit affinity, and
* use the hash m_flag bits to indicate what header fields were covered by
- * the hash. M_HASHTYPE_OPAQUE
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
sepherosa_gmail.com added a comment.
Any comment? I'd like to get this in before 11 code freeze.
REVISION DETAIL
https://reviews.freebsd.org/D5872
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, #network, glebius, adrian, delphij,
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6406#136037, @hselasky wrote:
> What is the advantage of this bit versus a hash-type range check?
Range check is not helpful. Some drivers' OPAQUE flowid is actually RSS hash
value (it just does not know the RSS
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6406#136051, @gallatin wrote:
> So the real goal here is to be able to express to the LRO code that you
have a hash that is usable as a hash (eg, not just an ordinal queue index), and
yet warn the RSS code that it is no
sepherosa_gmail.com added reviewers: network, adrian, delphij, rwatson, gnn,
glebius, rrs, gallatin, bz.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D6406
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#130813, @lstewart wrote:
> In https://reviews.freebsd.org/D5872#130806, @sepherosa_gmail.com wrote:
>
> > In https://reviews.freebsd.org/D5872#130805, @lstewart wrote:
> >
> > > In https://reviews.freebsd.org
sepherosa_gmail.com updated this revision to Diff 16171.
sepherosa_gmail.com added a comment.
Change if(..) {panic} into assertion and wrap the assertion using macro.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D5872?vs=15642&id=16171
REVISION DETAIL
https://reviews.freebsd.org/
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, rwatson, gnn, lstewart,
glebius, delphij, mike-karels.net, jtl, hiren, sbruno, hselasky.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
Herald added a reviewer: transport.
REVISION SUMMARY
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6120#130844, @hselasky wrote:
> Basically what you're doing is to loop back the flowid of the received
packet - right?
>
> Maybe you could put that in a code comment.
Yep, since we don't have inp to loopback
sepherosa_gmail.com updated the summary for this revision.
REVISION DETAIL
https://reviews.freebsd.org/D6120
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, adrian, rwatson, gnn, lstewart, glebius, delphij,
mike-karels.net, jtl, networ
sepherosa_gmail.com updated this revision to Diff 15725.
sepherosa_gmail.com added a comment.
Skip the free list operation, which may introduce extra cmp on hot code path
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D6137?vs=15684&id=15725
REVISION DETAIL
https://reviews.freebsd.
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#130813, @lstewart wrote:
> In https://reviews.freebsd.org/D5872#130806, @sepherosa_gmail.com wrote:
>
> > In https://reviews.freebsd.org/D5872#130805, @lstewart wrote:
> >
> > > In https://reviews.freebsd.org
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#130805, @lstewart wrote:
> In https://reviews.freebsd.org/D5872#130179, @sepherosa_gmail.com wrote:
>
> > We probably can leave the cwnd resetting to later rexmt timeout or
possible later fast retransmit (I thin
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6137#130603, @gallatin wrote:
> The tcp_lro_entry_get() abstraction adds an extra compare to the critical
path (the compare against NULL in the function itself, in addition to the same
compare in the main routine). At
sepherosa_gmail.com added inline comments.
INLINE COMMENTS
sys/netinet/tcp_syncache.c:1507 OK, but as a different commit.
REVISION DETAIL
https://reviews.freebsd.org/D6120
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, adrian, rwats
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D6120#130786, @hiren wrote:
> I hope you'd write a bit more descriptive commit-log (not just 'what' but
also 'why') for the change. Thanks a lot for your work!
OK :)
REVISION DETAIL
https://reviews.freebsd.org/
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, gallatin, rrs, adrian, delphij,
glebius, hselasky, np, decui_microsoft.com, honzhan_microsoft.com,
howard0su_gmail.com.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
Herald added a reviewer: trans
sepherosa_gmail.com added inline comments.
INLINE COMMENTS
sys/netinet/tcp_output.c:1551 It's what I am testing w/, since I need
non-INVARIANT kernel to generate enough traffic to make ENOBUFS happen.
We can change it into KASSERT, however, I am wondering should we just use "if
(__predict
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, rwatson, gnn, lstewart,
glebius, delphij, mike-karels.net, jtl, hiren.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
Herald added a reviewer: transport.
REVISION DETAIL
https://reviews.f
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#130173, @mike-karels.net wrote:
> I disagree; congestion is congestion, not "congestion for everyone but me".
I'd prefer to leave the cwnd change until it is replaced by something more
modern.
We probably
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#128542, @mike-karels.net wrote:
> btw, I think the line to set the snd_cwnd should remain for now, until
something replaces it. ENOBUFS signals local congestion.
Well, resetting the cwnd can be unfair for
sepherosa_gmail.com updated the summary for this revision.
sepherosa_gmail.com updated this revision to Diff 15642.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D5872?vs=14968&id=15642
REVISION DETAIL
https://reviews.freebsd.org/D5872
AFFECTED FILES
sys/netinet/tcp_output.c
CHANG
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#128556, @hiren wrote:
> In https://reviews.freebsd.org/D5872#128555, @lstewart wrote:
>
> > I thought that had been fixed ages ago... oops.
>
>
> Fixed? i.e. doing something other than setting cwnd to 1 seg
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#128542, @mike-karels.net wrote:
> btw, I think the line to set the snd_cwnd should remain for now, until
something replaces it. ENOBUFS signals local congestion.
ok.
REVISION DETAIL
https://reviews.fre
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#128535, @gnn wrote:
> Not my comment "once everyone agrees" :-)
heh, just read the first part of the comment :P
REVISION DETAIL
https://reviews.freebsd.org/D5872
EMAIL PREFERENCES
https://reviews.freebs
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#128530, @gnn wrote:
> Let's keep this moving along. Mike isn't (yet) a committer but if someone
can commit this once everyone agrees that would be great.
OK, I will do it.
REVISION DETAIL
https://reviews
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5872#127372, @mike-karels.net wrote:
> Setting a retransmission timer on an ACK makes no sense; I don't think
tcp_output will send an ACK on a retransmission timeout.
>
> Setting timers in the ENOBUFS case is at best
1 - 100 of 201 matches
Mail list logo
