Re: [FFmpeg-devel] [PATCH] avfilter/vf_tonemap: add slice threading

2019-04-30 Thread Paul B Mahol
On 4/30/19, Vittorio Giovara wrote: > On Tue, Apr 30, 2019 at 6:07 AM Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/vf_tonemap.c | 39 ++- >> 1 file changed, 34 insertions(+), 5 deletions(-)

Re: [FFmpeg-devel] [PATCH] lavfi: add gblur_opencl filter

2019-05-02 Thread Paul B Mahol
On 5/2/19, Dylan Fernando wrote: > On Tue, 30 Apr 2019 at 11:45 pm, Paul B Mahol wrote: > >> On 4/30/19, Dylan Fernando wrote: >> > >> > Anyone have any feedback? >> >> If I'm not mistaken there is already one available. >> __

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-03 Thread Paul B Mahol
On 4/28/19, Marton Balint wrote: > Hi All, > > There has been discussion on the mailing list several times about the > inclusion of support for closed source components (codecs, formats, > filters, etc) in the main ffmpeg codebase. > > Also the removal of libNDI happened without general consensus,

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-03 Thread Paul B Mahol
On 5/3/19, Gyan wrote: > > > On 29-04-2019 01:32 AM, Marton Balint wrote: >> So here is a call to the voting committee [1] to decide on the >> following two questions: >> >> 1) Should libNDI support be removed from the ffmpeg codebase? > > No. > Yes. > Gyan >

[FFmpeg-devel] [PATCH] avcodec/wavpack: use cached bit reader

2019-05-03 Thread Paul B Mahol
Gives noticeable speed boost. Signed-off-by: Paul B Mahol --- libavcodec/wavpack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c index d0242809fe..9798662045 100644 --- a/libavcodec/wavpack.c +++ b/libavcodec/wavpack.c @@ -21,6 +21,7

[FFmpeg-devel] [PATCH] avfilter: add xmedian filter

2019-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 11 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_xmedian.c | 325 +++ 4 files changed, 338 insertions(+) create mode 100644 libavfilter/vf_xmedian.c diff

[FFmpeg-devel] [PATCH] avfilter/f_interleave: switch to activate

2019-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/f_interleave.c | 125 +++-- 1 file changed, 51 insertions(+), 74 deletions(-) diff --git a/libavfilter/f_interleave.c b/libavfilter/f_interleave.c index d8a73b52e5..0966c4a0d8 100644 --- a/libavfilter/f_interleave.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pnm_parser: clear state if buffer is discarded

2019-05-04 Thread Paul B Mahol
On 5/4/19, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: > 14484/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGMYUV_fuzzer-5150016408125440 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nied

[FFmpeg-devel] [DECISION] scaletempo filter

2019-05-04 Thread Paul B Mahol
Hi, I open votes for 7 days. Voting is about inclusion of scaletempo filter (IMHO it is better than atempo) in FFmpeg. Thanks for voting. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

[FFmpeg-devel] [DECISION] colorhold filter

2019-05-04 Thread Paul B Mahol
Hi, I open voting for 7 days, for inclusion of colorhold filter in FFmpeg, with minor changes. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffm

[FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-05-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 18 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_colorkey.c | 102 +- 4 files changed, 121 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH v2] avfilter/f_realtime: add option to scale speed

2019-05-04 Thread Paul B Mahol
On 5/1/19, Moritz Barsnick wrote: > --- > doc/filters.texi | 8 > libavfilter/f_realtime.c | 7 +-- > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index cd82869849..2f9333c3f3 100644 > --- a/doc/filters.texi > +++ b/

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-04 Thread Paul B Mahol
On 5/4/19, John Warburton wrote: > On Sat, May 4, 2019 at 2:41 PM Nicolas George wrote: > >> Paul B Mahol (12019-05-04): >> > I open votes for 7 days. Voting is about inclusion of scaletempo >> > filter (IMHO it is better than atempo) in FFmpeg. >> > >&g

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-04 Thread Paul B Mahol
On 5/4/19, Paul B Mahol wrote: > Hi, > > I open voting for 7 days, for inclusion of colorhold filter in FFmpeg, > with minor changes. > > Thanks. > See: http://ffmpeg.org/pipermail/ffmpeg-devel/2019-May/243481.html ___ ffmpeg-deve

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-04 Thread Paul B Mahol
On 5/4/19, Nicolas George wrote: > Paul B Mahol (12019-05-04): >> There is old patch on this ML (but it probably no more applies cleanly), >> and no, >> this is not about removing/replacing filter, this is about adding new >> filter. > > And as I said, this vote

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-04 Thread Paul B Mahol
On 5/4/19, Swaraj Hota wrote: > Fixes ticket #2956. > > Signed-off-by: Swaraj Hota > --- > Revised patch. Made some minor changes based on original player: > - Removed incorrect reading of frame_rate, instead frame rate > is kept fixed at 25 (seems like this value is always same). > - Added readi

Re: [FFmpeg-devel] [PATCH v2] avfilter/f_realtime: add option to scale speed

2019-05-04 Thread Paul B Mahol
On 5/4/19, Moritz Barsnick wrote: > On Sat, May 04, 2019 at 16:19:13 +0200, Paul B Mahol wrote: >> > +{ "speed", "speed factor", OFFSET(speed), AV_OPT_TYPE_DOUBLE, { >> > .dbl = >> > 1.0 }, DBL_MIN, DBL_MAX, FLAGS }, >> >> Why

Re: [FFmpeg-devel] [PATCH] avfilter/f_interleave: switch to activate

2019-05-05 Thread Paul B Mahol
On 5/3/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/f_interleave.c | 125 +++-- > 1 file changed, 51 insertions(+), 74 deletions(-) > Will apply. ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] vf_tonemap.c: Support for slice thread for performance

2019-05-05 Thread Paul B Mahol
On 5/5/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > --- > libavfilter/vf_tonemap.c | 109 +-- > 1 file changed, 81 insertions(+), 28 deletions(-) > > diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c > index efd4af5466..0b26dd5e7f 10

Re: [FFmpeg-devel] [PATCH] avcodec/truehd_core: reset state when flushing

2019-05-05 Thread Paul B Mahol
On 5/5/19, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/truehd_core_bsf.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/truehd_core_bsf.c b/libavcodec/truehd_core_bsf.c > index 409e570eec..9e3ee07eed 100644 > --- a/libavcodec/truehd_core_bsf.c >

Re: [FFmpeg-devel] [PATCH] avcodec/qtrle: Do not output duplicated frames on insufficient input

2019-05-05 Thread Paul B Mahol
On 5/30/18, Michael Niedermayer wrote: > On Sun, May 27, 2018 at 09:59:58PM +0200, Michael Niedermayer wrote: >> This improves performance and makes qtrle behave more similar to other >> decoders. >> Libavcodec does generally not output known duplicated frames, instead the >> calling Application >

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Paul B Mahol
On 5/4/19, Paul B Mahol wrote: > On 5/4/19, Paul B Mahol wrote: >> Hi, >> >> I open voting for 7 days, for inclusion of colorhold filter in FFmpeg, >> with minor changes. >> >> Thanks. >> > > See: http://ffmpeg.org/pipermail/ffmpeg-dev

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Paul B Mahol
On 5/5/19, Reimar Döffinger wrote: > On 04.05.2019, at 15:40, Paul B Mahol wrote: >> Hi, >> >> I open voting for 7 days, for inclusion of colorhold filter in FFmpeg, >> with minor changes. >> >> Thanks. > > Why is there a need to vote? Because Nico

[FFmpeg-devel] [PATCH] avfilter: add asr filter

2019-05-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure| 4 + doc/filters.texi | 32 +++ libavfilter/Makefile | 1 + libavfilter/af_asr.c | 177 +++ libavfilter/allfilters.c | 1 + 5 files changed, 215 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH]lavf/rpl: Don't be case-sensitive detecting codecs

2019-05-05 Thread Paul B Mahol
On 5/5/19, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #7859. > > Please comment, Carl Eugen > ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Paul B Mahol
On 5/5/19, Nicolas George wrote: > Paul B Mahol (12019-05-05): >> Because Nicolas objected on initial implementation. Dunno if he still >> object something on current updated patch. > > Did it have a proper review on the mailing list? If yes, then I do not > oppose it.

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-05 Thread Paul B Mahol
On 5/4/19, Swaraj Hota wrote: > Okay. Thanks! > Sorry, but I found some issues while testing your patch. Why are there no timestamps? Seeking with mpv/ffplay caused hard crash. You do not handle EOF, so ffmpeg with .ivf never exits. ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avcodec/fits: Check bitpix

2019-05-05 Thread Paul B Mahol
On 5/5/19, Michael Niedermayer wrote: > Reference: Table 8: Interpretation of valid BITPIX value from FITS standard > 4.0 > Fixes: runtime error: division by zero > Fixes: > 14581/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5652382425284608 > > Found-by: continuous fuzzing proces

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-05 Thread Paul B Mahol
Some more or less important issues found: On 5/4/19, Swaraj Hota wrote: > Fixes ticket #2956. > > Signed-off-by: Swaraj Hota > --- > Revised patch. Made some minor changes based on original player: > - Removed incorrect reading of frame_rate, instead frame rate > is kept fixed at 25 (seems like

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Paul B Mahol
On 5/5/19, Nicolas George wrote: > Marton Balint (12019-05-05): >> I don't think you can insist on waiting for a review unless you plan to >> do >> it yourself in a reasonable time frame. > > Do you really think I have a duty to help Paul after all the insults he > have subjected me? Really? > > I

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Paul B Mahol
On 5/5/19, Reimar Döffinger wrote: > On 05.05.2019, at 18:04, Paul B Mahol wrote: > >> On 5/5/19, Reimar Döffinger wrote: >>> On 04.05.2019, at 15:40, Paul B Mahol wrote: >>>> Hi, >>>> >>>> I open voting for 7 days, for inclusi

Re: [FFmpeg-devel] Quo vadis, code of conduct?

2019-05-06 Thread Paul B Mahol
On 5/6/19, Nicolas George wrote: > Nicolas George (12019-05-06): >> Hi. Replying in private to avoid feeding the flame. > > Well, fumbled that. Yet, what I said was true and I made no judgement in > my mail. I singled somebody, but since it was specifically who would > have been in breach of the C

Re: [FFmpeg-devel] [PATCH] lavfi/gblur: doing several columns at the same time

2019-05-06 Thread Paul B Mahol
On 5/6/19, Ruiling Song wrote: > Instead of doing each column one by one, doing several columns > together gives about 30% better performance. > > Signed-off-by: Ruiling Song > --- > below is some of performance numbers(fps) on my i7-6770HQ (decode + gblur): > > resolution:480p | 720p

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-06 Thread Paul B Mahol
On 5/6/19, Marton Balint wrote: > > > On Sat, 4 May 2019, John Warburton wrote: > >> On Sat, May 4, 2019 at 3:34 PM Nicolas George wrote: >> >>> John Warburton (12019-05-04): >>> >>> > Is there a patch I can use to test scaletempo to compare it against >>> atempo? >>> > It'll be no trouble to do

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Paul B Mahol
On 5/6/19, Lynne wrote: > May 5, 2019, 1:52 PM by d...@lynne.ee: > >> May 4, 2019, 10:00 PM by > d...@lynne.ee > : >> >>> May 4, 2019, 8:10 PM by > >> mich...@niedermayer.cc >>> >> > mich...@niedermayer.cc >>> >>

[FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-06 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Makes ffplay display correct timestamps when seeking. --- libavfilter/af_atempo.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index bfdad7d76b..6a23d59641 100644 --- a/libavfilter

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-07 Thread Paul B Mahol
On 5/6/19, Marton Balint wrote: > > > On Mon, 6 May 2019, Marton Balint wrote: > >> >> >> On Mon, 6 May 2019, Paul B Mahol wrote: >> >>> On 5/6/19, Marton Balint wrote: >>>> >>>> >>>> On Sat, 4 May 2019, John

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: set better error msg for missing layout

2019-05-07 Thread Paul B Mahol
On 5/7/19, Gyan wrote: > Set a better error msg than the current failure to configure output pad. > Please apply, but with: avfilter/vf_xstack: set better error msg for missing layout ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: Make ffplay display correct timestamps when seeking

2019-05-08 Thread Paul B Mahol
On 5/8/19, Pavel Koshevoy wrote: > NOTE: this is a refinement of the patch from Paul B Mahol > offset all output timestamps by same amount of first input timestamp > --- > libavfilter/af_atempo.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > dif

Re: [FFmpeg-devel] loop Video Filter Not Looping

2019-05-08 Thread Paul B Mahol
On 5/8/19, talkvi...@talkvideo.net wrote: > The commands below all produce an output with a smaller video overlaid in > the upper left. But, it will not loop. It plays > the overlay until its end, and stays on the last frame. > > The overlay must of course be shorter in time than the main video, b

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-08 Thread Paul B Mahol
On 5/7/19, Paul B Mahol wrote: > On 5/6/19, Marton Balint wrote: >> >> >> On Mon, 6 May 2019, Marton Balint wrote: >> >>> >>> >>> On Mon, 6 May 2019, Paul B Mahol wrote: >>> >>>> On 5/6/19, Marton Balint wrote: >>&

Re: [FFmpeg-devel] [PATCH] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-05-09 Thread Paul B Mahol
On 5/9/19, Romane Lafon wrote: > This patch extends aphasemeter filter to display metadata for out-of-phase > or mono sequences of stereo streams. > Displays start, end and duration as for silencedetect filter. > We do not do: true/false thing. Use 1/0. __

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Paul B Mahol (12019-05-09): >> I got into possession of code that is better than atempo for very >> small scale factors (0.5). >> >> So I gonna write new filter which would also be able to change both >> tempo and pitch at same t

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Jun Li (12019-05-09): >> I see transpose filter and vflip/hvlip filter, but could not find >> "transform". > > I do not think I suggested a filter with that name exists. > >> are you suggesting creating a new one achieve both transpose and flip, or >> modify tra

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Paul B Mahol
On 5/9/19, Paul B Mahol wrote: > On 5/9/19, Nicolas George wrote: >> Paul B Mahol (12019-05-09): >>> I got into possession of code that is better than atempo for very >>> small scale factors (0.5). >>> >>> So I gonna write new filter which would also

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Paul B Mahol (12019-05-09): >> Also atempo does not do pitch adjustments. > > Pitch and speed adjustments are the same thing. Give mathematical proof. ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Paul B Mahol (12019-05-09): >> Merging of what filters? > > transpose and rotate when it is an integer quarter of turns. But > apparently they are already merged. > >> Your reasoning is illogical. > > Your reasoning is a

Re: [FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-05-11 Thread Paul B Mahol
On 5/4/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 18 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_colorkey.c | 102 +- > 4 files ch

Re: [FFmpeg-devel] [PATCH v2] fix issues with transparent crop. (see https://trac.ffmpeg.org/ticket/7890)

2019-05-11 Thread Paul B Mahol
On 5/9/19, Bjorn Roche wrote: > From: Jacob Graff > > Resolves issues with some transparent gifs. > see https://trac.ffmpeg.org/ticket/7890 > contribution by Jacob Graff > Applied. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.o

Re: [FFmpeg-devel] [PATCH] avfilter: add asr filter

2019-05-11 Thread Paul B Mahol
On 5/5/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure| 4 + > doc/filters.texi | 32 +++ > libavfilter/Makefile | 1 + > libavfilter/af_asr.c | 177 +++ > libavfilter/allf

Re: [FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-05-11 Thread Paul B Mahol
On 5/11/19, Nicolas George wrote: > Paul B Mahol (12019-05-11): >> 7 days passed, nobody voted against. So I will apply this filter soon. > > Two people have objected to the vote itself. That is more than one. > Please realize you are using intimidation techniques that have >

[FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- This filter can dynamically change both tempo and pitch of audio. Also scale range is bigger, from 0.01 to 100. --- libavfilter/Makefile | 1 + libavfilter/af_apitch.c | 764 +++ libavfilter/allfilters.c | 1 + 3

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-11 Thread Paul B Mahol
Hi, On 5/11/19, Nicolas George wrote: > Paul B Mahol (12019-05-11): >> Signed-off-by: Paul B Mahol >> --- >> >> This filter can dynamically change both tempo and pitch of audio. >> Also scale range is bigger, from 0.01 to 100. >> >> --- >>

Re: [FFmpeg-devel] [PATCH] avcodec/hq_hqa: Check available space before reading slice offsets

2019-05-12 Thread Paul B Mahol
On 5/12/19, Michael Niedermayer wrote: > Fixes: Timeout (43sec -> 18sec) > Fixes: > 14556/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQ_HQA_fuzzer-5673543024508928 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Paul B Mahol
On 5/12/19, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 09:41 Uhr schrieb Paul B Mahol : > >> Also you need real review. > > He needs to request a review which I believe he did. But full real review is still missing. ___ ffmpeg-

[FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- This filter can dynamically change both tempo and pitch of audio. Also scale range is bigger, from 0.01 to 100. Fixed silly out of phase bug for multichannel audio. --- libavfilter/Makefile | 1 + libavfilter/af_apitch.c | 776

Re: [FFmpeg-devel] [PATCHv2] lavfi: add gblur_opencl filter

2019-05-12 Thread Paul B Mahol
On 5/8/19, Song, Ruiling wrote: > > >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Dylan Fernando >> Sent: Tuesday, May 7, 2019 8:27 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCHv2] lavfi: add gblur_opencl filt

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
Hi, On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-11): >> It is currently separate filter for ease of testing. > > Then no problem. But I insist: once it is in shape, for the convenience > of the users and ease of maintenance, it should be a single filter. >

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> That is hard problem, how would one know what implementation is best for >> user scenario. > > Better developers who know the limits of their filters than users who do > not know. > >> I disagr

Re: [FFmpeg-devel] [PATCH] avfilter: add asr filter

2019-05-12 Thread Paul B Mahol
On 5/11/19, Paul B Mahol wrote: > On 5/5/19, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure| 4 + >> doc/filters.texi | 32 +++ >> libavfilter/Makefile | 1 + &

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> Calling atempo filter atempo when it also modifies pitch is bad for users >> and >> at same time not having apitch filter, user would think that they can >> not alter pitch. >> Sorry if you can

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> We have both setsar and setdar, > > And that is a mistake. We should have a single "set" filter that can > change all the transparent numeric properties of frames (sar, time base, > timestamp

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Marton Balint wrote: > > > On Sun, 12 May 2019, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> >> This filter can dynamically change both tempo and pitch of audio. >> Also scale range is bigger, from 0.01 to 100. > >

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> You can not merge filters by removing other filters as that will break >> user scripts. > > I know how do avoid that, thank you very much. > How would you avoid that?

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2019-05-12 Thread Paul B Mahol
On 5/12/19, Baptiste Coudurier wrote: > Hi Tomas > >> On May 12, 2019, at 6:47 AM, Tomas Härdin wrote: >> >> fre 2019-05-10 klockan 08:50 -0700 skrev Baptiste Coudurier: >>> +static inline int get_ue_golomb(GetBitContext *gb) { >>> +int i, v; >>> +for (i = 0; i < 32 && !get_bits1(gb); i++

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread Paul B Mahol
On 5/12/19, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : >> >> On 5/12/19, Carl Eugen Hoyos wrote: >> > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : >> >> >> >> Patch updated again. >> >> M

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread Paul B Mahol
On 5/12/19, Carl Eugen Hoyos wrote: > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : >> >> Patch updated again. >> Made some more cleanups to the transforms, the tables and the main >> context. >> API changed again, now the init function populates the function pointer >> for transform. >> I dec

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-12 Thread Paul B Mahol
On 5/12/19, Michael Niedermayer wrote: > On Sun, May 12, 2019 at 11:00:51PM +0200, Nicolas George wrote: >> Marton Balint (12019-05-12): >> > Yeah, you are right, what I had in mind was this: >> > >> > apitch === asetrate,aresample,atempo >> >> Exactly. And reciprocally, atempo = apitch+asetrate

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Paul B Mahol
On 5/13/19, Carl Eugen Hoyos wrote: > Am Mo., 13. Mai 2019 um 00:55 Uhr schrieb James Almer : >> >> On 5/12/2019 7:42 PM, Carl Eugen Hoyos wrote: >> > Am So., 12. Mai 2019 um 23:58 Uhr schrieb Lynne : >> >> I need *technical* feedback about the API. >> > >> > I understand that. >> >> Then, if you

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Paul B Mahol
On 5/13/19, Carl Eugen Hoyos wrote: > Am Mo., 13. Mai 2019 um 13:24 Uhr schrieb Lynne : > >> I'll ignore Carl's messages for now as I agree with the others that >> authorship is always >> preserved through git history. > > This is not the question here. > >> If he disagrees then it becomes a proje

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Paul B Mahol
On 5/13/19, Carl Eugen Hoyos wrote: > Am Mo., 13. Mai 2019 um 13:24 Uhr schrieb Lynne : > >> I'll ignore Carl's messages for now as I agree with the others that >> authorship is always >> preserved through git history. > >> If he disagrees then it becomes a project-wide issue as >> copyright heade

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Paul B Mahol
On 5/13/19, Carl Eugen Hoyos wrote: > Am Mo., 13. Mai 2019 um 13:31 Uhr schrieb Paul B Mahol : >> >> On 5/13/19, Carl Eugen Hoyos wrote: >> > Am Mo., 13. Mai 2019 um 13:24 Uhr schrieb Lynne : >> > >> >> I'll ignore Carl's messages for

Re: [FFmpeg-devel] [PATCH] avfilter: add xmedian filter

2019-05-13 Thread Paul B Mahol
On 5/3/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 11 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_xmedian.c | 325 +++ > 4 files ch

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stack: Don't modify const strings

2019-05-14 Thread Paul B Mahol
On 5/14/19, Gyan wrote: > > > On 14-05-2019 09:45 AM, Andreas Rheinhardt wrote: >> b3b7ba62 introduced undefined behaviour: A (non-modifiable) string >> literal has been assigned to a modifiable string; said string was indeed >> modified later via av_strtok. >> This of course caused compiler warni

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stack: Don't modify const strings

2019-05-14 Thread Paul B Mahol
On 5/14/19, Andreas Rheinhardt wrote: > b3b7ba62 introduced undefined behaviour: A (non-modifiable) string > literal has been assigned to a modifiable string; said string was indeed > modified later via av_strtok. > This of course caused compiler warnings because of the discarded > qualifier; thes

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-14 Thread Paul B Mahol
On 5/10/19, Lynne wrote: > Patch updated again. > Made some more cleanups to the transforms, the tables and the main context. > API changed again, now the init function populates the function pointer for > transform. > I decided that having a separate function would encourage bad usage (e.g. > cal

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-14 Thread Paul B Mahol
On 5/14/19, Carl Eugen Hoyos wrote: > > > >> Am 14.05.2019 um 19:17 schrieb Lynne : > >> I've attached the latest version. > > This patch is still not ok, please do not commit. > I will and you can not stop me. > Carl Eugen > ___ > ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: stop resource leak

2019-05-15 Thread Paul B Mahol
On 5/15/19, Gyan wrote: > > See http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-May/244029.html > > Gyan > probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link a

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-15 Thread Paul B Mahol
On 5/12/19, Paul B Mahol wrote: > On 5/12/19, Michael Niedermayer wrote: >> On Sun, May 12, 2019 at 11:00:51PM +0200, Nicolas George wrote: >>> Marton Balint (12019-05-12): >>> > Yeah, you are right, what I had in mind was this: >>> > >>> >

[FFmpeg-devel] [PATCH 2/4] avformat/vivo: improve probing of some files

2019-05-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 9a07c43849..1b1bfaffc7 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -59,9 +59,10 @@ static int vivo_probe(const

[FFmpeg-devel] [PATCH 3/4] avformat/vivo: add support for siren codec

2019-05-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 1b1bfaffc7..730ca4bb99 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -232,6 +232,11 @@ static int vivo_read_header

[FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

2019-05-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/siren.c | 724 5 files changed, 734 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH 4/4] avformat/vivo: set packet duration

2019-05-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 730ca4bb99..f3436fccd2 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -36,6 +36,7 @@ typedef struct VivoContext

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

2019-05-16 Thread Paul B Mahol
On 5/16/19, Nicolas George wrote: > Jun Li (12019-05-16): >> Sure. >> This patch is checking the frame's orientation status, and apply input >> filter if necessary. >>frame 1 -> check orientation -> get 2 -> need flip --> goto filter >>frame 2 -> check orientation -> get 1 -> do nothing >

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-17 Thread Paul B Mahol
On 5/17/19, Mathieu Duponchelle wrote: > There isn't one, as I said the added indentation is because of the new loop! To get this committed to tree you need to comply to review requests. > > On 5/13/19 3:39 PM, Carl Eugen Hoyos wrote: >> Am Mi., 10. Apr. 2019 um 13:26 Uhr schrieb Mathieu Duponch

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-17 Thread Paul B Mahol
On 5/15/19, Paul B Mahol wrote: > On 5/12/19, Paul B Mahol wrote: >> On 5/12/19, Michael Niedermayer wrote: >>> On Sun, May 12, 2019 at 11:00:51PM +0200, Nicolas George wrote: >>>> Marton Balint (12019-05-12): >>>> > Yeah, you are right, what

Re: [FFmpeg-devel] [PATCH] libavdevice/gdigrab: fix ffmpeg -devices doesn't show gdigrab

2019-05-17 Thread Paul B Mahol
On 5/17/19, Jun Zhao wrote: > From: Jun Zhao > > missed the category AV_CLASS_CATEGORY_DEVICE_VIDEO_INPUT lead to > ffmpeg -devices doesn't show gdigrab as a input device > > FIx #7848 > > Found-by: dangibson > Signed-off-by: Jun Zhao > --- > libavdevice/gdigrab.c |1 + > 1 files changed, 1

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-17 Thread Paul B Mahol
On 5/17/19, Nicolas George wrote: > Paul B Mahol (12019-05-17): >> Because lack of testers, I will apply this patch as is. > > Absolutely not. The consensus was to have a single filter, and even > possibly make it part of lswr. This is what is currently discussed. You are p

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-17 Thread Paul B Mahol
On 5/17/19, Paul B Mahol wrote: > On 5/17/19, Nicolas George wrote: >> Paul B Mahol (12019-05-17): >>> Because lack of testers, I will apply this patch as is. >> >> Absolutely not. The consensus was to have a single filter, and even >> possibly make it par

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-17 Thread Paul B Mahol
On 5/17/19, Nicolas George wrote: > Paul B Mahol (12019-05-17): >> If you or anyone does not propose some reasonable alternative solution >> in due time, I gonna apply this patch. > > As already said: a single filter named atempo with compatibility > options, or it is reje

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-17 Thread Paul B Mahol
On 5/17/19, Nicolas George wrote: > Paul B Mahol (12019-05-17): >> Says who? You are last person to be asked about this. > > Another ad-hominem attack. I really stopped counting, how many times you feel "attacked". > >> I already rejected such idea. > >

[FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-17 Thread Paul B Mahol
Hi, $subject. He is constantly against my patches, and derailing it with other things to just block them. He is also misguiding other fellow developers with unreasonable and impossible refactoring task, see that frame rotating patch set. libavfilter does not allow dynamic changing of frame para

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-18 Thread Paul B Mahol
On 5/18/19, Michael Niedermayer wrote: > On Wed, May 15, 2019 at 07:19:43PM +0200, Paul B Mahol wrote: >> On 5/12/19, Paul B Mahol wrote: >> > On 5/12/19, Michael Niedermayer wrote: >> >> On Sun, May 12, 2019 at 11:00:51PM +0200, Nicolas George wrote: >

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-18 Thread Paul B Mahol
ekend. You are obviously biased toward Nicolas, and far from being neutral. So I will just ignore your tries to be "helpful". > > Best regards, Not really. > Reimar Döffinger. > > On 17.05.2019, at 21:25, Paul B Mahol wrote: > >> Hi, >> >> $subject.

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-19 Thread Paul B Mahol
On 5/19/19, Ulf Zibis wrote: > > Am 18.05.19 um 23:48 schrieb Alexander Strasser: >> This is so sad :( >> And I am looking at both of you Nicolas and Paul. >> >> From what I know libavfilter wouldn't be anywhere near where it is today >> without you two! > +1 > >> There needs to be room for discus

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Paul B Mahol
On 5/19/19, Marton Balint wrote: > Fixes infinte loop with -vf loop=loop=1. > > Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. > > Signed-off-by: Marton Balint > --- > libavfilter/f_loop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Paul B Mahol
On 5/19/19, Marton Balint wrote: > > > On Sun, 19 May 2019, Paul B Mahol wrote: > >> On 5/19/19, Marton Balint wrote: >>> Fixes infinte loop with -vf loop=loop=1. >>> >>> Possible regression since ef1aadffc785b48ed62c45d954289e754

Re: [FFmpeg-devel] [PATCH V1 2/2] doc/writing_filters: Use ff_filter_get_nb_threads() get number of threads

2019-05-22 Thread Paul B Mahol
On 5/22/19, Jun Zhao wrote: > From: Jun Zhao > > ff_filter_get_nb_threads() respect AVFilterContext.nb_threads and > graph->nb_threads both, in most case, we perfer this API than using > ctx->graph->nb_threads directly. > --- > doc/writing_filters.txt |2 +- > 1 files changed, 1 insertions(+

Re: [FFmpeg-devel] [PATCH V1 1/2] lavfi/lensfun: Use ff_filter_get_nb_threads() get number of threads

2019-05-22 Thread Paul B Mahol
On 5/22/19, Jun Zhao wrote: > From: Jun Zhao > > ff_filter_get_nb_threads() respect AVFilterContext.nb_threads and > graph->nb_threads both, in most case, we perfer this API than using > ctx->graph->nb_threads directly. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_lensfun.c |4 ++-- >

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-23 Thread Paul B Mahol
On 5/23/19, Marton Balint wrote: > > > On Wed, 22 May 2019, Alexander Strasser wrote: > >> Hi! >> >> On 2019-05-20 20:51 +0200, Marton Balint wrote: >>> >>> On Mon, 20 May 2019, Gyan wrote: >>> >>> > On 20-05-2019 02:18 AM, M

<    1   2   3   4   5   6   7   8   9   10   >