e. Otherwise, changes in the function/macro can leave the error code
invalid.
We should never let the caller assume the error code.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.o
sign, fix it.
> Using variables is complicated. Constants make
> the code more simple and readable.
Simpler now, much more complex later to fix the incorrect error codes.
Regards,
--
Nicolas George
signature.asc
Descript
ose to anything that could give us more similar work.
If you do not like my proposal, feel free to make counter-proposals, but
if they pose the risk of losing the error code or let the caller invent
it, I will oppose them.
Regards,
--
Nicolas George
signature.asc
Description: PGP sig
Marton Balint (12020-05-12):
> Then I guess this patch got bikeshedded to pieces with no clear resolution.
> It was a cleanup attempt anyway, so I suggest the author to simply abandon
> it.
Do you mean you prefer to kill the patch than reach a consensus?
Regards,
--
Nicol
;d rather not add this feature.
It can only happen if the user has put filters in the middle. I move we
trust users who insert such obscure filters to do what they want to, or
to fix their issues if they have some.
Regards,
--
Nicolas George
signature.asc
Descripti
Paul B Mahol (12020-05-15):
> When to apply?
When I have time to check the few things I noted I had to check. Is it
important? Do you have a need for this?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-de
Nicolas George (12020-04-16):
> TODO APIchanges and minor bump.
>
> Signed-off-by: Nicolas George
> ---
> libavutil/rational.c | 9 +
> libavutil/rational.h | 6 ++
> 2 files changed, 15 insertions(+)
>
>
> This one too, I need for the code I am w
Nicolas George (12020-04-16):
> Signed-off-by: Nicolas George
> ---
> libavfilter/tests/formats.c | 136 ++--
> 1 file changed, 68 insertions(+), 68 deletions(-)
I indent to push this soon, so that I can push vf_untile too.
Regards,
--
Ni
e documented, I see no
reason to refuse them. Let us trust users. This is me NAKing your NAK.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listin
n a desktop distribution freshly
# installed, without configuration?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe,
Nicolas George (12020-05-19):
> The doc says:
>
> Requires either DRM master or CAP_SYS_ADMIN to run.
>
> Does it work for a normal user on a desktop distribution freshly
> installed, without configuration?
>
> (I should test, but all my boxes are very far from the
de.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
are problematic filters too.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-r
realize
that using a string for that was more of the same bad idea.
I have no objection to making this bit obsolete, but please do it
knowingly.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
Nicolas George (12020-05-19):
> Originally, the second parameter to avfilter_graph_dump() was supposed
> to be dump options. None was ever added, and I later came to realize
> that using a string for that was more of the same bad idea.
>
> I have no objection to making this bi
ns string, probably using
parse_key_value_pair() (why do we have two versions of this is beyond
me) or similar.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mail
Could you weigh in on the issue of filters/devices changing the OpenGL
global state, please?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailma
the request of the user.
Could we stop the fallacious implicit argument that the OpenGL devices
and filters would be used randomly rather than be explicitly requested
by users? If the users want to use that component and know the
consequences, who are you to deny them, seriously?
Regards,
-
sagree with yours; that does not
> necessarily mean they are wrong
> I know I am not alone in the impression that arguing with you is
> pointless since you seem to treat discussions as something that you need
> to win and disregard any arguments you disagree with.
Honestly, I have
kid.
> In any case, "other people do it too" is not much of a counter-argument
> here.
But "you do it too" is.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
ht
is unnecessary due to C's promotion rules.
> return NULL;
> size += sizeof(AVVideoBlockParams) * nb_blocks;
>
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel
Certainly. And?
> > The cast is unnecessary due to C's promotion rules.
> Yes, It seems it's not necessary as the first test.
The cast is unnecessary, period. Do you know C's promotion rules in this
case?
What I am really asking, in both cases, is:
Do you understand what you a
ze_t n, size_t s, size_t c)
{
return n <= SIZE_MAX / s && n * s < SIZE_MAX - c;
}
It would avoid the warning because n is size_t instead of unsigned.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-de
k->channel_layout);
> +av_bprintf(buf,
> +"fmt:%s sr:%d cl:%s tb:%d/%d",
> +av_get_sample_fmt_name(link->format),
> +link->sample_rate, audio_buf,
> + li
et the format and the change to allow to
set the output file belong in a different patch.
The existing dump_graph field can very well serve as the options string
for the function.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
Nicolas George (12020-04-16):
> Signed-off-by: Nicolas George
> ---
> doc/filters.texi | 34 ++
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/vf_untile.c | 198 +++
> tests/
Nicolas George (12020-04-16):
> TODO APIchanges and minor bump.
>
> Signed-off-by: Nicolas George
> ---
> libavutil/rational.c | 9 +
> libavutil/rational.h | 6 ++
> 2 files changed, 15 insertions(+)
Series pushed.
Regards,
--
Nicolas George
signature
Nicolas George (12020-04-16):
> Signed-off-by: Nicolas George
> ---
> libavfilter/formats.c | 41 +
> libavfilter/formats.h | 10 ++
> 2 files changed, 51 insertions(+)
Series pushed.
Regards,
--
Nicolas George
signature.
passing it
around and warning if there are remaining options should be the simplest
choice.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo
> code
> in the existing code for refering?
What?!? Definitely not. Have you read its doc? It is made for URLs, we
do not have any URL here.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
>
> libavformat/concatdec.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
Ok, I suppose.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
htt
myp...@gmail.com (12020-05-28):
> I guess it is based on https://github.com/VeriSilicon/VPI, but I just
> find some so library
There is no license.
I do not think we could consider supporting this until the external part
is solid enough.
Regards,
--
Nicolas George
signatu
two months ago as doing nothing useful?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or
Paul B Mahol (12020-05-28):
> Will apply soon.
I will hurry looking at it.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffm
ss allocations) and
simpler.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-de
lance.lmw...@gmail.com (12020-05-28):
> will apply the patchset tomorrow if no further comments.
Please give me time to look carefully. This is not urgent.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-de
Paul B Mahol (12020-05-28):
> Will apply in 5 minutes.
No. This code is unnecessary and complicates things.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mail
ours arguing over it.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ..
including unpublished projects, closed-source projects,
etc.
I can work with you to update the implementation so that it does not use
deprecated lavf APIs if you point me where the issue was discussed. But
just removing these libavdevices API is not acceptable.
Regards,
--
Nicolas George
sign
t; + * @param iter a pointer where iteration state is stored.
> + * @return AVClass corresponding to next potential child or NULL
> + */
> +const AVClass *av_opt_child_class_iterate(const AVClass *parent, void
> **iter);
>
> /**
> * @defgroup opt_set_funcs Option setting functions
> diff
.version = LIBAVUTIL_VERSION_INT, \
> .category = AV_CLASS_CATEGORY_FILTER, \
> .child_class_next = name##_child_class_next, \
> +.child_class_iterate = ff_framesync_child_class_iterate, \
> .child_next = name##_child_next, \
> }
>
ppens.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.o
lems));
If you change something, make sure the alignment is correct.
> if (!tmp)
> goto err_out;
> m->elems = tmp;
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-d
c changes on separate patches?
Because they make reviewing the actual changes harder.
But remember, changes in patches are shown lines per line.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
actually depended on the system-dependant definition
of the structure. This warning is just bogus, ={0} is always valid.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://f
ead the doc" should be SIGABORT. Proper error return should be reserved
for cases that cannot be tested statically.
So, in this case:
av_assert0(alloc);
If the code is tested, it is perfectly equivalent anyway, because alloc
will not be NULL.
Regards,
--
Nicolas George
signatur
ilter/af_afwtdn.c
No doc, name completely impossible to understand. Unacceptable.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Link *outlink = ctx->outputs[0];
> +ThreadData td;
> + AVFrame *out = NULL;
> +
> +out = ff_get_audio_buffer(outlink, in->nb_samples);
> +if (!out) {
> +av_frame_free(&in);
> +return AVERROR(ENOMEM);
> +}
> +out->pts =
s this filter is better than the others and in what cases it
is not.
We have been lax in the past, but that does not mean we should be lax
now or in the future. This filter should not be pushed unless these
concerns about user interface are addressed.
Regards,
--
Nicolas George
signature.asc
not the theory.
> frames stands for _frame_ _s_ize.
Not good, needs to be fixed.
> Seriously there are other wavelet non-audio filters in libavfilter or
> even libavcodec already, and they do not show from where numbers come.
They should.
--
Nicolas George
signature.asc
De
Paul B Mahol (12020-06-02):
I have nothing to add to what I have already written. This filter is
rejected until the problem I have pointed are resolved: better name,
better doc, better options name, comments on the magic numbers.
Regards,
--
Nicolas George
signature.asc
Description: PGP
ould need to know what this filter does, what benefit
it brings to the user. Let me see a user-oriented doc, and I can suggest
a name. But the user-oriented doc is missing too.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
Signed-off-by: Nicolas George
---
libavfilter/Makefile| 2 +-
libavfilter/asrc_sine.c | 53 -
libavfilter/intsine.c | 65 +
libavfilter/intsine.h | 44
4 files changed, 115 insertions
Allow to set the EOF timestamp.
Signed-off-by: Nicolas George
---
libavfilter/asrc_sine.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/libavfilter/asrc_sine.c b/libavfilter/asrc_sine.c
index 8fff1dda8b..947bc9a288 100644
--- a/libavfilter/asrc_sine.c
Signed-off-by: Nicolas George
---
Changelog | 1 +
doc/filters.texi| 50 ++
libavfilter/Makefile| 1 +
libavfilter/allfilters.c| 1 +
libavfilter/asrc_basicplay.c| 309
libavfilter/version.h
Fix trac ticket #8705.
Signed-off-by: Nicolas George
---
libavformat/tee.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Not tested, I have no icecast server at hand. I will ask the reporter to
test.
diff --git a/libavformat/tee.c b/libavformat/tee.c
index f2b11fcb35..c5c59975e6
Paul B Mahol (12020-06-02):
> No need to reinvent yet another poor synthesizer.
Which is precisely why what I implemented is something well established.
Can somebody give a third opinion please?
Regards,
--
Nicolas George
signature.asc
Description: PGP signat
to the documentation of the Music Macro Language, I
would gladly consider adding support for it too.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/li
anks for the pointers.
These syntaxes look rather easy to add to the filter. If I can assume
that your and Lou's comments are support for inclusion, I'll give it a
go.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
f
ut.
It was confirmed this change fixes the ticket. I will push it in a few
days if nobody finds an issue.
> On 2 Jun 2020, at 20:56, Nicolas George wrote:
Also please remember that top-posting is not accepted here.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
s in, now
|
"[content_type=video/webm]icecast://source:password@example.domain:8000/video.webm|savedVideo.webm"
| works as expected )
This the way to pass an option to an output.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
the link.
"Number of samples already sent through the link" seems more natural.
> + */
> +int64_t sample_count_in, sample_count_out;
Should be uint64_t.
> +
> /**
> * A pointer to a FFFramePool struct.
too. Signed arithmetic is more tricky, and compiler optimize it
less well: if something does not need to be negative, let it be
unsigned.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg
Kieran Kunhya (12020-06-03):
> $subj
Rejected for the flame-bait commit message.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffm
once for
> testing.
Thanks for the confirmation.
I just pushed the patch.
I think it is a candidate for back-porting.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https
> -outfilename = "/dev/stdout";
> -outfile = fopen(outfilename, "w");
> -if (!outfile) {
> -fprintf(stderr, "Failed to open output file '%s': %s\n",
> -outfil
ility, and you cannot change the
type of the existing option at all, or we do not, and it is not
necessary to add another option.
I move we do not care much about compatibility: the syntax was never
documented, except "1" should work. Then accept "1" and any valid
key-valu
Thilo Borgmann (12020-06-08):
> OSX accepts numerous formats, so there are several output devices.
The other audio output devices support all formats in a single device.
Why does Apple need to be different again?
Regards,
--
Nicolas George
signature.asc
Description: PGP signat
: Lavf58.42.100
Stream #0:0: Audio: pcm_s16le, 44100 Hz, mono, s16, 705 kb/s (default)
Output #0, alsa, to 'default':
Metadata:
encoder : Lavf58.42.100
Stream #0:0: Audio: pcm_f32le, 44100 Hz, mono, flt, 1411 kb/s (default)
Regards,
--
f, msg, argument_list);
> +avio_write(s->avio_context, buf.str, buf.len);
Error check missing.
> +av_bprint_finalize(&buf, NULL);
> }
> va_end(argument_list);
> }
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
__
ices have a matching lavfi sink. Unfortunately, for now, I am not
sure lavfi's scheduling work with non-buffer sinks. And it has other
drawbacks, including preventing S/PDIF.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
f data loss or data corruption, an error return is
necessary. If it requires changing the type of a function, so be it.
But you can do better than using BPrint: the existing code writes into a
buffer then writes the buffer to avio, even though we have
avio_printf().
Regards,
--
Nicolas George
t; va_end(argument_list);
> +
> +if (!av_bprint_is_complete(&buf)) {
> +av_bprint_finalize(&buf, NULL);
> +av_log(ctx, AV_LOG_ERROR, "No memory for buf\n");
> +return;
> +}
> +avio_write(s->avio_context, buf.str, buf.len);
We are talking about
if (options[0] == '1' && !options[1])
options = "";
at the beginning of an obscure function, not documented, only there to
avoid breaking existing scripts. If that stays for all eternity, we can
live w
rn AVERROR(ENOMEM);
> +}
> +}
> +
> +AudioQueueBufferRef buf = ctx->buffer[ctx->cur_buf];
> +
> +// copy audio data into buffer and enqueue the buffer
> +memcpy(buf->mAudioData, pkt->data, buf->mAudioDataBytesCapacity);
> +buf->mAudioDataByteSi
al solution.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmp
; now is your last chance to get it into 4.3
Can you include this commit:
commit a45be55d5b54827220ed9097932c9e2141488526 (HEAD -> michael,
michael/master, michael-ssh/master)
Author: Nicolas George
Date: 2020-06-02 20:55:30 +0200
lavf/tee: pass options to protocol.
Fix tra
en it is
not acceptable. It should be tested with codecs that use extradata (x264
for example) and also with rawvideo.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https:
lance.lmw...@gmail.com (12020-06-11):
> I'll apply the patch set in next two days if no further comments still.
> Please help to
> review if you think it's necessary.
Please do not include my name in the commit message.
Regards,
--
Nicolas George
signature.asc
Descrip
al header.
Why? How is it valid? If the codec requires global header, we cannot
just ignore them. And if the codec can change resolution, there is no
point in recreating it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpe
gt;
> Please help to comment, thx.
> https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=1470
Did it produce a rawvideo stream that can be decoded? I doubt it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
f
Fu, Linjie (12020-06-11):
> If rawvideo here means .h264, attached the output file produced by libx264:
Now, rawvideo means rawvideo.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-de
Paul B Mahol (12020-06-11):
> Signed-off-by: Paul B Mahol
> ---
> doc/filters.texi | 60 ++
> libavfilter/Makefile |1 +
> libavfilter/af_afwtdn.c | 1345 ++
> libavfilter/allfilters.c |1 +
> 4 files changed, 1407 insertions(+)
> create
ction much more complex, it would
be simpler implemented in the filters directly since they are not using
the full features of the queue.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
htt
Paul B Mahol (12020-06-12):
> This is part of basic math,
Then add the formula in a comment. But no, it is not just basic math:
there was a program that did the computations.
> you seems to lack basic math knowledge.
Rude again.
--
Nicolas George
signature.asc
Description: PGP sig
Paul B Mahol (12020-06-12):
> This is needed also by showspectrumpic filter and it needs random number of
> samples to skip and peek.
I looked at the code for showspectrumpic before making my comment: the
second part of your statement does not seem accurate.
--
Nicolas George
signatu
Paul B Mahol (12020-06-12):
> FFmpeg is not math encyclopedia.
You did not type these numbers, you took them from somewhere. Include it
in the source code, where it belongs.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffm
Paul B Mahol (12020-06-12):
> How so? Its purely random.
+ret = ff_inlink_peek_samples(inlink, s->win_size, &fin);
+ret = ff_inlink_peek_samples(inlink, s->window_size, &in);
They seem constant in both cases. Can you elaborate about this
randomness?
--
uld not be there!
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-r
would be kept in the original bitstream, since it's
> fundamentally
> supported in the encoder.
IIRC, encapsulation standards mandate one or the other for their
respective formats. We cannot choose.
Fact is, you cannot concatenate two packet streams and expect it to
work.
Regards,
--
av_timecode_make_smpte_tc_string(tcbuf, tc[j], 0);
> +av_bprintf(bp, "%s%s", tcbuf, j != m ? ", " : "");
> +}
> +}
> +}
> +
> if (s->tc_opt_string) {
> char tcbuf[AV_TIMECODE_STR
t; libavformat/dump.c| 22 ++
> 6 files changed, 36 insertions(+), 1 deletion(-)
Should come before the patches that use it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing l
ust_ntsc_framenum2(int framenum, int
> fps);
> uint32_t av_timecode_get_smpte_from_framenum(const AVTimecode *tc, int
> framenum);
>
> /**
> + * Convert TC string to SMPTE 12M binary representation.
> + *
> + * @param buf TC string
> + * @return the SMPTE
topped, check it is the end of the string.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link abo
count the comments that were made the first two times
this patch was proposed.
https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259659.html
https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259721.html
https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259722.html
Regards,
--
n that.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.or
lance.lmw...@gmail.com (12020-06-20):
> No, different function, if I can use it, then I'll use it.
Duplicating parsing code is a big no.
> do you have a broken string for my condition, I'm glad to test and fix it?
Any valid string with anything appended at the end.
Regards
is a good idea to do it like that, ok.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, o
from_framenum() to get the smpte binary
>
> do you think it's OK?
Yes, I think it is the correct way of doing it: using existing functions
instead of copying their code.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
lance.lmw...@gmail.com (12020-06-20):
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavutil/timecode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I doubt this was actually tested.
Regards,
--
Nicolas George
signature.asc
Descript
701 - 800 of 4940 matches
Mail list logo
