On Tue, Mar 26, 2019 at 00:24:40 +0100, Carl Eugen Hoyos wrote:
> > Fixes ticket #4519.
> I will push this if there are no objections.
While trying to see if the proposed XV demuxer[1] can be simplified, I
tripped over the fact that this KUX patch introduces a new demuxer for
what looks like "only
On more remark:
On Tue, Mar 19, 2019 at 22:41:32 +0530, swarajhota...@gmail.com wrote:
> +static int kux_probe(AVProbeData *p)
I get a warning if this isn't declared "const AVProbeData *p".
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
h
On Tue, Mar 26, 2019 at 11:22:58 +0100, Carl Eugen Hoyos wrote:
> > While trying to see if the proposed XV demuxer[1] can be simplified, I
> > tripped over the fact that this KUX patch introduces a new demuxer for
> > what looks like "only" a minor variant of FLV. Could the patch not just
> > as we
On Wed, Mar 27, 2019 at 18:05:32 +0530, Gyan wrote:
> +@item -drop_deviant_frames (@emph{input,per-stream})
> +Allows discarding decoded frames whose parameters differ from initialized
> +stream parameters. May be useful in
> +
It looks like this was truncated.
Moritz
Cheers,
On Wed, Mar 27, 2019 at 20:51:47 +0800, Zhong Li wrote:
> Just simply remove the private option, and switch to the AVCodecContext
> definition. Compatibility should not a big problem (expect can't exact map)
> since the option name is same as AVCodecContext.
You should probably bump libavcodec's m
On Thu, Mar 28, 2019 at 16:48:51 -0700, Laszlo Kovacs wrote:
> (P.S. I hope this text will be the body and not the subject :) )
> ---
> libavformat/hlsenc.c | 5 +++--
This time, the text is in the correct position. ;-) (Yes, you need an
empty line between what lands in the subject and what lands
On Sat, Mar 30, 2019 at 16:50:52 +0530, Gyan wrote:
> And what are the semantics of the user setting row_mt or enable-intrabc
> as -1?
The user doesn't set -1, they set 0 or 1 as bool. -1 helps to indicate
that nothing was set, and - in these cases - falls back to not setting
anything in the libar
Some minor nitpicking remarks from me:
> Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720.
Basically, the second sentence belongs into the body of the commit
message, after a single empty line separator. (It may not matter here.)
> Changelog| 1 +
>
On Tue, Apr 09, 2019 at 20:45:41 +0530, Shivam Goyal wrote:
> > I believe Carl Eugen asked you to change this to:
> > AVPROBE_SCORE_EXTENSION / 2 + 1
> Carl Eugen suggested me to change to AVPROBE_SCORE_MAX /2 +1
Ah, sorry, my bad - I missed that.
Thanks,
Moritz
__
On Sat, Apr 13, 2019 at 15:50:14 +0300, Eugene Lyapustin wrote:
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/vf_panorama.c | 637 ++
The documentation in doc/filters.texi also needs to be amended.
> +static const AVOpt
On Fri, Apr 19, 2019 at 19:20:50 +0200, Thomas Jammet wrote:
> @@ -6189,6 +6192,7 @@ enabled libopus && {
> enabled libpulse && require_pkg_config libpulse libpulse
> pulse/pulseaudio.h pa_context_new
> enabled librsvg && require_pkg_config librsvg librsvg-2.0
> librs
On Tue, Apr 23, 2019 at 11:15:40 +, Andreas Håkon wrote:
Nits:
> Subject: libavformat: forced PCR pid in mpegts muxer
"libavformat/mpegtsenc: allow to force the PID carrying the PCR"
(or something along those lines)
> By default FFmpeg selects the first video stream, or the first one in
> t
On Tue, Apr 23, 2019 at 12:03:11 +, Andreas Håkon wrote:
> In addition, one correction regarding the initialization.
> Sorry, but first version has an error. This is clean!
I had seen that the option got initialized to 0x, but checked that
that is never a legally assigned pid (there's a "<
On Thu, Apr 25, 2019 at 14:57:25 +0200, Paul B Mahol wrote:
> Found 65x65x65 3D LUT in wild
[...]
> /* 3D LUT don't often go up to level 32, but it is common to have a Hald CLUT
> * of 512x512 (64x64x64) */
> -#define MAX_LEVEL 64
> +#define MAX_LEVEL 65
You may also want to fix the values in t
On Thu, Apr 25, 2019 at 22:41:49 +1000, Dylan Fernando wrote:
> +static const AVOption gblur_opencl_options[] = {
> +{ "sigma", "set horizontal size", OFFSET(sigma), AV_OPT_TYPE_FLOAT,
> {.dbl=0.5}, 0.0, 1024, FLAGS },
^
Shouldn't this be "set sigma"?
> +{ "planes
Hi Paul,
On Sun, Apr 28, 2019 at 16:42:45 +0200, Paul B Mahol wrote:
Cosmetic nits:
> +Alowed range is from 1 to 6.
^ Allowed
> +Alowed range is from 2 to 256.
^
Ditto.
> +float *bbufers[256];
^
I'm not sure of the intent, but would this be "buffers" or "bbuffers"?
> +s
On Tue, Apr 30, 2019 at 15:45:23 +0200, Paul B Mahol wrote:
> On 4/30/19, Dylan Fernando wrote:
> >
> > Anyone have any feedback?
>
> If I'm not mistaken there is already one available.
Dylan did post a v2 of this patch (with changes made to those things I
commented on), but unfortunately posted
---
doc/filters.texi | 8
libavfilter/f_realtime.c | 7 +--
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index cd82869849..2f9333c3f3 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -21136,6 +21136,14 @@ They accep
a/libavcodec/realtime_bsf.c b/libavcodec/realtime_bsf.c
new file mode 100644
index 00..b9abda90a4
--- /dev/null
+++ b/libavcodec/realtime_bsf.c
@@ -0,0 +1,93 @@
+/*
+ * Realtime filter
+ * Copyright (c) 2015 Nicolas George
+ * Copyright (c) 2018 Moritz Barsnick
+ *
+ * This file is part of FFmpeg.
+
On Tue, Apr 30, 2019 at 22:13:13 +0200, Paul B Mahol wrote:
> > This adds two double precision divisions per frame, which seems acceptable.
>
> What is status of this patch?
While contemplating over it, I apparently got over it. V2 posted.
Retained the automatic sleep adjustment.
Thanks,
Moritz
_
On Wed, May 01, 2019 at 12:03:41 -0300, James Almer wrote:
> > +if (pkt->pts != AV_NOPTS_VALUE) {
> > +int64_t pts = av_rescale_q(pkt->pts, bsf->time_base_in,
> > AV_TIME_BASE_Q) / ctx->speed;
> > +int64_t now = av_gettime_relative();
> > +int64_t sleep = pts - now + ct
On Thu, May 02, 2019 at 10:33:41 +0530, shi...@iitk.ac.in wrote:
A minor nitpick (which the person pushing will/should notice):
> #define LIBAVFORMAT_VERSION_MAJOR 58
> -#define LIBAVFORMAT_VERSION_MINOR 27
> +#define LIBAVFORMAT_VERSION_MINOR 28
> #define LIBAVFORMAT_VERSION_MICRO 103
When
On Sat, May 04, 2019 at 15:10:03 +0100, John Warburton wrote:
> Is there a patch I can use to test scaletempo to compare it against atempo?
You can see the patch and follow the discussion here. The patch is at
the bottom (also available in raw form as download):
https://patchwork.ffmpeg.org/patch/
On Sat, May 04, 2019 at 16:19:13 +0200, Paul B Mahol wrote:
> > +{ "speed", "speed factor", OFFSET(speed), AV_OPT_TYPE_DOUBLE, { .dbl =
> > 1.0 }, DBL_MIN, DBL_MAX, FLAGS },
>
> Why is this allowed to be negative?
In my reading (and intent), it's forbidden to be negative. Both min and
max are
On Fri, May 03, 2019 at 23:47:47 -0300, James Almer wrote:
> The flush() callback exists to reset the bsf into its initial state
> without the need to destroy and recreate the context.
> For example, some decoders auto-insert certain bitstream filters that
[...]
> avcodec_flush_buffers(), which mus
On Mon, May 06, 2019 at 02:23:26 +0200, Lynne wrote:
> This allowed for the exptabs to be computed just once on startup and
> stored in a global array.
I have no real understanding of this, but:
Would there be a desire for a static implementation as well, for those
using "-enable-hardcoded-tables"
On Tue, May 07, 2019 at 01:33:08 +0200, Lynne wrote:
> May 6, 2019, 11:41 PM by barsn...@gmx.net:
> > Would there be a desire for a static implementation as well, for those
> > using "-enable-hardcoded-tables" (CONFIG_HARDCODED_TABLES)? Just
> > wondering whether that's esoteric, optional, or reall
On Mon, May 06, 2019 at 22:36:41 -0700, Jun Li wrote:
> +double av_display_rotation_hflip_get(const int32_t matrix[9], int *hflip)
> +{
> +int32_t m[9];
> +*hflip = 0;
> +memcpy(m, matrix, sizeof(int32_t) * 9);
You were asked to avoid this (at another code location though).
BTW, sizeof
On Tue, May 07, 2019 at 16:26:01 +0530, Gyan wrote:
> { "inputs", "set number of inputs", OFFSET(nb_inputs), AV_OPT_TYPE_INT,
> {.i64=2}, 2, INT_MAX, .flags = FLAGS },
> -{ "layout", "set custom layout", OFFSET(layout), AV_OPT_TYPE_STRING,
> {.str="0_0|w0_0"}, 0, 0, .flags = FLAGS },
> +
On Thu, May 09, 2019 at 07:28:20 +0530, Shivam Goyal wrote:
> >> +//Extra to find the http header
> >> +size = 2 * ARECONT_H264_MIME_SIZE + RAW_PACKET_SIZE;
> >> +data = av_malloc(size);
> >> +
> >> +if (av_new_packet(pkt, size) < 0)
> >> +return AVERROR(ENOMEM);
> >
> > mem
On Mon, May 13, 2019 at 12:54:58 +0530, Gyan wrote:
> >> Since 2.0.6 it works on Windows too.
> > Ping.
>
> Michael needs to confirm whether the build failure he had was due to his
> SDL version < 2.0.5
I can at least confirm that 2.0.4, which I have installed on one
machine, doesn't define this i
On Thu, May 16, 2019 at 12:51:46 +0200, Lynne wrote:
> > +#define STEPSIZE0.3010299957
>
> Just hardcode this in the powf call.
With an appended 'f'.
> > +const float scale = 1.0f;
> const float scale = 1.0 / 32768;
1.0f, but it doesn't matter here, as the preprocessor reduces it to
flo
On Wed, May 22, 2019 at 16:06:39 +0300, Boris wrote:
> Apologize me if this mailing list is not for such questions.
> I want help, then I think that here is the best place.
No, this is exactly the wrong place. ffmpeg-devel is for discussing the
development *of* the ffmpeg tools and libraries.
Fo
On Wed, May 22, 2019 at 12:03:55 +0200, Olivier Maignial wrote:
> In SDP provided by my RTSP server I had this fmtp line:
> a=fmtp:98 streamType=5; profile-level-id=40; mode=AAC-hbr; config=1188;
> sizeLength=13; indexLength=3; indexDeltaLength=3;
>
> In FFmpeg code, I found a check introduced
On Thu, May 23, 2019 at 16:51:16 +1200, Jonathan Viney wrote:
> > The NTP time from the first RTCP packet is currently extracted in
> > libavformat/rtsp.c and stored in AVFormatContext.start_time_realtime.
> > However, there is no way to access this value when using ffmpeg from the
> > commandline.
The string matching function's return value was evaluated incorrectly.
Fixes trac #7920.
Signed-off-by: Moritz Barsnick
---
libavformat/mpjpegdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mpjpegdec.c b/libavformat/mpjpegdec.c
index e653b5cc93..a2346
According to RFC1341, the multipart boundary indicated by the
Content-Type header must be prepended by CRLF + "--", and followed
by CRLF. In the case of strict MIME header boundary handling, the
"--" was forgotten to add.
Fixes trac #7921.
Signed-off-by: Moritz Barsni
The mpjpegdec option "-strict_mime_boundary 1" didn't actually work with
streams strictly adhering to RFC1341.
Moritz Barsnick (2):
avformat/mpjpegdec: fix finding multipart boundary parameter
avformat/mpjpegdec: fix strict boundary search string
libavformat/mpjpegdec.c | 6
On Fri, May 24, 2019 at 17:36:10 +0800, lance.lmw...@gmail.com wrote:
> Subject: [PATCH 1/7] libavfilter/vf_overlay.c: change the commands style for
> the macro defined function
^
It's not "commands", it's "comments", or "comment style".
On Fri, May 24, 2019 at 11:54:20 +0200, Michael Niedermayer wrote:
> LGTM
> a testcase in fate would be good
Thanks.
Indeed, I'll work on adding a fate testcase next week (have never done
so previously). There's valid input material in the as-yet unsolved
ticket #5023.
Moritz
___
On Fri, May 24, 2019 at 11:58:51 +0200, Michael Niedermayer wrote:
> > if (boundary != NULL) {
> > -mpjpeg->boundary = boundary;
> > -mpjpeg->searchstr = av_asprintf( "\r\n%s\r\n", boundary );
> > +mpjpeg->boundary = av_asprintf("--%s", boundary);
>
> me
According to RFC1341, the multipart boundary indicated by the
Content-Type header must be prepended by CRLF + "--", and followed
by CRLF. In the case of strict MIME header boundary handling, the
"--" was forgotten to add.
Fixes trac #7921.
Signed-off-by: Moritz Barsni
On Sun, May 26, 2019 at 22:44:00 +0200, Moritz Barsnick wrote:
> Subject: [FFmpeg-devel] [PATCH 2/2] avformat/mpjpegdec: fix strict boundary
> search string
D'uh, I told git send-email that the subject should contain "V2". I
wonder why that
On Mon, May 20, 2019 at 14:40:24 +0200, Romane Lafon wrote:
> +float tolerance = 1.0 - s->tolerance;
Strictly speaking 1.0f (or 1.f).
> +float angle = cos(s->angle/180.0*PI);
If you want a float as result, use cosf(s->angle / 180.f * M_PI). (I'm
aware PI and M_PI aren't explicitly marked
Hi,
> +during configuration. You need to explicitly configue the build with
^ configure
> +Sets the maximum qauntizer (floor) to use when using bitrate mode.
^ quantizer
Cheers,
Moritz
___
On Wed, May 29, 2019 at 19:28:24 +0100, Derek Buitenhuis wrote:
> +during configuration. You need to explicitly configue the build with
^ configure
> +Sets the maximum qauntizer (floor) to use when using bitrate mode.
^ quantizer
On Sun, Jun 02, 2019 at 18:46:17 +0100, Derek Buitenhuis wrote:
> take at least 1-2 months. The API itself won't change.
https://github.com/lu-zero/crav1e says:
Status
The API is far from stable
Just sayin',
Moritz
___
ffmpeg-devel mailing list
f
On Tue, Jun 04, 2019 at 00:19:05 +0100, Mark Thompson wrote:
> This can be used to add region of interest side data to video frames.
Very valuable addition for use of ROI the command line tool!
> +Mark regions of interest in a video frame.
Since you're using the plural, it's probably worth menti
On Sun, Jun 02, 2019 at 17:47:24 +0100, Mark Thompson wrote:
> >> Set the cropping fields in the AVFrame.
> > The patchset looks fine to me. But I am not quite sure if others are happy
> > with this crop patch.
> > If nobody against. I think you can go pushing the patchset when you make
> > sure
On Thu, Jun 06, 2019 at 22:31:45 +0200, Stephan Hilb wrote:
> If `AV_PKT_FLAG_KEY` stays unset on `pkt->flags`, the output stream
> stays empty with little information about what is going on.
> This change makes it easier to debug the situation for the user who
> could then choose to use the `-copy
On Fri, Jun 07, 2019 at 22:35:03 +0200, Stephan Hilb wrote:
> > Incorrect indentation.
>
> It's actually the same indentation as in other places in the same file,
> what would be the correct way then?
Sorry, my mind went flaky, you're corrent.
> > I suggest this message should be at INFO level, b
On Wed, Jun 12, 2019 at 08:23:29 +, Song, Ruiling wrote:
> > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> > Of Reimar D?ffinger
> > Where does this license come from?
> The license is from vf_gblur.c, because the code was copied from there.
> If I read correctly, thi
On Tue, Jun 11, 2019 at 13:38:43 +0800, lance.lmw...@gmail.com wrote:
> @@ -220,11 +248,6 @@ static av_cold int init(AVFilterContext *ctx)
> &cover->cover_frame->width,
> &cover->cover_frame->height,
> &cover->cover_frame->format,
On Tue, Jun 11, 2019 at 13:38:44 +0800, lance.lmw...@gmail.com wrote:
> doc/filters.texi | 2 +-
While you're at it, could you kindly add another patch to fix the
descriptions of the examples for find_rect and cover_rect? They are
copy pasted from pallettegen, and are totally misleading:
> Genera
On Wed, Jun 12, 2019 at 12:11:16 -0400, greg Luce wrote:
> Ooops apologies, .patch file attached and with hopefully better line breaks
Yes, but something went wrong with its contents:
> Subject: [PATCH] Signed-off-by: greg Luce
This doesn't look correct. It's supposed to contain
Subject: vf_dra
On Thu, Jun 13, 2019 at 01:20:20 +0200, Michael Niedermayer wrote:
> +if (header->data_min == header->data_max) {
Just a note:
Equality comparison of floats/doubles may trigger a warning. (Possibly
needs to be explicitly enabled though, like with "-Wfloat-equal" on
gcc.) Might be okay thou
On Thu, Jun 13, 2019 at 15:41:55 +, Eoff, Ullysses A wrote:
> According to comments in the gcc request, it looks like we
> could use " -fsanitize=address". Anyone care to test it
> out to see if it will work?
The AddressSanatizer does not make this a warning at compile time (or
perhaps it may
On Thu, Jun 13, 2019 at 08:52:22 -0700, Amir Pauker wrote:
> doc/APIchanges | 3 +++
> libavcodec/h264dec.c | 5 +
> libavutil/frame.h| 1 +
> libavutil/version.h | 2 +-
You should split the introduction of the API (libavutil and doc) and
the use of the API (libavcodec) into two se
On Thu, Jun 13, 2019 at 20:32:35 +0200, Michael Niedermayer wrote:
> avcodec/fitsdec: Fix division be 0 in size check
Nit:^ by
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/f
On Mon, Jun 24, 2019 at 01:01:02 +0200, Michael Niedermayer wrote:
> +if (sb + (j + k) / 64 > 29) {
[...]
> if (coding_method[ch][sb + (j + k) / 64][(j + k) % 64] >
> coding_method[ch][sb][j]) {
You could do the "sb + (j + k) / 64]" calculation only once a
On Wed, Jun 26, 2019 at 01:06:56 +0530, Gyan wrote:
> Wouldn't this be better if extended to be a BSF version of setpts? In
> addition to delays, rescaling as well as other ops could be carried out
> on TS.
I second that notion, or at least the suggestion of a setpts bsf.
IMO, there is probably s
On Tue, Jun 25, 2019 at 23:13:51 +0200, Ulf Zibis wrote:
> is there a functionality in the ffmpeg library to print AVFrame pts
> values in respect to AVRational time_base in human readable form?
This list is for the development *of* ffmpeg and its libraries. For the
use of the libraries and the de
On Thu, Jun 27, 2019 at 10:12:35 +0800, lance.lmw...@gmail.com wrote:
> +This filter takes in two video input, the first input is considered
^ inputs
> +the "main" source and is passed unchanged to the output. The "second"
> +input is used as a rectangular object f
On Thu, Jun 27, 2019 at 09:40:22 +0200, Moritz Barsnick wrote:
> I can't just on most of the rest of your changes.
Whot?
Meant to say: I can't judge most of the rest of your changes.
M.
___
ffmpeg-devel mailing list
On Sun, Jun 30, 2019 at 14:14:13 +0200, Thilo Borgmann wrote:
> -{ "capture_cursor", "capture the screen cursor", offsetof(AVFContext,
> capture_cursor), AV_OPT_TYPE_INT, {.i64=0}, 0, 1, AV_OPT_FLAG_DECODING_PARAM
> },
> -{ "capture_mouse_clicks", "capture the screen mouse clicks",
> off
On Mon, Jul 01, 2019 at 17:43:59 +0800, Steven Liu wrote:
> -av_log(h, AV_LOG_ERROR, "URL read error: %d\n", read_ret);
> +av_log(h, AV_LOG_ERROR, "URL read error: %s\n",
> av_err2str(read_ret));
^^
You c
On Sun, Jun 30, 2019 at 18:05:36 +0200, Paul B Mahol wrote:
> +DeesserChannel *chan = &s->chan[i];;
Duplicate semicolon.
> +av_frame_copy_props(out, in);
This can also return AVERROR(ENOMEM)?
Everything else looks fine, with my little knowledge, incl. docs.
Untested.
Cheers,
Mo
On Mon, Jul 08, 2019 at 18:48:46 +0800, lance.lmw...@gmail.com wrote:
> +@item keep_dar
> +stack with 1/nb_inputs of each inputs screen to keep the same DAR, Default
> is 0.
^
Probably "input's". Is screen the correct term here at all? (In three
places in the patc
Hi,
On Tue, Jul 09, 2019 at 19:34:33 +0100, Derek Buitenhuis wrote:
> Port to the new send/receive API by: James Almer .
Two nits:
> +Sets the minimum quantizer (ceiling) to use when in bitrate mdoe.
Typo -> "mode"
> +av_log(avctx, AV_LOG_ERROR, "Unknown return code from
> rav1e_send_
On Sat, Jul 13, 2019 at 00:24:29 +0200, mikroh...@gmail.com wrote:
> From: Jernej
I think you had your full name in here originally. Note that whatever
you provide here will be in the repo forever.
>
> Patch with requested changes.
Your original commit text should be in here, not your message t
On Mon, Jul 15, 2019 at 18:39:14 +0800, Linjie Fu wrote:
Nit:
> +@item -noautoscale
> +Disable automatically scale video based on first frame resolution.
^ scaling
Cheers,
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpe
On Wed, Jul 17, 2019 at 16:18:11 -0700, Juan De León wrote:
> ---
> libavfilter/vf_extractqp.c | 116
> libavutil/Makefile | 2 +
> libavutil/quantization_params.c | 28
> libavutil/quantization_params.h | 98 +
On Fri, Jul 19, 2019 at 11:08:00 +0800, leozhang wrote:
> change history:
> 1. Use normal descriptor string instead of base64 encoded
> 2. Add example to muxers.texi
> 3. Change descriptor char * and allocate it dynamically
>
> Please review, thanks
Please take care, the above text has become part
On Fri, Jul 19, 2019 at 10:00:52 +0200, Nicolas George wrote:
> I do not judge whether this filter would be useful and should be
> included, but if so, then I would appreciate that the output be done
> using AVIO, so that it can go to any supported protocol.
The metadata filter has a nice example
On Mon, Jul 22, 2019 at 02:03:33 +, Guo, Yejun wrote:
> I do not mean the official repository https://git.ffmpeg.org/ffmpeg.git, I
> mean another
> new repo and ffmpeg community has the right to assign/remove someone to have
> the write access.
[...]
> thanks, I think we can create a git repo
Even though you requested not to review:
On Tue, Jul 23, 2019 at 14:51:12 +0300, velocit...@gmail.com wrote:
> +#include "mjpegdec.h"
Subtle hint: Try configuring and compiling ffmpeg without support for
mjpeg, but with support for tiff.
I think you need to add a dependency in libavcodec/Makefi
On Tue, Jul 23, 2019 at 13:49:30 +, Guo, Yejun wrote:
> > Actually, http://git.videolan.org/?p=ffmpeg.git;a=summary is the
> > official repo (or rather its visualization). Github is the secondary
> > repo, a mirror.
>
> thanks Moritz, do you mean that the official repo is not
> https://git.ffm
On Tue, Jul 23, 2019 at 19:23:12 +, aran.clau...@wwu.edu wrote:
Some style nits for a first time contributer:
> +if(c->shmid != -1) {
^ Please stick to the style "if (" (whitespace).
> -id = shmget(IPC_PRIVATE, size, IPC_CREAT | 0777);
> +
> +id = shmget(IPC_PRIVATE, size,
On Thu, Jul 25, 2019 at 15:12:53 +0300, velocit...@gmail.com wrote:
Nit:
> tiff_decoder_suggest="zlib lzma"
> tiff_encoder_suggest="zlib"
> +tiff_decoder_select="mjpeg_decoder"
> truehd_decoder_select="mlp_parser"
You should pair the new decoder line with the other decoder line, not
place it
On Thu, Jul 25, 2019 at 15:12:52 +0300, velocit...@gmail.com wrote:
> From: Nick Renieris
Nit:
> -if (s->nb_components != 3 && s->nb_components != 4)
> +if (s->nb_components <= 0 || s->nb_components > 4)
> return AVERROR_INVALIDDATA;
> +
> if (s->v_max != 1 || s->h_max != 1
On Thu, Jul 25, 2019 at 16:19:19 +0200, Paul B Mahol wrote:
> patches attached.
> if (block_predictor > 6) {
> -av_log(avctx, AV_LOG_ERROR, "ERROR: block_predictor[1] =
> %d\n",
> +av_log(avctx, AV_LOG_ERROR, "ERROR: block_predictor[0] =
> %d\n",
>
> > This is not a reindent. ;-)
> It is. Look more carefully.
> You need brain to look too.
Sorry, I see it now. The indent, I mean, not the brain, which is not there.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailm
> +// read headers if not already loaded (this is needed to check if
> connection is closing)
> +if (!s->end_header) {
> + int new_location;
> + http_read_header(h, &new_location);
> +
> + if (s->willclose) {
> +ret = ffurl_closep(&s->hd);
> +
> +if (ret < 0)
Hi,
On Thu, Aug 01, 2019 at 07:42:28 -0400, ckerchne wrote:
Just a small hint: You patch was corrupted by newlines inserted by your
email client.
Try attaching the patch file, or using git send-email.
> > --- a/libswscale/ppc/yuv2rgb_altivec.c
> > +++ b/libswscale/ppc/yuv2rgb_altivec.c
> > @@ -
Hi Andreas,
On Fri, Aug 02, 2019 at 13:03:03 +, Andreas Håkon wrote:
While trying to figure out how to add features I'd like to see into
this ;-), some remarks:
> +Apply an offset to the PTS/DTS timestamps.
> +
> +@table @option
> +@item offset
> +The offset value to apply to the PTS/DTS tim
On Wed, Aug 07, 2019 at 00:14:06 +0200, Alexander Strasser wrote:
> Nicolas, changes to the coding style should be discussed and not
> be tunneled through documentation patches. Though I don't think
> the latter was the intention of the OP.
It was probably caused by different reviews:
- "Please re
On Tue, Aug 06, 2019 at 17:55:35 +0200, Daniel Kolesa wrote:
> The first of these patches fixes the original report as described in
> https://trac.ffmpeg.org/ticket/7861. The second of the patches fixes
> the second report in the same ticket (by leigh123linux).
If so, each of the commit messages s
On Thu, Aug 08, 2019 at 22:09:04 +0100, Cameron Cawley wrote:
> Signed-off-by: Cameron Cawley
> ---
> doc/general.texi| 1 +
> libavcodec/Makefile | 1 +
> libavcodec/adpcm.c | 14 ++
> libavcodec/allcodecs.c | 1 +
> libavcodec/avcodec.h| 1 +
> libavcodec/c
incorrect anyway. The third one adds the actual functionality,
the fourth one reindents.
Probably okay to squash, whatever the maintainers feel most appropriate.
Moritz Barsnick (4):
avformat/hashenc: use an array of hashes
avformat/hashenc: rearrange options definition
avformat/hashenc
Only the frame* muxers support the format_version option.
Signed-off-by: Moritz Barsnick
---
libavformat/hashenc.c | 35 +++
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c
index 7f83df5cca..96e00f580c
Only the first one used currently.
Signed-off-by: Moritz Barsnick
---
libavformat/hashenc.c | 58 +++
1 file changed, 36 insertions(+), 22 deletions(-)
diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c
index 06fc085d18..7f83df5cca 100644
--- a
Non-frame based muxers only, the frame based ones are already per
stream.
Signed-off-by: Moritz Barsnick
---
doc/muxers.texi | 5 +
libavformat/hashenc.c | 41 +
2 files changed, 34 insertions(+), 12 deletions(-)
diff --git a/doc/muxers.texi b
Signed-off-by: Moritz Barsnick
---
libavformat/hashenc.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c
index 394b8a0fce..070d4001b1 100644
--- a/libavformat/hashenc.c
+++ b/libavformat/hashenc.c
On Sun, Aug 11, 2019 at 14:47:52 +0200, Moritz Barsnick wrote:
> This patchset adds an option to the non-frame based hash muxers to create a
> hash per stream. (The frame based muxers already do that.)
I forgot to bump micro in the patch which adds the functionality.
Please do when pushing
On Sun, Aug 11, 2019 at 15:57:46 +0200, Nicolas George wrote:
> > +c->hashes = av_malloc_array(1, sizeof(c->hashes));
> > +if (!c->hashes)
> > +return AVERROR(ENOMEM);
> > +res = av_hash_alloc(&c->hashes[0], c->hash_name);
> > +if (res < 0) {
> > +av_freep(&c->hashes
On Mon, Aug 12, 2019 at 19:21:45 +0800, lance.lmw...@gmail.com wrote:
> +Set the max number frames generated for each tests:
Grammar nit:
Set the maximum number of frames generated for each test
(Note:
- use the complete word maximum
- "test", "not tests", when using "for each" singular
- *o
On Tue, Aug 13, 2019 at 21:38:41 +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
> fftoos/ffmpeg_opt: avoid to display the hwaccels name twice
^
Nit: fftools/ffmpeg_opt
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpe
On Tue, Aug 13, 2019 at 18:01:29 +0200, Romane Lafon wrote:
> +{ "duration", "set minimum mono or out-of-phase duration in seconds",
> OFFSET(duration), AV_OPT_TYPE_DOUBLE, {.dbl=2.}, 0, 24*60*60, FLAGS },
ffmpeg also provides a AV_OPT_TYPE_DURATION. (This may have been
discussed before - so
On Wed, Aug 14, 2019 at 11:23:09 +0200, Daniel Kučera wrote:
> I'm trying to lower the latency when playing mjpeg multipart http
> stream and I came to this line:
> https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/mpjpegdec.c#L157
>
> Does it mean each mjpeg stream is decoded as 25FPS?
Yes
On Mon, Aug 05, 2019 at 08:18:32 +0100, Ross Nicholson wrote:
> Example stream that does not work:
> rtsp://184.72.239.149/vod/mp4:BigBuckBunny_115k.mov
>
> Extending the condition allows the stream to be processed correctly.
Can you give a bit more detail? Decoding this stream works for me (at
l
1 - 100 of 1029 matches
Mail list logo
