On Tue, Jul 23, 2019 at 19:23:12 +0000, aran.clau...@wwu.edu wrote:
Some style nits for a first time contributer:
> + if(c->shmid != -1) {
^ Please stick to the style "if (" (whitespace).
> - id = shmget(IPC_PRIVATE, size, IPC_CREAT | 0777);
> +
> + id = shmget(IPC_PRIVATE, size, IPC_CREAT | 0666);
Is this change required for your fix?
And please don't introduce arbitrary new empty lines and such.
> }
> +
> xcb_shm_attach(c->conn, c->segment, id, 0);
Needless change, please remove.
> }
>
> +
> static int xcbgrab_frame_shm(AVFormatContext *s, AVPacket *pkt)
Needless change, please remove.
Cheers,
Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
