On Thu, Jul 25, 2019 at 15:12:52 +0300, [email protected] wrote:
> From: Nick Renieris <[email protected]>
Nit:
> - if (s->nb_components != 3 && s->nb_components != 4)
> + if (s->nb_components <= 0 || s->nb_components > 4)
> return AVERROR_INVALIDDATA;
> +
> if (s->v_max != 1 || s->h_max != 1 || !s->lossless)
> return AVERROR_INVALIDDATA;
>
> -
> s->restart_count = s->restart_interval;
Arbitrary addition and removal of newlines.
> + if (mb_y * s->width % s->restart_interval == 0) {
I personally would prefer an extra set of brackets to at least make it
more obvious which operation takes precedence.
Cheers,
Moritz
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".