[FFmpeg-devel] [PATCH] avcodec/aacdec_lpd: remove unused local variables

2024-06-08 Thread Leo Izen
int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. Signed-off-by: Leo Izen --- libavcodec/aac/aacdec_lpd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac

[FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables

2024-06-21 Thread Leo Izen
int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. --- libavcodec/aac/aacdec_lpd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c index 796edd2ab5..91

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpegxl_parser: ensure input padding is zeroed

2024-06-27 Thread Leo Izen
that one is unnecessary, but this one is fine. I have no comment on the generic patches. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables

2024-06-27 Thread Leo Izen
On 6/21/24 5:20 PM, Leo Izen wrote: int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. --- libavcodec/aac/aacdec_lpd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b

Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables

2024-06-27 Thread Leo Izen
On 6/27/24 1:27 PM, Lynne via ffmpeg-devel wrote: On 21/06/2024 23:20, Leo Izen wrote: int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. Sorry, missed this patch, LGTM. Applied as 539d2e989d7ce3556a549d59ee9c5125ae7d7b6b - Leo

[FFmpeg-devel] [PATCH] avcodec/libjxl: add JPEG XL decoding via libjxl

2021-10-20 Thread Leo Izen
libdavs2.cHuiwen Ren + libjxl*.c, libjxl.h Leo Izen libgsm.c Michel Bardiaux libkvazaar.c Arttu Ylä-Outinen libopenh264enc.c Martin Storsjo, Linjie Fu @@ -614,6 +615,7

[FFmpeg-devel] [PATCH v2] avcodec/libjxl: add JPEG XL decoding via libjxl

2021-10-20 Thread Leo Izen
libdavs2.cHuiwen Ren + libjxl*.c, libjxl.h Leo Izen libgsm.c Michel Bardiaux libkvazaar.c Arttu Ylä-Outinen libopenh264enc.c Martin Storsjo, Linjie Fu @@ -614,6 +615,7

[FFmpeg-devel] [PATCH v3] avcodec/libjxl: add JPEG XL decoding via libjxl

2021-10-21 Thread Leo Izen
Conrad libdavs2.cHuiwen Ren + libjxl*.c, libjxl.h Leo Izen libgsm.c Michel Bardiaux libkvazaar.c Arttu Ylä-Outinen libopenh264enc.c Martin Storsjo, Linjie Fu

Re: [FFmpeg-devel] [PATCH v3] avcodec/libjxl: add JPEG XL decoding via libjxl

2021-10-22 Thread Leo Izen
On Fri, Oct 22, 2021 at 4:31 PM Michael Niedermayer wrote: > > This should be split between libavcodec and libavformat How so? the avformat patch won't work without the avcodec codec ID addition anyway, so the avformat patch still requires changing avcodec. > also probe still fails > Failure of j

Re: [FFmpeg-devel] [PATCH v3] avcodec/libjxl: add JPEG XL decoding via libjxl

2021-10-23 Thread Leo Izen
rmissive JXL codestreams are. I'm thinking that it might make sense to write a parser for Jpeg XL in libavcodec, and then have libavformat's jpegxl prober just call some of that same code. Thoughts? -Leo Izen ___ ffmpeg-devel mailing list ffmpeg-

[FFmpeg-devel] [PATCH v4 1/2] avcodec/libjxc: add JPEG XL decoding via libjxl

2021-11-02 Thread Leo Izen
libdirac* David Conrad libdavs2.cHuiwen Ren + libjxl*.c, libjxl.h Leo Izen libgsm.c Michel Bardiaux libkvazaar.c Arttu Ylä-Outinen libopenh264enc.c

[FFmpeg-devel] [PATCH v4 2/2] avformat/image2: add JPEG XL image2 demuxer and muxer

2021-11-02 Thread Leo Izen
Add JPEG XL image demuxer and muxer to image2 to allow JPEG XL files to be read/written by libavformat. --- libavformat/allformats.c | 1 + libavformat/img2.c | 1 + libavformat/img2dec.c| 336 +++ libavformat/img2enc.c| 6 +- libavformat/mov

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libjxc: add JPEG XL decoding via libjxl

2021-11-02 Thread Leo Izen
On Tue, Nov 2, 2021 at 8:14 AM James Almer wrote: > New entries must not change the value of other entries. You need to add > it at the end of the list, or in this specific enum case, at the end of > the section before the big offset jump, so immediately after > AV_CODEC_ID_GEM. Thanks, will chan

[FFmpeg-devel] [PATCH v5 1/2] avcodec/libjxc: add JPEG XL decoding via libjxl

2021-11-02 Thread Leo Izen
libdirac* David Conrad libdavs2.cHuiwen Ren + libjxl*.c, libjxl.h Leo Izen libgsm.c Michel Bardiaux libkvazaar.c Arttu Ylä-Outinen libopenh264enc.c

[FFmpeg-devel] [PATCH v5 2/2] avformat/image2: add JPEG XL image2 demuxer and muxer

2021-11-02 Thread Leo Izen
Add JPEG XL image demuxer and muxer to image2 to allow JPEG XL files to be read/written by libavformat. --- libavformat/allformats.c | 1 + libavformat/img2.c | 1 + libavformat/img2dec.c| 336 +++ libavformat/img2enc.c| 6 +- libavformat/mov

[FFmpeg-devel] [PATCH v5 1/2] avcodec/libjxc: add JPEG XL decoding via libjxl

2021-11-02 Thread Leo Izen
libdirac* David Conrad libdavs2.cHuiwen Ren + libjxl*.c, libjxl.h Leo Izen libgsm.c Michel Bardiaux libkvazaar.c Arttu Ylä-Outinen libopenh264enc.c

[FFmpeg-devel] [PATCH] avcodec/librsvgdec: fix memory leaks and deprecated functions

2023-10-07 Thread Leo Izen
, guarded by #ifdefs while the newer replacements are used if librsvg >= 2.52.0. One of the deprecated functions is used as a check for the configure shell script, so it was replaced with a different function. Signed-off-by: Leo Izen --- configure | 2 +- libavcodec/librsvgdec.c |

Re: [FFmpeg-devel] [PATCH] configure: improve libmfx deprecation warning

2023-10-11 Thread Leo Izen
On 10/6/23 08:59, Leo Izen wrote: The libmfx deprecation warning tells you to build against libmfx 1.x, but the actual solution is to use --enable-libvpl instead of using --enable-libmfx. Update the warning message to reflect this. Will apply soon if there are no objections. - Leo Izen

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix OOB read regression

2023-10-12 Thread Leo Izen
In f7ac3512f5b5cb8eb149f37300b43461d8e93af3 the size of the dynamically allocated buffer was shrunk, but it was made too small for very small alphabet sizes. This patch sets a minimum size to prevent an OOB read. Reported-by: Cole Dilorenzo Signed-off-by: Leo Izen --- libavcodec

[FFmpeg-devel] [PATCH v2] avcodec/jpegxl_parser: fix OOB read regression

2023-10-14 Thread Leo Izen
In f7ac3512f5b5cb8eb149f37300b43461d8e93af3 the size of the dynamically allocated buffer was shrunk, but it was made too small for very small alphabet sizes. This patch restores the size to prevent an OOB read. Reported-by: Cole Dilorenzo Signed-off-by: Leo Izen --- libavcodec/jpegxl_parser.c

Re: [FFmpeg-devel] [PATCH] avcodec/librsvgdec: fix memory leaks and deprecated functions

2023-10-15 Thread Leo Izen
On 10/7/23 21:36, Leo Izen wrote: At various points through the function librsvg_decode_frame, errors are returned from immediately without deallocating any allocated structs. This patch both fixes those leaks, and also fixes the use of functions that are deprecated since librsvg version 2.52.0

[FFmpeg-devel] [PATCH] MAINTAINERS: add entry for jpegxl*

2023-10-15 Thread Leo Izen
Adding myself for jpegxl* in avcodec as I'm the maintainer of this parser. Signed-off-by: Leo Izen --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b5c116c3d4..b66c3d09a6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add entry for jpegxl*

2023-10-15 Thread Leo Izen
On 10/15/23 09:11, Lynne wrote: Oct 15, 2023, 14:14 by leo.i...@gmail.com: Adding myself for jpegxl* in avcodec as I'm the maintainer of this parser. Signed-off-by: Leo Izen --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTA

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpegxl_parser: fix OOB read regression

2023-10-16 Thread Leo Izen
On 10/14/23 20:49, Leo Izen wrote: In f7ac3512f5b5cb8eb149f37300b43461d8e93af3 the size of the dynamically allocated buffer was shrunk, but it was made too small for very small alphabet sizes. This patch restores the size to prevent an OOB read. Reported-by: Cole Dilorenzo Signed-off-by: Leo

Re: [FFmpeg-devel] [PATCH] avcodec/librsvgdec: fix memory leaks and deprecated functions

2023-10-22 Thread Leo Izen
On 10/15/23 08:06, Leo Izen wrote: On 10/7/23 21:36, Leo Izen wrote: At various points through the function librsvg_decode_frame, errors are returned from immediately without deallocating any allocated structs. This patch both fixes those leaks, and also fixes the use of functions that are

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/vlc: Pass VLC_MULTI_ELEM directly not by pointer

2023-10-22 Thread Leo Izen
, 0, sizeof(*info))? - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/vlc: Pass VLC_MULTI_ELEM directly not by pointer

2023-10-24 Thread Leo Izen
On 10/23/23 12:04, Michael Niedermayer wrote: On Mon, Oct 23, 2023 at 02:10:35AM -0400, Leo Izen wrote: On 10/22/23 17:51, Michael Niedermayer wrote: This makes the code more testable as uninitialized fields are 0 and not random values from the last call Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH] avcodec/pngdec: various stylistic changes

2023-10-24 Thread Leo Izen
Various parts of this file are restructured slightly for readability, such as spacing in arithmetic operations, and putting `if (ret < 0)` clauses on separate lines. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 241 +++- 1 file changed,

[FFmpeg-devel] [PATCH] avformat/hls: use av_strlcopy instead of strncpy

2023-10-25 Thread Leo Izen
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of strncpy. Signed-off-by: Leo Izen --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index f5f549b24d..076f92ecfb 100644 --- a/libavformat/hls.c

Re: [FFmpeg-devel] [PATCH] avformat/hls: use av_strlcopy instead of strncpy

2023-10-26 Thread Leo Izen
On 10/26/23 06:54, Andreas Rheinhardt wrote: Leo Izen: Avoids a -Wstringop-truncation warning by using av_strlcopy instead of strncpy. Signed-off-by: Leo Izen --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c

Re: [FFmpeg-devel] [PATCH] avformat/hls: use av_strlcopy instead of strncpy

2023-10-26 Thread Leo Izen
so it produces a warning. It seems the appropriate fix here is to change strncpy to av_strlcpy but also change the -2 to a -1. This will produce identical behavior to before, but it won't cause the compiler to produce a warning that the string might not be nul-terminated (cause it

[FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

2023-10-29 Thread Leo Izen
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of strncpy. Signed-off-by: Leo Izen --- libavformat/hls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index f5f549b24d..39440176c9 100644 --- a/libavformat/hls.c

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

2023-10-29 Thread Leo Izen
On 10/29/23 08:47, Leo Izen wrote: Avoids a -Wstringop-truncation warning by using av_strlcopy instead of strncpy. Changes from v1: - changed the length attribute, so now it has similar semantics to earlier. This patch has the same semantics with regard to the null-termination and the

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12: Remove "fast" mode

2023-10-29 Thread Leo Izen
understand what you mean - JPEG XL is fully specified. Are you thinking of mjpeg? - Leo Izen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

2023-10-29 Thread Leo Izen
On 10/29/23 20:23, Andreas Rheinhardt wrote: Leo Izen: Avoids a -Wstringop-truncation warning by using av_strlcopy instead of strncpy. Signed-off-by: Leo Izen --- libavformat/hls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12: Remove "fast" mode

2023-10-29 Thread Leo Izen
On 10/29/23 21:22, Lynne wrote: it can be argued that the error margins are small enough to permit bitexactness For what it's worth, the error margins for compliance are specified in 18181-3 and they're definitely within one pixel value for the various bit depths supported by the codestream f

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

2023-10-30 Thread Leo Izen
On 10/30/23 03:51, Nicolas George wrote: Leo Izen (12023-10-29): But it will be nul-terminated in either case, so there's no real difference between the old and new code, other than the warning. No real difference = you are not fixing the bug. There should

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: use av_strlcopy instead of strncpy

2023-10-30 Thread Leo Izen
On 10/30/23 09:55, Nicolas George wrote: Leo Izen (12023-10-30): difference: user data should not be silently truncated. There isn't really a bug here, just an extraneous compiler warning. Truncating user data silently is a bug. The warning is right and needs proper fix. Regards,

Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable

2023-11-12 Thread Leo Izen
have no issues with the commit itself.) - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

[FFmpeg-devel] [PATCH] fftools/ffplay_renderer: declare function argument as const

2023-11-23 Thread Leo Izen
Declaring the function argument as const fixes a warning down the line that the const parameter is stripped. We don't modify this argument. Signed-off-by: Leo Izen --- fftools/ffplay_renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay_rendere

[FFmpeg-devel] [PATCH v3] avformat/hls: use av_strlcopy instead of strncpy

2023-11-23 Thread Leo Izen
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of strncpy. Additionally, prints a warning to the log context if this truncation occurred. Signed-off-by: Leo Izen --- libavformat/hls.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 1/2] avcodec/jpegxl_parse{, r}: use correct ISOBMFF extended size location

2023-11-23 Thread Leo Izen
According to ISO/IEC 14996-12, size == 1 means a 64-bit extended-size field occurs *after* the 32-bit box type, not before. This fix should allow correct parsing of JXL files with extended-size boxes. Signed-off-by: Leo Izen --- libavcodec/jpegxl_parse.c | 6 +++--- libavcodec/jpegxl_parser.c

[FFmpeg-devel] [PATCH 0/2] JPEG XL parser bug fixes

2023-11-23 Thread Leo Izen
Two bug fixes related to the JPEG XL parser. They're not exactly related and don't need to be applied in sequence. Leo Izen (2): avcodec/jpegxl_parse{,r}: use correct ISOBMFF extended size location avcodec/jpegxl_parser: fix parsing sequences of extremely small files

[FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-23 Thread Leo Izen
This patch allows the JXL parser to parse sequences of extremely small files concatenated together. (e.g. smaller than the parser buffer) Signed-off-by: Leo Izen --- libavcodec/jpegxl_parser.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 2/9] avcodec/get_bits: add get_leb()

2023-11-26 Thread Leo Izen
, why do this (and the avio version) have to be global? What are they used for other than the iamf demuxer? Would it make sense to have a static inline read_leb function defined in iamf.c? - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-26 Thread Leo Izen
On 11/26/23 05:56, Anton Khirnov wrote: Would be nice to have tests for these. I have a sample at: https://buzo.us/l.jxl It would test both of these patches. I can send a fate test for these to the ML if the sample gets uploaded. I CC'd samples-requ...@ffmpeg.org as well. - Leo

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-26 Thread Leo Izen
On 11/26/23 13:07, Thilo Borgmann wrote: Am 26.11.2023 um 14:47 schrieb Leo Izen : On 11/26/23 05:56, Anton Khirnov wrote: Would be nice to have tests for these. I have a sample at: https://buzo.us/l.jxl It would test both of these patches. I can send a fate test for these to the ML if

[FFmpeg-devel] [PATCH v2 0/3] JPEG XL parser bug fixes

2023-11-27 Thread Leo Izen
Two bug fixes related to the JPEG XL parser. They're not exactly related and don't need to be applied in sequence. v2 change: patches themselves are identical, but now there's a FATE test. Leo Izen (3): avcodec/jpegxl_parse{,r}: use correct ISOBMFF extended size loc

[FFmpeg-devel] [PATCH v2 1/3] avcodec/jpegxl_parse{, r}: use correct ISOBMFF extended size location

2023-11-27 Thread Leo Izen
According to ISO/IEC 14996-12, size == 1 means a 64-bit extended-size field occurs *after* the 32-bit box type, not before. This fix should allow correct parsing of JXL files with extended-size boxes. Signed-off-by: Leo Izen --- libavcodec/jpegxl_parse.c | 6 +++--- libavcodec/jpegxl_parser.c

[FFmpeg-devel] [PATCH v2 2/3] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-27 Thread Leo Izen
This patch allows the JXL parser to parse sequences of extremely small files concatenated together. (e.g. smaller than the parser buffer) Signed-off-by: Leo Izen --- libavcodec/jpegxl_parser.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec

[FFmpeg-devel] [PATCH v2 3/3] fate/jpegxl: add parser test for extboxes and small files

2023-11-27 Thread Leo Izen
Add a fate test for the above commits fixing extremely small files or files with extended box sizes. Signed-off-by: Leo Izen --- tests/fate/jxl.mak | 8 tests/ref/fate/jxl-small-ext-box | 9 + 2 files changed, 17 insertions(+) create mode 100644 tests/ref/fate

Re: [FFmpeg-devel] [PATCH v2 0/3] JPEG XL parser bug fixes

2023-12-03 Thread Leo Izen
On 11/27/23 09:10, Leo Izen wrote: Two bug fixes related to the JPEG XL parser. They're not exactly related and don't need to be applied in sequence. v2 change: patches themselves are identical, but now there's a FATE test. Leo Izen (3): avcodec/jpegxl_parse{,r}: use

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: remove myself from FFmpeg

2023-12-07 Thread Leo Izen
answered yet (as of writing this). - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: remove myself from FFmpeg

2023-12-07 Thread Leo Izen
On 12/7/23 11:32, Nicolas George wrote: Leo Izen (12023-12-07): I believe the question was directed at Paul That does not make my answer any less relevant. I'm not going to have an argument with you about why a question to Paul about a decision Paul made should be answered by

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: use av_strlcopy instead of strncpy

2023-12-07 Thread Leo Izen
On 11/23/23 10:31, Leo Izen wrote: Avoids a -Wstringop-truncation warning by using av_strlcopy instead of strncpy. Additionally, prints a warning to the log context if this truncation occurred. Signed-off-by: Leo Izen --- Bump, thanks. - Leo Izen (Traneptora

[FFmpeg-devel] [PATCH] avcodec/libjxldec: emit proper PTS to decoded AVFrame

2023-12-08 Thread Leo Izen
the PTS information those containers provide to work as expected. Signed-off-by: Leo Izen --- libavcodec/libjxldec.c | 77 +++--- 1 file changed, 57 insertions(+), 20 deletions(-) diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c index 002740d9c1

[FFmpeg-devel] [PATCH 0/1] fate/jpegxl: add multiframe permuted TOC image parser

2023-12-09 Thread Leo Izen
sha256sum: 9288337dc0d37effd1f539d4e20083a8ffed757e486f4098121520c74e8de6f6 sample signature: https://buzo.us/A.asc Leo Izen (1): fate/jpegxl: add multiframe permuted TOC image parser test tests/fate/jxl.mak | 3 +++ tests/ref/fate/jxl-multiframe-permuted-toc | 11 ++

[FFmpeg-devel] [PATCH 1/1] fate/jpegxl: add multiframe permuted TOC image parser test

2023-12-09 Thread Leo Izen
This test verifies the parser's handling of multiframe JXL files that have an entropy-encoded permuted table of contents for each frame. The testcase is actually six JXL codestreams concatenated together, and the parser needs to be able to find the boundaries. Signed-off-by: Leo Izen ---

Re: [FFmpeg-devel] [PATCH] [WIP] [RFC] dvdvideo: initial contribution (DVD demuxer)

2023-12-09 Thread Leo Izen
On 12/9/23 05:06, Marth64 wrote: Hello, I am happy to share a DVD demuxer for ffmpeg powered by libdvdread and libdvdnav. I have been working on this on/off throughout the year and think it is in a good spot to share at the ML now. This was a major learning experience for me in many ways and a

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Leo Izen
it can get a little bit difficult for reviewers to track the versions. I have no comments on the patch itself, in either direction. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 0/1] fate/jpegxl: add multiframe permuted TOC image parser

2023-12-10 Thread Leo Izen
On 12/10/23 09:07, Andreas Rheinhardt wrote: Leo Izen: This patch requires a sample that hasn't been uploaded yet. It can be found at [1] and it should be placed at jxl/orange.jxl once uploaded. It's 262k, which is not very large, but large enough that I did not want to attach it to

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-12-11 Thread Leo Izen
On 12/10/23 23:20, Kacper Michajlow wrote: On Tue, 28 Feb 2023 at 20:46, Leo Izen wrote: On 2/27/23 11:34, Leo Izen wrote: On 2/21/23 17:35, Leo Izen wrote: These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. --- libav

[FFmpeg-devel] [PATCH 1/2] avcodec/libjxldec: produce rgbf32 and rgbaf32 frames

2023-12-11 Thread Leo Izen
These pixel formats have always been supported by libjxl, but at the time this plugin was written, they were not in FFmpeg yet. Now that they are in FFmpeg, we should support them. Signed-off-by: Leo Izen --- libavcodec/libjxldec.c | 17 + 1 file changed, 9 insertions(+), 8

[FFmpeg-devel] [PATCH 2/2] avcodec/libjxlenc: accept rgbf32 and rgbaf32 frames

2023-12-11 Thread Leo Izen
These pixel formats have always been supported by libjxl, but at the time this plugin was written, they were not in FFmpeg yet. Now that they are in FFmpeg, we should support them. Signed-off-by: Leo Izen --- libavcodec/libjxlenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec

[FFmpeg-devel] [PATCH] avcodec/pngdec: improve handling of bad cICP range tags

2023-12-12 Thread Leo Izen
as it should. Also, PNG doesn't support nonzero matrices but we only warn and ignore in that case, so we have no reason to error out for illegal cICP ranges either (i.e. greater than 1). Signed-off-by: Leo Izen Reported-by: Kacper Michajłow --- libavcodec/pngdec.c | 23 -

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libjxlenc: Move JxlBasicInfo to LibJxlEncodeContext

2023-12-12 Thread Leo Izen
On 12/11/23 12:05, Zsolt Vadász via ffmpeg-devel wrote: --- libavcodec/libjxlenc.c | 45 +- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c index d707f3a61b..92a458d51a 100644 Why? __

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libjxlenc: Move image initialization code into libjxl_encode_init_image

2023-12-12 Thread Leo Izen
/libavcodec/libjxlenc.c +++ b/libavcodec/libjxlenc.c If this is necessary for adding an animated encoder it needs to be in the commit, because this commit by itself doesn't do anything. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-14 Thread Leo Izen
On 12/13/23 15:53, Zsolt Vadász via ffmpeg-devel wrote: --- configure | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libjxlenc.c | 214 + 3 files changed, 177 insertions(+), 39 deletions(-) diff --git a/configure b/configure index 7d

Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: emit proper PTS to decoded AVFrame

2023-12-14 Thread Leo Izen
On 12/14/23 03:28, Anton Khirnov wrote: Quoting Leo Izen (2023-12-08 18:31:06) If a sequence of JXL images is encapsulated in a container that has PTS information, we should use the PTS information from the container. At this time there is no container that does this, but if JPEG XL support is

[FFmpeg-devel] [PATCH v2] avcodec/libjxldec: emit proper PTS to decoded AVFrame

2023-12-15 Thread Leo Izen
the PTS information those containers provide to work as expected. Signed-off-by: Leo Izen --- libavcodec/libjxldec.c | 57 +- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c index 002740d9c1

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-15 Thread Leo Izen
On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote: On Friday, December 15th, 2023 at 12:20 AM, Leo Izen wrote: + AVFrame *last; I don't see the purpose of keeping this here. The name is misleading, I should have named it `previous`, since it always contains the previous fra

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/libjxlenc: Add libjxl_animated encoder

2023-12-15 Thread Leo Izen
On 12/15/23 16:31, Zsolt Vadász via ffmpeg-devel wrote: On Friday, December 15th, 2023 at 10:12 PM, Leo Izen wrote: On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote: On Friday, December 15th, 2023 at 12:20 AM, Leo Izen leo.i...@gmail.com wrote: + AVFrame *last; I don't se

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-04-01 Thread Leo Izen
mats (matroska, mp4, avi, nut) and various output formats as well, both shrinking and growing the framerate. On 1/9/19 5:26 PM, Leo Izen wrote: --- fftools/ffmpeg.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c i

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-04-05 Thread Leo Izen
On 4/4/19 5:11 AM, Michael Niedermayer wrote: On Wed, Jan 09, 2019 at 05:26:53PM -0500, Leo Izen wrote: --- fftools/ffmpeg.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) Does this behave as intended when there is also an audio stream ? It depends on what you

[FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-18 Thread Leo Izen
--- fftools/ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index da4259a9a8..5d68194676 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2045,12 +2045,14 @@ static void do_streamcopy(InputStream *ist, OutputStream *

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-19 Thread Leo Izen
On 10/19/18 2:26 PM, Carl Eugen Hoyos wrote: 2018-10-19 4:58 GMT+02:00, Leo Izen : --- fftools/ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index da4259a9a8..5d68194676 100644 --- a/fftools/ffmpeg.c +++ b/fftools

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-19 Thread Leo Izen
On 10/19/18 3:02 PM, Carl Eugen Hoyos wrote: 2018-10-19 20:39 GMT+02:00, Leo Izen : On 10/19/18 2:26 PM, Carl Eugen Hoyos wrote: 2018-10-19 4:58 GMT+02:00, Leo Izen : --- fftools/ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-20 Thread Leo Izen
On 10/20/18 6:47 PM, Michael Niedermayer wrote: On Fri, Oct 19, 2018 at 07:29:28PM -0400, Leo Izen wrote: On 10/19/18 3:02 PM, Carl Eugen Hoyos wrote: 2018-10-19 20:39 GMT+02:00, Leo Izen : On 10/19/18 2:26 PM, Carl Eugen Hoyos wrote: 2018-10-19 4:58 GMT+02:00, Leo Izen : --- fftools

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-21 Thread Leo Izen
On 10/21/18 7:23 AM, Moritz Barsnick wrote: On Sat, Oct 20, 2018 at 22:42:55 -0400, Leo Izen wrote: On 10/20/18 6:47 PM, Michael Niedermayer wrote: This will not apply as it has too many newlines What do you mean by "this will not apply"? Do you mean attempting to apply the patch f

[FFmpeg-devel] [PATCH v2] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-28 Thread Leo Izen
This is v2 of a patch I sent earlier, revised after testing on various streams. --- fftools/ffmpeg.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index da4259a9a8..6e81716795 100644 --- a/fftools/ffmpeg.c +++ b/fftool

[FFmpeg-devel] [PATCH] configure: Fix some unsafe shell practices

2021-07-01 Thread Leo Izen
This commit fixes some unsafe shell pratcies in ./configure, particularly those that involve variable expansions on possibly unsanitized data in unsafe ways. This commit corrects this behavior in a small number of locations. --- configure | 16 1 file changed, 8 insertions(+), 8 d

[FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2019-01-09 Thread Leo Izen
--- fftools/ffmpeg.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 544f1a1cef..f4bd5d97b7 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2038,12 +2038,14 @@ static void do_streamcopy(InputStream *ist, O

[FFmpeg-devel] [PATCH] Added HEVC and Opus support to nut

2017-03-28 Thread Leo Izen
--- libavformat/nut.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/nut.c b/libavformat/nut.c index 04776e249f..592fe4dc28 100644 --- a/libavformat/nut.c +++ b/libavformat/nut.c @@ -42,6 +42,7 @@ const AVCodecTag ff_nut_video_tags[] = { { AV_CODEC_ID_GIF, MKTA

[FFmpeg-devel] [PATCH] Added HEVC and Opus FourCCs to nut4cc.txt

2017-03-29 Thread Leo Izen
--- docs/nut4cc.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/nut4cc.txt b/docs/nut4cc.txt index c2c067a..d6a5e7d 100644 --- a/docs/nut4cc.txt +++ b/docs/nut4cc.txt @@ -24,6 +24,7 @@ H261ITU H.261 H262ITU H.262 H263ITU H.263 H264ITU H.264 +HEVCITU H.265 HFY

[FFmpeg-devel] [PATCH] Added line to the af_bs2b filter docs mentioning --enable-libbs2b

2017-05-15 Thread Leo Izen
--- doc/filters.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 9611a41e28..a7c6063969 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -1911,6 +1911,9 @@ available are filtered. Bauer stereo to binaural transformation, which improves h

[FFmpeg-devel] [PATCH] doc/filters.texi: Add default values to vf_vaguedenoiser options

2017-09-03 Thread Leo Izen
--- doc/filters.texi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index afcb99d876..c898c43557 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -14911,7 +14911,7 @@ This filter accepts the following options: @item threshold

[FFmpeg-devel] [PATCH] libavformat/nutenc.c: Use ffv1 as default video encoder for NUT muxing

2017-09-27 Thread Leo Izen
--- libavformat/nutenc.c| 2 +- tests/ref/lavf/nut | 6 +++--- tests/ref/seek/lavf-nut | 54 - 3 files changed, 31 insertions(+), 31 deletions(-) diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c index a92ff55c01..6e96626ff0 100644

Re: [FFmpeg-devel] [PATCH] libavformat/nutenc.c: Use ffv1 as default video encoder for NUT muxing

2017-10-02 Thread Leo Izen
On 09/28/2017 04:51 PM, Michael Niedermayer wrote: On Wed, Sep 27, 2017 at 07:14:50PM -0400, Leo Izen wrote: --- libavformat/nutenc.c| 2 +- tests/ref/lavf/nut | 6 +++--- tests/ref/seek/lavf-nut | 54 - 3 files changed, 31

[FFmpeg-devel] [PATCH] encoders.texi: Replace x264 --full-help suggestion with --fullhelp

2017-08-10 Thread Leo Izen
--- doc/encoders.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 690cca83dc..f20be54ce8 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1793,7 +1793,7 @@ the documentation of the undocumented generic options, see @ref

Re: [FFmpeg-devel] [PATCH v2] doc: Add libtoch backend option to dnn_processing

2024-03-26 Thread Leo Izen
commit message, you want libtorch, not libtoch. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

[FFmpeg-devel] [PATCH v2 0/1] avcodec, avformat/ffjni: fix duplicate JNI symbols

2024-03-27 Thread Leo Izen
Changes since v1: - Rebased onto master I was unable to credit the original reporter with a Reported-by because the name used Chinese characters (and it translated to 'admin'). Leo Izen (1): avcodec,avformat/ffjni: fix duplicate JNI symbols libavcodec/Makefile | 1 + libavforma

[FFmpeg-devel] [PATCH v2 1/1] avcodec, avformat/ffjni: fix duplicate JNI symbols

2024-03-27 Thread Leo Izen
Use SHLIBOBJS and STLIBOBJS in the Makefiles for avcodec and avformat, and add a stub ffjni.c to libavformat, which allows the symbols to be duplicated for shared builds but not static builds. Signed-off-by: Leo Izen --- libavcodec/Makefile | 1 + libavformat/Makefile | 1 + libavformat

[FFmpeg-devel] [PATCH 0/3] [RFC] EXIF overhaul

2024-02-13 Thread Leo Izen
s place, as convenient as that would be. [1] https://exiv2.org/makernote.html [2] http://www.exif.org/samples.html Leo Izen (3): various: change EXIF metadata into AVFrameSideData avcodec/pngdec: parse eXIf chunk avcodec/pngenc: write eXIf chunks fftools/ffprobe.c

[FFmpeg-devel] [PATCH 1/3] various: change EXIF metadata into AVFrameSideData

2024-02-13 Thread Leo Izen
applied during a major version bump. Signed-off-by: Leo Izen --- fftools/ffprobe.c | 27 ++- libavcodec/Makefile| 1 + libavcodec/exif.c | 267 +++-- libavcodec/exif.h | 21 ++- libavcodec/exif_internal.h

[FFmpeg-devel] [PATCH 2/3] avcodec/pngdec: parse eXIf chunk

2024-02-13 Thread Leo Izen
Add support to parse eXIf chunks using the new EXIF framework. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 026da30c25..e7951d1802 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 3/3] avcodec/pngenc: write eXIf chunks

2024-02-13 Thread Leo Izen
Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk to PNG files, if present. Signed-off-by: Leo Izen --- libavcodec/pngenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 50689cb50c..a302c879da 100644 --- a/libavcodec

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/pngenc: write eXIf chunks

2024-02-15 Thread Leo Izen
On 2/14/24 13:53, Andreas Rheinhardt wrote: Leo Izen: Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk to PNG files, if present. Signed-off-by: Leo Izen --- libavcodec/pngenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c

Re: [FFmpeg-devel] Fixes #10509

2024-03-10 Thread Leo Izen
On 3/9/24 15:49, Poorva wrote: I have attached the git patch containing the changes for your review. This patch is submitted as part of my qualification task for Google Summer of Code (GSoC) Your editor appears to have stripped the newline at the end of the file. - Leo Izen (Traneptora

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-03-10 Thread Leo Izen
become widely used if it was in someones personal repository and main FFmpeg did not support it thx This is true, but also the code hasn't been touched in more than ten years, which makes it a bit different than, say, ffv1 which was actively developed for a while and still is. - Leo

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/dvdvideodec: add menu demuxing support

2024-03-10 Thread Leo Izen
On 3/9/24 13:27, Marth64 wrote: Signed-off-by: Marth64 --- doc/demuxers.texi | 43 +- libavformat/dvdvideodec.c | 314 -- 2 files changed, 339 insertions(+), 18 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index f4bac8f3b3.

  1   2   3   4   5   6   7   >