On 09/28/2017 04:51 PM, Michael Niedermayer wrote:
On Wed, Sep 27, 2017 at 07:14:50PM -0400, Leo Izen wrote:
---
libavformat/nutenc.c | 2 +-
tests/ref/lavf/nut | 6 +++---
tests/ref/seek/lavf-nut | 54 ++++++++++++++++++++++++-------------------------
3 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c
index a92ff55c01..6e96626ff0 100644
--- a/libavformat/nutenc.c
+++ b/libavformat/nutenc.c
@@ -1221,7 +1221,7 @@ AVOutputFormat ff_nut_muxer = {
.priv_data_size = sizeof(NUTContext),
.audio_codec = CONFIG_LIBVORBIS ? AV_CODEC_ID_VORBIS :
CONFIG_LIBMP3LAME ? AV_CODEC_ID_MP3 : AV_CODEC_ID_MP2,
- .video_codec = AV_CODEC_ID_MPEG4,
+ .video_codec = AV_CODEC_ID_FFV1,
.write_header = nut_write_header,
.write_packet = nut_write_packet,
.write_trailer = nut_write_trailer,
Why?
also this breaks existing code and command lines which expect mpeg4 as
default
This was a patch I submitted as suggested by Mark Thompson on IRC,
2017-09-27:
[18:47:51] <thebombzen> while we're on automatic order, for NUT, mpeg4
gets picked by default rather than ffv1
[18:47:59] <thebombzen> this doesn't make sense
[18:49:22] <@jkqxz> thebombzen: Yes. Change
<http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavformat/nutenc.c;h=a92ff55c01373bd7db36088114888a1c1d15ef69;hb=HEAD#l1224>?
[18:49:48] <thebombzen> sure. I'll send a patch to the mailing list
A discussion on whether this change is a good one would require their input.
Thanks,
Leo Izen (thebombzen)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
