Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-12 Thread Kyle Swanson
Hi, On Thu, Jan 11, 2018 at 5:42 AM, Gyan Doshi wrote: > The no-op commit e496c45 from Libav introduced an option which allowed the > user to relocate text to fit within the frame if it was going out of bounds. > > For some reason, when the merge commit b479e01 was applied, the option was > adde

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-19 Thread Kyle Swanson
Hi, > > Ping. Unless text needs to be rescaled as well, this patch is ready for > review. > > > Regards, > Gyan > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel LGTM as-is. I'll push this so

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-20 Thread Kyle Swanson
Hi, On Fri, Jan 19, 2018 at 5:03 PM, Michael Niedermayer wrote: > On Fri, Jan 19, 2018 at 03:46:57PM -0800, Kyle Swanson wrote: >> Hi, >> >> > >> > Ping. Unless text needs to be rescaled as well, this patch is ready for >> >

Re: [FFmpeg-devel] [PATCH] avfilter: add drmeter audio filter

2018-03-09 Thread Kyle Swanson
Hi, On Wed, Mar 7, 2018 at 3:15 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 11 +++ > libavfilter/Makefile | 1 + > libavfilter/af_drmeter.c | 233 ++ > + > libavfilter/allfilters.c | 1 + > 4 fil

Re: [FFmpeg-devel] [PATCH] avfilter: add drmeter audio filter

2018-03-09 Thread Kyle Swanson
> > > +@section drmeter > +Measure audio dynamic range. > Can you add a short description here explaining this flavor of dynamic range? + > +The filter accepts the following options: > + > +@table @option > +@item length > +Set window lenght in seconds used to split audio into segments of equal >

[FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-07 Thread Kyle Swanson
Hi, Adds the new avfilter `libvmaf_cuda`, integrating the new vmaf_cuda_* apis in libvmaf. Patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-14 Thread Kyle Swanson
Hi, On Mon, Aug 7, 2023 at 10:50 AM Kyle Swanson wrote: > Adds the new avfilter `libvmaf_cuda`, integrating the new vmaf_cuda_* > apis in libvmaf. Patch attached. Anyone interested in reviewing this? Would be appreciated. Thanks, Kyle ___

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-23 Thread Kyle Swanson
Hi, Thank you Timo for the review. Took your suggestions, updated patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmp

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-28 Thread Kyle Swanson
Hi, Added filter docs, new patch attached. Unless there are any other reviews I will plan on pushing this in a few days. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-28 Thread Kyle Swanson
Hi, On Mon, Aug 28, 2023 at 11:59 AM Timo Rothenpieler wrote: > > +libvmaf_cuda_filter_deps="libvmaf cuda_nvcc" > > Does this really depend on nvcc? > Does it not work with only ffnvcodec? > Ah, you're right, I think ffnvcodec is the right option to use, I'll switch this in the next patch versio

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-29 Thread Kyle Swanson
Hi, On Mon, Aug 28, 2023 at 1:16 PM Kyle Swanson wrote: > Ah, you're right, I think ffnvcodec is the right option to use, I'll > switch this in the next patch version. Patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Descript

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-30 Thread Kyle Swanson
Hi, On Tue, Aug 29, 2023 at 3:13 PM Andreas Rheinhardt wrote: > The CONFIG_* variables are always defined; you need to check via "#if", > not "#ifdef". Fixed in the attached patch. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data _

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-08-31 Thread Kyle Swanson
Hi, On Wed, Aug 30, 2023 at 9:44 AM Kyle Swanson wrote: > Fixed in the attached patch. Any other reviews, or is this one OK to merge now? Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-05 Thread Kyle Swanson
Hi, On Thu, Aug 31, 2023 at 11:39 AM Kyle Swanson wrote: > On Wed, Aug 30, 2023 at 9:44 AM Kyle Swanson wrote: > > Fixed in the attached patch. > > Any other reviews, or is this one OK to merge now? I'll merge this in a few

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-11 Thread Kyle Swanson
Hi, On Tue, Sep 5, 2023 at 10:16 AM Kyle Swanson wrote: > I'll merge this in a few days. Not merged yet because I noticed a bug in the configure script. Setting only `--enable-libvmaf` will enable both `libvmaf` and `libvmaf_cuda`. Anyone familiar with the configure script know why

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-14 Thread Kyle Swanson
Hi, On Mon, Sep 11, 2023 at 11:51 AM Timo Rothenpieler wrote: > > On 11.09.2023 19:53, Kyle Swanson wrote: > > Hi, > > > > On Tue, Sep 5, 2023 at 10:16 AM Kyle Swanson wrote: > >> I'll merge this in a few days. > > > > Not merged yet because I

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-15 Thread Kyle Swanson
Hi, On Thu, Sep 14, 2023 at 12:10 PM Timo Rothenpieler wrote: > This looks more complicated than necessary to me. > > My idea would have been to change, in the previous original patch, > > > libvmaf_cuda_filter_deps="libvmaf ffnvcodec" > > to > > > libvmaf_cuda_filter_deps="libvmaf libvmaf_cuda

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-18 Thread Kyle Swanson
Hi, On Fri, Sep 15, 2023 at 3:34 PM Timo Rothenpieler wrote: > I don't see why it wouldn't work. It doesn't matter what it is, it's > just the name of the dependency. Patch attached. Thanks, Kyle 0001-avfilter-add-libvmaf_cuda.patch Description: Binary data ___

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-18 Thread Kyle Swanson
Hi, On Mon, Sep 18, 2023 at 12:41 PM Timo Rothenpieler wrote: > On 18.09.2023 21:21, Marvin Scholz wrote: > > I am far from an expert with the configure script but won't that cause > > --enable-libvmaf to fail when > > libvmaf is built without cuda support? Which seems undesirable to me… > > Yea

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-20 Thread Kyle Swanson
Hi, On Mon, Sep 18, 2023 at 2:39 PM Kyle Swanson wrote: > > Hi, > > On Mon, Sep 18, 2023 at 12:41 PM Timo Rothenpieler > wrote: > > On 18.09.2023 21:21, Marvin Scholz wrote: > > > I am far from an expert with the configure script but won't that cause

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-23 Thread Kyle Swanson
Hi, On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler wrote: > Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled, > support for CUDA is checked for, and then the vmaf_cuda filter needs to > depend on that check. This previous patch should do just that [0]. What's missing?

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/vf_libvmaf: add warning when color ranges differ

2023-09-23 Thread Kyle Swanson
Hi, On Mon, Apr 17, 2023 at 10:14 PM Chema Gonzalez wrote: > Hi Kyle, > > Thanks for your answer. > > I couldn't find how to access the color range from the filter_frame > function. I checked other filters that access `AVFrame.color_range`, > and all of them do it in the filter_frame function, n

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-25 Thread Kyle Swanson
Hi, On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler wrote: > On 23.09.2023 11:50, Kyle Swanson wrote: > > Hi, > > > > On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler < > t...@rothenpieler.org> > > wrote: > >> Or it needs to be a sub-fe

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-27 Thread Kyle Swanson
Hi, On Mon, Sep 25, 2023 at 9:10 AM Timo Rothenpieler wrote: > lgtm > Pushed. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/libvmaf: remove deprecated options

2023-10-05 Thread Kyle Swanson
Hi, Removal of deprecated libvmaf filter options. These options have been deprecated since 3d29724c008d8f27fecf85757152789b074e8ef9 (Jan 23, 2022). Patch attached. Thanks, Kyle 0001-avfilter-libvmaf-remove-deprecated-options.patch Description: Binary data ___

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread Kyle Swanson
Hi, On Wed, Sep 14, 2022 at 9:52 AM wrote: > > Sure. sorry for that. Please find attached the patch file. > Was about to test / review, but it looks like this is already pushed by Paul. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread Kyle Swanson
On Wed, Sep 14, 2022 at 12:02 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Would it actually be possible to avoid the memcpy altogether? > There's no libvmaf API for user buffers yet, so no, not at this moment. ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: Update ssim, ms_ssim options description

2022-09-14 Thread Kyle Swanson
Hi, On Fri, Sep 9, 2022 at 10:58 AM Yondon Fu wrote: > Update description for ssim and ms_ssim libvmaf options to specify > feature=float_ssim and feature=float_ms_ssim which are used to request > ssim and ms_ssim values in the latest versions of libvmaf. > > Signed-off-by: Yondon Fu > --- > l

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: Update ssim, ms_ssim options description

2022-09-16 Thread Kyle Swanson
Hi, On Wed, Sep 14, 2022 at 2:27 PM Kyle Swanson wrote: > Thanks for the fix, I will apply this soon. > Pushed. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsub

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_libvmaf: Add metadata propagation support

2024-08-29 Thread Kyle Swanson
Hi, On Mon, Aug 26, 2024 at 10:51=E2=80=AFAM Yigithan Yigit wrote: > > --- > libavfilter/vf_libvmaf.c | 328 ++- > 1 file changed, 326 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c > index f655092b20..e6707

[FFmpeg-devel] [PATCH] avfilter/af_tremolo: clean up extra newlines

2015-10-14 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/af_tremolo.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/af_tremolo.c b/libavfilter/af_tremolo.c index 0ae7a7c..50df2e4 100644 --- a/libavfilter/af_tremolo.c +++ b/libavfilter/af_tremolo.c @@ -131,9 +131,7 @@ static int

[FFmpeg-devel] [PATCH] avfilter/af_flanger: free frame on ENOMEM

2015-10-15 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/af_flanger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_flanger.c b/libavfilter/af_flanger.c index 39d4e7b..f8ec830 100644 --- a/libavfilter/af_flanger.c +++ b/libavfilter/af_flanger.c @@ -149,8 +149,10

[FFmpeg-devel] [PATCH] avfilter: add vibrato filter

2015-10-23 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- Changelog| 2 +- doc/filters.texi | 16 libavfilter/Makefile | 1 + libavfilter/af_vibrato.c | 210 +++ libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- 6 files

[FFmpeg-devel] [PATCH] doc/filters.texi: ebur128 grammar fix

2015-10-26 Thread Kyle Swanson
--- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 1de6a2f..2914e40 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12958,7 +12958,7 @@ This mode requires a build with @code{libswresample}. Treat mono input f

[FFmpeg-devel] [PATCH] avfilter/asrc_sine: fix options typos

2015-10-28 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/asrc_sine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/asrc_sine.c b/libavfilter/asrc_sine.c index f361faa..2a2f3c3 100644 --- a/libavfilter/asrc_sine.c +++ b/libavfilter/asrc_sine.c @@ -69,8 +69,8 @@ typedef

[FFmpeg-devel] [PATCH] avfilter/tremolo: fix wavetable buffer size

2015-10-28 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/af_tremolo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_tremolo.c b/libavfilter/af_tremolo.c index 50df2e4..572e9e3 100644 --- a/libavfilter/af_tremolo.c +++ b/libavfilter/af_tremolo.c @@ -72,7 +72,7

Re: [FFmpeg-devel] [PATCH] avfilter/tremolo: fix wavetable buffer size

2015-10-28 Thread Kyle Swanson
This fixes an obvious bug for sub 1-hz modulation frequencies. Wavetable buffer was too small for frequencies under 1 hz, and also too big for frequencies above 1hz. One cycle is all we need. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f

Re: [FFmpeg-devel] [PATCH] avfilter/asrc_sine: fix options typos

2015-10-29 Thread Kyle Swanson
On Wed, Oct 28, 2015 at 3:02 PM, Michael Niedermayer wrote: > On Wed, Oct 28, 2015 at 07:10:24PM +0100, Nicolas George wrote: >> Le septidi 7 brumaire, an CCXXIV, Kyle Swanson a écrit : >> > Signed-off-by: Kyle Swanson >> > --- >> > libavfilter/asrc_sin

[FFmpeg-devel] [PATCH] avfilter: add audio noise source

2015-10-30 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- Changelog| 1 + doc/filters.texi | 30 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/asrc_noise.c | 141 +++ libavfilter/version.h| 2 +- 6

[FFmpeg-devel] [PATCH] avfilter: add anoisesrc

2015-11-04 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- Changelog| 1 + doc/filters.texi | 36 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/asrc_anoisesrc.c | 222 +++ libavfilter/version.h

Re: [FFmpeg-devel] [PATCH] avfilter: add anoisesrc

2015-11-04 Thread Kyle Swanson
Hi, On Wed, Nov 4, 2015 at 12:30 PM, Nicolas George wrote: > Thanks for the updated patch, see comments below. > > Le quartidi 14 brumaire, an CCXXIV, Kyle Swanson a écrit : >> Signed-off-by: Kyle Swanson >> --- >> Changelog| 1 + >> d

Re: [FFmpeg-devel] [PATCH] avfilter: add anoisesrc

2015-11-04 Thread Kyle Swanson
On Wed, Nov 4, 2015 at 1:10 PM, James Almer wrote: > On 11/4/2015 3:19 PM, Kyle Swanson wrote: >> Signed-off-by: Kyle Swanson >> diff --git a/libavfilter/asrc_anoisesrc.c b/libavfilter/asrc_anoisesrc.c >> new file mode 100644 >> index 000..d008d67 >> -

Re: [FFmpeg-devel] [PATCH] avfilter: add anoisesrc

2015-11-04 Thread Kyle Swanson
> +static double pink_filter(double white, double *buf) { > +double pink; > + > +/* http://www.musicdsp.org/files/pink.txt */ > +buf[0] = 0.99886 * buf[0] + white * 0.0555179; > +buf[1] = 0.99332 * buf[1] + white * 0.0750759; > +buf[2] = 0.96900 * buf[2] + white * 0.1538520; > +

Re: [FFmpeg-devel] [PATCH] avfilter: add anoisesrc

2015-11-04 Thread Kyle Swanson
> Alternatively, it should not be hard to find on the web. I personally > am ok with your patch with floats, leaving fixed point for future > work, but Paul and Nicolas have greater expertise and knowledge of > this stuff and their opinion is definitely more important. FWIW, SoX and Audacity both

[FFmpeg-devel] [PATCHv2] avfilter: add anoisesrc

2015-11-05 Thread Kyle Swanson
sing fixed-point methods. Fixed point sample formats could, of course, be implemented at a later time. Signed-off-by: Kyle Swanson --- Changelog| 1 + doc/filters.texi | 36 libavfilter/allfilters.c | 1 + libavfilter/asrc_anoises

[FFmpeg-devel] [PATCH] avfilter: add anoisesrc

2015-11-05 Thread Kyle Swanson
Here's v3. Uses AV_OPT_TYPE_CONST now. Signed-off-by: Kyle Swanson --- Changelog| 1 + doc/filters.texi | 36 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/asrc_anoisesrc.c

[FFmpeg-devel] [PATCHv3] avfilter: add anoisesrc

2015-11-05 Thread Kyle Swanson
Here's v3. Uses AV_OPT_TYPE_CONST now. Just sent this with the wrong subject line, here it is again. (sorry!) Signed-off-by: Kyle Swanson --- Changelog| 1 + doc/filters.texi | 36 libavfilter/Makefile | 1 + libavfilter/allfilt

[FFmpeg-devel] [PATCHv4] avfilter: add anoisesrc

2015-11-06 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- Changelog| 1 + doc/filters.texi | 36 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/asrc_anoisesrc.c | 207 +++ libavfilter/version.h

[FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-19 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- doc/filters.texi | 19 ++ libavfilter/Makefile | 1 + libavfilter/af_tremolo.c | 173 +++ libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- 5 files changed, 195 insertions(+), 1

[FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-21 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- doc/filters.texi | 19 + libavfilter/Makefile | 1 + libavfilter/af_tremolo.c | 177 +++ libavfilter/allfilters.c | 1 + libavfilter/version.h| 2 +- 5 files changed, 199 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-21 Thread Kyle Swanson
I've made these changes and have re-submitted as a new patch. Thanks! On Sun, Sep 20, 2015 at 2:46 AM, Paul B Mahol wrote: > Dana 20. 9. 2015. 06:28 osoba "Kyle Swanson" napisala je: >> >> Signed-off-by: Kyle Swanson >> --- >> doc/filters.texi

Re: [FFmpeg-devel] [PATCH] avfilter: add tremolo filter

2015-09-21 Thread Kyle Swanson
implement a vibrato as a filter as well. I calculate my envelope with ff_generate_wave_table() to avoid having to re-calculate sine for every sample. This is faster, but uses a small amount of memory. On Mon, Sep 21, 2015 at 4:18 PM, Paul B Mahol wrote: > On 9/21/15, Kyle Swanson wro

[FFmpeg-devel] [PATCH] avfilter/af_tremolo: fix envelope phase

2015-09-22 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/af_tremolo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_tremolo.c b/libavfilter/af_tremolo.c index 6335401..69eaa34 100644 --- a/libavfilter/af_tremolo.c +++ b/libavfilter/af_tremolo.c @@ -138,7 +138,7 @@ static

Re: [FFmpeg-devel] [PATCH] avfilter/af_tremolo: make it bit-exact with sox effect of same name

2015-09-23 Thread Kyle Swanson
Looks good. Thanks for the clean-up. On Wed, Sep 23, 2015 at 4:22 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 2 +- > libavfilter/af_tremolo.c | 45 ++--- > 2 files changed, 23 insertions(+), 24 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avfilter/af_tremolo: make it bit-exact with sox effect of same name

2015-09-24 Thread Kyle Swanson
> s->table = av_malloc_array(inlink->sample_rate, sizeof(*s->table)); Just wondering. Is there a reason that the size of s->table is (inlink->sample_rate) and not (1.0 / inlink->sample_rate) ? Thanks! Kyle On Wed, Sep 23, 2015 at 6:16 PM, Kyle Swanson wrote: > Lo

[FFmpeg-devel] [PATCH] avfilter/generate_wave_table: clean up extra newlines

2015-09-24 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/generate_wave_table.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/generate_wave_table.c b/libavfilter/generate_wave_table.c index bee9c00..6cd8022 100644 --- a/libavfilter/generate_wave_table.c +++ b/libavfilter

Re: [FFmpeg-devel] [PATCH] avfilter/af_tremolo: make it bit-exact with sox effect of same name

2015-09-24 Thread Kyle Swanson
Sorry, I meant to type (1.0 / s->freq). This is one wavelength. On Thu, Sep 24, 2015 at 9:29 AM, Kyle Swanson wrote: >> s->table = av_malloc_array(inlink->sample_rate, sizeof(*s->table)); > > > Just wondering. Is there a reason that the size of s->table is > (i

[FFmpeg-devel] [PATCH] avfilter/f_ebur128: add dualmono measurement option

2015-09-25 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- doc/filters.texi| 9 + libavfilter/f_ebur128.c | 22 ++ 2 files changed, 31 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 044876c..e63311a 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12642,6

Re: [FFmpeg-devel] [PATCH] avfilter/f_ebur128: add dualmono measurement option

2015-09-25 Thread Kyle Swanson
On Fri, Sep 25, 2015 at 4:04 PM, Kyle Swanson wrote: > Signed-off-by: Kyle Swanson > --- > doc/filters.texi| 9 + > libavfilter/f_ebur128.c | 22 ++ > 2 files changed, 31 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters

Re: [FFmpeg-devel] [PATCH] avfilter/f_ebur128: add dualmono measurement option

2015-09-28 Thread Kyle Swanson
> questions: > > - what happens if you resample the input (by prefixing ebur128 with > aformat=channel_layout=stereo)? > - if I'm reading the blog correctly ("Note that In my discussions with > leading experts in the space, it has come to my attention that this > approach may not be sustainab

[FFmpeg-devel] [PATCH] avfilter/f_ebur128: add dualmono measurement option

2015-09-30 Thread Kyle Swanson
--- doc/filters.texi| 9 + libavfilter/f_ebur128.c | 22 ++ 2 files changed, 31 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index a4d828e..0140550 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12662,6 +12662,15 @@ stream for bette

Re: [FFmpeg-devel] [PATCH] avfilter/f_ebur128: add dualmono measurement option

2015-09-30 Thread Kyle Swanson
> OK. I will test & apply this week-end unless you're in a hurry. In the > meantime, maybe just drop the V flag in the options (these options are > related to the audio only). Sounds good. I've removed the `V' flag from those options, and emailed a new patch. Thanks! __

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-06-30 Thread Kyle Swanson
On Mon, Jun 29, 2020 at 2:27 PM Carl Eugen Hoyos wrote: > No objections. Thanks. I will merge in 24 hours or so, when the next libvmaf minor release is cut. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

2020-07-02 Thread Kyle Swanson
On Tue, Jun 30, 2020 at 11:55 AM Kyle Swanson wrote: > > On Mon, Jun 29, 2020 at 2:27 PM Carl Eugen Hoyos wrote: > > No objections. > > Thanks. I will merge in 24 hours or so, when the next libvmaf minor > release is cut. Pushed. Thanks. _

[FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-07 Thread Kyle Swanson
From: Kyle Swanson Signed-off-by: Kyle Swanson --- configure| 2 +- libavfilter/vf_libvmaf.c | 9 - 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 15a58935de..e718c1531c 100755 --- a/configure +++ b/configure @@ -6089,7

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-07 Thread Kyle Swanson
Hi, On Tue, Aug 7, 2018 at 8:02 PM, James Almer wrote: > On 8/7/2018 7:37 PM, Kyle Swanson wrote: > > From: Kyle Swanson > > > > Signed-off-by: Kyle Swanson > > --- > > configure| 2 +- > > libavfilter/vf_libvmaf.c | 9 - &

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-09 Thread Kyle Swanson
Hi, On Tue, Aug 7, 2018 at 3:37 PM, Kyle Swanson wrote: > From: Kyle Swanson > > Signed-off-by: Kyle Swanson > --- > configure| 2 +- > libavfilter/vf_libvmaf.c | 9 - > 2 files changed, 9 insertions(+), 2 deletions(-) > > I'll updat

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-10 Thread Kyle Swanson
Hi, > On Aug 9, 2018, at 10:10 AM, Kyle Swanson wrote: > > Hi, > >> On Tue, Aug 7, 2018 at 3:37 PM, Kyle Swanson wrote: >> From: Kyle Swanson >> >> Signed-off-by: Kyle Swanson >> --- >> configure| 2 +- >> libavfi

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-13 Thread Kyle Swanson
Hi, On Mon, Aug 13, 2018 at 11:56 AM, Carl Eugen Hoyos wrote: > 2018-08-08 0:37 GMT+02:00, Kyle Swanson : > > > +{"n_threads", "Set number of threads to be used when computing > vmaf.", > > OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-24 Thread Kyle Swanson
Hi, Never followed through on this vf_libvmaf patch from last June, and I've had several people asking about its status lately. Rebased patch attached. It's been a while, so I guess let's start the review again. Would be nice if we could get this in before 5.0. Thanks, Kyle On Wed, Jun 30, 2021

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-30 Thread Kyle Swanson
Hi, On Fri, Dec 24, 2021 at 12:54 PM Timo Rothenpieler wrote: > > On Wed, Jun 30, 2021 at 6:55 AM Moritz Barsnick wrote: > >> > >> Hi, > >> > >>> -enabled libvmaf && require_pkg_config libvmaf "libvmaf >= > >>> 1.5.2" libvmaf.h compute_vmaf > >>> +enabled libvmaf && require_

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-30 Thread Kyle Swanson
Hi, On Sat, Dec 25, 2021 at 1:24 AM Paul B Mahol wrote: > > On Fri, Dec 24, 2021 at 9:52 PM Kyle Swanson wrote: > > > Hi, > > > > Never followed through on this vf_libvmaf patch from last June, and > > I've had several people asking about its status lately.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-02 Thread Kyle Swanson
Hi, On Thu, Dec 30, 2021 at 5:03 PM Kyle Swanson wrote: > > Hi, > > On Sat, Dec 25, 2021 at 1:24 AM Paul B Mahol wrote: > > > > On Fri, Dec 24, 2021 at 9:52 PM Kyle Swanson wrote: > > > > > Hi, > > > > > > Never followed through on

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-03 Thread Kyle Swanson
Hi, On Sun, Jan 2, 2022 at 9:21 PM Andreas Rheinhardt wrote: > > > > static const AVOption libvmaf_options[] = { > > -{"model_path", "Set the model to be used for computing vmaf.", > > OFFSET(model_path), AV_OPT_TYPE_STRING, > > {.str="/usr/local/share/model/vmaf_v0.6.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-08 Thread Kyle Swanson
Hi, On Mon, Jan 3, 2022 at 2:32 PM Kyle Swanson wrote: > > Hi, > > On Sun, Jan 2, 2022 at 9:21 PM Andreas Rheinhardt > wrote: > > > > > > static const AVOption libvmaf_options[] = { > > > -{"model_path", "Set the model to be use

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-13 Thread Kyle Swanson
Hi, On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt wrote: > 1. FFmpeg uses the ancient C90 rule that only allows variable > declarations at the beginning of a block (before all statements). You > should actually have received a compiler warning because of the above > code (unless you use Cla

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-19 Thread Kyle Swanson
Hi, On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson wrote: > > Hi, > > On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt > wrote: > > 1. FFmpeg uses the ancient C90 rule that only allows variable > > declarations at the beginning of a block (before all statements). Y

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-20 Thread Kyle Swanson
Hi, On Wed, Jan 19, 2022 at 10:23 AM Kyle Swanson wrote: > > Hi, > > On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson wrote: > > > > Hi, > > > > On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt > > wrote: > > > 1. FFmpeg uses the ancient C90 r

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2022-01-23 Thread Kyle Swanson
Hi, On Thu, Jan 20, 2022 at 1:06 PM Kyle Swanson wrote: > > Hi, > > On Wed, Jan 19, 2022 at 10:23 AM Kyle Swanson wrote: > > > > Hi, > > > > On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson wrote: > > > > > > Hi, > > > > &g

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-12 Thread Kyle Swanson
Hi, Should we consult with someone (a professional) outside of FFmpeg to assess the situation and provide a set of recommendations? This would be money well spent IMO. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_libvmaf: Add metadata propagation support

2024-09-19 Thread Kyle Swanson
Hi, On Wed, Sep 11, 2024 at 5:41 PM Yigithan Yigit wrote: > Yes, metadata callbacks are not coming in order. I looked libavutil and I > couldn’t find a data structure for this use case. I am open to suggestions If > we don’t prefer to use this data structure. Could we somehow get the AVFrame p

Re: [FFmpeg-devel] Graphprint Patches Overview

2025-05-21 Thread Kyle Swanson
Hi, On Wed, May 21, 2025 at 4:00 AM Kieran Kunhya via ffmpeg-devel wrote: > Can we just revert the whole set until it's cleaned up properly? > > There are more patches to fix issues than the set itself. This is > understandable if it's a bit architectural change like threading but it's > not. I

Re: [FFmpeg-devel] Forgejo questions

2025-07-24 Thread Kyle Swanson
Hi, On Thu, Jul 24, 2025 at 10:46 AM Timo Rothenpieler wrote: > The mails will never contain patches, they're just notifications. > They do contain a link to the patches and the PR number to fetch it via > CLI though. If you append ".patch" or ".diff" to the url in the mail, you can get the patc

[FFmpeg-devel] Re: [PATCH] avformat/demux: avoid unconditional ID3v2 tag consumption

2025-09-03 Thread Kyle Swanson via ffmpeg-devel
Hi, On Tue, Sep 2, 2025 at 9:41 AM Kyle Swanson wrote: > > On Wed, Aug 20, 2025 at 2:09 PM Kyle Swanson wrote: > > > > Hi, > > > > On Wed, Jul 23, 2025 at 10:51 AM Nil Fons Miret via ffmpeg-devel > > wrote: > > > Pinging this patch from a couple we

[FFmpeg-devel] Re: [PATCH] avformat/demux: avoid unconditional ID3v2 tag consumption

2025-09-02 Thread Kyle Swanson via ffmpeg-devel
On Wed, Aug 20, 2025 at 2:09 PM Kyle Swanson wrote: > > Hi, > > On Wed, Jul 23, 2025 at 10:51 AM Nil Fons Miret via ffmpeg-devel > wrote: > > Pinging this patch from a couple weeks ago. To be clear, I am not sure > > how people typically use ffmpeg's ID3v2 suppo

Re: [FFmpeg-devel] [PATCH] avformat/demux: avoid unconditional ID3v2 tag consumption

2025-08-20 Thread Kyle Swanson via ffmpeg-devel
Hi, On Wed, Jul 23, 2025 at 10:51 AM Nil Fons Miret via ffmpeg-devel wrote: > Pinging this patch from a couple weeks ago. To be clear, I am not sure > how people typically use ffmpeg's ID3v2 support, so please let me know > if the patch is missing something and I'm happy to iterate on it, but > i

<    1   2