Hi, On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson <k...@ylo.ph> wrote: > > Hi, > > On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt > <andreas.rheinha...@outlook.com> wrote: > > 1. FFmpeg uses the ancient C90 rule that only allows variable > > declarations at the beginning of a block (before all statements). You > > should actually have received a compiler warning because of the above > > code (unless you use Clang, which claims to support this type of > > warning, yet doesn't). > > 2. You jump over the initializion of str_copy if the dict allocation > > fails and consequently you free an uninitialized string. > > New patch attached. Fixes all of the GCC -Wdeclaration-after-statement > warnings. You're right, I didn't notice because I was building with > Clang. Andreas, I will just wait for your LGTM before merging. > > Thanks, > Kyle
Updated patch attached. Thank you to mkver for the mini review on IRC. The `delimited_dict_parse` multi-delimiter corner case should be sorted now. Thanks, Kyle
0001-avfilter-vf_libvmaf-update-filter-for-libvmaf-v2.0.0.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
