Hi,
On Sun, Jan 2, 2022 at 9:21 PM Andreas Rheinhardt
<andreas.rheinha...@outlook.com> wrote:
> >
> > static const AVOption libvmaf_options[] = {
> > - {"model_path", "Set the model to be used for computing vmaf.",
> > OFFSET(model_path), AV_OPT_TYPE_STRING,
> > {.str="/usr/local/share/model/vmaf_v0.6.1.pkl"}, 0, 1, FLAGS},
> > - {"log_path", "Set the file path to be used to store logs.",
> > OFFSET(log_path), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1,
> > FLAGS},
> > - {"log_fmt", "Set the format of the log (csv, json or xml).",
> > OFFSET(log_fmt), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS},
> > - {"enable_transform", "Enables transform for computing vmaf.",
> > OFFSET(enable_transform), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1,
> > FLAGS},
> > - {"phone_model", "Invokes the phone model that will generate higher
> > VMAF scores.", OFFSET(phone_model), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1,
> > FLAGS},
> > - {"psnr", "Enables computing psnr along with vmaf.",
> > OFFSET(psnr), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS},
> > - {"ssim", "Enables computing ssim along with vmaf.",
> > OFFSET(ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS},
> > - {"ms_ssim", "Enables computing ms-ssim along with vmaf.",
> > OFFSET(ms_ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS},
> > - {"pool", "Set the pool method to be used for computing vmaf.",
> > OFFSET(pool), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS},
> > + {"model", "Set the model to be used for computing vmaf.",
> > OFFSET(model_cfg), AV_OPT_TYPE_STRING,
> > {.str="version=vmaf_v0.6.1"}, 0, 1, FLAGS},
> > + {"feature", "Set the feature to be used for computing vmaf.",
> > OFFSET(feature_cfg), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1,
> > FLAGS},
> > + {"log_path", "Set the file path to be used to write log.",
> > OFFSET(log_path), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1,
> > FLAGS},
> > + {"log_fmt", "Set the format of the log (csv, json, xml, or sub).",
> > OFFSET(log_fmt), AV_OPT_TYPE_STRING, {.str="xml"}, 0, 1,
> > FLAGS},
> > {"n_threads", "Set number of threads to be used when computing vmaf.",
> > OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0, UINT_MAX,
> > FLAGS},
> > {"n_subsample", "Set interval for frame subsampling used when
> > computing vmaf.", OFFSET(n_subsample), AV_OPT_TYPE_INT, {.i64=1}, 1,
> > UINT_MAX, FLAGS},
> > - {"enable_conf_interval", "Enables confidence interval.",
> > OFFSET(enable_conf_interval), AV_OPT_TYPE_BOOL, {.i64=0}, 0,
> > 1, FLAGS},
> > { NULL }
> > };
>
> You are removing lots of options; removing options is only permissible
> during a major break and even then the options need to have been
> deprecated before that.Good point, thanks. New patch attached. No more missing options, everything that should be deprecated has been marked as deprecated and appropriate fallback behavior implemented. Thanks, Kyle
0001-avfilter-vf_libvmaf-update-filter-for-libvmaf-v2.0.0.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
